[{"id":1762160,"web_url":"http://patchwork.ozlabs.org/comment/1762160/","msgid":"","list_archive_url":null,"date":"2017-09-02T16:42:01","subject":"Re: [PATCH net-next 0/4] net: dsa: add master interface","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"Hi Vivien,\n\nOn 08/31/2017 11:37 AM, Vivien Didelot wrote:\n> Currently the SoC network interface (called master) to which a switch\n> fabric hangs, has its dsa_ptr pointing to a dsa_switch_tree instance.\n> \n> This is not quite correct, because this interface is physically wired to\n> one of the switch ports (called CPU port), and because in a switch\n> fabric with multiple CPU ports, several master interfaces will point to\n> several CPU ports of the same dsa_switch_tree.\n> \n> This patchset adds a new dsa_master structure to represent the pipe\n> between the SoC master interface and its switch CPU port. This structure\n> will store specific data such as the master ethtool_ops copy and the\n> tagging protocol used to pass frames with the associated slave ports.\n> The dsa_ptr is changed to a dsa_master instance, and each DSA slave now\n> has a pointer to a master port.\n> \n> This is a step forward better control over the CPU conduit and support\n> for multiple CPU ports.\n\nLooked briefly over this series and this looks good to me, Andrew has a\nvalid point about reducing the number of dereferences in hot paths\nthough. Thanks!\n\n> \n> Vivien Didelot (4):\n> net: dsa: introduce dsa_master\n> net: dsa: move master ethtool ops in dsa_master\n> net: dsa: change dsa_ptr for a dsa_master\n> net: dsa: assign a master to slave ports\n> \n> drivers/net/dsa/b53/b53_common.c | 4 +-\n> drivers/net/dsa/bcm_sf2.c | 8 +--\n> drivers/net/dsa/mt7530.c | 4 +-\n> drivers/net/dsa/mv88e6060.c | 2 +-\n> drivers/net/dsa/qca8k.c | 2 +-\n> include/linux/netdevice.h | 4 +-\n> include/net/dsa.h | 42 +++++------\n> net/dsa/Makefile | 2 +-\n> net/dsa/dsa.c | 34 +--------\n> net/dsa/dsa2.c | 38 +++++-----\n> net/dsa/dsa_priv.h | 24 +++----\n> net/dsa/legacy.c | 34 +++++----\n> net/dsa/master.c | 149 +++++++++++++++++++++++++++++++++++++++\n> net/dsa/slave.c | 117 +++++-------------------------\n> net/dsa/tag_brcm.c | 5 +-\n> net/dsa/tag_dsa.c | 3 +-\n> net/dsa/tag_edsa.c | 3 +-\n> net/dsa/tag_ksz.c | 5 +-\n> net/dsa/tag_lan9303.c | 6 +-\n> net/dsa/tag_mtk.c | 12 +---\n> net/dsa/tag_qca.c | 12 +---\n> net/dsa/tag_trailer.c | 5 +-\n> 22 files changed, 265 insertions(+), 250 deletions(-)\n> create mode 100644 net/dsa/master.c\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"j75nIiEx\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xl2341FR1z9t16\n\tfor ;\n\tSun, 3 Sep 2017 02:42:40 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752737AbdIBQmG (ORCPT );\n\tSat, 2 Sep 2017 12:42:06 -0400","from mail-oi0-f66.google.com ([209.85.218.66]:37095 \"EHLO\n\tmail-oi0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752702AbdIBQmE (ORCPT\n\t); Sat, 2 Sep 2017 12:42:04 -0400","by mail-oi0-f66.google.com with SMTP id b184so2302792oih.4;\n\tSat, 02 Sep 2017 09:42:04 -0700 (PDT)","from ?IPv6:2001:470:d:73f:e568:bfce:b965:99e3?\n\t([2001:470:d:73f:e568:bfce:b965:99e3])\n\tby smtp.gmail.com with ESMTPSA id\n\tu14sm6065626oie.40.2017.09.02.09.42.02\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 02 Sep 2017 09:42:03 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=pvCDxVttv/iu605zRkxJp30fCKnxrUfT3v6P5PqJStk=;\n\tb=j75nIiExVE62vNUtXxPjjO0QPZYeUQ6iv1nr1qdCUMlnDiOMccl0fOmcNk98u9Oy4e\n\tDKZC8DAk+9svoCN2Vfs5DBmHTOs+4SzFp15oKTNCXLyzOCXPmsN2EM0JZ099IyzAd3KR\n\tyvkm4doD36l3zj2fEroWQDX/iYF257q4wq9eji8eCur+ms8WEufMu13IgD9qEyvbjLbB\n\tP3BBwdgfQIPfC1AKpb1rIsipkvq14u/K4aJNxH7BseOaJPhCm4xTtUp/sSjtEvuvf1c+\n\tUyT4Me9WKUFir5g4a28cCCcjAdY20C07M5NfacbPSmauHADe8tGpo4Vb5QsITpg4HxLQ\n\tHp8A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=pvCDxVttv/iu605zRkxJp30fCKnxrUfT3v6P5PqJStk=;\n\tb=nL3yKEs72F0MBjW3j4DLY9NcYReKmbNUYR43f4oM+PIR2xC4xTB4K2fbbFPtAU6YUh\n\t9/B13VfIUFuHcbn6gEXPNw6IQvjK585553G5UExERbwux7nExdbnwBiOMtBIWxYRGgAF\n\tBQdfLvf/lhAZ/ojZ8/uqm3VdHLnJnq6MQ/Knr50aoKDXR6X+IQdoEWx+3NpYoI4+uwvJ\n\tLXaIi7IxRhLCLPD1nr7cBEY2LUD8ZcmsrpG7ACvTw+1E0O2zWAgKd5EilzXJNOxOZ52d\n\txjdPl1n3j0hgULzdyHvnKOmP1g7KFtwuRO289OgZ3hUIwSmgq2Ky45FxhTeuqOQGjyzq\n\tlgGQ==","X-Gm-Message-State":"AHPjjUjKll2FPluHo6lKIULt7ClxIKA6uysF4b3HBFSWIXKYH7dRAIzw\n\tXCGvBMu6uxY7Ng==","X-Google-Smtp-Source":"ADKCNb5wSfXqVw05HKNdQruOFeEs0NfduRdHAr2zrVXma/ZGiGy8KRMljbN+wzkcTngVt6P/nhycRQ==","X-Received":"by 10.202.216.11 with SMTP id p11mr755471oig.145.1504370524201; \n\tSat, 02 Sep 2017 09:42:04 -0700 (PDT)","Subject":"Re: [PATCH net-next 0/4] net: dsa: add master interface","To":"Vivien Didelot ,\n\tnetdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,\n\t\"David S. Miller\" , Andrew Lunn ","References":"<20170831183746.2109-1-vivien.didelot@savoirfairelinux.com>","From":"Florian Fainelli ","Message-ID":"","Date":"Sat, 2 Sep 2017 09:42:01 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170831183746.2109-1-vivien.didelot@savoirfairelinux.com>","Content-Type":"text/plain; charset=windows-1252","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]