[{"id":1761339,"web_url":"http://patchwork.ozlabs.org/comment/1761339/","msgid":"<20170831.144320.554040883431439478.davem@davemloft.net>","list_archive_url":null,"date":"2017-08-31T21:43:20","subject":"Re: [patch net-next repost 0/8] mlxsw: Add IPv6 host dpipe table","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Jiri Pirko \nDate: Thu, 31 Aug 2017 17:59:11 +0200\n\n> This patchset adds IPv6 host dpipe table support. This will provide the\n> ability to observe the hardware offloaded IPv6 neighbors.\n\nSeries applied, thanks.\n\nI noticed while reviewing this we are pretty much split on how\nto access neigh->primary_key.\n\nHalf the code goes \"(type *) n->primary_key\" and the other half\n(mostly in ipv6) goes \"(type *) &n->primary_key\"\n\nI know both forms are basically equivalent, but consistency\nmatters :-)","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjwq018CHz9s81\n\tfor ;\n\tFri, 1 Sep 2017 07:43:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751363AbdHaVnW (ORCPT );\n\tThu, 31 Aug 2017 17:43:22 -0400","from shards.monkeyblade.net ([184.105.139.130]:59060 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751009AbdHaVnV (ORCPT\n\t); Thu, 31 Aug 2017 17:43:21 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id B4199133FDB84;\n\tThu, 31 Aug 2017 14:43:20 -0700 (PDT)"],"Date":"Thu, 31 Aug 2017 14:43:20 -0700 (PDT)","Message-Id":"<20170831.144320.554040883431439478.davem@davemloft.net>","To":"jiri@resnulli.us","Cc":"netdev@vger.kernel.org, arkadis@mellanox.com, idosch@mellanox.com,\n\tmlxsw@mellanox.com","Subject":"Re: [patch net-next repost 0/8] mlxsw: Add IPv6 host dpipe table","From":"David Miller ","In-Reply-To":"<20170831155919.1366-1-jiri@resnulli.us>","References":"<20170831155919.1366-1-jiri@resnulli.us>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 31 Aug 2017 14:43:20 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]