[{"id":1765202,"web_url":"http://patchwork.ozlabs.org/comment/1765202/","msgid":"<87r2vhfsc2.fsf@dusky.pond.sub.org>","list_archive_url":null,"date":"2017-09-08T09:33:01","subject":"Re: [Qemu-devel] [PATCH v2 0/5] qapi: support py2 & py3 in parallel","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/","name":"Markus Armbruster","email":"armbru@redhat.com"},"content":"\"Daniel P. Berrange\" writes:\n\n> Since I claimed that supporting py2 & py3 in parallel would be easy\n> for QEMU, I figured I ought to actually give it a try to backup that\n> assertion.\n>\n> This small patch series is the result of that effort. I tested this\n> series on Fedora 26 using 2.7.13 and Python 3.6.2.\n>\n> To test with py3, I hacked config-host.mak to change the PYTHON\n> variable to point to 'python3' binary, then compared the following\n> generated content for the files:\n>\n> qmp-commands.h qapi-types.h qapi-visit.h qapi-event.h\n> qmp-marshal.c qapi-types.c qapi-visit.c qapi-event.c\n> qmp-introspect.c qmp-introspect.h\n>\n> with that generated under py2 to see they are identical.\n>\n> It is possible there's still more bugs hiding that could impact\n> on 2.6 or earlier versions of 3.x or 2.7.x, so this probably\n> needs a bit wider testing, but I think the series illustrates\n> the broad scope of the changes we can expect. Only the need\n> to adapt to different module import locations adds to the\n> line count, and that's fairly minimal.\n\nThis hasn't made it to the front of my review queue, but I got a quick\nquestion meanwhile.\n\nI guess this was triggered by the discussion of David's \"[PATCH]\nscripts: Support building with Python 3\". How does it differ from\nDavid's patch? Is it derived from it? Or is it an independently\ndeveloped replacement?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=armbru@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpXJW1q0Lz9ryv\n\tfor ;\n\tFri, 8 Sep 2017 19:36:27 +1000 (AEST)","from localhost ([::1]:44142 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqFi5-0005Fb-95\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 05:36:25 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:32802)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqFex-00033t-U2\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:33:20 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqFeq-0006BS-KT\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:33:11 -0400","from mx1.redhat.com ([209.132.183.28]:49712)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dqFeq-0006AV-EO\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:33:04 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 73D1A4A6E5;\n\tFri, 8 Sep 2017 09:33:03 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-75.ams2.redhat.com\n\t[10.36.116.75])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 42D935C8B2;\n\tFri, 8 Sep 2017 09:33:03 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid C00601138645; Fri, 8 Sep 2017 11:33:01 +0200 (CEST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 73D1A4A6E5","From":"Markus Armbruster ","To":"\"Daniel P. Berrange\" ","References":"<20170831142430.16665-1-berrange@redhat.com>","Date":"Fri, 08 Sep 2017 11:33:01 +0200","In-Reply-To":"<20170831142430.16665-1-berrange@redhat.com> (Daniel\n\tP. Berrange's message of \"Thu, 31 Aug 2017 15:24:25 +0100\")","Message-ID":"<87r2vhfsc2.fsf@dusky.pond.sub.org>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tFri, 08 Sep 2017 09:33:03 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 0/5] qapi: support py2 & py3 in parallel","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"David Michael , qemu-devel@nongnu.org,\n\tMichael Roth ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1765207,"web_url":"http://patchwork.ozlabs.org/comment/1765207/","msgid":"<20170908094002.GH3609@redhat.com>","list_archive_url":null,"date":"2017-09-08T09:40:02","subject":"Re: [Qemu-devel] [PATCH v2 0/5] qapi: support py2 & py3 in parallel","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Fri, Sep 08, 2017 at 11:33:01AM +0200, Markus Armbruster wrote:\n> \"Daniel P. Berrange\" writes:\n> \n> > Since I claimed that supporting py2 & py3 in parallel would be easy\n> > for QEMU, I figured I ought to actually give it a try to backup that\n> > assertion.\n> >\n> > This small patch series is the result of that effort. I tested this\n> > series on Fedora 26 using 2.7.13 and Python 3.6.2.\n> >\n> > To test with py3, I hacked config-host.mak to change the PYTHON\n> > variable to point to 'python3' binary, then compared the following\n> > generated content for the files:\n> >\n> > qmp-commands.h qapi-types.h qapi-visit.h qapi-event.h\n> > qmp-marshal.c qapi-types.c qapi-visit.c qapi-event.c\n> > qmp-introspect.c qmp-introspect.h\n> >\n> > with that generated under py2 to see they are identical.\n> >\n> > It is possible there's still more bugs hiding that could impact\n> > on 2.6 or earlier versions of 3.x or 2.7.x, so this probably\n> > needs a bit wider testing, but I think the series illustrates\n> > the broad scope of the changes we can expect. Only the need\n> > to adapt to different module import locations adds to the\n> > line count, and that's fairly minimal.\n> \n> This hasn't made it to the front of my review queue, but I got a quick\n> question meanwhile.\n> \n> I guess this was triggered by the discussion of David's \"[PATCH]\n> scripts: Support building with Python 3\". How does it differ from\n> David's patch? Is it derived from it? Or is it an independently\n> developed replacement?\n\nI didn't notice David's existed. In terms of the qapi file changes,\nhis patch appears equivelent to combining my patches 2->5.\n\nHe didn't seem to convert the print statement to a print function\nthough (my patch 1), so I'm surprised his changes actually work\nwith py3...\n\n\nRegards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpXPb5p13z9s4s\n\tfor ;\n\tFri, 8 Sep 2017 19:40:51 +1000 (AEST)","from localhost ([::1]:44164 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqFmL-0000eB-SY\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 05:40:49 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36144)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqFlm-0000ZZ-9R\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:40:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqFlh-0003fg-Hi\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:40:14 -0400","from mx1.redhat.com ([209.132.183.28]:47902)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dqFlh-0003eL-At\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:40:09 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 58E3DC0587E5;\n\tFri, 8 Sep 2017 09:40:08 +0000 (UTC)","from redhat.com (unknown [10.33.36.66])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 0938E58829;\n\tFri, 8 Sep 2017 09:40:05 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 58E3DC0587E5","Date":"Fri, 8 Sep 2017 10:40:02 +0100","From":"\"Daniel P. Berrange\" ","To":"Markus Armbruster ","Message-ID":"<20170908094002.GH3609@redhat.com>","References":"<20170831142430.16665-1-berrange@redhat.com>\n\t<87r2vhfsc2.fsf@dusky.pond.sub.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<87r2vhfsc2.fsf@dusky.pond.sub.org>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tFri, 08 Sep 2017 09:40:08 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 0/5] qapi: support py2 & py3 in parallel","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"\"Daniel P. Berrange\" ","Cc":"David Michael , qemu-devel@nongnu.org,\n\tMichael Roth ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1765432,"web_url":"http://patchwork.ozlabs.org/comment/1765432/","msgid":"","list_archive_url":null,"date":"2017-09-08T14:51:19","subject":"Re: [Qemu-devel] [PATCH v2 0/5] qapi: support py2 & py3 in parallel","submitter":{"id":64020,"url":"http://patchwork.ozlabs.org/api/people/64020/","name":"David Michael","email":"fedora.dm0@gmail.com"},"content":"On Fri, Sep 8, 2017 at 2:40 AM, Daniel P. Berrange wrote:\n> On Fri, Sep 08, 2017 at 11:33:01AM +0200, Markus Armbruster wrote:\n>> \"Daniel P. Berrange\" writes:\n>>\n>> > Since I claimed that supporting py2 & py3 in parallel would be easy\n>> > for QEMU, I figured I ought to actually give it a try to backup that\n>> > assertion.\n>> >\n>> > This small patch series is the result of that effort. I tested this\n>> > series on Fedora 26 using 2.7.13 and Python 3.6.2.\n>> >\n>> > To test with py3, I hacked config-host.mak to change the PYTHON\n>> > variable to point to 'python3' binary, then compared the following\n>> > generated content for the files:\n>> >\n>> > qmp-commands.h qapi-types.h qapi-visit.h qapi-event.h\n>> > qmp-marshal.c qapi-types.c qapi-visit.c qapi-event.c\n>> > qmp-introspect.c qmp-introspect.h\n>> >\n>> > with that generated under py2 to see they are identical.\n>> >\n>> > It is possible there's still more bugs hiding that could impact\n>> > on 2.6 or earlier versions of 3.x or 2.7.x, so this probably\n>> > needs a bit wider testing, but I think the series illustrates\n>> > the broad scope of the changes we can expect. Only the need\n>> > to adapt to different module import locations adds to the\n>> > line count, and that's fairly minimal.\n>>\n>> This hasn't made it to the front of my review queue, but I got a quick\n>> question meanwhile.\n>>\n>> I guess this was triggered by the discussion of David's \"[PATCH]\n>> scripts: Support building with Python 3\". How does it differ from\n>> David's patch? Is it derived from it? Or is it an independently\n>> developed replacement?\n>\n> I didn't notice David's existed. In terms of the qapi file changes,\n> his patch appears equivelent to combining my patches 2->5.\n>\n> He didn't seem to convert the print statement to a print function\n> though (my patch 1), so I'm surprised his changes actually work\n> with py3...\n\nIt looks like all of those qapi.py print statements are for handling\nerrors, so my builds must not have hit any of them. I had skimmed the\noutput of pylint for errors, and it seems the print statements are\nonly listed as warnings when printing to stderr, which I had\noverlooked.\n\n W:1945, 8: Expression \"((print) >> (sys.stderr), ('%s: %s') %\n((sys.argv[0], str(err))))\" is assigned to nothing\n(expression-not-assigned\n\nAnd instead of importing the print function, I just switched to\nsys.stderr.write etc. in qapi2texi.py.\n\nThanks.\n\nDavid","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"abXXfwAR\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpgLD1gPhz9sBd\n\tfor ;\n\tSat, 9 Sep 2017 00:53:24 +1000 (AEST)","from localhost ([::1]:45826 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqKeo-0005oh-Bu\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 10:53:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60956)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqKct-0004S7-6r\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 10:51:27 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqKcr-0007mF-Ul\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 10:51:23 -0400","from mail-oi0-x244.google.com ([2607:f8b0:4003:c06::244]:34494)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dqKcr-0007jT-Q4\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 10:51:21 -0400","by mail-oi0-x244.google.com with SMTP id a197so1958036oib.1\n\tfor ; Fri, 08 Sep 2017 07:51:20 -0700 (PDT)","by 10.157.61.133 with HTTP; Fri, 8 Sep 2017 07:51:19 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=QzWmhmQwdoZiIUVsCp/pbZaB2TrbJPwpoIuuV+TZ5UM=;\n\tb=abXXfwARwnoSt/N+Hsvpf8JrdDv8xCu/+InNnpQOzEr6gZtYcRBYm0BxP6Q/FMzL11\n\tVv2SVOxTJLCEwniPHKOX/pwopLcXINftPpMSABHw/dtGLKtrL+dB9UNl8Ki4m0yeBY2s\n\t0kRWmDWa82ZUdSysz/+Cp3J4d2R99HaM0s+yO4JfkEbOuXkRECO7BqIvOrlDOBiM6qUo\n\t70AzokZecdDkHN8NQ1k9OygZlJtW2MZWL7UrkZcPc42Xk59oFJUKg3OSH1t2TXcouMUZ\n\tpSr9FipBsKlembbOHIdpkqWZyowLI8lcc7CF4wZblwGGVqMFyeMk+aK8gOiwR6u2EwDc\n\tF9dA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=QzWmhmQwdoZiIUVsCp/pbZaB2TrbJPwpoIuuV+TZ5UM=;\n\tb=kM98nf9/JEEs/+BPIMm8b2GZGgPK1qxGrvcovPKZ4Cqih1UFNpEAE+sW6yiDVqEoZE\n\t/PFZq682ZuLca5BypEWg5n/JpxKnYmUG0MYOb2pKqJLaXZKpPxXXiXtydfAQumTHFS3L\n\tGyAudCmsGiEWrjWnCzGFPnG7mml3mJ7SKCIXIf/1j9dBA3++3szq9JOSc7mWFwVpH90T\n\tBwNKKDrM09f6KIeTaDDfrbALeV4US1416IlFtzEkJhWUKE4dAN6edStPFrFKJfy1orbe\n\t4ZI4hA98XB+TcBPaPIoVm7LzU3gqa0g8NZUXHWOAXO3mslNn8p2kpUwpmch0aDvO1QH3\n\tnFzQ==","X-Gm-Message-State":"AHPjjUgqf9MGtpA2wxGnlNnPth/k6a/I/scVsxGbnGpL/Omy39X4CZEB\n\th6y6cR1Ox3m4267V4HK+johDeDzTkw==","X-Google-Smtp-Source":"ADKCNb51SyDu5keGsJQ+o0wv/WaibI68RCaNuSkSLwq0tah+Z28mWZ1IgOWAP9eRBMRextNSXqZz1+nAvijeX5NuprA=","X-Received":"by 10.202.214.81 with SMTP id n78mr2668751oig.297.1504882279764; \n\tFri, 08 Sep 2017 07:51:19 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170908094002.GH3609@redhat.com>","References":"<20170831142430.16665-1-berrange@redhat.com>\n\t<87r2vhfsc2.fsf@dusky.pond.sub.org>\n\t<20170908094002.GH3609@redhat.com>","From":"David Michael ","Date":"Fri, 8 Sep 2017 07:51:19 -0700","Message-ID":"","To":"\"Daniel P. Berrange\" ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:4003:c06::244","Subject":"Re: [Qemu-devel] [PATCH v2 0/5] qapi: support py2 & py3 in parallel","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Michael Roth ,\n\tMarkus Armbruster , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]