[{"id":1785717,"web_url":"http://patchwork.ozlabs.org/comment/1785717/","msgid":"<20171012182624.GH1165@minitux>","list_archive_url":null,"date":"2017-10-12T18:26:24","subject":"Re: [PATCH v3 1/6] remoteproc: qcom: mdt_loader: Make the firmware\n\tauthentication optional","submitter":{"id":68398,"url":"http://patchwork.ozlabs.org/api/people/68398/","name":"Bjorn Andersson","email":"bjorn.andersson@linaro.org"},"content":"On Wed 30 Aug 21:45 PDT 2017, Sricharan R wrote:\n\n> qcom_mdt_load function loads the mdt type firmware and\n> initialises the secure memory as well. Make the initialisation only\n> when requested by the caller, so that the function can be used\n> by self-authenticating remoteproc as well.\n> \n> Signed-off-by: Sricharan R \n> ---\n> drivers/soc/qcom/mdt_loader.c | 70 +++++++++++++++++++++++++++++++------\n> include/linux/soc/qcom/mdt_loader.h | 3 ++\n> 2 files changed, 62 insertions(+), 11 deletions(-)\n> \n> diff --git a/drivers/soc/qcom/mdt_loader.c b/drivers/soc/qcom/mdt_loader.c\n> index bd63df0..851f5d7 100644\n> --- a/drivers/soc/qcom/mdt_loader.c\n> +++ b/drivers/soc/qcom/mdt_loader.c\n> @@ -86,9 +86,9 @@ ssize_t qcom_mdt_get_size(const struct firmware *fw)\n> *\n> * Returns 0 on success, negative errno otherwise.\n> */\n\nThis kerneldoc is now lacks @pas_init, but as it's just an internal\nfunction and you have kerneldoc on the public functions I suggest that\nyou drop it.\n\n> -int qcom_mdt_load(struct device *dev, const struct firmware *fw,\n> -\t\t const char *firmware, int pas_id, void *mem_region,\n> -\t\t phys_addr_t mem_phys, size_t mem_size)\n> +static int __qcom_mdt_load(struct device *dev, const struct firmware *fw,\n> +\t\t\t const char *firmware, int pas_id, void *mem_region,\n> +\t\t\t phys_addr_t mem_phys, size_t mem_size, bool pas_init)\n\nWith this you have my Acked-by.\n\nRegards,\nBjorn\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"iY+j2oBL\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yCfSh1Vp9z9sNc\n\tfor ;\n\tFri, 13 Oct 2017 05:26:44 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751542AbdJLS0a (ORCPT\n\t);\n\tThu, 12 Oct 2017 14:26:30 -0400","from mail-pf0-f170.google.com ([209.85.192.170]:56678 \"EHLO\n\tmail-pf0-f170.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751067AbdJLS02 (ORCPT\n\t); Thu, 12 Oct 2017 14:26:28 -0400","by mail-pf0-f170.google.com with SMTP id b85so6024700pfj.13\n\tfor ;\n\tThu, 12 Oct 2017 11:26:28 -0700 (PDT)","from minitux (ip68-111-217-79.sd.sd.cox.net. [68.111.217.79])\n\tby smtp.gmail.com with ESMTPSA id\n\tq9sm24723816pgs.1.2017.10.12.11.26.26\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 12 Oct 2017 11:26:27 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=XnCZVx84AMOcIF1y/rL1n2eGy9pa3yvU3wR/mM7PR/w=;\n\tb=iY+j2oBLScl0K5e5QP2GkHt31JkF34EhcTMkIBtCFFhiqpTaCFw8sQaK/MF6w4IUA+\n\tu/MNx+rO9SiXgbKfaJI0Rz30ZWp7+B4G2vWEh8ESuit9rk7JHFxpkAE2KSMbj0MxA2Ly\n\tPxGKrZELyK3XVz3kE8h2n7Y79oxGF+KGp38b4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=XnCZVx84AMOcIF1y/rL1n2eGy9pa3yvU3wR/mM7PR/w=;\n\tb=h6tRQVk9BXavvBTCTkEo0fMQCsYEUFm/bfCtN+uNP+yx8BeAF5uM3zajLybFnxQd0p\n\tQXaBMf/r5AqqoQvu2Q6wASe9rrOatvd58/Id4JdKg2HN0oiQhmkQUiK04SCTy53r8TTL\n\t8twx1sDyyqQgtl1JdUXs5H1OJBxiYKeAZPam5xzT10dwvUYrS09tR7ywRvtDKv10V8mc\n\tt2c1xrgPwa59GyEofvh5KUlVWwJHINHrOZLShHxKYJ34puA3adoHx9CBnf1qUcBCo1Go\n\tHftQs/d4rmqYyfgnVbl5ppKeXd9CgIhjE+nAW1+LwKK+bwcvZi6UxV3yBqjuhkgHiiWr\n\tmvMQ==","X-Gm-Message-State":"AMCzsaW3L/Wu2QeqXatQbuIJzJyfYwaSecN37fbl9cu0p+X67Tse2bxs\n\tTEZ6z5ZZa538ov58aPK6cf2HOw==","X-Google-Smtp-Source":"AOwi7QBBnWYrmMPNWrRqoxYzHmgUGqyUbPMa9n7RLw/STtRmqrVwPm/Bpu7zl+t7wSwRSz7Tl3QhSw==","X-Received":"by 10.84.232.76 with SMTP id f12mr910487pln.269.1507832788050;\n\tThu, 12 Oct 2017 11:26:28 -0700 (PDT)","Date":"Thu, 12 Oct 2017 11:26:24 -0700","From":"Bjorn Andersson ","To":"Sricharan R ","Cc":"ohad@wizery.com, robh+dt@kernel.org, mark.rutland@arm.com,\n\tandy.gross@linaro.org, david.brown@linaro.org,\n\tlinux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,\n\tlinux-soc@vger.kernel.org","Subject":"Re: [PATCH v3 1/6] remoteproc: qcom: mdt_loader: Make the firmware\n\tauthentication optional","Message-ID":"<20171012182624.GH1165@minitux>","References":"<1504154734-12175-1-git-send-email-sricharan@codeaurora.org>\n\t<1504154734-12175-2-git-send-email-sricharan@codeaurora.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1504154734-12175-2-git-send-email-sricharan@codeaurora.org>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1790129,"web_url":"http://patchwork.ozlabs.org/comment/1790129/","msgid":"<59a7c297-8cc1-f16f-c890-ed13959da102@codeaurora.org>","list_archive_url":null,"date":"2017-10-19T05:22:52","subject":"Re: [PATCH v3 1/6] remoteproc: qcom: mdt_loader: Make the firmware\n\tauthentication optional","submitter":{"id":65960,"url":"http://patchwork.ozlabs.org/api/people/65960/","name":"Sricharan Ramabadhran","email":"sricharan@codeaurora.org"},"content":"Hi Bjorn,\n\nOn 10/12/2017 11:56 PM, Bjorn Andersson wrote:\n> On Wed 30 Aug 21:45 PDT 2017, Sricharan R wrote:\n> \n>> qcom_mdt_load function loads the mdt type firmware and\n>> initialises the secure memory as well. Make the initialisation only\n>> when requested by the caller, so that the function can be used\n>> by self-authenticating remoteproc as well.\n>>\n>> Signed-off-by: Sricharan R \n>> ---\n>> drivers/soc/qcom/mdt_loader.c | 70 +++++++++++++++++++++++++++++++------\n>> include/linux/soc/qcom/mdt_loader.h | 3 ++\n>> 2 files changed, 62 insertions(+), 11 deletions(-)\n>>\n>> diff --git a/drivers/soc/qcom/mdt_loader.c b/drivers/soc/qcom/mdt_loader.c\n>> index bd63df0..851f5d7 100644\n>> --- a/drivers/soc/qcom/mdt_loader.c\n>> +++ b/drivers/soc/qcom/mdt_loader.c\n>> @@ -86,9 +86,9 @@ ssize_t qcom_mdt_get_size(const struct firmware *fw)\n>> *\n>> * Returns 0 on success, negative errno otherwise.\n>> */\n> \n> This kerneldoc is now lacks @pas_init, but as it's just an internal\n> function and you have kerneldoc on the public functions I suggest that\n> you drop it.\n> \n\n Sure. Will change.\n\n>> -int qcom_mdt_load(struct device *dev, const struct firmware *fw,\n>> -\t\t const char *firmware, int pas_id, void *mem_region,\n>> -\t\t phys_addr_t mem_phys, size_t mem_size)\n>> +static int __qcom_mdt_load(struct device *dev, const struct firmware *fw,\n>> +\t\t\t const char *firmware, int pas_id, void *mem_region,\n>> +\t\t\t phys_addr_t mem_phys, size_t mem_size, bool pas_init)\n> \n> With this you have my Acked-by.\n> \n\n Thanks.\n\nRegards,\n Sricharan","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"dFt94RO9\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n\theader.d=codeaurora.org header.i=@codeaurora.org header.b=\"dFt94RO9\"; \n\tdkim-atps=neutral","pdx-caf-mail.web.codeaurora.org;\n\tdmarc=none (p=none dis=none) header.from=codeaurora.org","pdx-caf-mail.web.codeaurora.org;\n\tspf=none smtp.mailfrom=sricharan@codeaurora.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yHclC4fbfz9s7p\n\tfor ;\n\tThu, 19 Oct 2017 16:23:03 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751479AbdJSFXC (ORCPT\n\t);\n\tThu, 19 Oct 2017 01:23:02 -0400","from smtp.codeaurora.org ([198.145.29.96]:46174 \"EHLO\n\tsmtp.codeaurora.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750899AbdJSFXA (ORCPT\n\t); Thu, 19 Oct 2017 01:23:00 -0400","by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid D557B6025D; Thu, 19 Oct 2017 05:22:59 +0000 (UTC)","from [10.201.3.39]\n\t(blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com\n\t[103.229.19.19])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\t(Authenticated sender: sricharan@smtp.codeaurora.org)\n\tby smtp.codeaurora.org (Postfix) with ESMTPSA id AEA816025D;\n\tThu, 19 Oct 2017 05:22:55 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1508390579;\n\tbh=ybYMm6o3FozVEi9mGpbAIafoUG+njMUeBg1fk2I95wk=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=dFt94RO9iwwySD8ddMNGmmRd8+E74ZSY0JkLmk4qiPNbIDDHu4/cFoKYYuD7WtxX5\n\tlAVI7j2fFS7HKDFqbs0BF4Rk88ExXOozU7Npc9sy/1z8yWPkVNuGAGPhFHQlVvZXUY\n\twpohUA2XM/X5+UAoaPubiwama1mBGxPvzF9D0K0k=","v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1508390579;\n\tbh=ybYMm6o3FozVEi9mGpbAIafoUG+njMUeBg1fk2I95wk=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=dFt94RO9iwwySD8ddMNGmmRd8+E74ZSY0JkLmk4qiPNbIDDHu4/cFoKYYuD7WtxX5\n\tlAVI7j2fFS7HKDFqbs0BF4Rk88ExXOozU7Npc9sy/1z8yWPkVNuGAGPhFHQlVvZXUY\n\twpohUA2XM/X5+UAoaPubiwama1mBGxPvzF9D0K0k="],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tpdx-caf-mail.web.codeaurora.org","X-Spam-Level":"","X-Spam-Status":"No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00,\n\tDKIM_SIGNED,\n\tT_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0","DMARC-Filter":"OpenDMARC Filter v1.3.2 smtp.codeaurora.org AEA816025D","Subject":"Re: [PATCH v3 1/6] remoteproc: qcom: mdt_loader: Make the firmware\n\tauthentication optional","To":"Bjorn Andersson ","Cc":"ohad@wizery.com, robh+dt@kernel.org, mark.rutland@arm.com,\n\tandy.gross@linaro.org, david.brown@linaro.org,\n\tlinux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,\n\tlinux-soc@vger.kernel.org","References":"<1504154734-12175-1-git-send-email-sricharan@codeaurora.org>\n\t<1504154734-12175-2-git-send-email-sricharan@codeaurora.org>\n\t<20171012182624.GH1165@minitux>","From":"Sricharan R ","Message-ID":"<59a7c297-8cc1-f16f-c890-ed13959da102@codeaurora.org>","Date":"Thu, 19 Oct 2017 10:52:52 +0530","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<20171012182624.GH1165@minitux>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Antivirus":"Avast (VPS 171018-10, 10/19/2017), Outbound message","X-Antivirus-Status":"Clean","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]