[{"id":1761414,"web_url":"http://patchwork.ozlabs.org/comment/1761414/","msgid":"<1504227536.5933.34.camel@aj.id.au>","list_archive_url":null,"date":"2017-09-01T00:58:56","subject":"Re: [PATCH linux dev-4.10 v6 0/3] Add user space accessibility for\n\tucd9000 stats","submitter":{"id":68332,"url":"http://patchwork.ozlabs.org/api/people/68332/","name":"Andrew Jeffery","email":"andrew@aj.id.au"},"content":"On Wed, 2017-08-30 at 16:49 -0500, Christopher Bostic wrote:\n> This set provides means to allow user space to access various properties of the\n> ucd9000 type chips.\n> \n> Patch 0001 Adds a user space means of clearing logged faults.  This ability is\n> useful in cases where one wants to start with a clean slate during each system\n> power on.\n> \n> patch 0002 Adds gpio_chip interface for user to access various GPIO pin states\n> via the /sys/class/gpio interface.\n> \n> Patch 0003 adds a debugfs for mfr_status information so user space can gain\n> visibility of gpi type faults. Note that there are limitations on type of devices\n> that debugfs supports.  Presently only ucd90160 is supported.  Any assumptions made\n> as to formatting of data is commented inline in the code.  Any expansion to other\n> ucd9000 types will need to take this into consideration.\n> \n> Note also that no pinmux support is provided at this point.  The ucd9000 devs do\n> have mux capability so this should be added.\n> \n> Patch 0003 (was patch v5-0002... previously) has been reviewed by Andrew Jeffery,\n> I did, however, add some small updates to this one:\n> \n> * Remove ida in bad and unbind paths.\n> * Remove type ucd90160 check when adding debugfs. Add for all ucd9000 devs.\n>   Results in cleaner ida code in the remove path.\n\nThanks for the summary and for splitting out the patch introducing the\nnew ABI.\n\nUnfortunately upstream NACKed what you've put as the first patch in\nyour series. In the future, it's best to order controversial patches\nlater, that way we can apply the uncontroversial patches without fuzz\nor failures from context/content dependencies.\n\nSo given I can't apply the first patch as we know it won't go upstream,\nI can't apply the rest either due to hunks failing or fuzzing. Can you\nplease respin, and given you need to do that, take into account\nGuenter's feedback?\n\nCheers,\n\nAndrew\n\n> \n> Christopher Bostic (3):\n>   hwmon: (ucd9000) Add interface to clear logged faults.\n>   hwmon: (ucd9000) Add gpio chip interface\n>   hwmon: (ucd9000) Add debugfs to list mfr_status info\n> \n>  drivers/hwmon/pmbus/ucd9000.c | 415 +++++++++++++++++++++++++++++++++++++++++-\n>  1 file changed, 413 insertions(+), 2 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","openbmc@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xk19016N0z9ryv\n\tfor ;\n\tFri, 1 Sep 2017 10:59:16 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xk18z6nsDzDqgx\n\tfor ;\n\tFri, 1 Sep 2017 10:59:15 +1000 (AEST)","from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n\t[66.111.4.25])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xk18q36gqzDqgk\n\tfor ; Fri, 1 Sep 2017 10:59:07 +1000 (AEST)","from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id F3EA020D54;\n\tThu, 31 Aug 2017 20:59:04 -0400 (EDT)","from frontend1 ([10.202.2.160])\n\tby compute4.internal (MEProxy); Thu, 31 Aug 2017 20:59:04 -0400","from keelia (ppp14-2-65-251.bras21.adl6.internode.on.net\n\t[14.2.65.251])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 59A437E7AD;\n\tThu, 31 Aug 2017 20:59:03 -0400 (EDT)"],"Authentication-Results":["ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"r7E6DoOD\";\n\tdkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"clOOZgvE\"; \n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"r7E6DoOD\";\n\tdkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"clOOZgvE\"; \n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"r7E6DoOD\";\n\tdkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com\n\theader.b=\"clOOZgvE\"; dkim-atps=neutral"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc\n\t:content-type:date:from:in-reply-to:message-id:mime-version\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc\n\t:x-sasl-enc; s=fm1; bh=o2Jf9yo+1G3eiVreB7KitNoITKNxHifnLn19DipJc\n\tHE=; b=r7E6DoOD8yX+y17FnNjmugz6O0KoMhRDWRgk6vm7WBxn9fzoVP3n//qrj\n\tU5shEc6o6azrAfKkV/ovnVnny3HOroZKEbzcl3IrEKnnCqtCYVDKN9/JF/j1TdoA\n\t335iIOKS7po5h2TgR+0nl+UJRqpP/5ODDprzIy8/iiUYNm4GWecPw5Gnf1tIkRd2\n\tt9jsxbY538yMIG4FcUwCidZ8LVT5mS29VGn9iXGiVz1P+dRh8TG5E+PV255yH91+\n\tcATQKzfKCH6guxSHeCo178LlUoA/pD7o/JpOIDXD0aYhLidYf41/MoZ9UBIE87K+\n\tzV5EnPMQucJJy9m7IYcNx3Bm+TF6Q==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to:x-me-sender\n\t:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=o2Jf9yo+1G3eiVreB7\n\tKitNoITKNxHifnLn19DipJcHE=; b=clOOZgvEHkGp+Am6uj++d3jZhCc/vaQd+o\n\tpiuphj073LAQW9UHK+WO6mPj8DmhU+lPo+CzLnu6OTIucZlEYFuKMYUG0gepLbhp\n\t4huPdYUHZYrLFi8ELLi4b6Gsb85fqpCNKVLCIvhYI2cA79AI8WqgJUsVfrPHl33w\n\tOKPp8ANBfg2rUvo8WthzUsCPwLkrOKzG8UyKg1XY2GpdJHTSo7PMXaCXbzuAwM3R\n\tJe4RjeNSOQKaos9Fm/BRcKMln2XlVqSnT3APjzZQkEkjUtU1Z2DMNH5N7kRyq5c2\n\tViN0+TMfAzYsggoHns4KBmuTYQ5WUP5EzK5RLU6LGd+ks9fisSlw=="],"X-ME-Sender":"","X-Sasl-enc":"Nw+CSBfl7xU+frbYJMdbJiRMTG4cAgjZZp6T2kkiqI69 1504227544","Message-ID":"<1504227536.5933.34.camel@aj.id.au>","Subject":"Re: [PATCH linux dev-4.10 v6 0/3] Add user space accessibility for\n\tucd9000 stats","From":"Andrew Jeffery ","To":"Christopher Bostic , joel@jms.id.au","Date":"Fri, 01 Sep 2017 10:28:56 +0930","In-Reply-To":"<20170830214953.73327-1-cbostic@linux.vnet.ibm.com>","References":"<20170830214953.73327-1-cbostic@linux.vnet.ibm.com>","Content-Type":"multipart/signed; micalg=\"pgp-sha512\";\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"=-8S/H6TPAWpXngKLKUTyz\"","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Mime-Version":"1.0","X-BeenThere":"openbmc@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Development list for OpenBMC ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"openbmc@lists.ozlabs.org","Errors-To":"openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"openbmc\"\n\t"}},{"id":1764350,"web_url":"http://patchwork.ozlabs.org/comment/1764350/","msgid":"<7b4467f2-c405-709e-d2b8-c4f53f28c4a7@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-06T20:24:26","subject":"Re: [PATCH linux dev-4.10 v6 0/3] Add user space accessibility for\n\tucd9000 stats","submitter":{"id":70879,"url":"http://patchwork.ozlabs.org/api/people/70879/","name":"Christopher Bostic","email":"cbostic@linux.vnet.ibm.com"},"content":"On 8/31/17 7:58 PM, Andrew Jeffery wrote:\n> On Wed, 2017-08-30 at 16:49 -0500, Christopher Bostic wrote:\n>> This set provides means to allow user space to access various properties of the\n>> ucd9000 type chips.\n>>\n>> Patch 0001 Adds a user space means of clearing logged faults. This ability is\n>> useful in cases where one wants to start with a clean slate during each system\n>> power on.\n>>\n>> patch 0002 Adds gpio_chip interface for user to access various GPIO pin states\n>> via the /sys/class/gpio interface.\n>>\n>> Patch 0003 adds a debugfs for mfr_status information so user space can gain\n>> visibility of gpi type faults. Note that there are limitations on type of devices\n>> that debugfs supports. Presently only ucd90160 is supported. Any assumptions made\n>> as to formatting of data is commented inline in the code. Any expansion to other\n>> ucd9000 types will need to take this into consideration.\n>>\n>> Note also that no pinmux support is provided at this point. The ucd9000 devs do\n>> have mux capability so this should be added.\n>>\n>> Patch 0003 (was patch v5-0002... previously) has been reviewed by Andrew Jeffery,\n>> I did, however, add some small updates to this one:\n>>\n>> * Remove ida in bad and unbind paths.\n>> * Remove type ucd90160 check when adding debugfs. Add for all ucd9000 devs.\n>> Results in cleaner ida code in the remove path.\n> Thanks for the summary and for splitting out the patch introducing the\n> new ABI.\n>\n> Unfortunately upstream NACKed what you've put as the first patch in\n> your series. In the future, it's best to order controversial patches\n> later, that way we can apply the uncontroversial patches without fuzz\n> or failures from context/content dependencies.\n>\n> So given I can't apply the first patch as we know it won't go upstream,\n> I can't apply the rest either due to hunks failing or fuzzing. Can you\n> please respin, and given you need to do that, take into account\n> Guenter's feedback?\n\nHi Andrew,\n\nYes will do that.\n\nThanks,\nChris\n\n> Cheers,\n>\n> Andrew\n>\n>> Christopher Bostic (3):\n>> hwmon: (ucd9000) Add interface to clear logged faults.\n>> hwmon: (ucd9000) Add gpio chip interface\n>> hwmon: (ucd9000) Add debugfs to list mfr_status info\n>>\n>> drivers/hwmon/pmbus/ucd9000.c | 415 +++++++++++++++++++++++++++++++++++++++++-\n>> 1 file changed, 413 insertions(+), 2 deletions(-)","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","openbmc@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnZnP4GZzz9sNd\n\tfor ;\n\tThu, 7 Sep 2017 06:24:41 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xnZnP3LTxzDrVn\n\tfor ;\n\tThu, 7 Sep 2017 06:24:41 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xnZnG6sh3zDrSV\n\tfor ; Thu, 7 Sep 2017 06:24:33 +1000 (AEST)","from pps.filterd (m0098417.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv86KNpnX014835\n\tfor ; Wed, 6 Sep 2017 16:24:31 -0400","from e18.ny.us.ibm.com (e18.ny.us.ibm.com [129.33.205.208])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2ctq574v1p-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 06 Sep 2017 16:24:31 -0400","from localhost\n\tby e18.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tWed, 6 Sep 2017 16:24:30 -0400","from b01cxnp22034.gho.pok.ibm.com (9.57.198.24)\n\tby e18.ny.us.ibm.com (146.89.104.205) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 6 Sep 2017 16:24:28 -0400","from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com\n\t[9.57.199.108])\n\tby b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v86KORMD23724126; Wed, 6 Sep 2017 20:24:27 GMT","from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 5626EB2056;\n\tWed, 6 Sep 2017 16:21:50 -0400 (EDT)","from christophersmbp.austin.ibm.com (unknown [9.41.175.36])\n\tby b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP id F38F4B204E;\n\tWed, 6 Sep 2017 16:21:49 -0400 (EDT)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=cbostic@linux.vnet.ibm.com; receiver=)","Subject":"Re: [PATCH linux dev-4.10 v6 0/3] Add user space accessibility for\n\tucd9000 stats","To":"Andrew Jeffery , joel@jms.id.au","References":"<20170830214953.73327-1-cbostic@linux.vnet.ibm.com>\n\t<1504227536.5933.34.camel@aj.id.au>","From":"Christopher Bostic ","Date":"Wed, 6 Sep 2017 15:24:26 -0500","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0)\n\tGecko/20100101 Thunderbird/45.7.0","MIME-Version":"1.0","In-Reply-To":"<1504227536.5933.34.camel@aj.id.au>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17090620-0044-0000-0000-0000038A1191","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007679; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00913226; UDB=6.00458324;\n\tIPR=6.00693488; \n\tBA=6.00005574; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017039;\n\tXFM=3.00000015; UTC=2017-09-06 20:24:29","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090620-0045-0000-0000-000007B91187","Message-Id":"<7b4467f2-c405-709e-d2b8-c4f53f28c4a7@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-06_06:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709060292","X-BeenThere":"openbmc@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Development list for OpenBMC ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"openbmc@lists.ozlabs.org","Errors-To":"openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"openbmc\"\n\t"}}]