[{"id":1760413,"web_url":"http://patchwork.ozlabs.org/comment/1760413/","msgid":"<20170830190119.GK22289@lunn.ch>","list_archive_url":null,"date":"2017-08-30T19:01:19","subject":"Re: [PATCH 0/5] net: mdio-mux: Misc fix","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Wed, Aug 30, 2017 at 07:46:46PM +0200, Corentin Labbe wrote:\n> Hello\n> \n> This patch series fix minor problems found when working on the\n> dwmac-sun8i syscon mdio-mux.\n\nHi Corentin\n\nIn general, a nice patchset.\n\nLooking at the code, there are a few calls to devm_kfree() which look\nredundant. This one should probably stay:\n\n\t \tif (r) {\n\t\t\tmdiobus_free(cb->mii_bus);\n\t\t\tdevm_kfree(dev, cb);\n\t\t} else {\n\nbut i think the others can go.\n\nJust a suggestion, not a problem if you don't feel like doing this...\n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjFGl6JgLz9sN5\n\tfor ;\n\tThu, 31 Aug 2017 05:01:35 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751283AbdH3TBX (ORCPT );\n\tWed, 30 Aug 2017 15:01:23 -0400","from vps0.lunn.ch ([178.209.37.122]:45441 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750757AbdH3TBV (ORCPT );\n\tWed, 30 Aug 2017 15:01:21 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dn8Ep-0000ku-Jm; Wed, 30 Aug 2017 21:01:19 +0200"],"Date":"Wed, 30 Aug 2017 21:01:19 +0200","From":"Andrew Lunn ","To":"Corentin Labbe ","Cc":"f.fainelli@gmail.com, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 0/5] net: mdio-mux: Misc fix","Message-ID":"<20170830190119.GK22289@lunn.ch>","References":"<20170830174651.30325-1-clabbe.montjoie@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170830174651.30325-1-clabbe.montjoie@gmail.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1761517,"web_url":"http://patchwork.ozlabs.org/comment/1761517/","msgid":"<20170901083015.GA6203@Red>","list_archive_url":null,"date":"2017-09-01T08:30:15","subject":"Re: [PATCH 0/5] net: mdio-mux: Misc fix","submitter":{"id":64152,"url":"http://patchwork.ozlabs.org/api/people/64152/","name":"Corentin Labbe","email":"clabbe.montjoie@gmail.com"},"content":"On Wed, Aug 30, 2017 at 09:01:19PM +0200, Andrew Lunn wrote:\n> On Wed, Aug 30, 2017 at 07:46:46PM +0200, Corentin Labbe wrote:\n> > Hello\n> > \n> > This patch series fix minor problems found when working on the\n> > dwmac-sun8i syscon mdio-mux.\n> \n> Hi Corentin\n> \n> In geineral, a nice patchset.\n\nThanks, I will send a v2 with your suggestions.\n\n> \n> Looking at the code, there are a few calls to devm_kfree() which look\n> redundant. This one should probably stay:\n> \n> \t \tif (r) {\n> \t\t\tmdiobus_free(cb->mii_bus);\n> \t\t\tdevm_kfree(dev, cb);\n> \t\t} else {\n> \n> but i think the others can go.\n> \n> Just a suggestion, not a problem if you don't feel like doing this...\n> \n\nI will try but in another serie. For letting more time for test.\n\nRegards","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"LYFAWtgh\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkCB00VTDz9sPk\n\tfor ;\n\tFri, 1 Sep 2017 18:30:48 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751463AbdIAIaZ (ORCPT );\n\tFri, 1 Sep 2017 04:30:25 -0400","from mail-wr0-f194.google.com ([209.85.128.194]:38413 \"EHLO\n\tmail-wr0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751237AbdIAIaY (ORCPT\n\t); Fri, 1 Sep 2017 04:30:24 -0400","by mail-wr0-f194.google.com with SMTP id j3so948177wrb.5;\n\tFri, 01 Sep 2017 01:30:23 -0700 (PDT)","from Red ([2a01:cb1d:16e:1300:2e56:dcff:fed2:c6d6])\n\tby smtp.googlemail.com with ESMTPSA id\n\tc18sm1877110wmd.5.2017.09.01.01.30.21\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 01 Sep 2017 01:30:22 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=Sv9eu9iH2JEYl5bb7Rqn70BqKp2C1Z+soriwXpaKs28=;\n\tb=LYFAWtgh+VkthHiV4zXDblSBDQsf6X86aszz9B3HM6LEVK9PblLfFB+/4m5z8xddkI\n\tseSG2/XIbQZ/dpw8R9TpkaQLtGcMvb4JMpCa+YOEa7jwlkj66wre8CzlF6PchjkNp/Qq\n\tGWS45f6t3p/C/wMLjjOtoastpj+I4lzqKqpfCTsvoQV7PWheilSVxkvcvhM8ymoP7eFF\n\tg0QnKsuoA2bZDYdKTtkj8Ja4SgceQto6028rqy0zoNbuSD4QmJ9mIPhPy40O/BXR/t3i\n\txzQT9OV9D/yi2FoJ+GrO++1zJLEL/PYPL/F8oJyELG02CY1NsrfBhl6DXbPPv6M3hSn6\n\t0Imw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=Sv9eu9iH2JEYl5bb7Rqn70BqKp2C1Z+soriwXpaKs28=;\n\tb=s4J45dU12A/26qIsMQT3dhRQ7VSCFlqKDnArI+WMdTE0pIJ7foHBZLWQJINGiecI+e\n\t2cXs+NlAzY0qiEzsTho2HjvwKDV9Uo0KccJLt/P5Q/gMbTih2xmXPGJKbAJUBYLspuPo\n\t+GsqpTNCiXaLy/0j9wqrhs4MDDCvC11nkGqgK1zaGGsh3hY9bsg755k9t4IOWJvQLxGG\n\tu+GA4F3eV6Co0OnafBBpystDJbAMO9wI44ABu9nqU6EGjK+6lxqOz4Itb3Dl+w+0eXAp\n\twOkIQe0Pd5+qC605CrRo8KvwVDH1GGfY1iM3cTJBn1N3jpwIteqjZJg58mpbLH0JUy6V\n\t71zg==","X-Gm-Message-State":"AHPjjUjfnlUlMy/29HhIW8VCd3TfiGnS97ktQnQmYT4hpJXyDZCw0huD\n\txF3k4pj48Trs+g==","X-Google-Smtp-Source":"ADKCNb5EoBqoDkLqGesok3Udt9yLrxpynh1WCXts4oE28RjMwsoa4ZcbZ0tLm+n6h+/Lr1+0CuqxEw==","X-Received":"by 10.223.196.199 with SMTP id o7mr741856wrf.176.1504254622636; \n\tFri, 01 Sep 2017 01:30:22 -0700 (PDT)","Date":"Fri, 1 Sep 2017 10:30:15 +0200","From":"Corentin Labbe ","To":"Andrew Lunn ","Cc":"f.fainelli@gmail.com, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 0/5] net: mdio-mux: Misc fix","Message-ID":"<20170901083015.GA6203@Red>","References":"<20170830174651.30325-1-clabbe.montjoie@gmail.com>\n\t<20170830190119.GK22289@lunn.ch>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170830190119.GK22289@lunn.ch>","User-Agent":"Mutt/1.7.2 (2016-11-26)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]