[{"id":1761074,"web_url":"http://patchwork.ozlabs.org/comment/1761074/","msgid":"<20170831164535.74070de3.cohuck@redhat.com>","list_archive_url":null,"date":"2017-08-31T14:45:35","subject":"Re: [Qemu-devel] [PATCH v1 00/11] next round of s390x cleanups","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 30 Aug 2017 19:05:50 +0200\nDavid Hildenbrand wrote:\n\n> No new functionality, only cleanups, some of the discussed during the last\n> round of cleanups.\n> \n> Not sure if the first two patches should be sent separatly? Anyhow, they\n> are most probably not worth the trouble :)\n\nIf you want to clean up the other unneeded includes of cpu-all.h as\nwell, it might make sense to send them separately. Otherwise, I'm happy\nto route them through s390-next if nobody complains.\n\n> \n> The biggest part of this series is getting rid of s390-virtio.c and\n> cleaning up our cpu number/id handling.\n> \n> Based on: git://github.com/cohuck/qemu s390-next\n\nLooking forward to v2 :)\n\n> \n> \n> David Hildenbrand (11):\n> exec,dump: don't include exec/exec-all.h explicitly\n> cpu: drop old comments describing members\n> s390x: store cpu states inside machine state\n> s390x: get rid of s390-virtio.c\n> s390x: rename s390-virtio.h to s390-virtio-hcall.h\n> target/s390x: cleanup cpu number/address handling\n> target/s390x: rename next_cpu_id to next_cpu_addr\n> s390x: allow only 1 CPU with TCG\n> target/s390x: tcg_s390_program_interrupt() will never return\n> target/s390x: use trigger_pgm_exception() in\n> s390_cpu_handle_mmu_fault()\n> target/s390x: use program_interrupt() in per_check_exception()\n> \n> dump.c | 1 -\n> exec.c | 1 -\n> hw/s390x/Makefile.objs | 1 -\n> hw/s390x/s390-virtio-ccw.c | 169 ++++++++++++++++++++++++++++++-\n> hw/s390x/s390-virtio-hcall.c | 2 +-\n> hw/s390x/s390-virtio-hcall.h | 20 ++++\n> hw/s390x/s390-virtio.c | 201 -------------------------------------\n> hw/s390x/s390-virtio.h | 35 -------\n> include/hw/s390x/s390-virtio-ccw.h | 3 +\n> include/qom/cpu.h | 6 +-\n> target/s390x/cpu-qom.h | 2 +-\n> target/s390x/cpu.c | 74 ++++----------\n> target/s390x/cpu.h | 5 +-\n> target/s390x/cpu_models.c | 2 +-\n> target/s390x/excp_helper.c | 5 +-\n> target/s390x/helper.c | 8 +-\n> target/s390x/interrupt.c | 3 +-\n> target/s390x/misc_helper.c | 13 +--\n> target/s390x/translate.c | 5 +-\n> 19 files changed, 230 insertions(+), 326 deletions(-)\n> create mode 100644 hw/s390x/s390-virtio-hcall.h\n> delete mode 100644 hw/s390x/s390-virtio.c\n> delete mode 100644 hw/s390x/s390-virtio.h\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjlYY6VxJz9s75\n\tfor ;\n\tFri, 1 Sep 2017 00:46:09 +1000 (AEST)","from localhost ([::1]:56160 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnQjQ-0007df-16\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 10:46:08 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50093)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnQj5-0007dO-2Q\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 10:45:48 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnQj1-0007by-Vy\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 10:45:47 -0400","from mx1.redhat.com ([209.132.183.28]:52912)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnQj1-0007ba-MF\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 10:45:43 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 7B8B94E33B;\n\tThu, 31 Aug 2017 14:45:42 +0000 (UTC)","from gondolin (ovpn-117-247.ams2.redhat.com [10.36.117.247])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 56FAAB23F3;\n\tThu, 31 Aug 2017 14:45:37 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 7B8B94E33B","Date":"Thu, 31 Aug 2017 16:45:35 +0200","From":"Cornelia Huck ","To":"David Hildenbrand ","Message-ID":"<20170831164535.74070de3.cohuck@redhat.com>","In-Reply-To":"<20170830170601.15855-1-david@redhat.com>","References":"<20170830170601.15855-1-david@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tThu, 31 Aug 2017 14:45:42 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 00/11] next round of s390x cleanups","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Richard Henderson ,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tborntraeger@de.ibm.com, Aurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]