[{"id":1760800,"web_url":"http://patchwork.ozlabs.org/comment/1760800/","msgid":"<20170831120407.447b0206.cohuck@redhat.com>","list_archive_url":null,"date":"2017-08-31T10:04:07","subject":"Re: [Qemu-devel] [PATCH 0/9]","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 30 Aug 2017 18:36:00 +0200\nHalil Pasic wrote:\n\n> This series has a character of a refactoring, as the initial motivation\n> was improving readability and reducing complexity.\n\nBut you reduced the cover letter subject too much ;)\n\n> \n> Despite of the original intent the tree first patches buxfixes, and\n> according to Dong Jia the patch-set also has a functional value: for ccw\n> pass-through, he is planing to pass-through the instruction completion\n> information (cc or interruption condition) from the kernel, and this\n> patch set can pretty much be seen as a preparation for that.\n\nI think the first one (with the precedence fixed as well) is pretty\nuncontroversial, and I'd be happy to queue an updated version.\n\n> \n> The basic idea is: tell how to handle an unusual conditon where it's\n> identified, instead of mapping it to an errno (more or less arbitrarily),\n> then possibly mapping these errnos around, to finally (mentally) map the\n> errno back to the condition and take appropriate action. \n> \n> At the end of the series we also have 125 lines of code less to maintain,\n> and the executable got a bit smaller too.\n\nI agree with the basic direction, but I think this needs more hashing\nout.\n\n> \n> Halil Pasic (9):\n> s390x/css: fix cc handling for XSCH\n> s390x: fix invalid use of cc 1 for SSCH\n> s390x/css: be more consistent if broken beyond repair\n> s390x: refactor error handling for SSCH and RSCH\n> s390x: refactor error handling for XSCH handler\n> s390x: refactor error handling for CSCH handler\n> s390x: refactor error handling for HSCH handler\n> s390x: refactor error handling for MSCH handler\n> s390x: factor out common ioinst handler logic\n> \n> hw/s390x/css.c | 158 ++++++++++++--------------------------\n> hw/s390x/s390-ccw.c | 8 +-\n> hw/vfio/ccw.c | 32 ++++++--\n> include/hw/s390x/css.h | 38 +++++++---\n> include/hw/s390x/s390-ccw.h | 2 +-\n> target/s390x/ioinst.c | 181 ++++++++++----------------------------------\n> 6 files changed, 147 insertions(+), 272 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjdJr0VQMz9sD9\n\tfor ;\n\tThu, 31 Aug 2017 20:04:42 +1000 (AEST)","from localhost ([::1]:54742 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnML2-0001kG-I0\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 06:04:40 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34102)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnMKc-0001fZ-N9\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:04:18 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnMKZ-0000ZO-JD\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:04:14 -0400","from mx1.redhat.com ([209.132.183.28]:50824)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnMKZ-0000Z7-E3\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:04:11 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 5808C267F6;\n\tThu, 31 Aug 2017 10:04:10 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 8FB2C841C1;\n\tThu, 31 Aug 2017 10:04:09 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 5808C267F6","Date":"Thu, 31 Aug 2017 12:04:07 +0200","From":"Cornelia Huck ","To":"Halil Pasic ","Message-ID":"<20170831120407.447b0206.cohuck@redhat.com>","In-Reply-To":"<20170830163609.50260-1-pasic@linux.vnet.ibm.com>","References":"<20170830163609.50260-1-pasic@linux.vnet.ibm.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tThu, 31 Aug 2017 10:04:10 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 0/9]","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Dong Jia Shi ,\n\tPierre Morel , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760829,"web_url":"http://patchwork.ozlabs.org/comment/1760829/","msgid":"","list_archive_url":null,"date":"2017-08-31T10:43:48","subject":"Re: [Qemu-devel] [PATCH 0/9]","submitter":{"id":68297,"url":"http://patchwork.ozlabs.org/api/people/68297/","name":"Halil Pasic","email":"pasic@linux.vnet.ibm.com"},"content":"On 08/31/2017 12:04 PM, Cornelia Huck wrote:\n> On Wed, 30 Aug 2017 18:36:00 +0200\n> Halil Pasic wrote:\n> \n>> This series has a character of a refactoring, as the initial motivation\n>> was improving readability and reducing complexity.\n> \n> But you reduced the cover letter subject too much ;)\n\nNoticed that after sending. The plan was to copy paste\nit form the internal version, but I'm no good at copy-pasting.\n\n> \n>>\n>> Despite of the original intent the tree first patches buxfixes, and\n>> according to Dong Jia the patch-set also has a functional value: for ccw\n>> pass-through, he is planing to pass-through the instruction completion\n>> information (cc or interruption condition) from the kernel, and this\n>> patch set can pretty much be seen as a preparation for that.\n> \n> I think the first one (with the precedence fixed as well) is pretty\n> uncontroversial, and I'd be happy to queue an updated version.\n> \n\nI will send it as a stand-alone patch (probably today).\n\n>>\n>> The basic idea is: tell how to handle an unusual conditon where it's\n>> identified, instead of mapping it to an errno (more or less arbitrarily),\n>> then possibly mapping these errnos around, to finally (mentally) map the\n>> errno back to the condition and take appropriate action. \n>>\n>> At the end of the series we also have 125 lines of code less to maintain,\n>> and the executable got a bit smaller too.\n> \n> I agree with the basic direction, but I think this needs more hashing\n> out.\n> \n\nI'm sure we will sort the details out.\n\n>>\n>> Halil Pasic (9):\n>> s390x/css: fix cc handling for XSCH\n>> s390x: fix invalid use of cc 1 for SSCH\n>> s390x/css: be more consistent if broken beyond repair\n>> s390x: refactor error handling for SSCH and RSCH\n>> s390x: refactor error handling for XSCH handler\n>> s390x: refactor error handling for CSCH handler\n>> s390x: refactor error handling for HSCH handler\n>> s390x: refactor error handling for MSCH handler\n>> s390x: factor out common ioinst handler logic\n>>\n>> hw/s390x/css.c | 158 ++++++++++++--------------------------\n>> hw/s390x/s390-ccw.c | 8 +-\n>> hw/vfio/ccw.c | 32 ++++++--\n>> include/hw/s390x/css.h | 38 +++++++---\n>> include/hw/s390x/s390-ccw.h | 2 +-\n>> target/s390x/ioinst.c | 181 ++++++++++----------------------------------\n>> 6 files changed, 147 insertions(+), 272 deletions(-)\n>>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjfYf2sWtz9sQl\n\tfor ;\n\tThu, 31 Aug 2017 21:00:54 +1000 (AEST)","from localhost ([::1]:54992 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnNDQ-0002Br-Az\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 07:00:52 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44494)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnMy2-0001yN-Tb\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:45:00 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnMxy-00014J-0Z\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:44:58 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:38334)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnMxx-000149-O1\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:44:53 -0400","from pps.filterd (m0098393.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7VAieGP126266\n\tfor ; Thu, 31 Aug 2017 06:44:52 -0400","from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cpa7d05dd-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Thu, 31 Aug 2017 06:44:51 -0400","from localhost\n\tby e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tThu, 31 Aug 2017 11:43:51 +0100","from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195)\n\tby e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tThu, 31 Aug 2017 11:43:50 +0100","from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com\n\t[9.149.105.61])\n\tby b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v7VAhnge10027078; Thu, 31 Aug 2017 10:43:49 GMT","from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 8C55111C04C;\n\tThu, 31 Aug 2017 11:40:19 +0100 (BST)","from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 263B911C04A;\n\tThu, 31 Aug 2017 11:40:19 +0100 (BST)","from oc3836556865.ibm.com (unknown [9.152.224.207])\n\tby d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tThu, 31 Aug 2017 11:40:19 +0100 (BST)"],"To":"Cornelia Huck ","References":"<20170830163609.50260-1-pasic@linux.vnet.ibm.com>\n\t<20170831120407.447b0206.cohuck@redhat.com>","From":"Halil Pasic ","Date":"Thu, 31 Aug 2017 12:43:48 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<20170831120407.447b0206.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17083110-0008-0000-0000-00000491A2E5","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17083110-0009-0000-0000-00001E21F866","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-31_03:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708310163","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH 0/9]","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Dong Jia Shi ,\n\tPierre Morel , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]