[{"id":1762412,"web_url":"http://patchwork.ozlabs.org/comment/1762412/","msgid":"<20170904042945.GA2735@umbus.fritz.box>","list_archive_url":null,"date":"2017-09-04T04:29:45","subject":"Re: [Qemu-devel] [PATCH v2 0/8] ppc: cpu_model handling cleanups","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Wed, Aug 30, 2017 at 03:24:27PM +0200, Igor Mammedov wrote:\n> \n> Changelog since v1:\n> - normalize all cpu model names to lower-case\n> - check that all cpu model string is consumed\n> before going to PVR lookup path\n> - add a new optional patch to remove unused junk\n> '[PATCH v2 8/8] ppc: remove non implemented cpu models'\n> - pull in dependency patch from\n> https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg03364.html\n> 'ppc: replace cpu_ppc_init() with cpu_generic_init()'\n> so this series won't depend unnecessarily on another series\n> \n> While removing cpu_init() tree-wide, I've stumbled uppon\n> PPC way of parsing cpu_model which looked way too complex\n> compared to other targets.\n> \n> So here goes cleanups that instead of current inconsistent\n> way of dealing with cpu models\n> - mix of case-(in)sensetive lookups and cpu model names\n> - aliases pointing to another aliases\n> normalize cpu model names to upper-case and make aliases\n> point to cpu moldel names. These changes allow to simplify\n> cpu model handling quite a bit and make it look/behave\n> a bit more in line with other targets.\n> \n> Patches are not must have for cpu_init() removal but make\n> it a little bit easier without need to deal with way of\n> conversion of cpu model to cpu type, so pls consider\n> merging it early once 2.11 merge window is open if\n> patches make any sense.\n\nPatches 1..7 applied to ppc-for-2.11. Still reading the thread of\ncomments on patch 8.\n\n> \n> \n> repo for testing:\n> https://github.com/imammedo/qemu.git ppc_cpu_model_cleanups_V2\n> \n> CC: David Gibson \n> CC: Alexander Graf \n> CC: qemu-ppc@nongnu.org\n> \n> Igor Mammedov (8):\n> ppc: replace cpu_ppc_init() with cpu_generic_init()\n> ppc: use macros to make cpu type name from string literal\n> ppc: make cpu_model translation to type consistent\n> ppc: make cpu alias point only to real cpu models\n> ppc: replace inter-function cyclic dependency/recurssion with 2 simple\n> lookups\n> ppc: simplify cpu model lookup by PVR\n> ppc: drop caching ObjectClass from PowerPCCPUAlias\n> ppc: remove non implemented cpu models\n> \n> target/ppc/cpu-models.h | 3 +-\n> target/ppc/cpu.h | 6 +-\n> target/ppc/kvm_ppc.h | 2 +-\n> hw/ppc/e500.c | 3 +-\n> hw/ppc/mac_newworld.c | 3 +-\n> hw/ppc/mac_oldworld.c | 3 +-\n> hw/ppc/ppc440_bamboo.c | 2 +-\n> hw/ppc/ppc4xx_devs.c | 2 +-\n> hw/ppc/prep.c | 5 +-\n> hw/ppc/spapr_cpu_core.c | 24 +-\n> hw/ppc/virtex_ml507.c | 2 +-\n> target/ppc/cpu-models.c | 1023 ++++++++++++-------------------------------\n> target/ppc/kvm.c | 5 +-\n> target/ppc/translate_init.c | 105 ++---\n> 14 files changed, 344 insertions(+), 844 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"mfLJPLk6\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xly7q4FhNz9s7M\n\tfor ;\n\tMon, 4 Sep 2017 14:49:58 +1000 (AEST)","from localhost ([::1]:58198 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dojKe-0004aO-CR\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 00:49:56 -0400","from eggs.gnu.org ([208.118.235.92]:60687)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dojHP-0003a8-V5\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 00:49:35 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dojGL-0002Dx-VG\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 00:46:35 -0400","from ozlabs.org ([103.22.144.67]:49081)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dojGL-000271-37; Mon, 04 Sep 2017 00:45:29 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xly2T2fxwz9s8J; Mon, 4 Sep 2017 14:45:21 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1504500321;\n\tbh=TsVihFXmunPEZLexsyxWb0UBiMwot3UW+DNaQjB4YG8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mfLJPLk6vd9uSKD9I9M+t7Vvexf0VnRZ8VEccT9cTbjXxCPao9wstpWlCB5GRLT9L\n\tVudHwcLft8tIFZb2qfrhXju/j2HnoOwSiukVU8buq3c8ILVK5eXZ2kljCSggwkHQMj\n\tC3qrRT+C3U87L0bXvBGi0O2coHM2TCvLJKMmViMU=","Date":"Mon, 4 Sep 2017 14:29:45 +1000","From":"David Gibson ","To":"Igor Mammedov ","Message-ID":"<20170904042945.GA2735@umbus.fritz.box>","References":"<1504099475-241036-1-git-send-email-imammedo@redhat.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"IS0zKkzwUGydFO0o\"","Content-Disposition":"inline","In-Reply-To":"<1504099475-241036-1-git-send-email-imammedo@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"103.22.144.67","Subject":"Re: [Qemu-devel] [PATCH v2 0/8] ppc: cpu_model handling cleanups","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-ppc@nongnu.org, qemu-devel@nongnu.org,\n\tAlexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]