[{"id":1760352,"web_url":"http://patchwork.ozlabs.org/comment/1760352/","msgid":"<20170830171759.GC22289@lunn.ch>","list_archive_url":null,"date":"2017-08-30T17:17:59","subject":"Re: [net-next PATCHv6 2/2] net: socionext: Add NetSec driver","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"> +static int netsec_mac_update_to_phy_state(struct netsec_priv *priv)\n> +{\n> +\tstruct phy_device *phydev = priv->ndev->phydev;\n> +\tu32 value = 0;\n> +\n> +\tvalue = phydev->duplex ? NETSEC_GMAC_MCR_REG_FULL_DUPLEX_COMMON :\n> +\t\t\t\t       NETSEC_GMAC_MCR_REG_HALF_DUPLEX_COMMON;\n> +\n> +\tif (phydev->speed != SPEED_1000)\n> +\t\tvalue |= NETSEC_MCR_PS;\n> +\n> +\tif ((priv->phy_interface != PHY_INTERFACE_MODE_GMII) &&\n> +\t    (phydev->speed == SPEED_100))\n> +\t\tvalue |= NETSEC_GMAC_MCR_REG_FES;\n> +\n> +\tvalue |= NETSEC_GMAC_MCR_REG_CST | NETSEC_GMAC_MCR_REG_JE;\n> +\n> +\tif (priv->phy_interface == PHY_INTERFACE_MODE_RGMII)\n> +\t\tvalue |= NETSEC_GMAC_MCR_REG_IBN;\n> +\n> +\tif (netsec_mac_write(priv, GMAC_REG_MCR, value))\n> +\t\treturn -ETIMEDOUT;\n> +\n> +\tpriv->actual_link_speed = phydev->speed;\n> +\tpriv->actual_duplex = phydev->duplex;\n> +\tnetif_info(priv, drv, priv->ndev, \"%s: %uMbps, duplex:%d\\n\",\n> +\t\t   __func__, phydev->speed, phydev->duplex);\n\nphy_print_status()\n\n> +\tmac = of_get_mac_address(pdev->dev.of_node);\n> +\tif (mac)\n> +\t\tether_addr_copy(ndev->dev_addr, mac);\n> +\n> +\tif (!is_valid_ether_addr(ndev->dev_addr)) {\n> +\t\teth_hw_addr_random(ndev);\n> +\t\tdev_warn(&pdev->dev, \"No MAC address found, using random\\n\");\n> +\t}\n\nSo the mac address is optional, unlike what the binding document says.\n\n> +\tpriv->phy_np = of_parse_phandle(pdev->dev.of_node, \"phy-handle\", 0);\n> +\tif (!priv->phy_np) {\n> +\t\tnetif_err(priv, probe, ndev, \"missing phy in DT\\n\");\n\nIt is the phy-handle which is missing, not the phy.\n\n> +\n> +\t/* MTU range */\n> +\tndev->min_mtu = ETH_MIN_MTU;\n\nNo need to set this, it is the default.\n\nOtherwise, this looks good, in terms of phy and mdio.\n\n\t   Andrew\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjBzM1YbTz9s8P\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 03:18:07 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752011AbdH3RSF (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tWed, 30 Aug 2017 13:18:05 -0400","from vps0.lunn.ch ([178.209.37.122]:45296 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751984AbdH3RSF (ORCPT <rfc822;devicetree@vger.kernel.org>);\n\tWed, 30 Aug 2017 13:18:05 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from <andrew@lunn.ch>)\n\tid 1dn6cp-0007in-Nt; Wed, 30 Aug 2017 19:17:59 +0200"],"Date":"Wed, 30 Aug 2017 19:17:59 +0200","From":"Andrew Lunn <andrew@lunn.ch>","To":"Jassi Brar <jassisinghbrar@gmail.com>","Cc":"netdev@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, davem@davemloft.net,\n\tmark.rutland@arm.com, arnd@arndb.de, patches@linaro.org,\n\tJassi Brar <jaswinder.singh@linaro.org>, robh+dt@kernel.org,\n\tandy@warmcat.com","Subject":"Re: [net-next PATCHv6 2/2] net: socionext: Add NetSec driver","Message-ID":"<20170830171759.GC22289@lunn.ch>","References":"<1504088657-6102-1-git-send-email-jaswinder.singh@linaro.org>\n\t<1504088771-6255-1-git-send-email-jaswinder.singh@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1504088771-6255-1-git-send-email-jaswinder.singh@linaro.org>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1760631,"web_url":"http://patchwork.ozlabs.org/comment/1760631/","msgid":"<27A7C5A5-AFF4-49F3-B0DF-7F53283EC2A4@gmail.com>","list_archive_url":null,"date":"2017-08-31T04:06:25","subject":"Re: [net-next PATCHv6 0/2] net: ethernet: Socionext Netsec","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On August 30, 2017 3:24:17 AM PDT, Jassi Brar <jassisinghbrar@gmail.com> wrote:\n>Hello,\n>\n>The OGMA/Netsec controller is used in latest SoC from\n>Socionext/Fujitsu.\n>\n>I am refreshing the patchset by basically using official name of the IP\n>from 'OGMA' to 'Netsec'. And the company is renamed too, from Fujitsu\n>to Socionext to better reflect the reality.\n>\n> I have addressed comments (that could be) on the last revision -->\n>https://patchwork.kernel.org/patch/4540651/\n>\n> Of course, I have scanned changes to the drivers/net/ethernet since\n>last submission and integrated whichever applicable and rebased the\n>driver on top of last rc.\n\nIt does not appear to be at first glance, but I will just ask anyways, this is not yet another variant of stmmac glued just a little bit differently into the SoC right?\n\nWill take a closer look at the register set and driver tomorrow. Thanks","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"OkAlmxcD\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjTMY2SSNz9s71\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 14:06:33 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750814AbdHaEGb (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tThu, 31 Aug 2017 00:06:31 -0400","from mail-oi0-f65.google.com ([209.85.218.65]:34093 \"EHLO\n\tmail-oi0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750714AbdHaEGa (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Thu, 31 Aug 2017 00:06:30 -0400","by mail-oi0-f65.google.com with SMTP id w10so7269245oie.1;\n\tWed, 30 Aug 2017 21:06:30 -0700 (PDT)","from ?IPv6:2001:470:d:73f:10ca:f176:623b:9249?\n\t([2001:470:d:73f:10ca:f176:623b:9249])\n\tby smtp.gmail.com with ESMTPSA id\n\tx81sm2542663oix.4.2017.08.30.21.06.28\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 30 Aug 2017 21:06:29 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:subject:to:cc:from:message-id;\n\tbh=hsNpMld8HRqs4/j7j+XZqmBOuCztbvPrQdcYjv7AJlM=;\n\tb=OkAlmxcDok06Xv+O/YfE2Jr4goqdg4zjsLbfxmwDTLNM/OB2IC/7bgCNHn31A2cLxs\n\tH41uTCj7+mdt0dEkS5KPv3sdiFSu3vFlFaeebYhZic/mpsZIAAI/YhGN63rSVr7BQ1cm\n\tlxw+tXyZ6B42oiTKHy+C9vJxsi/HeahisNqHUgRPPa3Q8VbF5d9HTFF44AY7yEDVtl0b\n\tU3lsJr0opwYvYmlkdsvvmaCaT2bJyTizxdmxjexhqm2QuzKCWflXmIi6Cz0UXppNcbHZ\n\t57D1zVBpZqmQKllC1/nxumLmBOxQgrzpGRE9iNU5mx5LOWGVS3yFiEqzzpUKLDGDTNSX\n\tbUYg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:user-agent:in-reply-to:references\n\t:mime-version:content-transfer-encoding:subject:to:cc:from\n\t:message-id;\n\tbh=hsNpMld8HRqs4/j7j+XZqmBOuCztbvPrQdcYjv7AJlM=;\n\tb=VB2DPdexaOTMd18hYxdmQObMwFzSi5S2EWKhD+rJNUDZiHzvkke1QILs8itb2Sh6Th\n\tw+qbeAezShL4ZbrbEE+ClNnaMK6G+n9NjZzWxi9Gzm/2JFdpGSkrYWhtugSX4kXTrPWt\n\t0nGOH2NNNFCiJI6xw7NzY3IuosroWVkDIsp+eUMLGw/fZN0Bj61toEB+uscSWGmB4KAZ\n\t3eUaf9DZD3wf1p/SMnKgeSzLb78TgBUlUlr+lLnmznIhEdXa+qsJHyxzzSJ/1hPgeBUh\n\tBaojjdkHRYp4gk7nMHaZNsQ9naixDMpBKwRMUo+VDB5Zer1tjGSOqzWrXHBVVnvUymfQ\n\tEUSQ==","X-Gm-Message-State":"AHYfb5hwLMMujYlkM38CNAUjhSaffKrD4Bn3O99TFZk5UtgydAfzm8aQ\n\t7bdOYYEMXNY2vw==","X-Received":"by 10.202.166.68 with SMTP id p65mr4060026oie.252.1504152390239; \n\tWed, 30 Aug 2017 21:06:30 -0700 (PDT)","Date":"Wed, 30 Aug 2017 21:06:25 -0700","User-Agent":"K-9 Mail for Android","In-Reply-To":"<1504088657-6102-1-git-send-email-jaswinder.singh@linaro.org>","References":"<1504088657-6102-1-git-send-email-jaswinder.singh@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain;\n charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [net-next PATCHv6 0/2] net: ethernet: Socionext Netsec","To":"linux-arm-kernel@lists.infradead.org,\n\tJassi Brar <jassisinghbrar@gmail.com>, netdev@vger.kernel.org,\n\tdevicetree@vger.kernel.org, davem@davemloft.net","CC":"mark.rutland@arm.com, arnd@arndb.de, patches@linaro.org,\n\tJassi Brar <jaswinder.singh@linaro.org>, robh+dt@kernel.org,\n\tandy@warmcat.com","From":"Florian Fainelli <f.fainelli@gmail.com>","Message-ID":"<27A7C5A5-AFF4-49F3-B0DF-7F53283EC2A4@gmail.com>","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1760670,"web_url":"http://patchwork.ozlabs.org/comment/1760670/","msgid":"<CABb+yY0r8ZgeYTdmYqTd3RhUnr1ufOaUUe3+81Q2JKm+xY8PRQ@mail.gmail.com>","list_archive_url":null,"date":"2017-08-31T06:31:37","subject":"Re: [net-next PATCHv6 0/2] net: ethernet: Socionext Netsec","submitter":{"id":4220,"url":"http://patchwork.ozlabs.org/api/people/4220/","name":"Jassi Brar","email":"jassisinghbrar@gmail.com"},"content":"On Thu, Aug 31, 2017 at 9:36 AM, Florian Fainelli <f.fainelli@gmail.com> wrote:\n> On August 30, 2017 3:24:17 AM PDT, Jassi Brar <jassisinghbrar@gmail.com> wrote:\n>>Hello,\n>>\n>>The OGMA/Netsec controller is used in latest SoC from\n>>Socionext/Fujitsu.\n>>\n>>I am refreshing the patchset by basically using official name of the IP\n>>from 'OGMA' to 'Netsec'. And the company is renamed too, from Fujitsu\n>>to Socionext to better reflect the reality.\n>>\n>> I have addressed comments (that could be) on the last revision -->\n>>https://patchwork.kernel.org/patch/4540651/\n>>\n>> Of course, I have scanned changes to the drivers/net/ethernet since\n>>last submission and integrated whichever applicable and rebased the\n>>driver on top of last rc.\n>\n> It does not appear to be at first glance, but I will just ask anyways, this is not yet another variant of stmmac glued just a little bit differently into the SoC right?\n>\nSorry, no idea. I will be glad if we could reuse existing code.\n\nThanks.\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"qgL5Cpyr\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjXb22GM5z9s7F\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 16:31:42 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750893AbdHaGbk (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tThu, 31 Aug 2017 02:31:40 -0400","from mail-wm0-f68.google.com ([74.125.82.68]:35141 \"EHLO\n\tmail-wm0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750863AbdHaGbj (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Thu, 31 Aug 2017 02:31:39 -0400","by mail-wm0-f68.google.com with SMTP id e204so3887648wma.2;\n\tWed, 30 Aug 2017 23:31:39 -0700 (PDT)","by 10.80.214.21 with HTTP; Wed, 30 Aug 2017 23:31:37 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=g57qyzK1PCRLDi/VwQPpAiNXEwV+bz6zP04FMZT91sk=;\n\tb=qgL5CpyrUWxW/J04b3fRvsIVMdehsQLaIJ0MkciQhk4ljlQFMY0kZTObQtVk9ruxEe\n\tZBXQVBB6zLpYqe8d2YEHcCPxuusXNUQjT1bbKoRc16+ljyXX2FcnnoOqR9urkTyKNgnX\n\tcdfIlaBbGjjC9s7wJTEgbQsxF6Zjv2tesALXzfUmva4zzEA/8vo+8ZqMACwW+IAIK2bU\n\toSvHQBuy1X2ySgBhK6lujWgjRSLTqpLOMxfI6I6cA5ZjXszCjXdkyq9gMHy28yjyy1N9\n\t9byRmlVzwgjalBfBae1rU/PhqkOS4E/mwuyeH1BnykS9TOM0naNo28eAnGVaRbTMgzva\n\tcoHw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=g57qyzK1PCRLDi/VwQPpAiNXEwV+bz6zP04FMZT91sk=;\n\tb=rsfNwiEg9DLqIaGw+BWVGKruerxFb0cK213pCOgwbfO5Cb0a38109QnYNWDStpdnHF\n\t2Tx8Rpwga9KuASDSUXLAZgJOQb5mqzVvHgTaxvcR9ORfAgD5SJh/i1mT3lVmjgXoNgKJ\n\tU+w3L+xn4dmQdBie3orL6hH4r7OBsZmUg6XWDYrAmxmOzzaJeorqR5a7L4c9XAN6/EIo\n\tw7asb7PGcJGrzhdcPl48yyG7WctJqr6lBvuDv94WxQBDmhIsf0KpUbFNFGY6xLCNqzCN\n\tqsJBdidgPhZxE9CopDcoa1BU3vU47cxgt5lwIKSegUW/36Y0asF6Ihg8xM7AApzFIXOg\n\tyAFA==","X-Gm-Message-State":"AHYfb5g1qWKgP8VAl4IfKAiuIqunWAwSTvk5wcfdKLd2H4YzJb9sBfO/\n\t77unR73K1qL3JsIqsY1WfF1/G2crvA==","X-Received":"by 10.80.210.211 with SMTP id q19mr703936edg.186.1504161098426; \n\tWed, 30 Aug 2017 23:31:38 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<27A7C5A5-AFF4-49F3-B0DF-7F53283EC2A4@gmail.com>","References":"<1504088657-6102-1-git-send-email-jaswinder.singh@linaro.org>\n\t<27A7C5A5-AFF4-49F3-B0DF-7F53283EC2A4@gmail.com>","From":"Jassi Brar <jassisinghbrar@gmail.com>","Date":"Thu, 31 Aug 2017 12:01:37 +0530","Message-ID":"<CABb+yY0r8ZgeYTdmYqTd3RhUnr1ufOaUUe3+81Q2JKm+xY8PRQ@mail.gmail.com>","Subject":"Re: [net-next PATCHv6 0/2] net: ethernet: Socionext Netsec","To":"Florian Fainelli <f.fainelli@gmail.com>","Cc":"\"linux-arm-kernel@lists.infradead.org\" \n\t<linux-arm-kernel@lists.infradead.org>, netdev@vger.kernel.org,\n\tDevicetree List <devicetree@vger.kernel.org>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tMark Rutland <mark.rutland@arm.com>, \"arnd@arndb.de\" <arnd@arndb.de>, \n\t\"patches@linaro.org\" <patches@linaro.org>,\n\tJassi Brar <jaswinder.singh@linaro.org>,\n\tRob Herring <robh+dt@kernel.org>, Andy Green <andy@warmcat.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1760673,"web_url":"http://patchwork.ozlabs.org/comment/1760673/","msgid":"<CABb+yY2TJhRFEh806ODZkxUYQNik8zjR8dVK6PR1mO=bT1KeGg@mail.gmail.com>","list_archive_url":null,"date":"2017-08-31T06:33:06","subject":"Re: [net-next PATCHv6 2/2] net: socionext: Add NetSec driver","submitter":{"id":4220,"url":"http://patchwork.ozlabs.org/api/people/4220/","name":"Jassi Brar","email":"jassisinghbrar@gmail.com"},"content":"On Wed, Aug 30, 2017 at 10:47 PM, Andrew Lunn <andrew@lunn.ch> wrote:\n>> +static int netsec_mac_update_to_phy_state(struct netsec_priv *priv)\n>> +{\n>> +     struct phy_device *phydev = priv->ndev->phydev;\n>> +     u32 value = 0;\n>> +\n>> +     value = phydev->duplex ? NETSEC_GMAC_MCR_REG_FULL_DUPLEX_COMMON :\n>> +                                    NETSEC_GMAC_MCR_REG_HALF_DUPLEX_COMMON;\n>> +\n>> +     if (phydev->speed != SPEED_1000)\n>> +             value |= NETSEC_MCR_PS;\n>> +\n>> +     if ((priv->phy_interface != PHY_INTERFACE_MODE_GMII) &&\n>> +         (phydev->speed == SPEED_100))\n>> +             value |= NETSEC_GMAC_MCR_REG_FES;\n>> +\n>> +     value |= NETSEC_GMAC_MCR_REG_CST | NETSEC_GMAC_MCR_REG_JE;\n>> +\n>> +     if (priv->phy_interface == PHY_INTERFACE_MODE_RGMII)\n>> +             value |= NETSEC_GMAC_MCR_REG_IBN;\n>> +\n>> +     if (netsec_mac_write(priv, GMAC_REG_MCR, value))\n>> +             return -ETIMEDOUT;\n>> +\n>> +     priv->actual_link_speed = phydev->speed;\n>> +     priv->actual_duplex = phydev->duplex;\n>> +     netif_info(priv, drv, priv->ndev, \"%s: %uMbps, duplex:%d\\n\",\n>> +                __func__, phydev->speed, phydev->duplex);\n>\n> phy_print_status()\n>\n>> +     mac = of_get_mac_address(pdev->dev.of_node);\n>> +     if (mac)\n>> +             ether_addr_copy(ndev->dev_addr, mac);\n>> +\n>> +     if (!is_valid_ether_addr(ndev->dev_addr)) {\n>> +             eth_hw_addr_random(ndev);\n>> +             dev_warn(&pdev->dev, \"No MAC address found, using random\\n\");\n>> +     }\n>\n> So the mac address is optional, unlike what the binding document says.\n>\n>> +     priv->phy_np = of_parse_phandle(pdev->dev.of_node, \"phy-handle\", 0);\n>> +     if (!priv->phy_np) {\n>> +             netif_err(priv, probe, ndev, \"missing phy in DT\\n\");\n>\n> It is the phy-handle which is missing, not the phy.\n>\n>> +\n>> +     /* MTU range */\n>> +     ndev->min_mtu = ETH_MIN_MTU;\n>\n> No need to set this, it is the default.\n>\n> Otherwise, this looks good, in terms of phy and mdio.\n>\nWill fix these.\n\nThanks.\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"lQ+wPlfd\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjXcl1G2xz9sMN\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 16:33:11 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750790AbdHaGdJ (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tThu, 31 Aug 2017 02:33:09 -0400","from mail-wm0-f65.google.com ([74.125.82.65]:35929 \"EHLO\n\tmail-wm0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750757AbdHaGdI (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Thu, 31 Aug 2017 02:33:08 -0400","by mail-wm0-f65.google.com with SMTP id i76so3872089wme.3;\n\tWed, 30 Aug 2017 23:33:08 -0700 (PDT)","by 10.80.214.21 with HTTP; Wed, 30 Aug 2017 23:33:06 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=/jYBGw2te320D+oU/5/+wX+I/ZHHU4acVsbbajvX944=;\n\tb=lQ+wPlfdiB2T3RhTesOOwe82xHs6GCJq9Tz5g7fHUrRfMS9cCWyea1kP/9Fx2tdS0F\n\tQJ0MN1jedgWx3V01tUzR27abWBc/5768SaLTh26eK1A14LZoJymkctcWHqaTKOaLcI+R\n\tHTTByzs0JVk1XKhn/mCv9fX1lk/Fyj79nF8lfkVKQfEwSaETMSKOk55HHVsod2D9GjdN\n\tuRgczQFsmINgmwE2nijlimYTXxjLBxPMvOid35JCfN5CWKEzV95H93G8NLbHvrTV5tFg\n\tyGVtiZr3SSD1/ZgHzwLPFl/3pQW8qMgEX2TtTQcxAGV39hMQGWIHuQCLOLX/lzfKjehc\n\tKbzQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=/jYBGw2te320D+oU/5/+wX+I/ZHHU4acVsbbajvX944=;\n\tb=H58/69NetlLuV17T2Y8TqAUM3JvD9QShN4nSEKxFgYbWw+Nfl6HZD7qwdi9TyRB/J5\n\tKyJG/n1hnHAajFdU6Mbd5qYsBOSe80Pv3YuC/synOu2DVThLTrn4tt3j61ATqquukgZ4\n\trf7NsF9tXhMjS9oEIkfQ9pNUptLayDrYRiu2+/zbdlvLTi8wUE9b2Ul6VLD4r44AyFgG\n\teMygf2tmMF6Ic8FLV9UzeuBeN8SEeyW2/3R1x4dOgNNMaQWj5MCKz1aILrFuB12mR04V\n\tDBEGxUR7K1Hd5m6TqLXXFgWEoNQrBp7m7DoFEoY5tbMgEUCZq4x+EgDbpetmTE8GMsta\n\tUrXg==","X-Gm-Message-State":"AHYfb5ilt8msYuS0GCSgda/mQFO4fQXlqsa9pC1YZNKszWAQ2/x1XUia\n\t0bh8J3f4V/2QLGT1TZdD38jXBcIC9CXm","X-Received":"by 10.80.196.66 with SMTP id w2mr659267edf.225.1504161187398;\n\tWed, 30 Aug 2017 23:33:07 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170830171759.GC22289@lunn.ch>","References":"<1504088657-6102-1-git-send-email-jaswinder.singh@linaro.org>\n\t<1504088771-6255-1-git-send-email-jaswinder.singh@linaro.org>\n\t<20170830171759.GC22289@lunn.ch>","From":"Jassi Brar <jassisinghbrar@gmail.com>","Date":"Thu, 31 Aug 2017 12:03:06 +0530","Message-ID":"<CABb+yY2TJhRFEh806ODZkxUYQNik8zjR8dVK6PR1mO=bT1KeGg@mail.gmail.com>","Subject":"Re: [net-next PATCHv6 2/2] net: socionext: Add NetSec driver","To":"Andrew Lunn <andrew@lunn.ch>","Cc":"netdev@vger.kernel.org, Devicetree List <devicetree@vger.kernel.org>,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t<linux-arm-kernel@lists.infradead.org>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tMark Rutland <mark.rutland@arm.com>, \"arnd@arndb.de\" <arnd@arndb.de>, \n\t\"patches@linaro.org\" <patches@linaro.org>,\n\tJassi Brar <jaswinder.singh@linaro.org>,\n\tRob Herring <robh+dt@kernel.org>, Andy Green <andy@warmcat.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}}]