[{"id":1760513,"web_url":"http://patchwork.ozlabs.org/comment/1760513/","msgid":"<20170830.143915.721461254974312457.davem@davemloft.net>","list_archive_url":null,"date":"2017-08-30T21:39:15","subject":"Re: [patch net-next v2 0/3] net/sched: Improve getting objects by\n\tindexes","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Chris Mi \nDate: Wed, 30 Aug 2017 02:31:56 -0400\n\n> Using current TC code, it is very slow to insert a lot of rules.\n> \n> In order to improve the rules update rate in TC,\n> we introduced the following two changes:\n> 1) changed cls_flower to use IDR to manage the filters.\n> 2) changed all act_xxx modules to use IDR instead of\n> a small hash table\n> \n> But IDR has a limitation that it uses int. TC handle uses u32.\n> To make sure there is no regression, we add several new IDR APIs\n> to support unsigned long.\n> \n> v2\n> ==\n> \n> Addressed Hannes's comment:\n> express idr_alloc in terms of idr_alloc_ext and most of the other functions\n\nSeries applied, thanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjJml6DjLz9s8P\n\tfor ;\n\tThu, 31 Aug 2017 07:39:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751236AbdH3VjS (ORCPT );\n\tWed, 30 Aug 2017 17:39:18 -0400","from shards.monkeyblade.net ([184.105.139.130]:34346 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750885AbdH3VjR (ORCPT\n\t); Wed, 30 Aug 2017 17:39:17 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 68C2A133FDE6A;\n\tWed, 30 Aug 2017 14:39:16 -0700 (PDT)"],"Date":"Wed, 30 Aug 2017 14:39:15 -0700 (PDT)","Message-Id":"<20170830.143915.721461254974312457.davem@davemloft.net>","To":"chrism@mellanox.com","Cc":"netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com,\n\tjiri@resnulli.us, mawilcox@microsoft.com","Subject":"Re: [patch net-next v2 0/3] net/sched: Improve getting objects by\n\tindexes","From":"David Miller ","In-Reply-To":"<1504074719-15147-1-git-send-email-chrism@mellanox.com>","References":"<1504074719-15147-1-git-send-email-chrism@mellanox.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Wed, 30 Aug 2017 14:39:16 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1760591,"web_url":"http://patchwork.ozlabs.org/comment/1760591/","msgid":"","list_archive_url":null,"date":"2017-08-31T01:05:40","subject":"RE: [patch net-next v2 0/3] net/sched: Improve getting objects by\n\tindexes","submitter":{"id":72170,"url":"http://patchwork.ozlabs.org/api/people/72170/","name":"Chris Mi","email":"chrism@mellanox.com"},"content":"> -----Original Message-----\n> From: David Miller [mailto:davem@davemloft.net]\n> Sent: Thursday, August 31, 2017 5:39 AM\n> To: Chris Mi \n> Cc: netdev@vger.kernel.org; jhs@mojatatu.com;\n> xiyou.wangcong@gmail.com; jiri@resnulli.us; mawilcox@microsoft.com\n> Subject: Re: [patch net-next v2 0/3] net/sched: Improve getting objects by\n> indexes\n> \n> From: Chris Mi \n> Date: Wed, 30 Aug 2017 02:31:56 -0400\n> \n> > Using current TC code, it is very slow to insert a lot of rules.\n> >\n> > In order to improve the rules update rate in TC, we introduced the\n> > following two changes:\n> > 1) changed cls_flower to use IDR to manage the filters.\n> > 2) changed all act_xxx modules to use IDR instead of\n> > a small hash table\n> >\n> > But IDR has a limitation that it uses int. TC handle uses u32.\n> > To make sure there is no regression, we add several new IDR APIs to\n> > support unsigned long.\n> >\n> > v2\n> > ==\n> >\n> > Addressed Hannes's comment:\n> > express idr_alloc in terms of idr_alloc_ext and most of the other\n> > functions\n> \n> Series applied, thanks.\n\nThank you, David,\n\n-Chris","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=Mellanox.com header.i=@Mellanox.com\n\theader.b=\"TEMbEwqD\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=chrism@mellanox.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjPM06WVtz9s7G\n\tfor ;\n\tThu, 31 Aug 2017 11:05:48 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751336AbdHaBFo (ORCPT );\n\tWed, 30 Aug 2017 21:05:44 -0400","from mail-ve1eur01on0089.outbound.protection.outlook.com\n\t([104.47.1.89]:43184\n\t\"EHLO EUR01-VE1-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1750822AbdHaBFn (ORCPT );\n\tWed, 30 Aug 2017 21:05:43 -0400","from VI1PR0501MB2143.eurprd05.prod.outlook.com (10.167.196.23) by\n\tVI1SPR00MB110.eurprd05.prod.outlook.com (10.173.72.151) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.1.1385.9; Thu, 31 Aug 2017 01:05:40 +0000","from VI1PR0501MB2143.eurprd05.prod.outlook.com\n\t([fe80::2d4b:bf44:cd0:3725]) by\n\tVI1PR0501MB2143.eurprd05.prod.outlook.com\n\t([fe80::2d4b:bf44:cd0:3725%13]) with mapi id 15.20.0013.012;\n\tThu, 31 Aug 2017 01:05:40 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=nVJNQ1wQwm8dJEZOqeyzJwXEK8tMdp1a2k8esOWnSpg=;\n\tb=TEMbEwqDwqi/MISWehSasltZ2JRY0uiyYi3KE0XZ7Ggl9zxl3uSjcPt4MaDFv0XUgbeI6wJ+Iq6IHc4spnUYEUvLM0S06R48EyWJt4tEDAsz2eIacQUwYg9AXm9bDbuwzn5Nji8+t3+XzeruPpKi1GAbUWI89W7VJDY0QSeEJbo=","From":"Chris Mi ","To":"David Miller ","CC":"\"netdev@vger.kernel.org\" ,\n\t\"jhs@mojatatu.com\" ,\n\t\"xiyou.wangcong@gmail.com\" ,\n\t\"jiri@resnulli.us\" ,\n\t\"mawilcox@microsoft.com\" ","Subject":"RE: [patch net-next v2 0/3] net/sched: Improve getting objects by\n\tindexes","Thread-Topic":"[patch net-next v2 0/3] net/sched: Improve getting objects by\n\tindexes","Thread-Index":"AQHTIdhyzMGC+eGQKUeYGsdlh3FDm6Kdpq+w","Date":"Thu, 31 Aug 2017 01:05:40 +0000","Message-ID":"","References":"<1504074719-15147-1-git-send-email-chrism@mellanox.com>\n\t<20170830.143915.721461254974312457.davem@davemloft.net>","In-Reply-To":"<20170830.143915.721461254974312457.davem@davemloft.net>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=Mellanox.com header.i=@Mellanox.com\n\theader.b=\"TEMbEwqD\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=chrism@mellanox.com; "],"x-originating-ip":"[202.225.191.18]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; VI1SPR00MB110;\n\t6:Ey1gPU3GDZ5C/Y26d042WuPLwSOhnK/gBs3BpcWPFcKSjdXL0uXK8Plhm4N/JfCVyZ9UbdhMrYFgPv1mNetdqsBdebHIZSzmZ/FXg2dsH0mVVn9WzH+8hJvWWPNsIKH/9G5hPUch09N/AszIj/vPwfemveFM0pP/EzQvvEmwdNZpWoVKvsbHLaBSIfl94IVVwQPR2CmPNNLTRDsXBcLG9k8JEGskupF7TPk5rvbzU3Fpy5DvyDOpJsk5Kx58h+b3sneQrezeJuxfeyOJu6IgJJbr3dr2zDE2WtiK5n3GcfTRrI1YWBJr0HLdCAyhsj9MZ5Fjtk8pqi4D1urCCAL3Dw==;\n\t5:EeC3iABgDeKmB9HzX6oOxAm59a+m8F0ij9Fr9gqDOLl6LoMgAkQ6Lv7rw24ARu3G8GgX/Zi13hejAANPT59Z8r5NjwfeROKI8PL9D58ugkaGm4TB4eypsstxTJHY0/ve+TK3zHgnDJR7fYFAdZzBXg==;\n\t24:u8Pk27cMMCBjrDfAYI0JNrEXdRtXG3Rz4R+xRtWRQiSHLvshrxwGmXd8NTYUF4YPBmpxnr5cU1afbc/eMgxFaXa8nMIovijnuvvJUUAJKMI=;\n\t7:mvbtnuMfndoUjL6gbgTyJgfXhZBOHgOvcKFhH/YXMuCqHwXNFqugnqR/EOgrTCPNTiNVh+M/DI/C0FRCpqlS1K2MNk3cnucZ/n3FFFwLzlkm3zgl346c/cwPcErbtjdsK1kciZ5YUBEgSRf0fF9AnbYrR8PJ/buXSpIM+9TrRIk0vYfbQR7XCLOKpaZwPsRqA9+Zr56QTTL96gB0kCmuq92CHbP/AGVgBxasglsqmKA=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"8cf1554e-e5ba-44f3-a4a2-08d4f00c65fc","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:VI1SPR00MB110; ","x-ms-traffictypediagnostic":"VI1SPR00MB110:","x-exchange-antispam-report-test":"UriScan:(9452136761055);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(6055026)(6041248)(20161123562025)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:VI1SPR00MB110; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:VI1SPR00MB110; ","x-forefront-prvs":"04163EF38A","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(199003)(189002)(377454003)(13464003)(6246003)(25786009)(4326008)(39060400002)(5660300001)(2950100002)(55016002)(74316002)(7696004)(2906002)(110136004)(6916009)(99286003)(68736007)(3280700002)(8666007)(5250100002)(106356001)(105586002)(3660700001)(189998001)(86362001)(6116002)(102836003)(6506006)(7736002)(2900100001)(81166006)(66066001)(81156014)(50986999)(6436002)(3846002)(53546010)(76176999)(54356999)(33656002)(97736004)(8676002)(9686003)(54906002)(101416001)(53936002)(14454004)(478600001)(45080400002)(8936002)(305945005)(229853002)(21314002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1SPR00MB110;\n\tH:VI1PR0501MB2143.eurprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","received-spf":"None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-OriginatorOrg":"Mellanox.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"31 Aug 2017 01:05:40.6162\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"a652971c-7d2e-4d9b-a6a4-d149256f461b","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1SPR00MB110","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]