[{"id":1776827,"web_url":"http://patchwork.ozlabs.org/comment/1776827/","msgid":"<1b54a382-c447-2f42-fd00-6a033449d394@electromag.com.au>","list_archive_url":null,"date":"2017-09-28T07:37:33","subject":"Re: [PATCH v3 0/4] i2c: designware: add i2c gpio recovery option","submitter":{"id":66145,"url":"http://patchwork.ozlabs.org/api/people/66145/","name":"Phil Reid","email":"preid@electromag.com.au"},"content":"On 30/08/2017 14:17, Phil Reid wrote:\n> Changes from V1:\n> - In review Andy suggested change the i2c core to use the gpiod\n> I've added a patch that allows the gradual switching of drivers\n> to using gpiod interface. The old interface is preserved so\n> that changes can be made incrementally.\n> - I've update Tim's patch for the designware driver to use the new\n> interface. Tweaked a couple of things to his patch and fixed\n> up things Andy id in last review.\n> The core changes in p1 don't require the get/set scl/sda functions.\n> Hopefully I've done the right thing with preserving authorship and\n> signoff.\n> \n> Changes from V2:\n> - Rebase on https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git/\n> i2c/for-next\n> No intentional changes, but needed to move i2c_dw_plat_prepare_clk to common\n> for the master recovery functions to use. which is included as two additional\n> patches.\n> \n> \n> Phil Reid (4):\n> i2c: Switch to using gpiod interface for gpio bus recovery\n> i2c: designware: move i2c_dw_plat_prepare_clk to common\n> i2c: designware: rename i2c_dw_plat_prepare_clk to i2c_dw_prepare_clk\n> \n> Tim Sander (1):\n> i2c: designware: add i2c gpio recovery option\n> \n> drivers/i2c/busses/i2c-designware-common.c | 24 ++++++++++--\n> drivers/i2c/busses/i2c-designware-core.h | 2 +\n> drivers/i2c/busses/i2c-designware-master.c | 57 +++++++++++++++++++++++++++++\n> drivers/i2c/busses/i2c-designware-platdrv.c | 18 ++-------\n> drivers/i2c/i2c-core-base.c | 22 +++++++++--\n> include/linux/i2c.h | 2 +\n> 6 files changed, 103 insertions(+), 22 deletions(-)\n> \n\nAny comments on this series?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2mkG1qbQz9t5x\n\tfor ;\n\tThu, 28 Sep 2017 17:37:42 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751941AbdI1Hhl (ORCPT );\n\tThu, 28 Sep 2017 03:37:41 -0400","from anchovy1.45ru.net.au ([203.30.46.145]:60820 \"EHLO\n\tanchovy.45ru.net.au\" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org\n\twith ESMTP id S1751495AbdI1Hhk (ORCPT\n\t); Thu, 28 Sep 2017 03:37:40 -0400","(qmail 28230 invoked by uid 5089); 28 Sep 2017 07:37:38 -0000","by simscan 1.2.0 ppid: 28150, pid: 28151, t: 0.0364s\n\tscanners: regex: 1.2.0 attach: 1.2.0 clamav: 0.88.3/m:40/d:1950","from unknown (HELO ?192.168.0.122?)\n\t(preid@electromag.com.au@203.59.230.133)\n\tby anchovy1.45ru.net.au with ESMTPA; 28 Sep 2017 07:37:37 -0000"],"Subject":"Re: [PATCH v3 0/4] i2c: designware: add i2c gpio recovery option","To":"jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com,\n\tmika.westerberg@linux.intel.com, wsa@the-dreams.de,\n\ttim@krieglstein.org, linux-i2c@vger.kernel.org","References":"<1504073857-122449-1-git-send-email-preid@electromag.com.au>","From":"Phil Reid ","Message-ID":"<1b54a382-c447-2f42-fd00-6a033449d394@electromag.com.au>","Date":"Thu, 28 Sep 2017 15:37:33 +0800","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1504073857-122449-1-git-send-email-preid@electromag.com.au>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-AU","Content-Transfer-Encoding":"7bit","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}},{"id":1776923,"web_url":"http://patchwork.ozlabs.org/comment/1776923/","msgid":"","list_archive_url":null,"date":"2017-09-28T09:55:41","subject":"Re: [PATCH v3 0/4] i2c: designware: add i2c gpio recovery option","submitter":{"id":43309,"url":"http://patchwork.ozlabs.org/api/people/43309/","name":"Jarkko Nikula","email":"jarkko.nikula@linux.intel.com"},"content":"On 09/28/2017 10:37 AM, Phil Reid wrote:\n> On 30/08/2017 14:17, Phil Reid wrote:\n>> Changes from V1:\n>> - In review Andy suggested change the i2c core to use the gpiod\n>>    I've added a patch that allows the gradual switching of drivers\n>>    to using gpiod interface. The old interface is preserved so\n>>    that changes can be made incrementally.\n>> - I've update Tim's patch for the designware driver to use the new\n>>    interface. Tweaked a couple of things to his patch and fixed\n>>    up things Andy id in last review.\n>>    The core changes in p1 don't require the get/set scl/sda functions.\n>>    Hopefully I've done the right thing with preserving authorship and\n>>    signoff.\n>>\n>> Changes from V2:\n>> - Rebase on \n>> https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git/\n>>    i2c/for-next\n>>    No intentional changes, but needed to move i2c_dw_plat_prepare_clk \n>> to common\n>>    for the master recovery functions to use. which is included as two \n>> additional\n>>    patches.\n>>\n>>\n>> Phil Reid (4):\n>>    i2c: Switch to using gpiod interface for gpio bus recovery\n>>    i2c: designware: move i2c_dw_plat_prepare_clk to common\n>>    i2c: designware: rename i2c_dw_plat_prepare_clk to i2c_dw_prepare_clk\n>>\n>> Tim Sander (1):\n>>    i2c: designware: add i2c gpio recovery option\n>>\n>>   drivers/i2c/busses/i2c-designware-common.c  | 24 ++++++++++--\n>>   drivers/i2c/busses/i2c-designware-core.h    |  2 +\n>>   drivers/i2c/busses/i2c-designware-master.c  | 57 \n>> +++++++++++++++++++++++++++++\n>>   drivers/i2c/busses/i2c-designware-platdrv.c | 18 ++-------\n>>   drivers/i2c/i2c-core-base.c                 | 22 +++++++++--\n>>   include/linux/i2c.h                         |  2 +\n>>   6 files changed, 103 insertions(+), 22 deletions(-)\n>>\n> \n> Any comments on this series?\n> \nThanks for reminder. This got buried under other activity... \ni2c-designware changes look ok at quick look.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2qnZ0kgNz9t3h\n\tfor ;\n\tThu, 28 Sep 2017 19:55:46 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752005AbdI1Jzo (ORCPT );\n\tThu, 28 Sep 2017 05:55:44 -0400","from mga07.intel.com ([134.134.136.100]:59117 \"EHLO\n\tmga07.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751396AbdI1Jzo (ORCPT );\n\tThu, 28 Sep 2017 05:55:44 -0400","from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga105.jf.intel.com with ESMTP; 28 Sep 2017 02:55:43 -0700","from mylly.fi.intel.com (HELO [10.237.72.59]) ([10.237.72.59])\n\tby fmsmga002.fm.intel.com with ESMTP; 28 Sep 2017 02:55:41 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,449,1500966000\"; d=\"scan'208\";a=\"1224721859\"","Subject":"Re: [PATCH v3 0/4] i2c: designware: add i2c gpio recovery option","To":"Phil Reid ,\n\tandriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com,\n\twsa@the-dreams.de, tim@krieglstein.org, linux-i2c@vger.kernel.org","References":"<1504073857-122449-1-git-send-email-preid@electromag.com.au>\n\t<1b54a382-c447-2f42-fd00-6a033449d394@electromag.com.au>","From":"Jarkko Nikula ","Message-ID":"","Date":"Thu, 28 Sep 2017 12:55:41 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1b54a382-c447-2f42-fd00-6a033449d394@electromag.com.au>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}},{"id":1776961,"web_url":"http://patchwork.ozlabs.org/comment/1776961/","msgid":"<1506596114.16112.148.camel@linux.intel.com>","list_archive_url":null,"date":"2017-09-28T10:55:14","subject":"Re: [PATCH v3 0/4] i2c: designware: add i2c gpio recovery option","submitter":{"id":8583,"url":"http://patchwork.ozlabs.org/api/people/8583/","name":"Andy Shevchenko","email":"andriy.shevchenko@linux.intel.com"},"content":"On Thu, 2017-09-28 at 15:37 +0800, Phil Reid wrote:\n> On 30/08/2017 14:17, Phil Reid wrote:\n> > Changes from V1:\n> > - In review Andy suggested change the i2c core to use the gpiod\n> > I've added a patch that allows the gradual switching of drivers\n> > to using gpiod interface. The old interface is preserved so\n> > that changes can be made incrementally.\n> > - I've update Tim's patch for the designware driver to use the new\n> > interface. Tweaked a couple of things to his patch and fixed\n> > up things Andy id in last review.\n> > The core changes in p1 don't require the get/set scl/sda\n> > functions.\n> > Hopefully I've done the right thing with preserving authorship\n> > and\n> > signoff.\n\n+Cc: Ferry.\n\nFerry, I think you might be interested in this series.\nIf so, perhaps Phil can include you in Cc for v4 of it.\n\n> > \n> > Changes from V2:\n> > - Rebase on https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linu\n> > x.git/\n> > i2c/for-next\n> > No intentional changes, but needed to move\n> > i2c_dw_plat_prepare_clk to common\n> > for the master recovery functions to use. which is included as\n> > two additional\n> > patches.\n> > \n> > \n> > Phil Reid (4):\n> > i2c: Switch to using gpiod interface for gpio bus recovery\n> > i2c: designware: move i2c_dw_plat_prepare_clk to common\n> > i2c: designware: rename i2c_dw_plat_prepare_clk to\n> > i2c_dw_prepare_clk\n> > \n> > Tim Sander (1):\n> > i2c: designware: add i2c gpio recovery option\n> > \n> > drivers/i2c/busses/i2c-designware-common.c | 24 ++++++++++--\n> > drivers/i2c/busses/i2c-designware-core.h | 2 +\n> > drivers/i2c/busses/i2c-designware-master.c | 57\n> > +++++++++++++++++++++++++++++\n> > drivers/i2c/busses/i2c-designware-platdrv.c | 18 ++-------\n> > drivers/i2c/i2c-core-base.c | 22 +++++++++--\n> > include/linux/i2c.h | 2 +\n> > 6 files changed, 103 insertions(+), 22 deletions(-)\n> > \n> \n> Any comments on this series?\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2sJR4tSdz9tXj\n\tfor ;\n\tThu, 28 Sep 2017 21:04:07 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752738AbdI1LEG (ORCPT );\n\tThu, 28 Sep 2017 07:04:06 -0400","from mga14.intel.com ([192.55.52.115]:2299 \"EHLO mga14.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752543AbdI1LEG (ORCPT );\n\tThu, 28 Sep 2017 07:04:06 -0400","from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Sep 2017 04:04:05 -0700","from smile.fi.intel.com (HELO smile) ([10.237.72.86])\n\tby FMSMGA003.fm.intel.com with ESMTP; 28 Sep 2017 04:04:03 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,449,1500966000\"; d=\"scan'208\";a=\"904715479\"","Message-ID":"<1506596114.16112.148.camel@linux.intel.com>","Subject":"Re: [PATCH v3 0/4] i2c: designware: add i2c gpio recovery option","From":"Andy Shevchenko ","To":"Phil Reid , jarkko.nikula@linux.intel.com,\n\tmika.westerberg@linux.intel.com, wsa@the-dreams.de,\n\ttim@krieglstein.org, linux-i2c@vger.kernel.org","Cc":"Ferry Toth gmail ","Date":"Thu, 28 Sep 2017 13:55:14 +0300","In-Reply-To":"<1b54a382-c447-2f42-fd00-6a033449d394@electromag.com.au>","References":"<1504073857-122449-1-git-send-email-preid@electromag.com.au>\n\t<1b54a382-c447-2f42-fd00-6a033449d394@electromag.com.au>","Organization":"Intel Finland Oy","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.26.0-1 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}},{"id":1779581,"web_url":"http://patchwork.ozlabs.org/comment/1779581/","msgid":"<1507110098.6358.1.camel@telfort.nl>","list_archive_url":null,"date":"2017-10-04T09:41:38","subject":"Re: [PATCH v3 0/4] i2c: designware: add i2c gpio recovery option","submitter":{"id":72490,"url":"http://patchwork.ozlabs.org/api/people/72490/","name":"Ferry Toth","email":"ftoth@telfort.nl"},"content":"Andy Shevchenko schreef op do 28-09-2017 om 13:55 [+0300]:\n> On Thu, 2017-09-28 at 15:37 +0800, Phil Reid wrote:\n> > On 30/08/2017 14:17, Phil Reid wrote:\n> > > Changes from V1:\n> > > - In review Andy suggested change the i2c core to use the gpiod\n> > >    I've added a patch that allows the gradual switching of\n> > > drivers\n> > >    to using gpiod interface. The old interface is preserved so\n> > >    that changes can be made incrementally.\n> > > - I've update Tim's patch for the designware driver to use the\n> > > new\n> > >    interface. Tweaked a couple of things to his patch and fixed\n> > >    up things Andy id in last review.\n> > >    The core changes in p1 don't require the get/set scl/sda\n> > > functions.\n> > >    Hopefully I've done the right thing with preserving authorship\n> > > and\n> > >    signoff.\n> \n> +Cc: Ferry.\n> \n> Ferry, I think you might be interested in this series.\n> If so, perhaps Phil can include you in Cc for v4 of it.\n\nThanks. I am interested in this, though I may be experiencing a\nsomewhat different issue.\n\nI my case (Intel Edison on Arduino expansion board) there are 4 MUX\nattached to the same i2c bus. On warm boot sometimes the first device\nis not detected (as shown by i2c-detect). The 2nd - 4th devices are\ndetected fine.\n\nIt would seem that initially the bus is stuck accessing the first\ndevice and recovers after this. But this is probably not the case, as\non successive warm reboots, the same first device remains undetected.\n\nA cold boot fixes this.\n\nTo me that looks like the bus is not stuck, but the particular slave is\nin the wrong state. \n\nI have not yet been able to figure out if this patch series only resets\na device when it holds the bus, or if it also resets a device that\ndoesn't respond or responds with garbled data, but I will look into it.\n\nUp to now I have not found a reliable way to trigger the situation,\nother than noting it seems to happen mostly after a kernel or u-boot\nreflash. \n\n> > > \n> > > Changes from V2:\n> > > - Rebase on https://git.kernel.org/pub/scm/linux/kernel/git/wsa/l\n> > > inu\n> > > x.git/\n> > >    i2c/for-next\n> > >    No intentional changes, but needed to move\n> > > i2c_dw_plat_prepare_clk to common\n> > >    for the master recovery functions to use. which is included as\n> > > two additional\n> > >    patches.\n> > > \n> > > \n> > > Phil Reid (4):\n> > >    i2c: Switch to using gpiod interface for gpio bus recovery\n> > >    i2c: designware: move i2c_dw_plat_prepare_clk to common\n> > >    i2c: designware: rename i2c_dw_plat_prepare_clk to\n> > > i2c_dw_prepare_clk\n> > > \n> > > Tim Sander (1):\n> > >    i2c: designware: add i2c gpio recovery option\n> > > \n> > >   drivers/i2c/busses/i2c-designware-common.c  | 24 ++++++++++--\n> > >   drivers/i2c/busses/i2c-designware-core.h    |  2 +\n> > >   drivers/i2c/busses/i2c-designware-master.c  | 57\n> > > +++++++++++++++++++++++++++++\n> > >   drivers/i2c/busses/i2c-designware-platdrv.c | 18 ++-------\n> > >   drivers/i2c/i2c-core-base.c                 | 22 +++++++++--\n> > >   include/linux/i2c.h                         |  2 +\n> > >   6 files changed, 103 insertions(+), 22 deletions(-)\n> > > \n> > \n> > Any comments on this series?\n> > \n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y6WGp2NBbz9sNr\n\tfor ;\n\tWed, 4 Oct 2017 20:45:22 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751322AbdJDJpV convert rfc822-to-8bit (ORCPT\n\t);\n\tWed, 4 Oct 2017 05:45:21 -0400","from [195.159.176.226] ([195.159.176.226]:33216 \"EHLO\n\tblaine.gmane.org\" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751240AbdJDJpU (ORCPT\n\t); Wed, 4 Oct 2017 05:45:20 -0400","from list by blaine.gmane.org with local (Exim 4.84_2)\n\t(envelope-from ) id 1dzgEi-0008IJ-Ct\n\tfor linux-i2c@vger.kernel.org; Wed, 04 Oct 2017 11:45:04 +0200"],"X-Injected-Via-Gmane":"http://gmane.org/","To":"linux-i2c@vger.kernel.org","From":"Ferry Toth ","Subject":"Re: [PATCH v3 0/4] i2c: designware: add i2c gpio recovery option","Date":"Wed, 04 Oct 2017 11:41:38 +0200","Lines":"101","Message-ID":"<1507110098.6358.1.camel@telfort.nl>","References":"<1504073857-122449-1-git-send-email-preid@electromag.com.au>\n\t<1b54a382-c447-2f42-fd00-6a033449d394@electromag.com.au>\n\t<1506596114.16112.148.camel@linux.intel.com>","Mime-Version":"1.0","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"8BIT","X-Complaints-To":"usenet@blaine.gmane.org","In-Reply-To":"<1506596114.16112.148.camel@linux.intel.com>","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}}]