[{"id":1759792,"web_url":"http://patchwork.ozlabs.org/comment/1759792/","msgid":"<20170829.180557.1826943085634265902.davem@davemloft.net>","list_archive_url":null,"date":"2017-08-30T01:05:57","subject":"Re: [PATCH net-next 0/3 v10] Add support for rmnet driver","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Subash Abhinov Kasiviswanathan \nDate: Tue, 29 Aug 2017 18:47:55 -0600\n\n> I have updated the locking scheme as follows -\n\nSeries applied, but this is not how you write a header posting for a\npatch set.\n\nThis posting is where you say at a high level what the patch series is\ndoing, how it is doing it, and why it is doing it that way.\n\nYou can explain what changes happened, and why, but that belongs\nin the changelog at the end of this posting. Here you've made\nan explaination for one change the entire content of the text.\n\nYou not even saying what rmnet is, why we would want to add it to the\nkernel, and what it's all about. So now when someone tries to read\nthe merge commit that contains this text, they will have no context\nabout you and me talking about locking and they will thus ask\nthemselves \"what is this person talking about here? it's not\nexplaining the patch series at all\"","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhnPk2X7Zz9s9Y\n\tfor ;\n\tWed, 30 Aug 2017 11:06:01 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751746AbdH3BF7 (ORCPT );\n\tTue, 29 Aug 2017 21:05:59 -0400","from shards.monkeyblade.net ([184.105.139.130]:42974 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751318AbdH3BF6 (ORCPT\n\t); Tue, 29 Aug 2017 21:05:58 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id E351D13DA891D;\n\tTue, 29 Aug 2017 18:05:57 -0700 (PDT)"],"Date":"Tue, 29 Aug 2017 18:05:57 -0700 (PDT)","Message-Id":"<20170829.180557.1826943085634265902.davem@davemloft.net>","To":"subashab@codeaurora.org","Cc":"netdev@vger.kernel.org, fengguang.wu@intel.com, dcbw@redhat.com,\n\tjiri@resnulli.us, stephen@networkplumber.org,\n\tDavid.Laight@ACULAB.COM, marcel@holtmann.org, andrew@lunn.ch","Subject":"Re: [PATCH net-next 0/3 v10] Add support for rmnet driver","From":"David Miller ","In-Reply-To":"<1504054078-10173-1-git-send-email-subashab@codeaurora.org>","References":"<1504054078-10173-1-git-send-email-subashab@codeaurora.org>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 29 Aug 2017 18:05:58 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1759801,"web_url":"http://patchwork.ozlabs.org/comment/1759801/","msgid":"<20170829.181244.658164638453646342.davem@davemloft.net>","list_archive_url":null,"date":"2017-08-30T01:12:44","subject":"Re: [PATCH net-next 0/3 v10] Add support for rmnet driver","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"Sigh, I had to revert.\n\nYou only allow RMNET to take on the values 'y' and 'n'.\n\nYou must allow for it to be 'm' and modular as well.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhnYX2NtNz9sN7\n\tfor ;\n\tWed, 30 Aug 2017 11:12:48 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751792AbdH3BMp (ORCPT );\n\tTue, 29 Aug 2017 21:12:45 -0400","from shards.monkeyblade.net ([184.105.139.130]:43164 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751329AbdH3BMp (ORCPT\n\t); Tue, 29 Aug 2017 21:12:45 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 93CBD13DABE8D;\n\tTue, 29 Aug 2017 18:12:44 -0700 (PDT)"],"Date":"Tue, 29 Aug 2017 18:12:44 -0700 (PDT)","Message-Id":"<20170829.181244.658164638453646342.davem@davemloft.net>","To":"subashab@codeaurora.org","Cc":"netdev@vger.kernel.org, fengguang.wu@intel.com, dcbw@redhat.com,\n\tjiri@resnulli.us, stephen@networkplumber.org,\n\tDavid.Laight@ACULAB.COM, marcel@holtmann.org, andrew@lunn.ch","Subject":"Re: [PATCH net-next 0/3 v10] Add support for rmnet driver","From":"David Miller ","In-Reply-To":"<20170829.180557.1826943085634265902.davem@davemloft.net>","References":"<1504054078-10173-1-git-send-email-subashab@codeaurora.org>\n\t<20170829.180557.1826943085634265902.davem@davemloft.net>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 29 Aug 2017 18:12:44 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1759803,"web_url":"http://patchwork.ozlabs.org/comment/1759803/","msgid":"<178ce09c87a24b63f6b5057fcd606583@codeaurora.org>","list_archive_url":null,"date":"2017-08-30T01:18:05","subject":"Re: [PATCH net-next 0/3 v10] Add support for rmnet driver","submitter":{"id":65547,"url":"http://patchwork.ozlabs.org/api/people/65547/","name":"Subash Abhinov Kasiviswanathan","email":"subashab@codeaurora.org"},"content":"On 2017-08-29 19:12, David Miller wrote:\n> Sigh, I had to revert.\n> \n> You only allow RMNET to take on the values 'y' and 'n'.\n> \n> You must allow for it to be 'm' and modular as well.\n\nHi David\n\nI'll fix this now.\n\nSorry about the cover letter. I'll explain it better in subsequent \nsubmission.\n--\nQualcomm Innovation Center, Inc.\nThe Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a \nLinux Foundation Collaborative Project","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"g1pzw9ai\"; \n\tdkim=pass (1024-bit key) header.d=codeaurora.org\n\theader.i=@codeaurora.org header.b=\"TCJKhm/D\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhngl4dKrz9sN7\n\tfor ;\n\tWed, 30 Aug 2017 11:18:11 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751440AbdH3BSH (ORCPT );\n\tTue, 29 Aug 2017 21:18:07 -0400","from smtp.codeaurora.org ([198.145.29.96]:53714 \"EHLO\n\tsmtp.codeaurora.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751240AbdH3BSG (ORCPT\n\t); Tue, 29 Aug 2017 21:18:06 -0400","by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid 4CC276072F; Wed, 30 Aug 2017 01:18:06 +0000 (UTC)","from mail.codeaurora.org (localhost.localdomain [127.0.0.1])\n\tby smtp.codeaurora.org (Postfix) with ESMTP id 935CB603D2;\n\tWed, 30 Aug 2017 01:18:05 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1504055886;\n\tbh=nO0zVUVSHgPiUvLe9WLtned+QevoWCpgEjrfGCzh/lA=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:References:From;\n\tb=g1pzw9ai65+LMM24fEqrO3X3vTf+O2utvja9GeBTPeA1doAorns32Ar+6lpMYO/AP\n\tv1Y2D8TESiVnlEw7lSYX1Am1WB30n7nVGVUKQdJ69BxFoQg1+YbHMduE5TQoyQ2aYC\n\t667iVMcJ6Oxf+oEWfThnSYQyjRwZtWLtUtJMnakA=","v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1504055885;\n\tbh=nO0zVUVSHgPiUvLe9WLtned+QevoWCpgEjrfGCzh/lA=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:References:From;\n\tb=TCJKhm/DK1/aZdB7PRGD321nSTsBaSreND6wPQ3WJFFxKlxtjSSCVyanHcK+uwP8F\n\t3qbTuo4YBpSm0/aOzLm+ossWkS6eV59GBvl4AXV14X/s1MVNAFvYLVXz39M92lqIGo\n\tFek2lNHoo41RanIIOeHai4d/DqEM8uqtfyYV8m4M="],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tpdx-caf-mail.web.codeaurora.org","X-Spam-Level":"","X-Spam-Status":"No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00,\n\tDKIM_SIGNED,\n\tT_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII;\n format=flowed","Content-Transfer-Encoding":"7bit","Date":"Tue, 29 Aug 2017 19:18:05 -0600","From":"Subash Abhinov Kasiviswanathan ","To":"David Miller ","Cc":"netdev@vger.kernel.org, fengguang.wu@intel.com, dcbw@redhat.com,\n\tjiri@resnulli.us, stephen@networkplumber.org,\n\tDavid.Laight@aculab.com, marcel@holtmann.org, andrew@lunn.ch","Subject":"Re: [PATCH net-next 0/3 v10] Add support for rmnet driver","In-Reply-To":"<20170829.181244.658164638453646342.davem@davemloft.net>","References":"<1504054078-10173-1-git-send-email-subashab@codeaurora.org>\n\t<20170829.180557.1826943085634265902.davem@davemloft.net>\n\t<20170829.181244.658164638453646342.davem@davemloft.net>","Message-ID":"<178ce09c87a24b63f6b5057fcd606583@codeaurora.org>","X-Sender":"subashab@codeaurora.org","User-Agent":"Roundcube Webmail/1.2.5","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]