[{"id":1759692,"web_url":"http://patchwork.ozlabs.org/comment/1759692/","msgid":"<150404129008.69.15341038356367048349@b5667b65043c>","list_archive_url":null,"date":"2017-08-29T21:14:51","subject":"Re: [Qemu-devel] [PATCH v2 0/9] IDE: replace printfs with tracing","submitter":{"id":69632,"url":"http://patchwork.ozlabs.org/api/people/69632/","name":null,"email":"no-reply@patchew.org"},"content":"Hi,\n\nThis series seems to have some coding style problems. See output below for\nmore information:\n\nMessage-id: 20170829204934.9039-1-jsnow@redhat.com\nSubject: [Qemu-devel] [PATCH v2 0/9] IDE: replace printfs with tracing\nType: series\n\n=== TEST SCRIPT BEGIN ===\n#!/bin/bash\n\nBASE=base\nn=1\ntotal=$(git log --oneline $BASE.. | wc -l)\nfailed=0\n\ngit config --local diff.renamelimit 0\ngit config --local diff.renames True\n\ncommits=\"$(git log --format=%H --reverse $BASE..)\"\nfor c in $commits; do\n echo \"Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)...\"\n if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then\n failed=1\n echo\n fi\n n=$((n+1))\ndone\n\nexit $failed\n=== TEST SCRIPT END ===\n\nUpdating 3c8cf5a9c21ff8782164d1def7f44bd888713384\nFrom https://github.com/patchew-project/qemu\n * [new tag] patchew/20170829204934.9039-1-jsnow@redhat.com -> patchew/20170829204934.9039-1-jsnow@redhat.com\nSwitched to a new branch 'test'\n317562672d AHCI: remove DPRINTF macro\n5111f245b5 AHCI: pretty-print FIS to buffer instead of stderr\nfd94464a09 AHCI: Rework IRQ constants\na2cbc7a1b9 AHCI: Replace DPRINTF with trace-events\n7617a100a4 IDE: replace DEBUG_AIO with trace events\nd0ab9d9ae8 ATAPI: Replace DEBUG_IDE_ATAPI with tracing events\nec07b9f487 IDE: add tracing for data ports\nad50ebd27b IDE: Add register hints to tracing\n99af2ced97 IDE: replace DEBUG_IDE with tracing system\n\n=== OUTPUT BEGIN ===\nChecking PATCH 1/9: IDE: replace DEBUG_IDE with tracing system...\nERROR: spaces required around that '|' (ctx:VxV)\n#143: FILE: hw/ide/core.c:1197:\n+ if (reg_num != 7 && (s->status & (BUSY_STAT|DRQ_STAT))) {\n ^\n\ntotal: 1 errors, 0 warnings, 337 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 2/9: IDE: Add register hints to tracing...\nChecking PATCH 3/9: IDE: add tracing for data ports...\nChecking PATCH 4/9: ATAPI: Replace DEBUG_IDE_ATAPI with tracing events...\nChecking PATCH 5/9: IDE: replace DEBUG_AIO with trace events...\nChecking PATCH 6/9: AHCI: Replace DPRINTF with trace-events...\nERROR: Hex numbers must be prefixed with '0x'\n#540: FILE: hw/ide/trace-events:91:\n+handle_reg_h2d_fis_pmp(void *s, int port, char b0, char b1, char b2) \"ahci(%p)[%d]: Port Multiplier not supported, FIS: 0x%02x-%02x-%02x\"\n\nERROR: Hex numbers must be prefixed with '0x'\n#541: FILE: hw/ide/trace-events:92:\n+handle_reg_h2d_fis_res(void *s, int port, char b0, char b1, char b2) \"ahci(%p)[%d]: Reserved flags set in H2D Register FIS, FIS: 0x%02x-%02x-%02x\"\n\nERROR: Hex numbers must be prefixed with '0x'\n#547: FILE: hw/ide/trace-events:98:\n+handle_cmd_unhandled_fis(void *s, int port, uint8_t b0, uint8_t b1, uint8_t b2) \"ahci(%p)[%d]: unhandled FIS type. cmd_fis: 0x%02x-%02x-%02x\"\n\ntotal: 3 errors, 0 warnings, 496 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 7/9: AHCI: Rework IRQ constants...\nChecking PATCH 8/9: AHCI: pretty-print FIS to buffer instead of stderr...\nERROR: Use g_assert or g_assert_not_reached\n#35: FILE: hw/ide/ahci.c:658:\n+ g_assert_cmpint(cmd_len, <=, 0x100);\n\ntotal: 1 errors, 0 warnings, 86 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 9/9: AHCI: remove DPRINTF macro...\n=== OUTPUT END ===\n\nTest command exited with code: 1\n\n\n---\nEmail generated automatically by Patchew [http://patchew.org/].\nPlease send your feedback to patchew-devel@freelists.org","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhhHm03zmz9sPt\n\tfor ;\n\tWed, 30 Aug 2017 07:15:29 +1000 (AEST)","from localhost ([::1]:47034 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmnr4-0004XA-7R\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 17:15:26 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55454)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmnqi-0004Te-DG\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 17:15:05 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmnqd-0006bv-To\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 17:15:04 -0400","from sender-of-o52.zoho.com ([135.84.80.217]:21395)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmnqd-0006bJ-LN; Tue, 29 Aug 2017 17:14:59 -0400","from [172.17.0.2] (23.253.156.214 [23.253.156.214]) by\n\tmx.zohomail.com with SMTPS id 1504041291878682.7535096836892;\n\tTue, 29 Aug 2017 14:14:51 -0700 (PDT)"],"Resent-Date":"Tue, 29 Aug 2017 17:15:04 -0400","Resent-Message-Id":"","In-Reply-To":"<20170829204934.9039-1-jsnow@redhat.com>","Message-ID":"<150404129008.69.15341038356367048349@b5667b65043c>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Resent-From":"","From":"no-reply@patchew.org","To":"jsnow@redhat.com","Date":"Tue, 29 Aug 2017 14:14:51 -0700 (PDT)","X-ZohoMailClient":"External","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"135.84.80.217","Subject":"Re: [Qemu-devel] [PATCH v2 0/9] IDE: replace printfs with tracing","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"qemu-devel@nongnu.org","Cc":"jsnow@redhat.com, famz@redhat.com, qemu-devel@nongnu.org,\n\tqemu-block@nongnu.org, f4bug@amsat.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1759992,"web_url":"http://patchwork.ozlabs.org/comment/1759992/","msgid":"<20170830092156.GE24565@stefanha-x1.localdomain>","list_archive_url":null,"date":"2017-08-30T09:21:56","subject":"Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/9] IDE: replace printfs\n\twith tracing","submitter":{"id":2747,"url":"http://patchwork.ozlabs.org/api/people/2747/","name":"Stefan Hajnoczi","email":"stefanha@gmail.com"},"content":"On Tue, Aug 29, 2017 at 04:49:25PM -0400, John Snow wrote:\n> Wherever possible, replace all printfs with proper tracing.\n> In most places I've tried to do a straight replacement, but\n> forthcoming patches may calibrate the tracing to be a little nicer.\n> \n> For now, it's nice to just remove the all-or-nothing tracing.\n> \n> For V2, I opted to leave in the nearly redundant tracers for now\n> with their individual names so that they can be targeted individually.\n\nLooks good. I left a comment on one patch.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ETW6hbkK\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj0QX1jfNz9t2R\n\tfor ;\n\tWed, 30 Aug 2017 19:22:28 +1000 (AEST)","from localhost ([::1]:49294 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmzCc-0007Kx-2m\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 05:22:26 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49553)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmzCI-0007Iq-35\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 05:22:06 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmzCH-0000pz-7w\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 05:22:06 -0400","from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:35786)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmzCC-0000nb-2N; Wed, 30 Aug 2017 05:22:00 -0400","by mail-wm0-x234.google.com with SMTP id a80so6079782wma.0;\n\tWed, 30 Aug 2017 02:21:59 -0700 (PDT)","from localhost ([51.15.41.238]) by smtp.gmail.com with ESMTPSA id\n\tz71sm2178633ede.8.2017.08.30.02.21.57\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 30 Aug 2017 02:21:58 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=tnFi5R9myyhUjo6V9OnW9L95I8hVZ0RMCIbwRk9n5Uw=;\n\tb=ETW6hbkKgPFhujUGJRH1Ncvk/XecyEagF2lXa5D+n5tnRmLv3nEgBIRhKr49/b/Fzi\n\tIugv+uvchmzPWyGuFcZoqSI7+61USGumnNfv9/N9qVMDqB5fCBIkSmfVltOEWp8myKn3\n\tzkzvJDiPsgQ5jKAlE1ZEF8nuhgJRee91XPeUjqs28N4peq0uE07W3zdmyZipGaB8BkUI\n\tINZFuzN87bpNUvt9jxAxiCTTn1RsWpBXoHHQuTK/da1M41YkAh316+qgiKmsARuCzy7r\n\tpTIMZAb735dvELCsWiPoC1XdtuP3h5x4wwLAghW+K8Q4s4iI/TFWdsYMefrIVCKDilUv\n\tq1jA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=tnFi5R9myyhUjo6V9OnW9L95I8hVZ0RMCIbwRk9n5Uw=;\n\tb=bTZvRZ+w6etRFEVs1eWqtZ0ZqlyVDbTZF+uzPdQ7brgOGBiHJVU0PrF5hJuNQaKDpu\n\tk5xaGOiC3nsKaXgERLAIgI8XnOlv9l5qDuw8aK7COMe+yjs2IbDRxamzakVisqcANMvK\n\tk7UPo8ZsjB7N/6wStyenQlYcAu+uhccTswjGNH0XUEPvTNif7/psYYjhEvlj9kqUb3P6\n\tlO2ppjs+tXakGhkMKx0B3K8sUsMYhhp7YjQ6lFX6KNQnqCXBmK4jWXPKL/5oPt0q4O0B\n\tVum9z6dBDUhU7e+25Up1IRDDryKklZNy7vD2bUliyABD1trbTSH9keKbyL7Iig86wtu6\n\t6BTg==","X-Gm-Message-State":"AHYfb5haZeDpgUbelBZlx9XfTa75jy0r62GTU+MXobYcLPuSPfbgsn1v\n\tf+0pJYqTVPv8530wGxE=","X-Received":"by 10.80.179.185 with SMTP id s54mr1206232edd.138.1504084918932; \n\tWed, 30 Aug 2017 02:21:58 -0700 (PDT)","Date":"Wed, 30 Aug 2017 10:21:56 +0100","From":"Stefan Hajnoczi ","To":"John Snow ","Message-ID":"<20170830092156.GE24565@stefanha-x1.localdomain>","References":"<20170829204934.9039-1-jsnow@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170829204934.9039-1-jsnow@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::234","Subject":"Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/9] IDE: replace printfs\n\twith tracing","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, qemu-block@nongnu.org, f4bug@amsat.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]