[{"id":1763020,"web_url":"http://patchwork.ozlabs.org/comment/1763020/","msgid":"<20170905073540.uxqhchcveu5d6vtk@dell>","list_archive_url":null,"date":"2017-09-05T07:35:40","subject":"Re: [patch v4 2/2] mfd: Add Mellanox regmap I2C driver","submitter":{"id":12720,"url":"http://patchwork.ozlabs.org/api/people/12720/","name":"Lee Jones","email":"lee.jones@linaro.org"},"content":"On Tue, 29 Aug 2017, Vadim Pasternak wrote:\n\n> This patch adds I2C regmap driver for Mellanox BMC cards with the\n> programmable devices attached to I2C interface. It allows support\n> for CPLD devices with one and two bytes address space.\n> \n> Signed-off-by: Vadim Pasternak \n> Acked-by: Pavel Machek \n> ---\n> MAINTAINERS | 1 +\n> drivers/mfd/Kconfig | 13 ++++\n> drivers/mfd/Makefile | 1 +\n> drivers/mfd/mlxreg-i2c.c | 183 +++++++++++++++++++++++++++++++++++++++++++++++\n> 4 files changed, 198 insertions(+)\n> create mode 100644 drivers/mfd/mlxreg-i2c.c\n\nI don't know what this is, but it is not an MFD driver. Please find\nsomewhere more appropriate to locate it. MFD is not a dumping ground\nfor drivers which do not fit anywhere else.\n\n> diff --git a/MAINTAINERS b/MAINTAINERS\n> index bcb7f45..86a5f8f 100644\n> --- a/MAINTAINERS\n> +++ b/MAINTAINERS\n> @@ -8299,6 +8299,7 @@ M:\tVadim Pasternak \n> S:\tSupported\n> F:\tDocumentation/devicetree/bindings/mfd/mellanox,mlxreg-core\n> F:\tdrivers/mfd/mlxreg-core.c\n> +F:\tdrivers/mfd/mlxreg-i2c.c\n> F:\tinclude/linux/platform_data/mlxreg.h\n> \n> MELLANOX ETHERNET DRIVER (mlx4_en)\n> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig\n> index fa1562f..453afcb 100644\n> --- a/drivers/mfd/Kconfig\n> +++ b/drivers/mfd/Kconfig\n> @@ -1709,6 +1709,19 @@ config MFD_MLXREG_CORE\n> \t This driver can also be built as a module. If so the module\n> \t will be called mlxreg-core.\n> \n> +config MFD_MLXREG_I2C\n> +\tbool \"Mellanox programmable device with I2C interface\"\n> +\tdepends on I2C && REGMAP_I2C\n> +\tdepends on MFD_MLXREG_CORE\n> +\thelp\n> +\t Support for the Mellanox BMC card with hardware control by a\n> +\t programmable device. This option enables core support for the\n> +\t programmable devices with I2C interface. It allows support for\n> +\t the devices with address space 1 and 2 bytes.\n> +\n> +\t This driver can also be built as a module. If so the module\n> +\t will be called mlxreg-i2c.\n> +\n> menu \"Multimedia Capabilities Port drivers\"\n> \tdepends on ARCH_SA1100\n> \n> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile\n> index 9661ee2..b76c5b2 100644\n> --- a/drivers/mfd/Makefile\n> +++ b/drivers/mfd/Makefile\n> @@ -222,3 +222,4 @@ obj-$(CONFIG_MFD_SUN4I_GPADC)\t+= sun4i-gpadc.o\n> obj-$(CONFIG_MFD_STM32_TIMERS) \t+= stm32-timers.o\n> obj-$(CONFIG_MFD_MXS_LRADC) += mxs-lradc.o\n> obj-$(CONFIG_MFD_MLXREG_CORE)\t+= mlxreg-core.o\n> +obj-$(CONFIG_MFD_MLXREG_I2C)\t+= mlxreg-i2c.o\n> diff --git a/drivers/mfd/mlxreg-i2c.c b/drivers/mfd/mlxreg-i2c.c\n> new file mode 100644\n> index 0000000..04823b5\n> --- /dev/null\n> +++ b/drivers/mfd/mlxreg-i2c.c\n> @@ -0,0 +1,183 @@\n> +/*\n> + * Copyright (c) 2017 Mellanox Technologies. All rights reserved.\n> + * Copyright (c) 2017 Vadim Pasternak \n> + *\n> + * Redistribution and use in source and binary forms, with or without\n> + * modification, are permitted provided that the following conditions are met:\n> + *\n> + * 1. Redistributions of source code must retain the above copyright\n> + * notice, this list of conditions and the following disclaimer.\n> + * 2. Redistributions in binary form must reproduce the above copyright\n> + * notice, this list of conditions and the following disclaimer in the\n> + * documentation and/or other materials provided with the distribution.\n> + * 3. Neither the names of the copyright holders nor the names of its\n> + * contributors may be used to endorse or promote products derived from\n> + * this software without specific prior written permission.\n> + *\n> + * Alternatively, this software may be distributed under the terms of the\n> + * GNU General Public License (\"GPL\") version 2 as published by the Free\n> + * Software Foundation.\n> + *\n> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE\n> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR\n> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF\n> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS\n> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN\n> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)\n> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE\n> + * POSSIBILITY OF SUCH DAMAGE.\n> + */\n> +\n> +#include \n> +#include \n> +#include \n> +#include \n> +#include \n> +#include \n> +\n> +/**\n> + * enum mlxreg_i2c_type - driver flavours:\n> + *\n> + * @MLXREG_8BIT: type for I2C CPLD control with 1 byte address space;\n> + * @MLXREG_16BIT: type for I2C CPLD control with 2 bytes address space;\n> + */\n> +enum mlxreg_i2c_type {\n> +\tMLXREG_8BIT,\n> +\tMLXREG_16BIT,\n> +};\n> +\n> +/**\n> + * Configuration for the register map of a device with 1 byte address space.\n> + */\n> +static const struct regmap_config mlxreg_i2c_regmap8_conf = {\n> +\t.reg_bits = 8,\n> +\t.val_bits = 8,\n> +\t.max_register = 255,\n> +};\n> +\n> +/**\n> + * Configuration for the register map of a device with 2 bytes address space.\n> + */\n> +static const struct regmap_config mlxreg_i2c_regmap16_conf = {\n> +\t.reg_bits = 16,\n> +\t.val_bits = 16,\n> +\t.max_register = 1023,\n> +};\n> +\n> +static struct resource mlxreg_i2c_resources[] = {\n> +\t[0] = DEFINE_RES_IRQ_NAMED(-1, \"mlxcpld-ctrl-2c\"),\n> +};\n> +\n> +static int\n> +mlxreg_i2c_probe(struct i2c_client *client, const struct i2c_device_id *id)\n> +{\n> +\tstruct device_node *child, *np = client->dev.of_node;\n> +\tstruct platform_device *pdev;\n> +\tstruct i2c_adapter *adapter;\n> +\tstruct regmap *regmap;\n> +\tint err = 0;\n> +\n> +\tif (!np)\n> +\t\treturn -ENODEV;\n> +\n> +\tif (!of_device_is_compatible(np, \"mellanox,mlxreg-i2c\"))\n> +\t\treturn -ENODEV;\n> +\n> +\tchild = of_parse_phandle(np, \"deferred\", 0);\n> +\tif (child) {\n> +\t\tadapter = of_find_i2c_adapter_by_node(child);\n> +\t\tof_node_put(child);\n> +\t\tif (!adapter)\n> +\t\t\treturn -EPROBE_DEFER;\n> +\t}\n> +\n> +\tif (!i2c_check_functionality(client->adapter,\n> +\t\t\t\t I2C_FUNC_SMBUS_BYTE_DATA |\n> +\t\t\t\t I2C_FUNC_SMBUS_WORD_DATA |\n> +\t\t\t\t I2C_FUNC_SMBUS_I2C_BLOCK))\n> +\t\treturn -ENODEV;\n> +\n> +\tswitch (id->driver_data) {\n> +\tcase MLXREG_8BIT:\n> +\t\tregmap = devm_regmap_init_i2c(client,\n> +\t\t\t\t\t &mlxreg_i2c_regmap8_conf);\n> +\t\tbreak;\n> +\tcase MLXREG_16BIT:\n> +\t\tregmap = devm_regmap_init_i2c(client,\n> +\t\t\t\t\t &mlxreg_i2c_regmap16_conf);\n> +\t\tbreak;\n> +\tdefault:\n> +\t\treturn -EINVAL;\n> +\t}\n> +\n> +\tif (IS_ERR(regmap))\n> +\t\treturn PTR_ERR(regmap);\n> +\n> +\tpdev = platform_device_alloc(\"mlxreg-core\", (client->adapter->nr << 8)\n> +\t\t\t\t | client->addr);\n> +\tif (!pdev)\n> +\t\treturn -ENOMEM;\n> +\n> +\ti2c_set_clientdata(client, pdev);\n> +\tpdev->dev.parent = &client->dev;\n> +\tpdev->dev.of_node = client->dev.of_node;\n> +\tpdev->dev.platform_data = regmap;\n> +\n> +\tif (client->irq) {\n> +\t\tmlxreg_i2c_resources[0].start = client->irq;\n> +\t\terr = platform_device_add_resources(pdev,\n> +\t\t\t\tmlxreg_i2c_resources,\n> +\t\t\t\tARRAY_SIZE(mlxreg_i2c_resources));\n> +\t}\n> +\n> +\terr = err ? err : platform_device_add(pdev);\n> +\n> +\tif (err)\n> +\t\tplatform_device_put(pdev);\n> +\n> +\treturn err;\n> +}\n> +\n> +static int mlxreg_i2c_remove(struct i2c_client *client)\n> +{\n> +\tstruct platform_device *pdev = i2c_get_clientdata(client);\n> +\n> +\tplatform_device_unregister(pdev);\n> +\n> +\treturn 0;\n> +}\n> +\n> +static const struct i2c_device_id mlxreg_i2c_id[] = {\n> +\t{ \"mlxreg-i2c\", MLXREG_8BIT },\n> +\t{ \"mlxreg-i2c-16\", MLXREG_16BIT },\n> +\t{ },\n> +};\n> +MODULE_DEVICE_TABLE(i2c, mlxreg_i2c_id);\n> +\n> +static const struct of_device_id mlxreg_i2c_dt_match[] = {\n> +\t{ .compatible = \"mellanox,mlxreg-i2c\" },\n> +\t{ .compatible = \"mellanox,mlxreg-i2c-16\" },\n> +\t{ },\n> +};\n> +MODULE_DEVICE_TABLE(of, mlxreg_i2c_dt_match);\n> +\n> +static struct i2c_driver mlxreg_i2c_driver = {\n> +\t.class = I2C_CLASS_HWMON,\n> +\t.driver = {\n> +\t .name = \"mlxreg-i2c\",\n> +\t .of_match_table = of_match_ptr(mlxreg_i2c_dt_match),\n> +\t},\n> +\t.probe = mlxreg_i2c_probe,\n> +\t.remove = mlxreg_i2c_remove,\n> +\t.id_table = mlxreg_i2c_id,\n> +};\n> +\n> +module_i2c_driver(mlxreg_i2c_driver);\n> +\n> +MODULE_AUTHOR(\"Vadim Pasternak \");\n> +MODULE_DESCRIPTION(\"Mellanox CPLD control I2C driver\");\n> +MODULE_LICENSE(\"Dual BSD/GPL\");\n> +MODULE_ALIAS(\"mlxreg-i2c\");","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"IGIgs2l3\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmdmn4H6Nz9sP3\n\tfor ;\n\tTue, 5 Sep 2017 17:35:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751427AbdIEHfv (ORCPT\n\t);\n\tTue, 5 Sep 2017 03:35:51 -0400","from mail-wm0-f47.google.com ([74.125.82.47]:33327 \"EHLO\n\tmail-wm0-f47.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751451AbdIEHfp (ORCPT\n\t); Tue, 5 Sep 2017 03:35:45 -0400","by mail-wm0-f47.google.com with SMTP id f145so9289361wme.0\n\tfor ;\n\tTue, 05 Sep 2017 00:35:44 -0700 (PDT)","from dell ([2.27.167.120])\n\tby smtp.gmail.com with ESMTPSA id v5sm56654wmv.12.2017.09.05.00.35.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 05 Sep 2017 00:35:43 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=/qKks9NEQTEKiVGVVLyNTCc+e0StxtpQIOT7bTmam/Y=;\n\tb=IGIgs2l3ZzN6VLA79J6Zl5RsY8dNjeiF3KOuIAFXvB9ZQxILW0p3aRZtmz3Y9Ghpdx\n\tCrp0fWsp0WQbjiv4tZnb0HjEAWtwVJ9OxZfEqjKlaZMS8RciamNqm1FXz5GYK0yYjLaJ\n\t/yFiTRJTzZW5bYUcPPTw82hgFivIrgeoA6+Fg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=/qKks9NEQTEKiVGVVLyNTCc+e0StxtpQIOT7bTmam/Y=;\n\tb=ggjqX86SyaPWGQ2Bk0WsjN+ag8sYH2VTNod+7CosBWTq17B9cknoyQWE2/cE+Guc0l\n\tY6CzLP62S3fZz/iFo4q2wgLc35qJ+dE9asKbXLaBx0LeszmAOMlv9Fs5RfMJ4cK2d/HG\n\twCGaD5m9BGuNG/gUNtcANRBThBZk+2I/4Rr5zfn38s+Nd9t/xEHnywh95HUkYCJYOHBN\n\tgDA217Ia9n1HgtSqJvaUI5X/HcRhZ6dw3rDDUBmQ9BvCdY9CwiA0wpxohJ3lhfbGIdRU\n\t3CUYlFISsgnl3MICJx8kC/PEVocVyWlG8+E9lq12D4oMr2tRxaSXxYZaQl2sggYeBN6z\n\t61dg==","X-Gm-Message-State":"AHPjjUjyu+ksJRw0l/SSBbnSzUo0aR7HMPVRBcSSAGPFIa0Ieqa62TEy\n\t0tz16ckOFvCDbsx3","X-Google-Smtp-Source":"ADKCNb4GbhQ9As1rQy2wO8657Mn2LRyy1rLqJlyyT8923eQGWxPFL2Q2PMLVfm1Vt9jBsR8Ujd/LqA==","X-Received":"by 10.28.37.65 with SMTP id l62mr1482847wml.158.1504596943966;\n\tTue, 05 Sep 2017 00:35:43 -0700 (PDT)","Date":"Tue, 5 Sep 2017 08:35:40 +0100","From":"Lee Jones ","To":"Vadim Pasternak ","Cc":"robh+dt@kernel.org, pavel@ucw.cz, devicetree@vger.kernel.org,\n\tj.anaszewski@samsung.com, rpurdie@rpsys.net,\n\tlinux-leds@vger.kernel.org, jiri@resnulli.us,\n\tgregkh@linuxfoundation.org, platform-driver-x86@vger.kernel.org","Subject":"Re: [patch v4 2/2] mfd: Add Mellanox regmap I2C driver","Message-ID":"<20170905073540.uxqhchcveu5d6vtk@dell>","References":"<1504029616-192277-1-git-send-email-vadimp@mellanox.com>\n\t<1504029616-192277-3-git-send-email-vadimp@mellanox.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<1504029616-192277-3-git-send-email-vadimp@mellanox.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1763056,"web_url":"http://patchwork.ozlabs.org/comment/1763056/","msgid":"<20170905081357.odg56cf3pkmze6cm@dell>","list_archive_url":null,"date":"2017-09-05T08:13:57","subject":"Re: [patch v4 2/2] mfd: Add Mellanox regmap I2C driver","submitter":{"id":12720,"url":"http://patchwork.ozlabs.org/api/people/12720/","name":"Lee Jones","email":"lee.jones@linaro.org"},"content":"On Tue, 05 Sep 2017, Vadim Pasternak wrote:\n> > -----Original Message-----\n> > From: Lee Jones [mailto:lee.jones@linaro.org]\n> > Sent: Tuesday, September 05, 2017 10:36 AM\n> > To: Vadim Pasternak \n> > Cc: robh+dt@kernel.org; pavel@ucw.cz; devicetree@vger.kernel.org;\n> > j.anaszewski@samsung.com; rpurdie@rpsys.net; linux-leds@vger.kernel.org;\n> > jiri@resnulli.us; gregkh@linuxfoundation.org; platform-driver-\n> > x86@vger.kernel.org\n> > Subject: Re: [patch v4 2/2] mfd: Add Mellanox regmap I2C driver\n\nThis should not appear in your replies.\n\nPlease fix your mailer.\n\n> > On Tue, 29 Aug 2017, Vadim Pasternak wrote:\n> > \n> > > This patch adds I2C regmap driver for Mellanox BMC cards with the\n> > > programmable devices attached to I2C interface. It allows support for\n> > > CPLD devices with one and two bytes address space.\n> > >\n> > > Signed-off-by: Vadim Pasternak \n> > > Acked-by: Pavel Machek \n> > > ---\n> > > MAINTAINERS | 1 +\n> > > drivers/mfd/Kconfig | 13 ++++\n> > > drivers/mfd/Makefile | 1 +\n> > > drivers/mfd/mlxreg-i2c.c | 183\n> > > +++++++++++++++++++++++++++++++++++++++++++++++\n> > > 4 files changed, 198 insertions(+)\n> > > create mode 100644 drivers/mfd/mlxreg-i2c.c\n> > \n> > I don't know what this is, but it is not an MFD driver. Please find somewhere\n> > more appropriate to locate it. MFD is not a dumping ground for drivers\n> > which do not fit anywhere else.\n> \n> Hi Lee,\n> \n> As according your previous notes I am splitting hotplug driver and moving it to new \n> folder drivers/platform/mellanox/, possibly it would be the best place to relocate it\n> there. I also intend to have in the future small drivers mlxreg-spi, mlxreg-mmio and\n> maybe it would be correct to to use these new folder for all of them?\n\nI'm afraid I don't have the topology of the driver in my mind. I\nguess those decisions will be best taken by the Platform maintainer.","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"BjywgQ/1\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmfcx1FZfz9s9Y\n\tfor ;\n\tTue, 5 Sep 2017 18:14:09 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751096AbdIEIOG (ORCPT\n\t);\n\tTue, 5 Sep 2017 04:14:06 -0400","from mail-wm0-f42.google.com ([74.125.82.42]:37390 \"EHLO\n\tmail-wm0-f42.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751677AbdIEIOB (ORCPT\n\t); Tue, 5 Sep 2017 04:14:01 -0400","by mail-wm0-f42.google.com with SMTP id u26so15192512wma.0\n\tfor ;\n\tTue, 05 Sep 2017 01:14:00 -0700 (PDT)","from dell ([2.27.167.120])\n\tby smtp.gmail.com with ESMTPSA id h14sm5447wrb.6.2017.09.05.01.13.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 05 Sep 2017 01:13:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=x80TsiejpUHVEzaw5YAe9aKE2Sfo3Q2JZIP5yS+yPKc=;\n\tb=BjywgQ/1M3gNWg3E9aTV8f0CA5K6a0Zxog8dxX6mYoxst1/JUeHYqqki+uMIwTKH1z\n\t58pl1NuyMmywT97H/a2Btmd8OloR4hOPKMu82QnXk5k1Hd/xVq94fB+fwPMV4Web/S71\n\tVidA5QgDnwAvxa6Yyg7TIMkLbIJs/7GTeh5Cs=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=x80TsiejpUHVEzaw5YAe9aKE2Sfo3Q2JZIP5yS+yPKc=;\n\tb=bW8ogoCazGsKqIizK2B9kj9T1dr2gdFcZD2U/2pbyww9zSMNetekidki3KrZS041Mk\n\t5jZT6qEN/Xv0Ucwt9+k+OLhiofNPrLmnOccdiGrbDBCvvZCX8bssNYexnciubla/bnaO\n\tsQrbSvbLtUHB+Eoj/VIvYYC6+aqWPLFvLRTer3n0hDfVRN7KOndJklXuhVOydWpd17At\n\tabHOvbMutxqmpzAa25cUezb4I36Ppd+Pv301ml55ZzZ/9RXT+BI1uvlkWAl0yanQGxO1\n\ty5SysGgj7vLjjg9tKKfxbIvcqZ/h4ZPlk6Df9Y4lgngDQGAMwLg97zykVvOI7mjgdCS6\n\txlBg==","X-Gm-Message-State":"AHPjjUhCB2vjgl37nDyGdz5GVkrzJnqRxxLCocmhzCSzbiFO9iDt5yso\n\t3BnAB9G20SOxhJ0Y","X-Google-Smtp-Source":"ADKCNb7/BBhLnYaDeUIE7x38qrw4tqDxAlopUVjTCaVQAcdU/Q53XApLt6Hydxxsf03PySDRhn65dw==","X-Received":"by 10.28.58.17 with SMTP id h17mr1793846wma.150.1504599240188;\n\tTue, 05 Sep 2017 01:14:00 -0700 (PDT)","Date":"Tue, 5 Sep 2017 09:13:57 +0100","From":"Lee Jones ","To":"Vadim Pasternak ","Cc":"\"robh+dt@kernel.org\" , \"pavel@ucw.cz\" ,\n\t\"devicetree@vger.kernel.org\" ,\n\t\"j.anaszewski@samsung.com\" ,\n\t\"rpurdie@rpsys.net\" ,\n\t\"linux-leds@vger.kernel.org\" ,\n\t\"jiri@resnulli.us\" ,\n\t\"gregkh@linuxfoundation.org\" ,\n\t\"platform-driver-x86@vger.kernel.org\" \n\t","Subject":"Re: [patch v4 2/2] mfd: Add Mellanox regmap I2C driver","Message-ID":"<20170905081357.odg56cf3pkmze6cm@dell>","References":"<1504029616-192277-1-git-send-email-vadimp@mellanox.com>\n\t<1504029616-192277-3-git-send-email-vadimp@mellanox.com>\n\t<20170905073540.uxqhchcveu5d6vtk@dell>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]