[{"id":1759462,"web_url":"http://patchwork.ozlabs.org/comment/1759462/","msgid":"<20170829183303-mutt-send-email-mst@kernel.org>","list_archive_url":null,"date":"2017-08-29T15:34:07","subject":"Re: [Qemu-devel] [PATCH v2 0/2] vhost-user-bridge reconnect\n\tregression","submitter":{"id":2235,"url":"http://patchwork.ozlabs.org/api/people/2235/","name":"Michael S. Tsirkin","email":"mst@redhat.com"},"content":"On Tue, Aug 29, 2017 at 05:27:49PM +0200, Marc-André Lureau wrote:\n> Hi,\n> \n> libvhost-user doesn't support resuming with the same trick vubr had\n> since commit 523b018dde3b7650fe5401d0499b30cf2f117515. The following\n> two patches fix that regression.\n\n\nThanks! Do we need this in 2.10? If not pls ping after 2.10 is out.\n\n> Thanks\n> \n> Marc-André Lureau (2):\n> libvhost-user: support resuming vq->last_avail_idx based on used_idx\n> vhost-user-bridge: fix resume regression (since 2.9)\n> \n> contrib/libvhost-user/libvhost-user.h | 7 +++++++\n> contrib/libvhost-user/libvhost-user.c | 13 +++++++++++++\n> tests/vhost-user-bridge.c | 7 +++++++\n> 3 files changed, 27 insertions(+)\n> \n> -- \n> 2.14.1.146.gd35faa819","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=mst@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhXl06Yw9z9t33\n\tfor ;\n\tWed, 30 Aug 2017 01:35:08 +1000 (AEST)","from localhost ([::1]:45524 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmiXi-0004gg-Ne\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 11:35:06 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47998)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmiWx-0004f8-LN\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 11:34:20 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmiWu-0005HP-IB\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 11:34:19 -0400","from mx1.redhat.com ([209.132.183.28]:50692)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmiWu-0005Fc-CQ; Tue, 29 Aug 2017 11:34:16 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 519236146A;\n\tTue, 29 Aug 2017 15:34:15 +0000 (UTC)","from redhat.com (ovpn-120-128.rdu2.redhat.com [10.10.120.128])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 999CA69290;\n\tTue, 29 Aug 2017 15:34:07 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 519236146A","Date":"Tue, 29 Aug 2017 18:34:07 +0300","From":"\"Michael S. Tsirkin\" ","To":"=?iso-8859-1?q?Marc-Andr=E9?= Lureau ","Message-ID":"<20170829183303-mutt-send-email-mst@kernel.org>","References":"<20170829152751.3174-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","In-Reply-To":"<20170829152751.3174-1-marcandre.lureau@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tTue, 29 Aug 2017 15:34:15 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 0/2] vhost-user-bridge reconnect\n\tregression","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"victork@redhat.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1759491,"web_url":"http://patchwork.ozlabs.org/comment/1759491/","msgid":"","list_archive_url":null,"date":"2017-08-29T15:57:01","subject":"Re: [Qemu-devel] [PATCH v2 0/2] vhost-user-bridge reconnect\n\tregression","submitter":{"id":6442,"url":"http://patchwork.ozlabs.org/api/people/6442/","name":"Marc-André Lureau","email":"marcandre.lureau@gmail.com"},"content":"Hi\n\nOn Tue, Aug 29, 2017 at 5:34 PM, Michael S. Tsirkin wrote:\n> On Tue, Aug 29, 2017 at 05:27:49PM +0200, Marc-André Lureau wrote:\n>> Hi,\n>>\n>> libvhost-user doesn't support resuming with the same trick vubr had\n>> since commit 523b018dde3b7650fe5401d0499b30cf2f117515. The following\n>> two patches fix that regression.\n>\n>\n> Thanks! Do we need this in 2.10? If not pls ping after 2.10 is out.\n\nI think it's not necessary since the regression appeared in 2.9\nalready, and it's a manual test.\n\nI'll ping after 2.10\n\n>\n>> Thanks\n>>\n>> Marc-André Lureau (2):\n>> libvhost-user: support resuming vq->last_avail_idx based on used_idx\n>> vhost-user-bridge: fix resume regression (since 2.9)\n>>\n>> contrib/libvhost-user/libvhost-user.h | 7 +++++++\n>> contrib/libvhost-user/libvhost-user.c | 13 +++++++++++++\n>> tests/vhost-user-bridge.c | 7 +++++++\n>> 3 files changed, 27 insertions(+)\n>>\n>> --\n>> 2.14.1.146.gd35faa819\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"qtah2fDE\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhYF35ZCXz9t3F\n\tfor ;\n\tWed, 30 Aug 2017 01:57:42 +1000 (AEST)","from localhost ([::1]:45641 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmitX-0001SK-Vx\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 11:57:40 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56110)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmisx-0001QN-UV\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 11:57:04 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmisx-0005Bi-4L\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 11:57:03 -0400","from mail-vk0-x243.google.com ([2607:f8b0:400c:c05::243]:34877)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmisw-0005BN-VJ; Tue, 29 Aug 2017 11:57:03 -0400","by mail-vk0-x243.google.com with SMTP id s199so1486460vke.2;\n\tTue, 29 Aug 2017 08:57:02 -0700 (PDT)","by 10.159.51.146 with HTTP; Tue, 29 Aug 2017 08:57:01 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=LJhEb/2kxab4WcBsQOjAbgrIby3YQx7kjiT6vlMYwno=;\n\tb=qtah2fDEpigTtD2TLQFewUhR0eT3qAs4E/kZToY4wUcFvJW01ZyFZxKhdL7JrXdK9u\n\tm3Vgn/9R1A27RV6x/5C05fZuEcoq7vKG/YlAhdMRdB2y52ZC8WZAiFOs6zBropz83LGX\n\tAkfs1GbR9R1iMjaKnZYp4A68IyGwT4BSBEniTT31NyzfY65dLjkf2yz5lB8C6WTjza0o\n\tqEhdn6SXQo39XXfIvUQpXifTd6C5wVwS4NBVWQVzDWKU4jq414IvVRSHCNMdgnGXFqlP\n\trM5g3vozqoYb5CH4qkTNpmOwWL7y1Bb6IntI7GRh6ZQSej26IVb92Aj9hs46FXquwjyV\n\tFzCQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=LJhEb/2kxab4WcBsQOjAbgrIby3YQx7kjiT6vlMYwno=;\n\tb=AWGoqUNWaUtGaDZvclbg+txAKRgD0evhxx+/MOCBsrkQ33ow6GTUpRPO1idmp7g3Ex\n\tfycwiIh1TnJBABYRHi0R+F4NNXKsy0R9pKdesv7YURzsGNIEAlcjYa/9NNH2aHaEZjZi\n\tebuVbQQVF7Uz/aWT3hxPNDmvVyXs19rL8B6/bwKYualnVxmHNlFD2q08FGSuPI0Ucbk+\n\tf8VUHqcsnzPsBueeRzNljXTL/YCxxxunfk5MbQD74quJDCGUefzJabRiWZmOHNkI//R7\n\tfZXce4UUz9x+p2y/vcOuufSpbiSOlSJdYhhptR6J8QaC804J6pHqbwWAfxTLfvyuoU2Z\n\tdKew==","X-Gm-Message-State":"AHYfb5gJ7nY/LXE62BKDIclh2LqgmoLrbiqhs1983g1oVQ+IfJnzBXm+\n\tUkPxVl+K+ixRRfFxWOMo4YvUKqjGqw==","X-Received":"by 10.31.54.138 with SMTP id d132mr451097vka.11.1504022222230;\n\tTue, 29 Aug 2017 08:57:02 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170829183303-mutt-send-email-mst@kernel.org>","References":"<20170829152751.3174-1-marcandre.lureau@redhat.com>\n\t<20170829183303-mutt-send-email-mst@kernel.org>","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Tue, 29 Aug 2017 17:57:01 +0200","Message-ID":"","To":"\"Michael S. Tsirkin\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400c:c05::243","Subject":"Re: [Qemu-devel] [PATCH v2 0/2] vhost-user-bridge reconnect\n\tregression","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Victor Kaplansky , QEMU ,\n\tqemu-stable ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1768886,"web_url":"http://patchwork.ozlabs.org/comment/1768886/","msgid":"<150543406487.22700.15054030640393601199@loki>","list_archive_url":null,"date":"2017-09-15T00:07:44","subject":"Re: [Qemu-devel] [Qemu-stable] [PATCH v2 0/2] vhost-user-bridge\n\treconnect regression","submitter":{"id":5549,"url":"http://patchwork.ozlabs.org/api/people/5549/","name":"Michael Roth","email":"mdroth@linux.vnet.ibm.com"},"content":"Quoting Marc-André Lureau (2017-08-29 10:57:01)\n> Hi\n> \n> On Tue, Aug 29, 2017 at 5:34 PM, Michael S. Tsirkin wrote:\n> > On Tue, Aug 29, 2017 at 05:27:49PM +0200, Marc-André Lureau wrote:\n> >> Hi,\n> >>\n> >> libvhost-user doesn't support resuming with the same trick vubr had\n> >> since commit 523b018dde3b7650fe5401d0499b30cf2f117515. The following\n> >> two patches fix that regression.\n> >\n> >\n> > Thanks! Do we need this in 2.10? If not pls ping after 2.10 is out.\n> \n> I think it's not necessary since the regression appeared in 2.9\n> already, and it's a manual test.\n> \n> I'll ping after 2.10\n\nFYI I'm looking to get v2.10.1 out this month, freeze will likely be set for\nSep. 25th if you're looking to get this in.\n\n> \n> >\n> >> Thanks\n> >>\n> >> Marc-André Lureau (2):\n> >> libvhost-user: support resuming vq->last_avail_idx based on used_idx\n> >> vhost-user-bridge: fix resume regression (since 2.9)\n> >>\n> >> contrib/libvhost-user/libvhost-user.h | 7 +++++++\n> >> contrib/libvhost-user/libvhost-user.c | 13 +++++++++++++\n> >> tests/vhost-user-bridge.c | 7 +++++++\n> >> 3 files changed, 27 insertions(+)\n> >>\n> >> --\n> >> 2.14.1.146.gd35faa819\n> >\n> \n> \n> \n> -- \n> Marc-André Lureau\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtbzD5LDZz9s7M\n\tfor ;\n\tFri, 15 Sep 2017 10:35:34 +1000 (AEST)","from localhost ([::1]:50648 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsebT-00087q-Al\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 20:35:31 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51766)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dseb8-000861-NN\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 20:35:11 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dseb4-0007bS-0Q\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 20:35:10 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:44937)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dseb3-0007b1-O7\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 20:35:05 -0400","from pps.filterd (m0098410.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8F0YObq053802\n\tfor ; Thu, 14 Sep 2017 20:35:03 -0400","from e19.ny.us.ibm.com (e19.ny.us.ibm.com [129.33.205.209])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cyypsax85-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Thu, 14 Sep 2017 20:35:03 -0400","from localhost\n\tby e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tThu, 14 Sep 2017 20:35:02 -0400","from b01cxnp22035.gho.pok.ibm.com (9.57.198.25)\n\tby e19.ny.us.ibm.com (146.89.104.206) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tThu, 14 Sep 2017 20:34:58 -0400","from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com\n\t[9.57.199.108])\n\tby b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v8F0YwCv49545404; Fri, 15 Sep 2017 00:34:58 GMT","from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 138D6B2046;\n\tThu, 14 Sep 2017 20:32:20 -0400 (EDT)","from localhost (unknown [9.80.107.119])\n\tby b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP id D09EFB204D;\n\tThu, 14 Sep 2017 20:32:19 -0400 (EDT)"],"Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","To":"\"Michael S. Tsirkin\" , =?utf-8?q?Marc-Andr=C3=A9_Lurea?=\n\t=?utf-8?q?u?= ","From":"Michael Roth ","In-Reply-To":"","References":"<20170829152751.3174-1-marcandre.lureau@redhat.com>\n\t<20170829183303-mutt-send-email-mst@kernel.org>\n\t","User-Agent":"alot/0.5.1","Date":"Thu, 14 Sep 2017 19:07:44 -0500","X-TM-AS-GCONF":"00","x-cbid":"17091500-0056-0000-0000-000003C92279","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007736; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000227; SDB=6.00917135; UDB=6.00460616;\n\tIPR=6.00697362; \n\tBA=6.00005589; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017159;\n\tXFM=3.00000015; UTC=2017-09-15 00:35:00","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17091500-0057-0000-0000-000008002455","Message-Id":"<150543406487.22700.15054030640393601199@loki>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-14_07:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709150005","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [Qemu-stable] [PATCH v2 0/2] vhost-user-bridge\n\treconnect regression","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Victor Kaplansky , QEMU ,\n\tqemu-stable ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]