[{"id":1759396,"web_url":"http://patchwork.ozlabs.org/comment/1759396/","msgid":"<w51fucafnk2.fsf@maestria.local.igalia.com>","list_archive_url":null,"date":"2017-08-29T14:36:45","subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","submitter":{"id":65704,"url":"http://patchwork.ozlabs.org/api/people/65704/","name":"Alberto Garcia","email":"berto@igalia.com"},"content":"On Tue 29 Aug 2017 04:23:01 PM CEST, Pradeep Jagadeesh wrote:\n> These patches provide the qmp interface, to query the io throttle \n> status of the all fsdev devices that are present in a vm.\n> also, it provides an interface to set the io throttle parameters of a\n> fsdev to a required value. some of the patches also remove the duplicate\n> code that was present in block and fsdev files. \n\nOops, I was just reviewing the previous version of this series, but it\nlooks like you just moved code around, so my comments still apply.\n\nAnyway, this should be v9, shouldn't it? v8 was published weeks ago:\n\n   https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg01043.html\n\nBerto","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"P8XCE3D1\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhWSQ0KCpz9s7f\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 00:37:22 +1000 (AEST)","from localhost ([::1]:45271 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmhdo-00006E-9b\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 10:37:20 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58110)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <berto@igalia.com>) id 1dmhdV-000068-Rw\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 10:37:03 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <berto@igalia.com>) id 1dmhdR-0001vN-Hp\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 10:37:01 -0400","from fanzine.igalia.com ([91.117.99.155]:41765)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <berto@igalia.com>) id 1dmhdR-0001ut-8M\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 10:36:57 -0400","from maestria.local.igalia.com ([192.168.10.14]\n\thelo=mail.igalia.com) by fanzine.igalia.com with esmtps \n\t(Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim)\n\tid 1dmhdG-0001h4-16; Tue, 29 Aug 2017 16:36:46 +0200","from berto by mail.igalia.com with local (Exim)\n\tid 1dmhdF-00040Z-Ue; Tue, 29 Aug 2017 16:36:45 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329; \n\th=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From;\n\tbh=F4o88fROP5uRuI1lDBVwWFyhnTXofz+bTlTXXagjhjk=; \n\tb=P8XCE3D1e2Ctlm60WpNqepy3amVM+j6ansjAjbPOzes3VkuCmkQs7AC2SZKM6sIHL6dTXiZ1EUh4zoDCsoso8+bzcX+C1KYbaTJ2ZTPQyBIUCUwsuavUHmXmNmfFKETV7y7C+nqnx20QUzlBx/pQCVh1BwcVOghz5RiVEr8eNcBpi9EQXw0YZ6q+YHEDML7XfgzXkaiCTG9lwaieyUDK7f/p3/G10vAVPsKAMX5BYmxaZvHPN23uwfSc+DYk99Py3uyGQk632/HfMxlT5N/ee6V8je3sF0hrPWmqeG6K5/an/s/4hdWRy03Fn06uYNwxXz9Z0YgkYOxgnGwqsYthRA==;","From":"Alberto Garcia <berto@igalia.com>","To":"Pradeep Jagadeesh <pradeepkiruvale@gmail.com>,\n\teric blake <eblake@redhat.com>, greg kurz <groug@kaod.org>","In-Reply-To":"<1504016587-39779-1-git-send-email-pradeep.jagadeesh@huawei.com>","References":"<1504016587-39779-1-git-send-email-pradeep.jagadeesh@huawei.com>","User-Agent":"Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1\n\t(i586-pc-linux-gnu)","Date":"Tue, 29 Aug 2017 16:36:45 +0200","Message-ID":"<w51fucafnk2.fsf@maestria.local.igalia.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no\n\ttimestamps) [generic] [fuzzy]","X-Received-From":"91.117.99.155","Subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"qemu-devel@nongnu.org, jani kokkonen <jani.kokkonen@huawei.com>,\n\tPradeep Jagadeesh <pradeep.jagadeesh@huawei.com>,\n\t\"Dr. David Alan Gilbert\" <dgilbert@redhat.com>,\n\tMarkus Armbruster <armbru@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1759399,"web_url":"http://patchwork.ozlabs.org/comment/1759399/","msgid":"<a81bc8f8-8ceb-8f92-1554-bc0d26180b1d@huawei.com>","list_archive_url":null,"date":"2017-08-29T14:39:39","subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","submitter":{"id":69883,"url":"http://patchwork.ozlabs.org/api/people/69883/","name":"Pradeep Jagadeesh","email":"pradeep.jagadeesh@huawei.com"},"content":"On 8/29/2017 4:36 PM, Alberto Garcia wrote:\n> On Tue 29 Aug 2017 04:23:01 PM CEST, Pradeep Jagadeesh wrote:\n>> These patches provide the qmp interface, to query the io throttle\n>> status of the all fsdev devices that are present in a vm.\n>> also, it provides an interface to set the io throttle parameters of a\n>> fsdev to a required value. some of the patches also remove the duplicate\n>> code that was present in block and fsdev files.\n>\n> Oops, I was just reviewing the previous version of this series, but it\n> looks like you just moved code around, so my comments still apply.\n>\n> Anyway, this should be v9, shouldn't it? v8 was published weeks ago:\n>\n>    https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg01043.html\n\nHmm, sorry it should be v9, I missed. I will resend the patches with \nnewer version.\n\nRegards,\nPradeep\n>\n> Berto\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhWYD2FPhz9s7f\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 00:41:36 +1000 (AEST)","from localhost ([::1]:45289 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmhhu-0001Gd-7P\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 10:41:34 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59816)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <pradeep.jagadeesh@huawei.com>) id 1dmhhP-0001FS-22\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 10:41:04 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <pradeep.jagadeesh@huawei.com>) id 1dmhhJ-00046Z-8i\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 10:41:03 -0400","from lhrrgout.huawei.com ([194.213.3.17]:22390)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)\n\t(envelope-from <pradeep.jagadeesh@huawei.com>) id 1dmhhI-0003yV-VT\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 10:40:57 -0400","from 172.18.7.190 (EHLO lhreml707-cah.china.huawei.com)\n\t([172.18.7.190])\n\tby lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued)\n\twith ESMTP id DNN83639; Tue, 29 Aug 2017 14:40:04 +0000 (GMT)","from [127.0.0.1] (10.210.171.103) by lhreml707-cah.china.huawei.com\n\t(10.201.108.48) with Microsoft SMTP Server id 14.3.301.0;\n\tTue, 29 Aug 2017 15:39:51 +0100"],"To":"Alberto Garcia <berto@igalia.com>, Pradeep Jagadeesh\n\t<pradeepkiruvale@gmail.com>, eric blake <eblake@redhat.com>, greg kurz\n\t<groug@kaod.org>","References":"<1504016587-39779-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<w51fucafnk2.fsf@maestria.local.igalia.com>","From":"Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>","Message-ID":"<a81bc8f8-8ceb-8f92-1554-bc0d26180b1d@huawei.com>","Date":"Tue, 29 Aug 2017 16:39:39 +0200","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<w51fucafnk2.fsf@maestria.local.igalia.com>","Content-Type":"text/plain; charset=\"windows-1252\"; format=flowed","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.210.171.103]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A0B0206.59A57CC5.00E4, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"c9710b05c4ce1b7d11d1d7d57c4dbdbc","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic]\n\t[fuzzy]","X-Received-From":"194.213.3.17","Subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"qemu-devel@nongnu.org, jani kokkonen <jani.kokkonen@huawei.com>,\n\tMarkus Armbruster <armbru@redhat.com>,\n\t\"Dr. David Alan Gilbert\" <dgilbert@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1760095,"web_url":"http://patchwork.ozlabs.org/comment/1760095/","msgid":"<w51fuc98di8.fsf@maestria.local.igalia.com>","list_archive_url":null,"date":"2017-08-30T12:07:59","subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","submitter":{"id":65704,"url":"http://patchwork.ozlabs.org/api/people/65704/","name":"Alberto Garcia","email":"berto@igalia.com"},"content":"On Tue 29 Aug 2017 04:23:01 PM CEST, Pradeep Jagadeesh wrote:\n> These patches provide the qmp interface, to query the io throttle \n> status of the all fsdev devices that are present in a vm.\n\nI'm trying to read from an 9p share that has limits set with hmp\nfsdev_set_io_throttle and I'm having some problems.\n\nFor example if I'm reading a large file and I change the I/O limits\nwhile the file is still being read then the guest process freezes.\n\nCan you try to reproduce that scenario?\n\nBerto","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"cue+zqUJ\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj46Q0MP1z9sQl\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 22:08:44 +1000 (AEST)","from localhost ([::1]:50217 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dn1nW-0002BN-0N\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 08:08:42 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60474)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <berto@igalia.com>) id 1dn1nA-0002BE-5v\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 08:08:21 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <berto@igalia.com>) id 1dn1n7-0005Ut-15\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 08:08:20 -0400","from fanzine.igalia.com ([91.117.99.155]:47756)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <berto@igalia.com>) id 1dn1n6-0005UZ-KV\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 08:08:16 -0400","from maestria.local.igalia.com ([192.168.10.14]\n\thelo=mail.igalia.com) by fanzine.igalia.com with esmtps \n\t(Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim)\n\tid 1dn1mp-0004mP-4Y; Wed, 30 Aug 2017 14:07:59 +0200","from berto by mail.igalia.com with local (Exim)\n\tid 1dn1mp-0000o0-22; Wed, 30 Aug 2017 14:07:59 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329; \n\th=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From;\n\tbh=NKm7aXD73SOcU+7IfLJdy4ijxegFjZRP4BdCknp2SA4=; \n\tb=cue+zqUJcMx/bLk1fNgL8pO30COOtTKNMMNNO6fmbSdpgVbAGGpTVrjNysFeB02iQvSvj8oruE+0qVdKIKiFm+uaOQOlUYrXTjSrEu25n6xLF5CFGOAfdOcjyUl/HnGoRsMIIz0M6NAHJn3CPkqILGS3s6Vmo4wuSMpodEpw4DL+W3nVGwIjifgFoyvZ7sCofffb5IKy+U0aWZ8LpEQNo+QMzyAOkOE658NSohwg/J/DOvJapKvrY3gpeW+o+13rcTEAsFKmvewMRb51lo3XxnJ1HbBUm2WHhlfHYnKitrXtNpQbB5uLqZOL0AvlQhYFFGsdJp7cMppA6UqmofxQRw==;","From":"Alberto Garcia <berto@igalia.com>","To":"Pradeep Jagadeesh <pradeepkiruvale@gmail.com>,\n\teric blake <eblake@redhat.com>, greg kurz <groug@kaod.org>","In-Reply-To":"<1504016587-39779-1-git-send-email-pradeep.jagadeesh@huawei.com>","References":"<1504016587-39779-1-git-send-email-pradeep.jagadeesh@huawei.com>","User-Agent":"Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1\n\t(i586-pc-linux-gnu)","Date":"Wed, 30 Aug 2017 14:07:59 +0200","Message-ID":"<w51fuc98di8.fsf@maestria.local.igalia.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no\n\ttimestamps) [generic] [fuzzy]","X-Received-From":"91.117.99.155","Subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"qemu-devel@nongnu.org, jani kokkonen <jani.kokkonen@huawei.com>,\n\tPradeep Jagadeesh <pradeep.jagadeesh@huawei.com>,\n\t\"Dr. David Alan Gilbert\" <dgilbert@redhat.com>,\n\tMarkus Armbruster <armbru@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1760104,"web_url":"http://patchwork.ozlabs.org/comment/1760104/","msgid":"<9b24c28f-f891-1046-f09f-bffded9e316f@huawei.com>","list_archive_url":null,"date":"2017-08-30T12:10:53","subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","submitter":{"id":69883,"url":"http://patchwork.ozlabs.org/api/people/69883/","name":"Pradeep Jagadeesh","email":"pradeep.jagadeesh@huawei.com"},"content":"On 8/30/2017 2:07 PM, Alberto Garcia wrote:\n> On Tue 29 Aug 2017 04:23:01 PM CEST, Pradeep Jagadeesh wrote:\n>> These patches provide the qmp interface, to query the io throttle\n>> status of the all fsdev devices that are present in a vm.\n>\n> I'm trying to read from an 9p share that has limits set with hmp\n> fsdev_set_io_throttle and I'm having some problems.\n>\n> For example if I'm reading a large file and I change the I/O limits\n> while the file is still being read then the guest process freezes.\n>\n> Can you try to reproduce that scenario?\nThanks for letting me know about the issue.\nOK, I will try to reproduce.have a look.\n\n-Pradeep\n\n>\n> Berto\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj4D83Dwvz9sQl\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 22:13:43 +1000 (AEST)","from localhost ([::1]:50239 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dn1sL-0004CR-MV\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 08:13:41 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33086)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <pradeep.jagadeesh@huawei.com>) id 1dn1qh-0003OK-HQ\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 08:12:00 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <pradeep.jagadeesh@huawei.com>) id 1dn1qe-0006hN-E6\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 08:11:59 -0400","from lhrrgout.huawei.com ([194.213.3.17]:22454)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)\n\t(envelope-from <pradeep.jagadeesh@huawei.com>) id 1dn1qe-0006gR-4j\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 08:11:56 -0400","from 172.18.7.190 (EHLO lhreml704-cah.china.huawei.com)\n\t([172.18.7.190])\n\tby lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued)\n\twith ESMTP id DUL41711; Wed, 30 Aug 2017 12:11:09 +0000 (GMT)","from [127.0.0.1] (10.210.172.95) by lhreml704-cah.china.huawei.com\n\t(10.201.108.45) with Microsoft SMTP Server id 14.3.301.0;\n\tWed, 30 Aug 2017 13:10:54 +0100"],"To":"Alberto Garcia <berto@igalia.com>, Pradeep Jagadeesh\n\t<pradeepkiruvale@gmail.com>, eric blake <eblake@redhat.com>, greg kurz\n\t<groug@kaod.org>","References":"<1504016587-39779-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<w51fuc98di8.fsf@maestria.local.igalia.com>","From":"Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>","Message-ID":"<9b24c28f-f891-1046-f09f-bffded9e316f@huawei.com>","Date":"Wed, 30 Aug 2017 14:10:53 +0200","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<w51fuc98di8.fsf@maestria.local.igalia.com>","Content-Type":"text/plain; charset=\"windows-1252\"; format=flowed","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.210.172.95]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A0B0203.59A6AB5E.003A, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"ac8b53006291d841b37d16462c1eae72","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic]\n\t[fuzzy]","X-Received-From":"194.213.3.17","Subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"qemu-devel@nongnu.org, jani kokkonen <jani.kokkonen@huawei.com>,\n\tMarkus Armbruster <armbru@redhat.com>,\n\t\"Dr. David Alan Gilbert\" <dgilbert@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1760208,"web_url":"http://patchwork.ozlabs.org/comment/1760208/","msgid":"<20170830162859.16b5a8a3@bahia>","list_archive_url":null,"date":"2017-08-30T14:28:59","subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","submitter":{"id":69178,"url":"http://patchwork.ozlabs.org/api/people/69178/","name":"Greg Kurz","email":"groug@kaod.org"},"content":"On Wed, 30 Aug 2017 14:07:59 +0200\nAlberto Garcia <berto@igalia.com> wrote:\n\n> On Tue 29 Aug 2017 04:23:01 PM CEST, Pradeep Jagadeesh wrote:\n> > These patches provide the qmp interface, to query the io throttle \n> > status of the all fsdev devices that are present in a vm.  \n> \n> I'm trying to read from an 9p share that has limits set with hmp\n> fsdev_set_io_throttle and I'm having some problems.\n> \n> For example if I'm reading a large file and I change the I/O limits\n> while the file is still being read then the guest process freezes.\n> \n> Can you try to reproduce that scenario?\n> \n> Berto\n\nThanks Berto for the review and the testing ! I'm on vacation but I'll\njump in next week when I'm back and Pradeep has posted the next version.\n\nCheers,\n\n--\nGreg","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj7Dz5fl8z9s8J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 00:29:39 +1000 (AEST)","from localhost ([::1]:50895 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dn3zt-0007WW-KL\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 10:29:37 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45278)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <groug@kaod.org>) id 1dn3zX-0007WB-4v\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:29:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <groug@kaod.org>) id 1dn3zT-0001MM-SC\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:29:15 -0400","from 17.mo6.mail-out.ovh.net ([46.105.36.150]:59851)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <groug@kaod.org>) id 1dn3zT-0001Lw-LI\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:29:11 -0400","from player735.ha.ovh.net (b9.ovh.net [213.186.33.59])\n\tby mo6.mail-out.ovh.net (Postfix) with ESMTP id 145381086E8\n\tfor <qemu-devel@nongnu.org>; Wed, 30 Aug 2017 16:29:09 +0200 (CEST)","from bahia (ACaen-652-1-166-41.w86-215.abo.wanadoo.fr\n\t[86.215.38.41]) (Authenticated sender: groug@kaod.org)\n\tby player735.ha.ovh.net (Postfix) with ESMTPSA id C9CF2160083;\n\tWed, 30 Aug 2017 16:29:00 +0200 (CEST)"],"Date":"Wed, 30 Aug 2017 16:28:59 +0200","From":"Greg Kurz <groug@kaod.org>","To":"Alberto Garcia <berto@igalia.com>","Message-ID":"<20170830162859.16b5a8a3@bahia>","In-Reply-To":"<w51fuc98di8.fsf@maestria.local.igalia.com>","References":"<1504016587-39779-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<w51fuc98di8.fsf@maestria.local.igalia.com>","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tboundary=\"Sig_/iJ8gq0Fa_.u+/FoGimXAt/f\";\n\tprotocol=\"application/pgp-signature\"","X-Ovh-Tracer-Id":"14678638563710376336","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrfeelledrudeigdejjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"46.105.36.150","Subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"qemu-devel@nongnu.org, \"Dr. David Alan Gilbert\" <dgilbert@redhat.com>,\n\tPradeep Jagadeesh <pradeepkiruvale@gmail.com>,\n\tMarkus Armbruster <armbru@redhat.com>,\n\tPradeep Jagadeesh <pradeep.jagadeesh@huawei.com>,\n\tjani kokkonen <jani.kokkonen@huawei.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1760260,"web_url":"http://patchwork.ozlabs.org/comment/1760260/","msgid":"<w51bmmx85so.fsf@maestria.local.igalia.com>","list_archive_url":null,"date":"2017-08-30T14:54:31","subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","submitter":{"id":65704,"url":"http://patchwork.ozlabs.org/api/people/65704/","name":"Alberto Garcia","email":"berto@igalia.com"},"content":"On Wed 30 Aug 2017 02:10:53 PM CEST, Pradeep Jagadeesh wrote:\n\n>> I'm trying to read from an 9p share that has limits set with hmp\n>> fsdev_set_io_throttle and I'm having some problems.\n\nHere's one simple way to reproduce it:\n\n1) Launch qemu with\n\n   -fsdev local,security_model=none,id=fs0,path=/some/files\n   -device virtio-9p-pci,fsdev=fs0,mount_tag=fs0\n\n2) In the guest, mount the fs0 share in /mnt\n\n3) Run this hmp command\n\n   fsdev_set_io_throttle fs0 0 4096 0 0 0 0\n\n4) In the guest, start reading some large file from the 9p share:\n\n   dd if=/mnt/large_file of=/dev/null bs=4k iflag=direct status=progress\n\n5) Check the progress, reading speed should be around 4k per second.\n\n6) While dd is still running, change the I/O limits:\n\n   fsdev_set_io_throttle fs0 0 8192 0 0 0 0\n\n7) If you check the status of the dd command, reading should be faster\n   now. Instead, it is stalled.\n\nBerto","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"IoyD16Au\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj82R72M8z9sP5\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 01:05:34 +1000 (AEST)","from localhost ([::1]:51056 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dn4Yd-0007AT-Kg\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 11:05:31 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55316)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <berto@igalia.com>) id 1dn4YC-00076y-I0\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 11:05:10 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <berto@igalia.com>) id 1dn4Y8-0005z2-A1\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 11:05:04 -0400","from fanzine.igalia.com ([91.117.99.155]:43130)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <berto@igalia.com>) id 1dn4Y7-0005yX-Tt\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 11:05:00 -0400","from maestria.local.igalia.com ([192.168.10.14]\n\thelo=mail.igalia.com) by fanzine.igalia.com with esmtps \n\t(Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim)\n\tid 1dn4Xu-0005y2-5E; Wed, 30 Aug 2017 17:04:46 +0200","from berto by mail.igalia.com with local (Exim)\n\tid 1dn4Nz-0000gX-P4; Wed, 30 Aug 2017 16:54:31 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329; \n\th=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From;\n\tbh=JRtSpqOY9j4cWTFF60cB/jEDiF080/OWyiDpifc7CN0=; \n\tb=IoyD16AuA7lzhcBFOviyVtsL5ZFiwh5cZ/LQs4d/K7mpAny6KxIJO8rIUb8YExGxq7OL6M1RsK4AZMYznnFsJ4+ns8sUoiG+06AzaYkkegTV4ZR12To0qfw7NUpjJUozvnsIKAqcnPS5v1W8gAYXqimDhTPTHrR/M2XJpPFj+ZMT7Otnt+bf7l0ZItVJP9PKqCb7+wmNXT5tJLdTL/zSXS1ddFxJyKcXw8LFzNNDsNCsQo1osxM94l2vFSEyjr7UhHit/+NQ9LN5IPyiKeVAmMwq5AvltutzQluC54rhG7V4dCYOPDAs68aR9UZVSt8eUPPiuCOZJ+ZTjL+xsf9wqw==;","From":"Alberto Garcia <berto@igalia.com>","To":"Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>,\n\tPradeep Jagadeesh <pradeepkiruvale@gmail.com>,\n\teric blake <eblake@redhat.com>, greg kurz <groug@kaod.org>","In-Reply-To":"<9b24c28f-f891-1046-f09f-bffded9e316f@huawei.com>","References":"<1504016587-39779-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<w51fuc98di8.fsf@maestria.local.igalia.com>\n\t<9b24c28f-f891-1046-f09f-bffded9e316f@huawei.com>","User-Agent":"Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1\n\t(i586-pc-linux-gnu)","Date":"Wed, 30 Aug 2017 16:54:31 +0200","Message-ID":"<w51bmmx85so.fsf@maestria.local.igalia.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no\n\ttimestamps) [generic] [fuzzy]","X-Received-From":"91.117.99.155","Subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"qemu-devel@nongnu.org, jani kokkonen <jani.kokkonen@huawei.com>,\n\tMarkus Armbruster <armbru@redhat.com>,\n\t\"Dr. David Alan Gilbert\" <dgilbert@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1760263,"web_url":"http://patchwork.ozlabs.org/comment/1760263/","msgid":"<f6cdc881-39a4-92f6-c218-a57516ca0921@huawei.com>","list_archive_url":null,"date":"2017-08-30T15:07:29","subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","submitter":{"id":69883,"url":"http://patchwork.ozlabs.org/api/people/69883/","name":"Pradeep Jagadeesh","email":"pradeep.jagadeesh@huawei.com"},"content":"On 8/30/2017 4:54 PM, Alberto Garcia wrote:\n> On Wed 30 Aug 2017 02:10:53 PM CEST, Pradeep Jagadeesh wrote:\n>\n>>> I'm trying to read from an 9p share that has limits set with hmp\n>>> fsdev_set_io_throttle and I'm having some problems.\n>\n> Here's one simple way to reproduce it:\n>\n> 1) Launch qemu with\n>\n>    -fsdev local,security_model=none,id=fs0,path=/some/files\n>    -device virtio-9p-pci,fsdev=fs0,mount_tag=fs0\n>\n> 2) In the guest, mount the fs0 share in /mnt\n>\n> 3) Run this hmp command\n>\n>    fsdev_set_io_throttle fs0 0 4096 0 0 0 0\n>\n> 4) In the guest, start reading some large file from the 9p share:\n>\n>    dd if=/mnt/large_file of=/dev/null bs=4k iflag=direct status=progress\n>\n> 5) Check the progress, reading speed should be around 4k per second.\n>\n> 6) While dd is still running, change the I/O limits:\n>\n>    fsdev_set_io_throttle fs0 0 8192 0 0 0 0\n>\n> 7) If you check the status of the dd command, reading should be faster\n>    now. Instead, it is stalled.\n\nThanks for the steps, I did reproduce the issue easily.\nLooking into the code, may be we also need to try the same with the \nblock devices.\n\n-Pradeep\n>\n> Berto\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj86X35W2z9sN7\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 01:09:08 +1000 (AEST)","from localhost ([::1]:51073 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dn4c6-000143-5W\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 11:09:06 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56528)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <pradeep.jagadeesh@huawei.com>) id 1dn4ba-00010U-0G\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 11:08:39 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <pradeep.jagadeesh@huawei.com>) id 1dn4bW-0007el-HL\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 11:08:33 -0400","from lhrrgout.huawei.com ([194.213.3.17]:22458)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)\n\t(envelope-from <pradeep.jagadeesh@huawei.com>) id 1dn4bW-0007dB-7s\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 11:08:30 -0400","from 172.18.7.190 (EHLO lhreml708-cah.china.huawei.com)\n\t([172.18.7.190])\n\tby lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued)\n\twith ESMTP id DNP68367; Wed, 30 Aug 2017 15:07:40 +0000 (GMT)","from [127.0.0.1] (10.210.172.95) by lhreml708-cah.china.huawei.com\n\t(10.201.108.49) with Microsoft SMTP Server id 14.3.301.0;\n\tWed, 30 Aug 2017 16:07:31 +0100"],"To":"Alberto Garcia <berto@igalia.com>, Pradeep Jagadeesh\n\t<pradeepkiruvale@gmail.com>, eric blake <eblake@redhat.com>, greg kurz\n\t<groug@kaod.org>","References":"<1504016587-39779-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<w51fuc98di8.fsf@maestria.local.igalia.com>\n\t<9b24c28f-f891-1046-f09f-bffded9e316f@huawei.com>\n\t<w51bmmx85so.fsf@maestria.local.igalia.com>","From":"Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>","Message-ID":"<f6cdc881-39a4-92f6-c218-a57516ca0921@huawei.com>","Date":"Wed, 30 Aug 2017 17:07:29 +0200","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<w51bmmx85so.fsf@maestria.local.igalia.com>","Content-Type":"text/plain; charset=\"windows-1252\"; format=flowed","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.210.172.95]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A090206.59A6D4BE.012A, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"c9710b05c4ce1b7d11d1d7d57c4dbdbc","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic]\n\t[fuzzy]","X-Received-From":"194.213.3.17","Subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"qemu-devel@nongnu.org, jani kokkonen <jani.kokkonen@huawei.com>,\n\tMarkus Armbruster <armbru@redhat.com>,\n\t\"Dr. David Alan Gilbert\" <dgilbert@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1760266,"web_url":"http://patchwork.ozlabs.org/comment/1760266/","msgid":"<w518ti1851v.fsf@maestria.local.igalia.com>","list_archive_url":null,"date":"2017-08-30T15:10:36","subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","submitter":{"id":65704,"url":"http://patchwork.ozlabs.org/api/people/65704/","name":"Alberto Garcia","email":"berto@igalia.com"},"content":"On Wed 30 Aug 2017 05:07:29 PM CEST, Pradeep Jagadeesh wrote:\n\n> Thanks for the steps, I did reproduce the issue easily. Looking into\n> the code, may be we also need to try the same with the block devices.\n\nI did some tests and it was working fine, so I'd suspect of the fsdev\ncode first.\n\nBerto","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"M7c+xPeT\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj8973Jl0z9sN7\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 01:11:21 +1000 (AEST)","from localhost ([::1]:51091 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dn4eE-000366-NF\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 11:11:18 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57900)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <berto@igalia.com>) id 1dn4dr-00035h-EE\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 11:10:59 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <berto@igalia.com>) id 1dn4do-0000OA-0R\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 11:10:55 -0400","from fanzine.igalia.com ([91.117.99.155]:43929)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <berto@igalia.com>) id 1dn4dn-0000Md-Il\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 11:10:51 -0400","from maestria.local.igalia.com ([192.168.10.14]\n\thelo=mail.igalia.com) by fanzine.igalia.com with esmtps \n\t(Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim)\n\tid 1dn4dY-0006Vk-7H; Wed, 30 Aug 2017 17:10:36 +0200","from berto by mail.igalia.com with local (Exim)\n\tid 1dn4dY-0006Za-4c; Wed, 30 Aug 2017 17:10:36 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329; \n\th=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From;\n\tbh=3eDoTqacGvqt5FNf5sunf3sEo6d2coNneYB9GIH/FqA=; \n\tb=M7c+xPeTbiyuvEaZ4LkvidExBOd/Sop6XgVcMDxGZO+szp+BV5H12iPFTz89L48HcORk2seqMtXIe3ZE9HpSiOixv9TpURhr7baNn8rOgZ2Yb87VvPJdWTRLZM7W1RbE89b7NmHB1gDleUSNXuATN+LEHiJnTo0PxLG6mx8EwW4Ud1jcq69/ZxYQ6Tlu/crwgBHAipDpcQl7y3mCTDDX2QU6TDkO1Jwy51SA6BjtHPTEETwduw3q1cMK7QWV+gfQsEVpwW8lLztns6nqdGgmsgcIJcXlg/FZdbpIg8cfqCJPFcP7xPqjNnhfjhfziZL1C0vPQcFsF9YS6+pguXLs9g==;","From":"Alberto Garcia <berto@igalia.com>","To":"Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>,\n\tPradeep Jagadeesh <pradeepkiruvale@gmail.com>,\n\teric blake <eblake@redhat.com>, greg kurz <groug@kaod.org>","In-Reply-To":"<f6cdc881-39a4-92f6-c218-a57516ca0921@huawei.com>","References":"<1504016587-39779-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<w51fuc98di8.fsf@maestria.local.igalia.com>\n\t<9b24c28f-f891-1046-f09f-bffded9e316f@huawei.com>\n\t<w51bmmx85so.fsf@maestria.local.igalia.com>\n\t<f6cdc881-39a4-92f6-c218-a57516ca0921@huawei.com>","User-Agent":"Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1\n\t(i586-pc-linux-gnu)","Date":"Wed, 30 Aug 2017 17:10:36 +0200","Message-ID":"<w518ti1851v.fsf@maestria.local.igalia.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no\n\ttimestamps) [generic] [fuzzy]","X-Received-From":"91.117.99.155","Subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"qemu-devel@nongnu.org, jani kokkonen <jani.kokkonen@huawei.com>,\n\tMarkus Armbruster <armbru@redhat.com>,\n\t\"Dr. David Alan Gilbert\" <dgilbert@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1760271,"web_url":"http://patchwork.ozlabs.org/comment/1760271/","msgid":"<f44d823d-d7a6-1783-051f-9d754ada0475@huawei.com>","list_archive_url":null,"date":"2017-08-30T15:12:22","subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","submitter":{"id":69883,"url":"http://patchwork.ozlabs.org/api/people/69883/","name":"Pradeep Jagadeesh","email":"pradeep.jagadeesh@huawei.com"},"content":"On 8/30/2017 5:10 PM, Alberto Garcia wrote:\n> On Wed 30 Aug 2017 05:07:29 PM CEST, Pradeep Jagadeesh wrote:\n>\n>> Thanks for the steps, I did reproduce the issue easily. Looking into\n>> the code, may be we also need to try the same with the block devices.\n>\n> I did some tests and it was working fine, so I'd suspect of the fsdev\n> code first.\n>\nOK, thanks for the clarification. I will look into fsdev code.\n\n-Pradeep\n> Berto\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj8Cw0CMsz9sN7\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 01:13:48 +1000 (AEST)","from localhost ([::1]:51098 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dn4gb-0004QJ-Ru\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 11:13:45 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58790)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <pradeep.jagadeesh@huawei.com>) id 1dn4gE-0004O3-8n\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 11:13:27 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <pradeep.jagadeesh@huawei.com>) id 1dn4gA-0001WX-SK\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 11:13:22 -0400","from lhrrgout.huawei.com ([194.213.3.17]:22459)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)\n\t(envelope-from <pradeep.jagadeesh@huawei.com>) id 1dn4gA-0001Vz-Ib\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 11:13:18 -0400","from 172.18.7.190 (EHLO lhreml701-cah.china.huawei.com)\n\t([172.18.7.190])\n\tby lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued)\n\twith ESMTP id DNP69111; Wed, 30 Aug 2017 15:12:33 +0000 (GMT)","from [127.0.0.1] (10.210.172.95) by lhreml701-cah.china.huawei.com\n\t(10.201.108.42) with Microsoft SMTP Server id 14.3.301.0;\n\tWed, 30 Aug 2017 16:12:23 +0100"],"To":"Alberto Garcia <berto@igalia.com>, Pradeep Jagadeesh\n\t<pradeepkiruvale@gmail.com>, eric blake <eblake@redhat.com>, greg kurz\n\t<groug@kaod.org>","References":"<1504016587-39779-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<w51fuc98di8.fsf@maestria.local.igalia.com>\n\t<9b24c28f-f891-1046-f09f-bffded9e316f@huawei.com>\n\t<w51bmmx85so.fsf@maestria.local.igalia.com>\n\t<f6cdc881-39a4-92f6-c218-a57516ca0921@huawei.com>\n\t<w518ti1851v.fsf@maestria.local.igalia.com>","From":"Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>","Message-ID":"<f44d823d-d7a6-1783-051f-9d754ada0475@huawei.com>","Date":"Wed, 30 Aug 2017 17:12:22 +0200","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<w518ti1851v.fsf@maestria.local.igalia.com>","Content-Type":"text/plain; charset=\"windows-1252\"; format=flowed","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.210.172.95]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A090202.59A6D5E1.010A, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"c9710b05c4ce1b7d11d1d7d57c4dbdbc","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic]\n\t[fuzzy]","X-Received-From":"194.213.3.17","Subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"qemu-devel@nongnu.org, jani kokkonen <jani.kokkonen@huawei.com>,\n\tMarkus Armbruster <armbru@redhat.com>,\n\t\"Dr. David Alan Gilbert\" <dgilbert@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1760999,"web_url":"http://patchwork.ozlabs.org/comment/1760999/","msgid":"<w51pobb509z.fsf@maestria.local.igalia.com>","list_archive_url":null,"date":"2017-08-31T13:34:16","subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","submitter":{"id":65704,"url":"http://patchwork.ozlabs.org/api/people/65704/","name":"Alberto Garcia","email":"berto@igalia.com"},"content":"On Wed 30 Aug 2017 05:12:22 PM CEST, Pradeep Jagadeesh wrote:\n> On 8/30/2017 5:10 PM, Alberto Garcia wrote:\n>> On Wed 30 Aug 2017 05:07:29 PM CEST, Pradeep Jagadeesh wrote:\n>>\n>>> Thanks for the steps, I did reproduce the issue easily. Looking into\n>>> the code, may be we also need to try the same with the block devices.\n>>\n>> I did some tests and it was working fine, so I'd suspect of the fsdev\n>> code first.\n>>\n> OK, thanks for the clarification. I will look into fsdev code.\n\nI just took a quick look at the code, the problem is almost certainly in\nfsdev_set_io_throttle(): that doesn't simply update the config, it also\nreinitializes the FsThrottle structure completely, creates new timers\nand new throttled_reqs queues. If there were pending requests there\nthey're probably lost forever.\n\nTake a look at blk_set_io_limits() and see how it is done for block\ndevices.\n\nBerto","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"olpPCe30\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjk0L5sPNz9sPm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 23:35:45 +1000 (AEST)","from localhost ([::1]:55855 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dnPdH-0002zJ-7F\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 09:35:43 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59473)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <berto@igalia.com>) id 1dnPcl-0002v3-88\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:35:15 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <berto@igalia.com>) id 1dnPci-0007tb-63\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:35:11 -0400","from fanzine.igalia.com ([91.117.99.155]:45881)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <berto@igalia.com>) id 1dnPch-0007fd-PC\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:35:08 -0400","from maestria.local.igalia.com ([192.168.10.14]\n\thelo=mail.igalia.com) by fanzine.igalia.com with esmtps \n\t(Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim)\n\tid 1dnPbs-000548-VG; Thu, 31 Aug 2017 15:34:16 +0200","from berto by mail.igalia.com with local (Exim)\n\tid 1dnPbs-0004x5-Sr; Thu, 31 Aug 2017 15:34:16 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329; \n\th=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From;\n\tbh=VBhaXSX2GsZw0KpO/iXa46UZYkInbgrR/wHzs+GefmU=; \n\tb=olpPCe30Oi/D3K6fVqbsxl216cGRbkkVKTgJ+ywL92XRDDhYp2Yn+2oGRwdRuTSeGtMZyK5Z8RTg+/ForcjjLu8Q5lh74Ur1/Fa0oWhnPyuAjhgwwv6Uq17s6Mi4wc5tr/iY6WI0r7Hz5kiWOgpUKag8YtI0n6n4npUsE67BPev+hEpZZ76m7OzPH+kvAVMeMxmTWj4dhsKEoeEH/VBbC5MzdwinxH8u5FitSdkxBDrpJ4vHxTDwBgqyb3Bh4xz0hEn5ixeIwP7iUBhU4Ie0wE8aYb/7kHkwQ2N60ZGYxwvN0p7kNpkAAbOUr/b6OatZWiY7CPoam+Ves63plNGmRQ==;","From":"Alberto Garcia <berto@igalia.com>","To":"Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>,\n\tPradeep Jagadeesh <pradeepkiruvale@gmail.com>,\n\teric blake <eblake@redhat.com>, greg kurz <groug@kaod.org>","In-Reply-To":"<f44d823d-d7a6-1783-051f-9d754ada0475@huawei.com>","References":"<1504016587-39779-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<w51fuc98di8.fsf@maestria.local.igalia.com>\n\t<9b24c28f-f891-1046-f09f-bffded9e316f@huawei.com>\n\t<w51bmmx85so.fsf@maestria.local.igalia.com>\n\t<f6cdc881-39a4-92f6-c218-a57516ca0921@huawei.com>\n\t<w518ti1851v.fsf@maestria.local.igalia.com>\n\t<f44d823d-d7a6-1783-051f-9d754ada0475@huawei.com>","User-Agent":"Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1\n\t(i586-pc-linux-gnu)","Date":"Thu, 31 Aug 2017 15:34:16 +0200","Message-ID":"<w51pobb509z.fsf@maestria.local.igalia.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no\n\ttimestamps) [generic] [fuzzy]","X-Received-From":"91.117.99.155","Subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"qemu-devel@nongnu.org, jani kokkonen <jani.kokkonen@huawei.com>,\n\tMarkus Armbruster <armbru@redhat.com>,\n\t\"Dr. David Alan Gilbert\" <dgilbert@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1761005,"web_url":"http://patchwork.ozlabs.org/comment/1761005/","msgid":"<d255cd1e-cdb9-74d3-f2e2-a1614c6f29bd@huawei.com>","list_archive_url":null,"date":"2017-08-31T13:39:41","subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","submitter":{"id":69883,"url":"http://patchwork.ozlabs.org/api/people/69883/","name":"Pradeep Jagadeesh","email":"pradeep.jagadeesh@huawei.com"},"content":"On 8/31/2017 3:34 PM, Alberto Garcia wrote:\n> On Wed 30 Aug 2017 05:12:22 PM CEST, Pradeep Jagadeesh wrote:\n>> On 8/30/2017 5:10 PM, Alberto Garcia wrote:\n>>> On Wed 30 Aug 2017 05:07:29 PM CEST, Pradeep Jagadeesh wrote:\n>>>\n>>>> Thanks for the steps, I did reproduce the issue easily. Looking into\n>>>> the code, may be we also need to try the same with the block devices.\n>>>\n>>> I did some tests and it was working fine, so I'd suspect of the fsdev\n>>> code first.\n>>>\n>> OK, thanks for the clarification. I will look into fsdev code.\n>\n> I just took a quick look at the code, the problem is almost certainly in\n> fsdev_set_io_throttle(): that doesn't simply update the config, it also\n> reinitializes the FsThrottle structure completely, creates new timers\n> and new throttled_reqs queues. If there were pending requests there\n> they're probably lost forever.\n>\n> Take a look at blk_set_io_limits() and see how it is done for block\n> devices.\nYes, that is right. I had a look. Now I am figuring out how to \ninitialize the timers without loosing the pending requests.\nIf I update the config when there is no IO going, it works fine.\nWhen IO is going and try to update it hangs.\n\n-Pradeep\n>\n> Berto\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjk6q2LyLz9sPm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 23:41:21 +1000 (AEST)","from localhost ([::1]:55875 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dnPif-0006fI-4U\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 09:41:17 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60859)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <pradeep.jagadeesh@huawei.com>) id 1dnPiL-0006fC-CT\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:40:58 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <pradeep.jagadeesh@huawei.com>) id 1dnPiD-0001ab-Nk\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:40:57 -0400","from lhrrgout.huawei.com ([194.213.3.17]:22604)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)\n\t(envelope-from <pradeep.jagadeesh@huawei.com>) id 1dnPiD-0001aL-Dv\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:40:49 -0400","from 172.18.7.190 (EHLO LHREML711-CAH.china.huawei.com)\n\t([172.18.7.190])\n\tby lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued)\n\twith ESMTP id DNR21009; Thu, 31 Aug 2017 13:40:01 +0000 (GMT)","from [127.0.0.1] (10.210.170.223) by LHREML711-CAH.china.huawei.com\n\t(10.201.108.34) with Microsoft SMTP Server id 14.3.301.0;\n\tThu, 31 Aug 2017 14:39:42 +0100"],"To":"Alberto Garcia <berto@igalia.com>, Pradeep Jagadeesh\n\t<pradeepkiruvale@gmail.com>, eric blake <eblake@redhat.com>, greg kurz\n\t<groug@kaod.org>","References":"<1504016587-39779-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<w51fuc98di8.fsf@maestria.local.igalia.com>\n\t<9b24c28f-f891-1046-f09f-bffded9e316f@huawei.com>\n\t<w51bmmx85so.fsf@maestria.local.igalia.com>\n\t<f6cdc881-39a4-92f6-c218-a57516ca0921@huawei.com>\n\t<w518ti1851v.fsf@maestria.local.igalia.com>\n\t<f44d823d-d7a6-1783-051f-9d754ada0475@huawei.com>\n\t<w51pobb509z.fsf@maestria.local.igalia.com>","From":"Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>","Message-ID":"<d255cd1e-cdb9-74d3-f2e2-a1614c6f29bd@huawei.com>","Date":"Thu, 31 Aug 2017 15:39:41 +0200","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<w51pobb509z.fsf@maestria.local.igalia.com>","Content-Type":"text/plain; charset=\"windows-1252\"; format=flowed","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.210.170.223]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A090204.59A811B2.02C1, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"c9710b05c4ce1b7d11d1d7d57c4dbdbc","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic]\n\t[fuzzy]","X-Received-From":"194.213.3.17","Subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"qemu-devel@nongnu.org, jani kokkonen <jani.kokkonen@huawei.com>,\n\tMarkus Armbruster <armbru@redhat.com>,\n\t\"Dr. David Alan Gilbert\" <dgilbert@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1761655,"web_url":"http://patchwork.ozlabs.org/comment/1761655/","msgid":"<b0d876a3-da9b-83c9-3257-df88feb0f4a2@huawei.com>","list_archive_url":null,"date":"2017-09-01T12:44:27","subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","submitter":{"id":69883,"url":"http://patchwork.ozlabs.org/api/people/69883/","name":"Pradeep Jagadeesh","email":"pradeep.jagadeesh@huawei.com"},"content":"On 8/31/2017 3:34 PM, Alberto Garcia wrote:\n> On Wed 30 Aug 2017 05:12:22 PM CEST, Pradeep Jagadeesh wrote:\n>> On 8/30/2017 5:10 PM, Alberto Garcia wrote:\n>>> On Wed 30 Aug 2017 05:07:29 PM CEST, Pradeep Jagadeesh wrote:\n>>>\n>>>> Thanks for the steps, I did reproduce the issue easily. Looking into\n>>>> the code, may be we also need to try the same with the block devices.\n>>>\n>>> I did some tests and it was working fine, so I'd suspect of the fsdev\n>>> code first.\n>>>\n>> OK, thanks for the clarification. I will look into fsdev code.\n>\n> I just took a quick look at the code, the problem is almost certainly in\n> fsdev_set_io_throttle(): that doesn't simply update the config, it also\n> reinitializes the FsThrottle structure completely, creates new timers\n> and new throttled_reqs queues. If there were pending requests there\n> they're probably lost forever.\n>\n> Take a look at blk_set_io_limits() and see how it is done for block\n> devices.\nI fixed it. I am testing it. I was initializing the queues again.\nBut it just needs updation of throttle configuration.\n\n-Pradeep\n>\n> Berto\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkJrl0RNLz9s7c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  1 Sep 2017 22:46:15 +1000 (AEST)","from localhost ([::1]:39511 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dnlKv-0004Wr-6s\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 08:46:13 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52433)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <pradeep.jagadeesh@huawei.com>) id 1dnlKL-0004Tg-DW\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 08:45:43 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <pradeep.jagadeesh@huawei.com>) id 1dnlKF-0002uW-If\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 08:45:37 -0400","from lhrrgout.huawei.com ([194.213.3.17]:22653)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)\n\t(envelope-from <pradeep.jagadeesh@huawei.com>) id 1dnlKF-0002tA-90\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 08:45:31 -0400","from 172.18.7.190 (EHLO LHREML710-CAH.china.huawei.com)\n\t([172.18.7.190])\n\tby lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued)\n\twith ESMTP id DNS65137; Fri, 01 Sep 2017 12:44:37 +0000 (GMT)","from [127.0.0.1] (10.210.168.85) by LHREML710-CAH.china.huawei.com\n\t(10.201.108.33) with Microsoft SMTP Server id 14.3.301.0;\n\tFri, 1 Sep 2017 13:44:28 +0100"],"To":"Alberto Garcia <berto@igalia.com>, Pradeep Jagadeesh\n\t<pradeepkiruvale@gmail.com>, eric blake <eblake@redhat.com>, greg kurz\n\t<groug@kaod.org>","References":"<1504016587-39779-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<w51fuc98di8.fsf@maestria.local.igalia.com>\n\t<9b24c28f-f891-1046-f09f-bffded9e316f@huawei.com>\n\t<w51bmmx85so.fsf@maestria.local.igalia.com>\n\t<f6cdc881-39a4-92f6-c218-a57516ca0921@huawei.com>\n\t<w518ti1851v.fsf@maestria.local.igalia.com>\n\t<f44d823d-d7a6-1783-051f-9d754ada0475@huawei.com>\n\t<w51pobb509z.fsf@maestria.local.igalia.com>","From":"Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>","Message-ID":"<b0d876a3-da9b-83c9-3257-df88feb0f4a2@huawei.com>","Date":"Fri, 1 Sep 2017 14:44:27 +0200","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<w51pobb509z.fsf@maestria.local.igalia.com>","Content-Type":"text/plain; charset=\"windows-1252\"; format=flowed","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.210.168.85]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A020203.59A95638.0013, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"c9710b05c4ce1b7d11d1d7d57c4dbdbc","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic]\n\t[fuzzy]","X-Received-From":"194.213.3.17","Subject":"Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io\n\tthrottling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"qemu-devel@nongnu.org, jani kokkonen <jani.kokkonen@huawei.com>,\n\tMarkus Armbruster <armbru@redhat.com>,\n\t\"Dr. David Alan Gilbert\" <dgilbert@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]