[{"id":1760838,"web_url":"http://patchwork.ozlabs.org/comment/1760838/","msgid":"<20170831131836.777aa652@bbrezillon>","list_archive_url":null,"date":"2017-08-31T11:18:36","subject":"Re: [PATCH 0/2] mtd: nand: fix regression introduced by splitting\n\toff manufacturer dependent code","submitter":{"id":63120,"url":"http://patchwork.ozlabs.org/api/people/63120/","name":"Boris Brezillon","email":"boris.brezillon@free-electrons.com"},"content":"On Tue, 29 Aug 2017 12:17:11 +0200\nLothar Waßmann wrote:\n\n> commit c51d0ac59f24 (\"mtd: nand: Move Samsung specific init/detection\n> logic in nand_samsung.c\") introduced a regression for Samsung SLC NAND\n> chips by skipping the initialization of chip->bits_per_cell that is\n> done in nand_decode_ext_id() from which the manufacturer dependent\n> code was extracted.\n> The regression should also affect Hynix and Macronix chips whose code\n> was separated out in further commits but which I cannot test.\n> AMD/Spansion and Toshiba NAND are not affected, since they are calling \n> nand_decode_ext_id() (which initializes bhip->bits_per_cell) in their\n> .detect function.\n> \n> Fix the regression and add a warning to nand_is_slc() to prevent\n> further regressions of this kind.\n\nApplied both to nand/next and generated a new PR to push this in 4.14.\nAlso added the Fixes and Cc-stable tag to the first patch.\n\nThanks,\n\nBoris","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"X0S1xxJ8\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjfzG0HhMz9sQl\n\tfor ;\n\tThu, 31 Aug 2017 21:19:38 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dnNVM-0007oq-Nz; Thu, 31 Aug 2017 11:19:24 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dnNV6-0007Yk-R7\n\tfor linux-mtd@lists.infradead.org; Thu, 31 Aug 2017 11:19:10 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 043FA20919; Thu, 31 Aug 2017 13:18:46 +0200 (CEST)","from bbrezillon (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id BD903208E3;\n\tThu, 31 Aug 2017 13:18:35 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=oWZqhyI9iBPCuXPUWCF9uYUmbCM39aF30E1FV4fSN5s=;\n\tb=X0S1xxJ81ifNUy\n\tmmwLA5A2Vc/ygTUB/y55aQbpHBV1YkDY1kM5oC2bPZC/O2bjR3YyYA6AklCef5x6333V+gU5YLCVD\n\tktjiU1ozmgLTpoNSxVuIPqTHBOrbkR7nocBKx9DyyoRDv2Daw8DfoS4/AUFvFBzN+pl02V9RZe3z8\n\taqzCeCDbhnoeTDyF6GaLnaGb61BHOzENIloVmlbT3XfxlkwCl9pTofn7FR9zAQFD06WidCyvVxQOj\n\totY+J4Y/gJhvIbJZiLrNWoS0U4z6DvZdVqSENRy8qaT58R48x/2QSF7syD581H+OhHVQdAm7vw9HW\n\tE6KJrTah4MZDnO8l7Q8A==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT\n\tshortcircuit=ham autolearn=disabled version=3.4.0","Date":"Thu, 31 Aug 2017 13:18:36 +0200","From":"Boris Brezillon ","To":"Lothar =?utf-8?q?Wa=C3=9Fmann?= ","Subject":"Re: [PATCH 0/2] mtd: nand: fix regression introduced by splitting\n\toff manufacturer dependent code","Message-ID":"<20170831131836.777aa652@bbrezillon>","In-Reply-To":"<1504001833-18097-1-git-send-email-LW@KARO-electronics.de>","References":"<1504001833-18097-1-git-send-email-LW@KARO-electronics.de>","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170831_041909_043633_2D131CAD ","X-CRM114-Status":"GOOD ( 11.60 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Richard Weinberger , linux-kernel@vger.kernel.org,\n\tMarek Vasut , linux-mtd@lists.infradead.org,\n\tCyrille Pitchen ,\n\tBrian Norris ,\n\tDavid Woodhouse ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]