[{"id":1758748,"web_url":"http://patchwork.ozlabs.org/comment/1758748/","msgid":"<150394317426.30.4061505269299378548@b5667b65043c>","list_archive_url":null,"date":"2017-08-28T17:59:36","subject":"Re: [Qemu-devel] [PATCH v4 00/10] tests: Add VM based build tests\n\t(for non-x86_64 and/or non-Linux)","submitter":{"id":69632,"url":"http://patchwork.ozlabs.org/api/people/69632/","name":null,"email":"no-reply@patchew.org"},"content":"Hi,\n\nThis series seems to have some coding style problems. See output below for\nmore information:\n\nMessage-id: 20170828174707.20786-1-famz@redhat.com\nSubject: [Qemu-devel] [PATCH v4 00/10] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)\nType: series\n\n=== TEST SCRIPT BEGIN ===\n#!/bin/bash\n\nBASE=base\nn=1\ntotal=$(git log --oneline $BASE.. | wc -l)\nfailed=0\n\ngit config --local diff.renamelimit 0\ngit config --local diff.renames True\n\ncommits=\"$(git log --format=%H --reverse $BASE..)\"\nfor c in $commits; do\n echo \"Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)...\"\n if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then\n failed=1\n echo\n fi\n n=$((n+1))\ndone\n\nexit $failed\n=== TEST SCRIPT END ===\n\nUpdating 3c8cf5a9c21ff8782164d1def7f44bd888713384\nFrom https://github.com/patchew-project/qemu\n * [new tag] patchew/20170828174707.20786-1-famz@redhat.com -> patchew/20170828174707.20786-1-famz@redhat.com\nSwitched to a new branch 'test'\nf3b1bda848 tests: Add README for vm tests\n04700be074 MAINTAINERS: Add tests/vm entry\na0ca710c91 Makefile: Add rules to run vm tests\n4c0b2bd683 tests: Add OpenBSD image\nd80c217349 tests: Add NetBSD image\n6626fdfad5 tests: Add FreeBSD image\ne5c04f2943 tests: Add ubuntu.i386 image\nbb43450459 tests: Add vm test lib\n3c32f56fea qemu.py: Add \"wait()\" method\n349a29d4ad gitignore: Ignore vm test images\n\n=== OUTPUT BEGIN ===\nChecking PATCH 1/10: gitignore: Ignore vm test images...\nChecking PATCH 2/10: qemu.py: Add \"wait()\" method...\nChecking PATCH 3/10: tests: Add vm test lib...\nERROR: line over 90 characters\n#85: FILE: tests/vm/basevm.py:60:\n+ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQCikC46WYtXotUd0UGPz9547Aj0KqC4gk+nt4BBJm86IHgCD9FygSGX9EFutXlhz9KZIPg9Okk7+IzXRHCWI2MNvhrcjyrezKREm71z08j9iwfxY3340fY2Mo+0khwpO7bzsgzkljHIHqcOg7MgttPInVMNH/EfqpgR8EDKJuWCB2Ny+EBFN/3dAiff0X/EvKle9PUrY70EkSycnyURS8HZReEqj8lN9J5kXzA8F6jBo/0Q42Ttv6e4k5YcaDrwmLrBWLra2PCXZLNyHqXEiFkGmdXtA1Eox9gc/p4jIXim6xrPNmpN6WyrrEjaCF5xYvNv8wXkD6uSWwbHYU24lIAn qemu-vm-key\n\nWARNING: line over 80 characters\n#206: FILE: tests/vm/basevm.py:181:\n+ \"file=%s,if=none,id=%s,cache=writeback,format=raw\" % \\\n\nWARNING: line over 80 characters\n#209: FILE: tests/vm/basevm.py:184:\n+ \"virtio-blk,drive=%s,serial=%s,bootindex=1\" % (name, name)]\n\nERROR: line over 90 characters\n#256: FILE: tests/vm/basevm.py:231:\n+ VM test utility. Exit codes: 0 = success, 1 = command line error, 2 = environment initialization failed, 3 = test command failed\"\"\")\n\ntotal: 2 errors, 2 warnings, 287 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 4/10: tests: Add ubuntu.i386 image...\nChecking PATCH 5/10: tests: Add FreeBSD image...\nChecking PATCH 6/10: tests: Add NetBSD image...\nChecking PATCH 7/10: tests: Add OpenBSD image...\nChecking PATCH 8/10: Makefile: Add rules to run vm tests...\nChecking PATCH 9/10: MAINTAINERS: Add tests/vm entry...\nChecking PATCH 10/10: tests: Add README for vm tests...\n=== OUTPUT END ===\n\nTest command exited with code: 1\n\n\n---\nEmail generated automatically by Patchew [http://patchew.org/].\nPlease send your feedback to patchew-devel@freelists.org","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xh02W3rnSz9sNr\n\tfor ;\n\tTue, 29 Aug 2017 04:01:39 +1000 (AEST)","from localhost ([::1]:40926 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmOLx-00017w-AK\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 14:01:37 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36708)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmOKS-0000As-4z\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 14:00:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmOKO-0008IP-6O\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 14:00:04 -0400","from sender-of-o52.zoho.com ([135.84.80.217]:21326)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmOKN-0008Hu-UI\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 14:00:00 -0400","from [172.17.0.2] (23.253.156.214 [23.253.156.214]) by\n\tmx.zohomail.com with SMTPS id 1503943176859799.3810294037577;\n\tMon, 28 Aug 2017 10:59:36 -0700 (PDT)"],"Resent-Date":"Mon, 28 Aug 2017 14:00:04 -0400","Resent-Message-Id":"","In-Reply-To":"<20170828174707.20786-1-famz@redhat.com>","Message-ID":"<150394317426.30.4061505269299378548@b5667b65043c>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Resent-From":"","From":"no-reply@patchew.org","To":"famz@redhat.com","Date":"Mon, 28 Aug 2017 10:59:36 -0700 (PDT)","X-ZohoMailClient":"External","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"135.84.80.217","Subject":"Re: [Qemu-devel] [PATCH v4 00/10] tests: Add VM based build tests\n\t(for non-x86_64 and/or non-Linux)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"qemu-devel@nongnu.org","Cc":"peter.maydell@linaro.org, famz@redhat.com, f4bug@amsat.org,\n\tqemu-devel@nongnu.org, kamil@netbsd.org, stefanha@redhat.com,\n\tcrosa@redhat.com, pbonzini@redhat.com, alex.bennee@linaro.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]