[{"id":1760446,"web_url":"http://patchwork.ozlabs.org/comment/1760446/","msgid":"<20170830200700.GX8154@bhelgaas-glaptop.roam.corp.google.com>","list_archive_url":null,"date":"2017-08-30T20:07:00","subject":"Re: [PATCH 0/2] fix 4GB DRAM window support on mvebu","submitter":{"id":67298,"url":"http://patchwork.ozlabs.org/api/people/67298/","name":"Bjorn Helgaas","email":"helgaas@kernel.org"},"content":"On Mon, Aug 28, 2017 at 05:25:15PM +0200, Jan Luebbe wrote:\n> The current MBUS DRAM window calculation fails for 4GB windows because it\n> overflows. This is fixed in the first patch by using u64 instead of u32 to\n> store the size. The second excplicitly checks that we don't try to configure a\n> too large memory window in the pci driver.\n> \n> As they don't depend on each other, they could also go in separatly.\n> \n> Jan Luebbe (2):\n> bus: mbus: fix window size calculation for 4GB windows\n> PCI: mvebu: Check DRAM window size\n> \n> drivers/bus/mvebu-mbus.c | 2 +-\n> drivers/pci/host/pci-mvebu.c | 27 ++++++++++++++++++++++-----\n> include/linux/mbus.h | 4 ++--\n> 3 files changed, 25 insertions(+), 8 deletions(-)\n\nSince these can be applied separately, I'll let somebody else take care of\nthe drivers/bus/mvebu-mbus.c part.\n\nI'll look for an ack from Thomas or Jason before applying the second patch,\nwhich touches drivers/pci/host/pci-mvebu.c.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=helgaas@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjGkJ3PTSz9rxm\n\tfor ;\n\tThu, 31 Aug 2017 06:07:04 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750761AbdH3UHC (ORCPT );\n\tWed, 30 Aug 2017 16:07:02 -0400","from mail.kernel.org ([198.145.29.99]:35078 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750756AbdH3UHC (ORCPT );\n\tWed, 30 Aug 2017 16:07:02 -0400","from localhost (unknown [69.55.156.165])\n\t(using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 8394D2199E;\n\tWed, 30 Aug 2017 20:07:01 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 8394D2199E","Date":"Wed, 30 Aug 2017 15:07:00 -0500","From":"Bjorn Helgaas ","To":"Jan Luebbe ","Cc":"Gregory Clement ,\n\tAndrew Lunn ,\n\tThomas Petazzoni ,\n\tJason Cooper , linux-pci@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,\n\tkernel@pengutronix.de","Subject":"Re: [PATCH 0/2] fix 4GB DRAM window support on mvebu","Message-ID":"<20170830200700.GX8154@bhelgaas-glaptop.roam.corp.google.com>","References":"<20170828152517.24506-1-jlu@pengutronix.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170828152517.24506-1-jlu@pengutronix.de>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1760731,"web_url":"http://patchwork.ozlabs.org/comment/1760731/","msgid":"<87y3q017ih.fsf@free-electrons.com>","list_archive_url":null,"date":"2017-08-31T08:11:34","subject":"Re: [PATCH 0/2] fix 4GB DRAM window support on mvebu","submitter":{"id":15771,"url":"http://patchwork.ozlabs.org/api/people/15771/","name":"Gregory CLEMENT","email":"gregory.clement@free-electrons.com"},"content":"Hi Bjorn and Jan,\n \n On mer., août 30 2017, Bjorn Helgaas wrote:\n\n> On Mon, Aug 28, 2017 at 05:25:15PM +0200, Jan Luebbe wrote:\n>> The current MBUS DRAM window calculation fails for 4GB windows because it\n>> overflows. This is fixed in the first patch by using u64 instead of u32 to\n>> store the size. The second excplicitly checks that we don't try to configure a\n>> too large memory window in the pci driver.\n>> \n>> As they don't depend on each other, they could also go in separatly.\n>> \n>> Jan Luebbe (2):\n>> bus: mbus: fix window size calculation for 4GB windows\n>> PCI: mvebu: Check DRAM window size\n>> \n>> drivers/bus/mvebu-mbus.c | 2 +-\n>> drivers/pci/host/pci-mvebu.c | 27 ++++++++++++++++++++++-----\n>> include/linux/mbus.h | 4 ++--\n>> 3 files changed, 25 insertions(+), 8 deletions(-)\n>\n> Since these can be applied separately, I'll let somebody else take care of\n> the drivers/bus/mvebu-mbus.c part.\n\nI think I am the one who should take it. I will apply it when v4.14-rc1\nwill be released as it is too late for me for 4.14 now.\n\nHowever I am not against the fact that it is applied through an other\ntree because we don't touch this file for the next release so there is\nno risk for a conflict, I can give my Acked-by if needed.\n\nThanks,\n\nGregory\n\n>\n> I'll look for an ack from Thomas or Jason before applying the second patch,\n> which touches drivers/pci/host/pci-mvebu.c.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjZqM2GGpz9sRW\n\tfor ;\n\tThu, 31 Aug 2017 18:12:31 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751392AbdHaILs convert rfc822-to-8bit (ORCPT\n\t);\n\tThu, 31 Aug 2017 04:11:48 -0400","from mail.free-electrons.com ([62.4.15.54]:40341 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751264AbdHaILq (ORCPT\n\t); Thu, 31 Aug 2017 04:11:46 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 2255D209BF; Thu, 31 Aug 2017 10:11:44 +0200 (CEST)","from localhost (unknown [93.29.146.83])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id E6FAA209B2;\n\tThu, 31 Aug 2017 10:11:33 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","From":"Gregory CLEMENT ","To":"Jan Luebbe , Bjorn Helgaas ","Cc":"Andrew Lunn ,\n\tThomas Petazzoni ,\n\tJason Cooper , linux-pci@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,\n\tkernel@pengutronix.de","Subject":"Re: [PATCH 0/2] fix 4GB DRAM window support on mvebu","References":"<20170828152517.24506-1-jlu@pengutronix.de>\n\t<20170830200700.GX8154@bhelgaas-glaptop.roam.corp.google.com>","Date":"Thu, 31 Aug 2017 10:11:34 +0200","In-Reply-To":"<20170830200700.GX8154@bhelgaas-glaptop.roam.corp.google.com>\n\t(Bjorn Helgaas's message of \"Wed, 30 Aug 2017 15:07:00 -0500\")","Message-ID":"<87y3q017ih.fsf@free-electrons.com>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8BIT","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}}]