[{"id":3688393,"web_url":"http://patchwork.ozlabs.org/comment/3688393/","msgid":"","list_archive_url":null,"date":"2026-05-08T12:49:36","subject":"Re: [PATCH v2 0/9] Fixes/improvements for the PCI M.2 power\n sequencing driver","submitter":{"id":93245,"url":"http://patchwork.ozlabs.org/api/people/93245/","name":"Wei Deng","email":"wei.deng@oss.qualcomm.com"},"content":"Hi Mani,\n\nTested with WCN685x on both M.2 card (pwrseq-pcie-m2) and direct attach\n(pwrseq-qcom-wcn). BT works correctly in both cases.\n\nTested-by: Wei Deng \n\nOn 5/8/2026 12:06 AM, Manivannan Sadhasivam via B4 Relay wrote:\n> Hi,\n> \n> This series has several key improvements and fixes to the M.2 power sequencing\n> driver and also the BT HCI_QCA driver. Notably, this series allows the M.2 power\n> sequencing driver to work with more M.2 cards, not just WCN7850. It also allows\n> the BT HCI_QCA driver to detect whether it can control BT_EN (or W_DISABLE2#)\n> signal on the connector and set the HCI_QUIRK_NON_PERSISTENT_SETUP quirk.\n> \n> Testing\n> =======\n> \n> This series was tested on Lenovo Thinkpad T14s together with the below DTS\n> patches:\n> https://github.com/Mani-Sadhasivam/linux/commit/29534d15307551b2355eb254601dec511169f0aa\n> https://github.com/Mani-Sadhasivam/linux/commit/f4eaacfe647674be200847092b43cdef2194fc55\n> \n> Merge Strategy\n> ==============\n> \n> Since the BT HCI_QCA changes depend on the pwrseq changes, it would be good to\n> merge the whole series through pwrseq tree or through an immutable branch.\n> \n> Signed-off-by: Manivannan Sadhasivam \n> ---\n> Changes in v2:\n> - Dropped the pwrseq_is_fixed() change in favor or exporting pwrseq device's dev\n> pointer and using it to check for the presence of W_DISABLE2# property\n> - Dropped the BT_EN fix for the Qcom WCN devices since it will be handled\n> separately\n> - Collected tags\n> - Link to v1: https://patch.msgid.link/20260422-pwrseq-m2-bt-v1-0-720d02545a64@oss.qualcomm.com\n> \n> ---\n> Manivannan Sadhasivam (9):\n> power: sequencing: pcie-m2: Fix inconsistent function prefixes\n> power: sequencing: pcie-m2: Allow creating serdev for multiple PCI devices\n> power: sequencing: pcie-m2: Improve PCI device ID check\n> power: sequencing: pcie-m2: Create serdev for PCI devices present before probe\n> power: sequencing: pcie-m2: Create BT node based on the pci_device_id[] table\n> Bluetooth: hci_qca: Add M.2 Bluetooth device support using pwrseq\n> Bluetooth: hci_qca: Rename 'power_ctrl_enabled' to 'bt_en_available'\n> power: sequencing: Add an API to return the pwrseq device's 'dev' pointer\n> Bluetooth: hci_qca: Set 'bt_en_available' based on W_DISABLE2# presence in M.2 connector\n> \n> drivers/bluetooth/hci_qca.c | 28 +++-\n> drivers/power/sequencing/core.c | 9 ++\n> drivers/power/sequencing/pwrseq-pcie-m2.c | 234 ++++++++++++++++++++++--------\n> include/linux/pwrseq/consumer.h | 7 +\n> 4 files changed, 217 insertions(+), 61 deletions(-)\n> ---\n> base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731\n> change-id: 20260422-pwrseq-m2-bt-abdaa71094eb\n> \n> Best regards,\n> -- \n> Manivannan Sadhasivam \n> \n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=AEc5OrVj;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=EH81jZz9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-54245-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"AEc5OrVj\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"EH81jZz9\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.180.131","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBprw3SWRz1yKd\n\tfor ; Fri, 08 May 2026 22:51:12 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 3E1E53041AAE\n\tfor ; Fri, 8 May 2026 12:50:10 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id C9D4A3876B9;\n\tFri, 8 May 2026 12:50:09 +0000 (UTC)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n [205.220.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 6904E3BAD9B\n\tfor ; Fri, 8 May 2026 12:50:08 +0000 (UTC)","from pps.filterd (m0279869.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 648CRIiU1174218\n\tfor ; Fri, 8 May 2026 12:50:07 GMT","from mail-dy1-f199.google.com (mail-dy1-f199.google.com\n [74.125.82.199])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e132haxeu-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ; Fri, 08 May 2026 12:50:06 +0000 (GMT)","by mail-dy1-f199.google.com with SMTP id\n 5a478bee46e88-2f50f4b826eso366129eec.2\n for ; Fri, 08 May 2026 05:50:06 -0700 (PDT)","from [10.239.97.27] ([114.94.8.21])\n by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-132781103e7sm2635918c88.1.2026.05.08.05.49.59\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 08 May 2026 05:50:04 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778244609; cv=none;\n b=ExWRQNFxd0SVwmINCTJO3ul2pnZEkmBYyDoQNVKWqPCK5uzfZsiJY1w1c+XNYnyKj5GFscsyUslNipe7+93UatOAzUFp7Dd7JFIoN1egw0ZAPJhDZ0nE5CcNUmQgsjgk4eBL2LlSTK9xIDTPbb0cyAwEeXhb+Vp+n4T9hC6G62Q=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778244609; c=relaxed/simple;\n\tbh=zw7g2Yy6gSTJR6AEXuh6Ij4LgD/Ye5RZbXDj40piSG0=;\n\th=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References:\n\t In-Reply-To:Content-Type;\n b=dtacrr2cN3U7KtDSeoPNfV38GBrtMSg8bUTSilufcLkkmzOE00I/l0z/F/tnR6B4xR8fKzpv9lcp78CBXx7+/bFpDyQqXumm3yi2dLnlD6VkDNcQNfkI+YBxB73bZU0OlEQdY598FDQqGImkzNebClJFmw+Skoi48/KdUeVONWU=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=AEc5OrVj;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=EH81jZz9; arc=none smtp.client-ip=205.220.180.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\tfgy0grFfJFOerAGbvrwoD3Um+wI6cGrkAGMGsBcSdPA=; b=AEc5OrVjL0wweDjV\n\tLM81Ei88lJb9V/aW+wrlAueL0bNYeUkLPYe0l+CJNzj/JElm7BvQz0XzV9DFrmIP\n\tGYDFojJHOv94qhRiJiTOT6yu4uI7y/fhkDg+aRCHSL2EW8IgnTZ/6QkVBntS1qoO\n\tlRTL7yYuDUhFCp5c/aju0VnEDEIDPJPIg2XI6YMadvqW+ErAoaxhtYq0pRyULRCD\n\tUzbSQFhNpMzl/Iy0nFpEG+rfwZbItzxywgVNAqH9uxxn0EIA7gEz0RNq3j27Kt1v\n\tqY7o3xM1aDIbqYysgh2U4hq0EcLR+vNt3jM6UBDUXyvWFkBmPGwrTS8jwgGUCLCL\n\tOoEH3w==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1778244605; x=1778849405;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:content-language:references\n :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to\n :cc:subject:date:message-id:reply-to;\n bh=fgy0grFfJFOerAGbvrwoD3Um+wI6cGrkAGMGsBcSdPA=;\n b=EH81jZz9IsVLBYf9LJWfMO13zjA1oujFo9pcI271Q6J42R2TdKUtzehiuMUGH8so+S\n eMnlOwWOW8dCR67DbyFJ/1znNQrNDy6Y/t4LVeIJJIeE2fTosEcn3JbR+FyQxSf/+B9n\n utYT5ZRIzK+sfyuQ4xSHA37SdHruhh8VPGUXOEpWq1q+ES6R+WZEPjmcH/m16y7NhdlN\n EulA/mnlaT3gzUJoTEbmm80v8KVnuKXNZv4er3tZJDXoef9nk1mKr77Okl81hLgxQU5W\n pfzSlKnDLoIlt3akPs/REhsIfz2goFrfsd3LTfXdZOFfi5um9cYvPFDk4z1cdHNYhu3/\n YlFg=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778244605; x=1778849405;\n h=content-transfer-encoding:in-reply-to:content-language:references\n :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=fgy0grFfJFOerAGbvrwoD3Um+wI6cGrkAGMGsBcSdPA=;\n b=MJjAFXGQERfhvouJXiJcWqBDHLRb6g02/VC/74tmWV1qJAH641nilDH50kEUlLs1Gs\n ljycDJ8ZwI+2zUKV29YqvcBYBnn8BwBwd0pXCsBCM/UMT4ijrKVrWA6Bz0Hdtm1/f7Yb\n OI2XrIWANBoBiKov+6hx2vXQpK9bvfJllXMKOy8AJUoupS3nLajUsH3sun0SGz9o+oap\n UE95i/lmAGkrnaE0XXn4UxR5r/uUzLq2Qwa7hbdg1YBFpUQzeB9rDM/N6/pbtvsaIdSA\n yrIxY7arpmWncEdLwXzHQNOZ+lIAsXSU32z0y3iMflcGyYV5V8XmsX43gtTkG/0WQCww\n oOKg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ90gQPYVGn90DbFWb9yuwE41UiIuAGKSU00ODq5eRWfRHrkjIrhnzG5Cp4SeYHxU2+r8qloIkXSZD8=@vger.kernel.org","X-Gm-Message-State":"AOJu0YxnobvTjbJLSqTLq2m/s5t+Ncxgmcuy4cxoUw/m1yM1XMgl6OU+\n\tFrONADOPOnwZ+Huj3ardfPnDdxuxDqFt1zps9Rb1kMjsoHRctdd6h7MKe3sjKrD3w5DPTNd6DbN\n\te5Uaecf5rM+zOLxNTeGjg4+/JIcqwolWjcy8D27XV60BbN8fimhGVC0H0agVbPVk=","X-Gm-Gg":"AeBDietTmyZoXpidBrwa19J3eatSQWpAK4e8PgaBcLoVey1x23K/yWOET408BT589Z8\n\taQ8i0RN5AR3nfYGucDA8KEsZcqffXmvhi7ogsPT1CbBlu2noPW/fCXTV1eAgQ4a6ewjhTj67kEw\n\tH97Crydx3iWPCerPjyN5EWiAaEfNaWrnP6s7W8n2Ft2U0po0zrXi952PB5wOChOHtjDz3UUkagi\n\tIcWikvhq/dFc4VjgzSxszwfkrJ1MXZnIdlTL0dijp8CUT0ui5pA3IJIdsjdzni9dpqBIBXN3Nwu\n\teAeYQCda1VFvQ32FmZMoT/r06FGhTXLWWzhckzGE8P5uZBh+ltU+tVSCSpT2ukbfs1KYiYXw6x6\n\tO/zjtKAwGrs+mBWzAEygOxMlKBZWuHFJuBHCZis2kVos=","X-Received":["by 2002:a05:7022:68a9:b0:11b:ad6a:6e39 with SMTP id\n a92af1059eb24-1320b6fa279mr2355540c88.5.1778244605507;\n Fri, 08 May 2026 05:50:05 -0700 (PDT)","by 2002:a05:7022:68a9:b0:11b:ad6a:6e39 with SMTP id\n a92af1059eb24-1320b6fa279mr2355521c88.5.1778244604928;\n Fri, 08 May 2026 05:50:04 -0700 (PDT)"],"Message-ID":"","Date":"Fri, 8 May 2026 20:49:36 +0800","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","From":"Wei Deng ","Subject":"Re: [PATCH v2 0/9] Fixes/improvements for the PCI M.2 power\n sequencing driver","To":"manivannan.sadhasivam@oss.qualcomm.com,\n Bartosz Golaszewski ,\n Manivannan Sadhasivam ,\n Marcel Holtmann ,\n Luiz Augusto von Dentz ,\n Shuai Zhang ","Cc":"linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,\n linux-bluetooth@vger.kernel.org,\n Luiz Augusto von Dentz ,\n Konrad Dybcio ,\n Bartosz Golaszewski ,\n Dmitry Baryshkov ","References":"<20260507-pwrseq-m2-bt-v2-0-1740bd478539@oss.qualcomm.com>","Content-Language":"en-US","In-Reply-To":"<20260507-pwrseq-m2-bt-v2-0-1740bd478539@oss.qualcomm.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNTA4MDEzMiBTYWx0ZWRfX125WgCRa3AYS\n HwMKJKnzGqsDB10BrmWGnoZWKQ3exD8TpVc67MtTgErfd8oiNGbTtgnq0OWzYnxk95raw27Ox7x\n hP/I3XZCzf9vmzDg89WfxkKd5YMgV5cKx0UG6cIi33a+CDU13k94snDnpnl0puZYIPOvs+Is6WJ\n SsgS0BM63RD6fYDA10aPQSQDbwzJ69K5wBqEyA5D6mMulyDaTWjQ63bm7MixrgN6ft8ymHwXsjK\n 9YL61YiynvuJuBQjUTWJ5Rfu1UU7824RygTgCFuAcUAl123/ZLZqi6EttcuhJHTCPU2bQKYFGKR\n tPl2ChAE+P2lIqPQ82WTz0TaBx1BXOzngOD3zbbddaJ12pNs0BGWSzdBEhSt6bgSrKTG5JLv+KR\n utQuqbRWW0N8Y5yv6xzRZeTp9vJMgzUS5W0SHiYRdX+DKmXQ5hJPShE+BTLeTvLHAs+8QTldsqu\n IDyW/+lciOiegmr9qUw==","X-Proofpoint-ORIG-GUID":"gkgtnitYSugn2T-lANpxl2LDswN4FSt8","X-Proofpoint-GUID":"gkgtnitYSugn2T-lANpxl2LDswN4FSt8","X-Authority-Analysis":"v=2.4 cv=McxcfZ/f c=1 sm=1 tr=0 ts=69fddbfe cx=c_pps\n a=cFYjgdjTJScbgFmBucgdfQ==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17\n a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22\n a=NEAV23lmAAAA:8 a=bC-a23v3AAAA:8 a=EUspDBNiAAAA:8 a=qRrKk6tSi6DhAyMAVQEA:9\n a=QEXdDO2ut3YA:10 a=scEy_gLbYbu1JhEsrz4S:22 a=FO4_E8m0qiDe52t0p3_H:22","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-05-07_02,2026-05-06_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n clxscore=1015 malwarescore=0 suspectscore=0 spamscore=0 bulkscore=0\n adultscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0\n phishscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000\n definitions=main-2605080132"}}]