[{"id":3687718,"web_url":"http://patchwork.ozlabs.org/comment/3687718/","msgid":"<20260507-healthy-gainful-fox-500552-mkl@pengutronix.de>","list_archive_url":null,"date":"2026-05-07T10:55:45","subject":"Re: [Intel-wired-lan] [PATCH net-next v2 1/2] net: Consistently\n define pci_device_ids using named initializers","submitter":{"id":2822,"url":"http://patchwork.ozlabs.org/api/people/2822/","name":"Marc Kleine-Budde","email":"mkl@pengutronix.de"},"content":"> diff --git a/drivers/net/can/sja1000/plx_pci.c b/drivers/net/can/sja1000/plx_pci.c\n> index 08183833c9bc..a03553b80a5d 100644\n> --- a/drivers/net/can/sja1000/plx_pci.c\n> +++ b/drivers/net/can/sja1000/plx_pci.c\n> @@ -272,124 +272,89 @@ static struct plx_pci_card_info plx_pci_card_info_asem_dual_can = {\n>  static const struct pci_device_id plx_pci_tbl[] = {\n>  \t{\n>  \t\t/* Adlink PCI-7841/cPCI-7841 */\n> -\t\tADLINK_PCI_VENDOR_ID, ADLINK_PCI_DEVICE_ID,\n> -\t\tPCI_ANY_ID, PCI_ANY_ID,\n> -\t\tPCI_CLASS_NETWORK_OTHER << 8, ~0,\n> -\t\t(kernel_ulong_t)&plx_pci_card_info_adlink\n> -\t},\n> -\t{\n> +\t\tPCI_DEVICE(ADLINK_PCI_VENDOR_ID, ADLINK_PCI_DEVICE_ID),\n> +\t\t.class = PCI_CLASS_NETWORK_OTHER << 8,\n> +\t\t.class_mask = ~0,\n> +\t\t.driver_data = (kernel_ulong_t)&plx_pci_card_info_adlink,\n> +\t}, {\n>  \t\t/* Adlink PCI-7841/cPCI-7841 SE */\n> -\t\tADLINK_PCI_VENDOR_ID, ADLINK_PCI_DEVICE_ID,\n> -\t\tPCI_ANY_ID, PCI_ANY_ID,\n> -\t\tPCI_CLASS_COMMUNICATION_OTHER << 8, ~0,\n> -\t\t(kernel_ulong_t)&plx_pci_card_info_adlink_se\n> -\t},\n> -\t{\n> +\t\tPCI_DEVICE(ADLINK_PCI_VENDOR_ID, ADLINK_PCI_DEVICE_ID),\n> +\t\t.class = PCI_CLASS_COMMUNICATION_OTHER << 8,\n> +\t\t.class_mask = ~0,\n> +\t\t.driver_data = (kernel_ulong_t)&plx_pci_card_info_adlink_se,\n> +\t}, {\n>  \t\t/* esd CAN-PCI/200 */\n> -\t\tPCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050,\n> -\t\tPCI_VENDOR_ID_ESDGMBH, ESD_PCI_SUB_SYS_ID_PCI200,\n> -\t\t0, 0,\n> -\t\t(kernel_ulong_t)&plx_pci_card_info_esd200\n> -\t},\n> -\t{\n> +\t\tPCI_VDEVICE_SUB(PLX, PCI_DEVICE_ID_PLX_9050,\n> +\t\t\t\tPCI_VENDOR_ID_ESDGMBH, ESD_PCI_SUB_SYS_ID_PCI200),\n> +\t\t.driver_data = (kernel_ulong_t)&plx_pci_card_info_esd200,\n> +\t}, {\n>  \t\t/* esd CAN-CPCI/200 */\n> -\t\tPCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030,\n> -\t\tPCI_VENDOR_ID_ESDGMBH, ESD_PCI_SUB_SYS_ID_CPCI200,\n> -\t\t0, 0,\n> -\t\t(kernel_ulong_t)&plx_pci_card_info_esd200\n> -\t},\n> -\t{\n> +\t\tPCI_VDEVICE_SUB(PLX, PCI_DEVICE_ID_PLX_9030,\n> +\t\t\t\tPCI_VENDOR_ID_ESDGMBH, ESD_PCI_SUB_SYS_ID_CPCI200),\n> +\t\t.driver_data = (kernel_ulong_t)&plx_pci_card_info_esd200,\n> +\t}, {\n>  \t\t/* esd CAN-PCI104/200 */\n> -\t\tPCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030,\n> -\t\tPCI_VENDOR_ID_ESDGMBH, ESD_PCI_SUB_SYS_ID_PCI104200,\n> -\t\t0, 0,\n> -\t\t(kernel_ulong_t)&plx_pci_card_info_esd200\n> -\t},\n> -\t{\n> +\t\tPCI_VDEVICE_SUB(PLX, PCI_DEVICE_ID_PLX_9030,\n> +\t\t\t\tPCI_VENDOR_ID_ESDGMBH, ESD_PCI_SUB_SYS_ID_PCI104200),\n> +\t\t.driver_data = (kernel_ulong_t)&plx_pci_card_info_esd200,\n> +\t}, {\n>  \t\t/* esd CAN-PCI/266 */\n> -\t\tPCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9056,\n> -\t\tPCI_VENDOR_ID_ESDGMBH, ESD_PCI_SUB_SYS_ID_PCI266,\n> -\t\t0, 0,\n> -\t\t(kernel_ulong_t)&plx_pci_card_info_esd266\n> -\t},\n> -\t{\n> +\t\tPCI_VDEVICE_SUB(PLX, PCI_DEVICE_ID_PLX_9056,\n> +\t\t\t\tPCI_VENDOR_ID_ESDGMBH, ESD_PCI_SUB_SYS_ID_PCI266),\n> +\t\t.driver_data = (kernel_ulong_t)&plx_pci_card_info_esd266,\n> +\t}, {\n>  \t\t/* esd CAN-PMC/266 */\n> -\t\tPCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9056,\n> -\t\tPCI_VENDOR_ID_ESDGMBH, ESD_PCI_SUB_SYS_ID_PMC266,\n> -\t\t0, 0,\n> -\t\t(kernel_ulong_t)&plx_pci_card_info_esd266\n> -\t},\n> -\t{\n> +\t\tPCI_VDEVICE_SUB(PLX, PCI_DEVICE_ID_PLX_9056,\n> +\t\t\t\tPCI_VENDOR_ID_ESDGMBH, ESD_PCI_SUB_SYS_ID_PMC266),\n> +\t\t.driver_data = (kernel_ulong_t)&plx_pci_card_info_esd266,\n> +\t}, {\n>  \t\t/* esd CAN-PCIE/2000 */\n> -\t\tPCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9056,\n> -\t\tPCI_VENDOR_ID_ESDGMBH, ESD_PCI_SUB_SYS_ID_PCIE2000,\n> -\t\t0, 0,\n> -\t\t(kernel_ulong_t)&plx_pci_card_info_esd2000\n> -\t},\n> -\t{\n> +\t\tPCI_VDEVICE_SUB(PLX, PCI_DEVICE_ID_PLX_9056,\n> +\t\t\t\tPCI_VENDOR_ID_ESDGMBH, ESD_PCI_SUB_SYS_ID_PCIE2000),\n> +\t\t.driver_data = (kernel_ulong_t)&plx_pci_card_info_esd2000,\n> +\t}, {\n>  \t\t/* IXXAT PC-I 04/PCI card */\n> -\t\tIXXAT_PCI_VENDOR_ID, IXXAT_PCI_DEVICE_ID,\n> -\t\tPCI_ANY_ID, IXXAT_PCI_SUB_SYS_ID,\n> -\t\t0, 0,\n> -\t\t(kernel_ulong_t)&plx_pci_card_info_ixxat\n> -\t},\n> -\t{\n> +\t\tPCI_DEVICE_SUB(IXXAT_PCI_VENDOR_ID, IXXAT_PCI_DEVICE_ID,\n> +\t\t\t       PCI_ANY_ID, IXXAT_PCI_SUB_SYS_ID),\n> +\t\t.driver_data = (kernel_ulong_t)&plx_pci_card_info_ixxat,\n> +\t}, {\n>  \t\t/* Marathon CAN-bus-PCI card */\n> -\t\tPCI_VENDOR_ID_PLX, MARATHON_PCI_DEVICE_ID,\n> -\t\tPCI_ANY_ID, PCI_ANY_ID,\n> -\t\t0, 0,\n> -\t\t(kernel_ulong_t)&plx_pci_card_info_marathon_pci\n> -\t},\n> -\t{\n> +\t\tPCI_VDEVICE(PLX, MARATHON_PCI_DEVICE_ID),\n> +\t\t.driver_data = (kernel_ulong_t)&plx_pci_card_info_marathon_pci,\n> +\t}, {\n>  \t\t/* Marathon CAN-bus-PCIe card */\n> -\t\tPCI_VENDOR_ID_PLX, MARATHON_PCIE_DEVICE_ID,\n> -\t\tPCI_ANY_ID, PCI_ANY_ID,\n> -\t\t0, 0,\n> -\t\t(kernel_ulong_t)&plx_pci_card_info_marathon_pcie\n> -\t},\n> -\t{\n> +\t\tPCI_VDEVICE(PLX, MARATHON_PCIE_DEVICE_ID),\n> +\t\t.driver_data = (kernel_ulong_t)&plx_pci_card_info_marathon_pcie,\n> +\t}, {\n>  \t\t/* TEWS TECHNOLOGIES TPMC810 card */\n> -\t\tTEWS_PCI_VENDOR_ID, TEWS_PCI_DEVICE_ID_TMPC810,\n> -\t\tPCI_ANY_ID, PCI_ANY_ID,\n> -\t\t0, 0,\n> -\t\t(kernel_ulong_t)&plx_pci_card_info_tews\n> -\t},\n> -\t{\n> +\t\tPCI_DEVICE(TEWS_PCI_VENDOR_ID, TEWS_PCI_DEVICE_ID_TMPC810),\n> +\t\t.driver_data = (kernel_ulong_t)&plx_pci_card_info_tews,\n> +\t}, {\n>  \t\t/* Connect Tech Inc. CANpro/104-Plus Opto (CRG001) card */\n> -\t\tPCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030,\n> -\t\tPCI_SUBVENDOR_ID_CONNECT_TECH, CTI_PCI_DEVICE_ID_CRG001,\n> -\t\t0, 0,\n> -\t\t(kernel_ulong_t)&plx_pci_card_info_cti\n> -\t},\n> -\t{\n> +\t\tPCI_VDEVICE_SUB(PLX, PCI_DEVICE_ID_PLX_9030,\n> +\t\t\t\tPCI_SUBVENDOR_ID_CONNECT_TECH, CTI_PCI_DEVICE_ID_CRG001),\n> +\t\t.driver_data = (kernel_ulong_t)&plx_pci_card_info_cti,\n> +\t}, {\n>  \t\t/* Elcus CAN-200-PCI */\n> -\t\tCAN200PCI_VENDOR_ID, CAN200PCI_DEVICE_ID,\n> -\t\tCAN200PCI_SUB_VENDOR_ID, CAN200PCI_SUB_DEVICE_ID,\n> -\t\t0, 0,\n> -\t\t(kernel_ulong_t)&plx_pci_card_info_elcus\n> -\t},\n> -\t{\n> +\t\tPCI_DEVICE_SUB(CAN200PCI_VENDOR_ID, CAN200PCI_DEVICE_ID,\n> +\t\t\t       CAN200PCI_SUB_VENDOR_ID, CAN200PCI_SUB_DEVICE_ID),\n> +\t\t.driver_data = (kernel_ulong_t)&plx_pci_card_info_elcus,\n> +\t}, {\n>  \t\t/* moxa */\n> -\t\tMOXA_PCI_VENDOR_ID, MOXA_PCI_DEVICE_ID,\n> -\t\tPCI_ANY_ID, PCI_ANY_ID,\n> -\t\t0, 0,\n> -\t\t(kernel_ulong_t)&plx_pci_card_info_moxa\n> -\t},\n> -\t{\n> +\t\tPCI_DEVICE(MOXA_PCI_VENDOR_ID, MOXA_PCI_DEVICE_ID),\n> +\t\t.driver_data = (kernel_ulong_t)&plx_pci_card_info_moxa,\n> +\t}, {\n>  \t\t/* ASEM Dual CAN raw */\n> -\t\tASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DEVICE_ID,\n> -\t\tASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CAN_SUB_DEVICE_ID,\n> -\t\t0, 0,\n> -\t\t(kernel_ulong_t)&plx_pci_card_info_asem_dual_can\n> -\t},\n> -\t{\n> +\t\tPCI_DEVICE_SUB(ASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DEVICE_ID,\n> +\t\t\t       ASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CAN_SUB_DEVICE_ID),\n> +\t\t.driver_data = (kernel_ulong_t)&plx_pci_card_info_asem_dual_can,\n> +\t}, {\n>  \t\t/* ASEM Dual CAN raw -new model */\n> -\t\tASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DEVICE_ID,\n> -\t\tASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CAN_SUB_DEVICE_ID_BIS,\n> -\t\t0, 0,\n> -\t\t(kernel_ulong_t)&plx_pci_card_info_asem_dual_can\n> +\t\tPCI_DEVICE_SUB(ASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DEVICE_ID,\n> +\t\t\t       ASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CAN_SUB_DEVICE_ID_BIS),\n> +\t\t.driver_data = (kernel_ulong_t)&plx_pci_card_info_asem_dual_can,\n>  \t},\n> -\t{ 0,}\n> +\t{ }\n\nNitpick: can you convert the terminating entry to follow the same style\nas the rest of the driver:\n\ndiff --git a/drivers/net/can/sja1000/plx_pci.c b/drivers/net/can/sja1000/plx_pci.c\nindex a03553b80a5d..d69ff0ccfd94 100644\n--- a/drivers/net/can/sja1000/plx_pci.c\n+++ b/drivers/net/can/sja1000/plx_pci.c\n@@ -353,8 +353,8 @@ static const struct pci_device_id plx_pci_tbl[] = {\n                 PCI_DEVICE_SUB(ASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DEVICE_ID,\n                                ASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CAN_SUB_DEVICE_ID_BIS),\n                 .driver_data = (kernel_ulong_t)&plx_pci_card_info_asem_dual_can,\n-        },\n-        { }\n+        }, {\n+        }\n };\n MODULE_DEVICE_TABLE(pci, plx_pci_tbl);\n\nMarc","headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=wwKMFlpI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gB8M845Byz1yCg\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 07 May 2026 20:56:36 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id D981483B6A;\n\tThu,  7 May 2026 10:56:34 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 2ZPm7A5o-i7i; Thu,  7 May 2026 10:56:34 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id E3F5683B89;\n\tThu,  7 May 2026 10:56:33 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id A5A4511B\n for <intel-wired-lan@lists.osuosl.org>; Thu,  7 May 2026 10:56:32 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 8ADD683B89\n for <intel-wired-lan@lists.osuosl.org>; Thu,  7 May 2026 10:56:32 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id wtSd5cGgi91z for <intel-wired-lan@lists.osuosl.org>;\n Thu,  7 May 2026 10:56:31 +0000 (UTC)","from metis.whiteo.stw.pengutronix.de\n (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 8D37383B6A\n for <intel-wired-lan@lists.osuosl.org>; Thu,  7 May 2026 10:56:29 +0000 (UTC)","from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])\n by metis.whiteo.stw.pengutronix.de with esmtps\n (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)\n (envelope-from <mkl@pengutronix.de>)\n id 1wKwOz-0001uh-6W; Thu, 07 May 2026 12:56:21 +0200","from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b]\n helo=bjornoya.blackshift.org)\n by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls\n TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96)\n (envelope-from <mkl@pengutronix.de>) id 1wKwOQ-000uFj-2Z;\n Thu, 07 May 2026 12:55:47 +0200","from pengutronix.de (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (Client did not present a certificate)\n (Authenticated sender: mkl-all@blackshift.org)\n by smtp.blackshift.org (Postfix) with ESMTPSA id 2374E5302D0;\n Thu, 07 May 2026 10:55:46 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org E3F5683B89","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8D37383B6A"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1778151393;\n\tbh=4T8SRfubYSidiXl3PYqb4SiN/ZhagWS/FSjMbB5B6xA=;\n\th=Date:From:To:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=wwKMFlpIDp/oT85sYhKkm/NBQg4ywlEWrEyJ1iVU2fAWiDoaVm1Of6yCcsr58MKpE\n\t D3Gu9tN+wbroncRLyHHhAPLlttiwhoVR0Hax8hss89zztNEUPir2qLTu8jtATUEIOU\n\t IK2PvRuEHLwSA+UY20J/zbOCdODqHPWPulAm8r4Urrt+d0prC4A2ymy47OhEZY75ZO\n\t jepnFs0H5vmcha//UhL4zWoC5cBi8LEc/A4Tu63sDfphcDzAy0VW85WgBC5XFxbFJb\n\t 2gV9v5xegqYZ08R1+6eUP13OeN6b5fqG+sB/j4JKT186EifbFSC2q56ORbAFG9M8bZ\n\t 4ab873guDZrhg==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2a0a:edc0:2:b01:1d::104; helo=metis.whiteo.stw.pengutronix.de;\n envelope-from=mkl@pengutronix.de; receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 8D37383B6A","Date":"Thu, 7 May 2026 12:55:45 +0200","From":"Marc Kleine-Budde <mkl@pengutronix.de>","To":"Uwe =?utf-8?q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?=\n <u.kleine-koenig@baylibre.com>","Message-ID":"<20260507-healthy-gainful-fox-500552-mkl@pengutronix.de>","X-AI":"stop_reason: \"refusal\"","References":"<cover.1778149923.git.u.kleine-koenig@baylibre.com>\n <76da4f44d48bdde84580963862bf9616bee5c9e9.1778149923.git.u.kleine-koenig@baylibre.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n protocol=\"application/pgp-signature\"; boundary=\"bj6moo23k7mnjddb\"","Content-Disposition":"inline","In-Reply-To":"\n <76da4f44d48bdde84580963862bf9616bee5c9e9.1778149923.git.u.kleine-koenig@baylibre.com>","X-SA-Exim-Connect-IP":"2a0a:edc0:0:c01:1d::a2","X-SA-Exim-Mail-From":"mkl@pengutronix.de","X-SA-Exim-Scanned":"No (on metis.whiteo.stw.pengutronix.de);\n SAEximRunCond expanded to false","X-PTX-Original-Recipient":"intel-wired-lan@lists.osuosl.org","X-Mailman-Original-Authentication-Results":"smtp1.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=pengutronix.de","Subject":"Re: [Intel-wired-lan] [PATCH net-next v2 1/2] net: Consistently\n define pci_device_ids using named initializers","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Cc":"Richard Cochran <richardcochran@gmail.com>,\n Marco Crivellari <marco.crivellari@suse.com>,\n Randy Dunlap <rdunlap@infradead.org>, Yonglong Liu <liuyonglong@huawei.com>,\n Kees Cook <kees@kernel.org>, linux-wireless@vger.kernel.org,\n Ian Lin <ian.lin@infineon.com>, brcm80211@lists.linux.dev,\n Daniele Venzano <venza@brownhat.org>, Eric Dumazet <edumazet@google.com>,\n netdev@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,\n MD Danish Anwar <danishanwar@ti.com>, Samuel Chessman <chessman@tux.org>,\n Fan Gong <gongfan1@huawei.com>, Mengyuan Lou <mengyuanlou@net-swift.com>,\n Kevin Curtis <kevin.curtis@farsite.co.uk>, Ingo Molnar <mingo@kernel.org>,\n Michael Grzeschik <mgr@kernel.org>, Ion Badulescu <ionut@badula.org>,\n Yeounsu Moon <yyyynoom@gmail.com>, Manish Chopra <manishc@marvell.com>,\n Colin Ian King <colin.i.king@gmail.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Thomas Fourier <fourier.thomas@gmail.com>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>,\n Denis Kirjanov <kirjanov@gmail.com>, intel-wired-lan@lists.osuosl.org,\n linux-parisc@vger.kernel.org, Jacob Keller <jacob.e.keller@intel.com>,\n Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,\n Steffen Klassert <klassert@kernel.org>,\n Stanislav Yakovlev <stas.yakovlev@gmail.com>, linux-rdma@vger.kernel.org,\n Arend van Spriel <arend.vanspriel@broadcom.com>, nic_swsd@realtek.com,\n Jiri Pirko <jiri@resnulli.us>, Ethan Nelson-Moore <enelsonmoore@gmail.com>,\n Larysa Zaremba <larysa.zaremba@intel.com>, Ido Schimmel <idosch@nvidia.com>,\n Potnuri Bharat Teja <bharat@chelsio.com>, Double Lo <double.lo@cypress.com>,\n Markus Schneider-Pargmann <msp@baylibre.com>,\n Nathan Chancellor <nathan@kernel.org>, Jiawen Wu <jiawenwu@trustnetic.com>,\n Cai Huoqing <cai.huoqing@linux.dev>, Bjorn Helgaas <bhelgaas@google.com>,\n Zilin Guan <zilin@seu.edu.cn>, linux-can@vger.kernel.org,\n Yibo Dong <dong100@mucse.com>, Andy Shevchenko <andriy.shevchenko@intel.com>,\n Petr Machata <petrm@nvidia.com>, Kory Maincent <kory.maincent@bootlin.com>,\n brcm80211-dev-list.pdl@broadcom.com, GR-Linux-NIC-Dev@marvell.com,\n Vadim Fedorenko <vadim.fedorenko@linux.dev>,\n Leon Romanovsky <leon@kernel.org>,\n Denis Benato <benato.denis96@gmail.com>, Rasesh Mody <rmody@marvell.com>,\n David Arinzon <darinzon@amazon.com>, oss-drivers@corigine.com,\n Vincent Mailhol <mailhol@kernel.org>, Mark Bloch <mbloch@nvidia.com>,\n linux-kernel@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,\n Jian Shen <shenjian15@huawei.com>, Jijie Shao <shaojijie@huawei.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>, Thomas Gleixner <tglx@kernel.org>,\n Simon Horman <horms@kernel.org>, Yicong Hui <yiconghui@gmail.com>,\n Mark Einon <mark.einon@gmail.com>, Johannes Berg <johannes@sipsolutions.net>,\n Heiner Kallweit <hkallweit1@gmail.com>, Saeed Mahameed <saeedm@nvidia.com>,\n \"David S. Miller\" <davem@davemloft.net>, Krzysztof Halasa <khc@pm.waw.pl>","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"}},{"id":3687848,"web_url":"http://patchwork.ozlabs.org/comment/3687848/","msgid":"<afyfa4E4rNbkMYTk@monoceros>","list_archive_url":null,"date":"2026-05-07T14:23:43","subject":"Re: [Intel-wired-lan] [PATCH net-next v2 1/2] net: Consistently\n define pci_device_ids using named initializers","submitter":{"id":88686,"url":"http://patchwork.ozlabs.org/api/people/88686/","name":"Uwe Kleine-König (The Capable Hub)","email":"u.kleine-koenig@baylibre.com"},"content":"Hello Marc,\n\nOn Thu, May 07, 2026 at 12:55:45PM +0200, Marc Kleine-Budde wrote:\n> > +\t}, {\n> >  \t\t/* ASEM Dual CAN raw -new model */\n> > -\t\tASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DEVICE_ID,\n> > -\t\tASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CAN_SUB_DEVICE_ID_BIS,\n> > -\t\t0, 0,\n> > -\t\t(kernel_ulong_t)&plx_pci_card_info_asem_dual_can\n> > +\t\tPCI_DEVICE_SUB(ASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DEVICE_ID,\n> > +\t\t\t       ASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CAN_SUB_DEVICE_ID_BIS),\n> > +\t\t.driver_data = (kernel_ulong_t)&plx_pci_card_info_asem_dual_can,\n> >  \t},\n> > -\t{ 0,}\n> > +\t{ }\n> \n> Nitpick: can you convert the terminating entry to follow the same style\n> as the rest of the driver:\n> \n> diff --git a/drivers/net/can/sja1000/plx_pci.c b/drivers/net/can/sja1000/plx_pci.c\n> index a03553b80a5d..d69ff0ccfd94 100644\n> --- a/drivers/net/can/sja1000/plx_pci.c\n> +++ b/drivers/net/can/sja1000/plx_pci.c\n> @@ -353,8 +353,8 @@ static const struct pci_device_id plx_pci_tbl[] = {\n>                  PCI_DEVICE_SUB(ASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DEVICE_ID,\n>                                 ASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CAN_SUB_DEVICE_ID_BIS),\n>                  .driver_data = (kernel_ulong_t)&plx_pci_card_info_asem_dual_can,\n> -        },\n> -        { }\n> +        }, {\n> +        }\n>  };\n>  MODULE_DEVICE_TABLE(pci, plx_pci_tbl);\n\nAfter the conversation in the v1 thread it was unclear to me if you\nstand by your opinion, so I kept the format as it was. I interpret your\nrepetition of the nitpick as request to rework the can drivers for the\nnext revision (if that happens).\n\nBest regards\nUwe","headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=GxUJIVLU;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBDyR2LyPz1yCg\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 08 May 2026 00:23:57 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 218514114A;\n\tThu,  7 May 2026 14:23:54 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id FKzp5n1F-g9p; Thu,  7 May 2026 14:23:53 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 4931941146;\n\tThu,  7 May 2026 14:23:53 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id 0624E317\n for <intel-wired-lan@lists.osuosl.org>; Thu,  7 May 2026 14:23:52 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id DF78682F98\n for <intel-wired-lan@lists.osuosl.org>; Thu,  7 May 2026 14:23:51 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 9q7KnM2wkuEL for <intel-wired-lan@lists.osuosl.org>;\n Thu,  7 May 2026 14:23:50 +0000 (UTC)","from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n [IPv6:2a00:1450:4864:20::330])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 6A5E882993\n for <intel-wired-lan@lists.osuosl.org>; Thu,  7 May 2026 14:23:47 +0000 (UTC)","by mail-wm1-x330.google.com with SMTP id\n 5b1f17b1804b1-4852a9c6309so8131495e9.0\n for <intel-wired-lan@lists.osuosl.org>; Thu, 07 May 2026 07:23:47 -0700 (PDT)","from localhost\n (p200300f65f114e08e9fd60f450b139aa.dip0.t-ipconnect.de.\n [2003:f6:5f11:4e08:e9fd:60f4:50b1:39aa])\n by smtp.gmail.com with UTF8SMTPSA id\n 5b1f17b1804b1-48e538a8159sm137501655e9.6.2026.05.07.07.23.44\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 07 May 2026 07:23:44 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4931941146","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 6A5E882993"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1778163833;\n\tbh=KHdHPIlg8ERzV5KgqRTDZ9XRFXSHKLYAiHw6AYH9eg4=;\n\th=Date:From:To:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=GxUJIVLUeRintfuhkD1AyMMusTkdJpsow8qbphD3V0NrN3MpvfPtdEfiDbQCgz17P\n\t JacdEuqttxpJx+ZKlDhkah3JmhxKxP80jHh1GZ7BcdaG4z/CqlQeIL23Uvx+xNhUrj\n\t 6gA4RuAdmdnr6QECDESdPXf1ZtxS58eJdsduqjycha9q6B6cdGHL9FuwC+bw972Q/Y\n\t 315Wte/IMJDpStyDlvZgq/3Sdh727AaQSZGoLVx/Xufrn3Io6dgRRZpl6/pi8knaJX\n\t ueKSl1qm61YYA3WRVai3SdpgjezTiU3ES6VfyQF+vDHb2awd6OHaAhQ9FWiEupSYLR\n\t sB+t56ehop4PQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2a00:1450:4864:20::330; helo=mail-wm1-x330.google.com;\n envelope-from=ukleinek@baylibre.com; receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 6A5E882993","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778163825; x=1778768625;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=KHdHPIlg8ERzV5KgqRTDZ9XRFXSHKLYAiHw6AYH9eg4=;\n b=r5gkq9O9B3OXWMEVeaEwEbzaQUUITiOAcx1ESbp395y3Oz6CWp6cOg0Nv+arVM9BKt\n LQPhOWJnZYNTWpuqpVAVvTajCj2BjlMWpEJhAh8H7cImKijJyS2rNUo6HIjpSCapu3Lk\n dGq6VmkKp+WbkMV++BP70j90lgu4iZACe47zhGpEC2HO1wtMjUr1UMUb06vgUxjpUa/c\n WWNXUwNwTlySgeUeyBReGa9RTCEERcORRptxghyPBykjrDDTdqhUr5jxcVRY0mmAM7rm\n JC5gEm1N1ef1oietQQ8FlnX4VF+Z9Kp2NJB7hAaL6eenyXwAyB5SrA+pGvJyTgU05oX8\n 8NIw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+eHYa4jNyrn/mPYACLncAcQQz32qFMVnHoBOklug8XXzUJv9fPJDNgL2Omn7N09IP3YTMKkG9qw4o1akUZyHQ=@lists.osuosl.org","X-Gm-Message-State":"AOJu0YzMYL4w1g5kp3PYsnvWkWktboIkOhSlKbkiKViq0AV+xdGpW+HG\n YoI2OdT1GS/6Ihiswr6j1knm21hwniYBQa3JJClI3Mdy7905RDa80dJDkfcoFmGt9Po=","X-Gm-Gg":"AeBDietWwd4pL56G2z5fAM1NsQfk2gSVGJYPL/gL23MOu/E/2hD/dm22Hvt/DI1pRwN\n D+Q9SUNLxKWmUWRGE7fIfkgrzCKXo9qZT3KLQo7ssE5M4fR6/EAKG13jfD4Lh4Ma29E3dBfeAcL\n sVAb8sH5JT+uIXdOvsqNX92GJOBgA6ROTvPU4W2p8HTCqclT/POww3vSkBL4o++1w+6BUIQS9xf\n k6R97jchDOoiDhugcy8W08EMcAmuBkf2BpNuHobJchwNeyoerjoqjZ9e8jq++2AwSFzNKtv1BbT\n vtRwmyrXZ0bO/pR4kTy08+XaQ6CqgCbLa1XqBd63bj5Shbozk56S9X9NqASTbEruiSw5ZoFbNjb\n c43SJsQ3xefqSEzu2adp4Xv8VbkjFSFEPCcIGK4X01pdfNqgvA1A0IPDuKO8Z2N+kYE/SpgRI2C\n hIZs80S0E4IGGbnV8C9j24ivZVW8qq/v1SCdoF6j1NcSlp+fvg9cHrQMxb5zUh7T/wDfVhJrv8h\n MmYgQ+Ee0vvg57C1KNDAbyieSfo2Ot96Bx4","X-Received":"by 2002:a05:600c:628e:b0:48e:60a3:220a with SMTP id\n 5b1f17b1804b1-48e60a32224mr33559005e9.0.1778163825055;\n Thu, 07 May 2026 07:23:45 -0700 (PDT)","Date":"Thu, 7 May 2026 16:23:43 +0200","From":"Uwe =?utf-8?q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?=\n <u.kleine-koenig@baylibre.com>","To":"Marc Kleine-Budde <mkl@pengutronix.de>","Message-ID":"<afyfa4E4rNbkMYTk@monoceros>","References":"<cover.1778149923.git.u.kleine-koenig@baylibre.com>\n <76da4f44d48bdde84580963862bf9616bee5c9e9.1778149923.git.u.kleine-koenig@baylibre.com>\n <20260507-healthy-gainful-fox-500552-mkl@pengutronix.de>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n protocol=\"application/pgp-signature\"; boundary=\"2r3luua3e55dgqvk\"","Content-Disposition":"inline","In-Reply-To":"<20260507-healthy-gainful-fox-500552-mkl@pengutronix.de>","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1778163825;\n x=1778768625;\n darn=lists.osuosl.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=KHdHPIlg8ERzV5KgqRTDZ9XRFXSHKLYAiHw6AYH9eg4=;\n b=HW9yWwwwsrCVWF6YM8OUSR95PksWl+Chx/Z3Qv73lWmyIUxkGl84Lw8bAIP3CGOQ0l\n yYIcPV0Pxej7cMBZ328/zTlmaYfTkvsiLIqJutYYDx5me0D5Dv0bZO773pY6IkefB1RY\n azSqeeNe3L4P0VWmJv09L8rf6aFxnPxCKjnz48VwCV8WVCUXmKBflf3odisQpPahan7S\n 1D/CY8poECMVbwE5Hu7O7MZE28/EK3fNimTnoFgaVhq4+tJFq06oL4j+g+O/IVOfGKkf\n rSRvdf0u6CcRDcW6S1J4udz0cYrE9wv1r/8EobNBua1P0l+lJxIAxOkZdtZjChPPo0GN\n 0uWg==","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=baylibre.com","smtp1.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=HW9yWwww"],"Subject":"Re: [Intel-wired-lan] [PATCH net-next v2 1/2] net: Consistently\n define pci_device_ids using named initializers","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Cc":"Richard Cochran <richardcochran@gmail.com>,\n Marco Crivellari <marco.crivellari@suse.com>,\n Randy Dunlap <rdunlap@infradead.org>, Yonglong Liu <liuyonglong@huawei.com>,\n Kees Cook <kees@kernel.org>, linux-wireless@vger.kernel.org,\n Ian Lin <ian.lin@infineon.com>, brcm80211@lists.linux.dev,\n Daniele Venzano <venza@brownhat.org>, Eric Dumazet <edumazet@google.com>,\n netdev@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,\n MD Danish Anwar <danishanwar@ti.com>, Samuel Chessman <chessman@tux.org>,\n Fan Gong <gongfan1@huawei.com>, Mengyuan Lou <mengyuanlou@net-swift.com>,\n Kevin Curtis <kevin.curtis@farsite.co.uk>, Ingo Molnar <mingo@kernel.org>,\n Michael Grzeschik <mgr@kernel.org>, Ion Badulescu <ionut@badula.org>,\n Yeounsu Moon <yyyynoom@gmail.com>, Manish Chopra <manishc@marvell.com>,\n Colin Ian King <colin.i.king@gmail.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Thomas Fourier <fourier.thomas@gmail.com>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>,\n Denis Kirjanov <kirjanov@gmail.com>, intel-wired-lan@lists.osuosl.org,\n linux-parisc@vger.kernel.org, Jacob Keller <jacob.e.keller@intel.com>,\n Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,\n Steffen Klassert <klassert@kernel.org>,\n Stanislav Yakovlev <stas.yakovlev@gmail.com>, linux-rdma@vger.kernel.org,\n Arend van Spriel <arend.vanspriel@broadcom.com>, nic_swsd@realtek.com,\n Jiri Pirko <jiri@resnulli.us>, Ethan Nelson-Moore <enelsonmoore@gmail.com>,\n Larysa Zaremba <larysa.zaremba@intel.com>, Ido Schimmel <idosch@nvidia.com>,\n Potnuri Bharat Teja <bharat@chelsio.com>, Double Lo <double.lo@cypress.com>,\n Markus Schneider-Pargmann <msp@baylibre.com>,\n Nathan Chancellor <nathan@kernel.org>, Jiawen Wu <jiawenwu@trustnetic.com>,\n Cai Huoqing <cai.huoqing@linux.dev>, Bjorn Helgaas <bhelgaas@google.com>,\n Zilin Guan <zilin@seu.edu.cn>, linux-can@vger.kernel.org,\n Yibo Dong <dong100@mucse.com>, Andy Shevchenko <andriy.shevchenko@intel.com>,\n Petr Machata <petrm@nvidia.com>, Kory Maincent <kory.maincent@bootlin.com>,\n brcm80211-dev-list.pdl@broadcom.com, GR-Linux-NIC-Dev@marvell.com,\n Vadim Fedorenko <vadim.fedorenko@linux.dev>,\n Leon Romanovsky <leon@kernel.org>,\n Denis Benato <benato.denis96@gmail.com>, Rasesh Mody <rmody@marvell.com>,\n David Arinzon <darinzon@amazon.com>, oss-drivers@corigine.com,\n Vincent Mailhol <mailhol@kernel.org>, Mark Bloch <mbloch@nvidia.com>,\n linux-kernel@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,\n Jian Shen <shenjian15@huawei.com>, Jijie Shao <shaojijie@huawei.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>, Thomas Gleixner <tglx@kernel.org>,\n Simon Horman <horms@kernel.org>, Yicong Hui <yiconghui@gmail.com>,\n Mark Einon <mark.einon@gmail.com>, Johannes Berg <johannes@sipsolutions.net>,\n Heiner Kallweit <hkallweit1@gmail.com>, Saeed Mahameed <saeedm@nvidia.com>,\n \"David S. Miller\" <davem@davemloft.net>, Krzysztof Halasa <khc@pm.waw.pl>","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"}},{"id":3687862,"web_url":"http://patchwork.ozlabs.org/comment/3687862/","msgid":"<20260507-dangerous-manipulative-guan-bfd474-mkl@pengutronix.de>","list_archive_url":null,"date":"2026-05-07T14:48:24","subject":"Re: [Intel-wired-lan] [PATCH net-next v2 1/2] net: Consistently\n define pci_device_ids using named initializers","submitter":{"id":2822,"url":"http://patchwork.ozlabs.org/api/people/2822/","name":"Marc Kleine-Budde","email":"mkl@pengutronix.de"},"content":"On 07.05.2026 16:23:43, Uwe Kleine-König (The Capable Hub) wrote:\n> Hello Marc,\n>\n> On Thu, May 07, 2026 at 12:55:45PM +0200, Marc Kleine-Budde wrote:\n> > > +\t}, {\n> > >  \t\t/* ASEM Dual CAN raw -new model */\n> > > -\t\tASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DEVICE_ID,\n> > > -\t\tASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CAN_SUB_DEVICE_ID_BIS,\n> > > -\t\t0, 0,\n> > > -\t\t(kernel_ulong_t)&plx_pci_card_info_asem_dual_can\n> > > +\t\tPCI_DEVICE_SUB(ASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DEVICE_ID,\n> > > +\t\t\t       ASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CAN_SUB_DEVICE_ID_BIS),\n> > > +\t\t.driver_data = (kernel_ulong_t)&plx_pci_card_info_asem_dual_can,\n> > >  \t},\n> > > -\t{ 0,}\n> > > +\t{ }\n> >\n> > Nitpick: can you convert the terminating entry to follow the same style\n> > as the rest of the driver:\n> >\n> > diff --git a/drivers/net/can/sja1000/plx_pci.c b/drivers/net/can/sja1000/plx_pci.c\n> > index a03553b80a5d..d69ff0ccfd94 100644\n> > --- a/drivers/net/can/sja1000/plx_pci.c\n> > +++ b/drivers/net/can/sja1000/plx_pci.c\n> > @@ -353,8 +353,8 @@ static const struct pci_device_id plx_pci_tbl[] = {\n> >                  PCI_DEVICE_SUB(ASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DEVICE_ID,\n> >                                 ASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CAN_SUB_DEVICE_ID_BIS),\n> >                  .driver_data = (kernel_ulong_t)&plx_pci_card_info_asem_dual_can,\n> > -        },\n> > -        { }\n> > +        }, {\n> > +        }\n> >  };\n> >  MODULE_DEVICE_TABLE(pci, plx_pci_tbl);\n>\n> After the conversation in the v1 thread it was unclear to me if you\n> stand by your opinion, so I kept the format as it was. I interpret your\n> repetition of the nitpick as request to rework the can drivers for the\n> next revision (if that happens).\n\nDoh - Yes, right, we discussed this already. Keep it as is and add my:\n\nAcked-by: Marc Kleine-Budde <mkl@pengutronix.de> # for drivers/net/can\n\nregards,\nMarc","headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=ZZz2G2pj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBFW76My1z1yKd\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 08 May 2026 00:48:51 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id B1FC361057;\n\tThu,  7 May 2026 14:48:49 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 30voBWYAKnjZ; Thu,  7 May 2026 14:48:47 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id B19016102A;\n\tThu,  7 May 2026 14:48:47 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 61F6A280\n for <intel-wired-lan@lists.osuosl.org>; Thu,  7 May 2026 14:48:46 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 47F1141161\n for <intel-wired-lan@lists.osuosl.org>; Thu,  7 May 2026 14:48:46 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id zZJwd4PkBy9y for <intel-wired-lan@lists.osuosl.org>;\n Thu,  7 May 2026 14:48:45 +0000 (UTC)","from metis.whiteo.stw.pengutronix.de\n (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104])\n by smtp4.osuosl.org (Postfix) with ESMTPS id AD5134115E\n for <intel-wired-lan@lists.osuosl.org>; Thu,  7 May 2026 14:48:43 +0000 (UTC)","from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])\n by metis.whiteo.stw.pengutronix.de with esmtps\n (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)\n (envelope-from <mkl@pengutronix.de>)\n id 1wL01i-0001Vq-3i; Thu, 07 May 2026 16:48:34 +0200","from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b]\n helo=bjornoya.blackshift.org)\n by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls\n TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96)\n (envelope-from <mkl@pengutronix.de>) id 1wL01Z-000wEM-1k;\n Thu, 07 May 2026 16:48:26 +0200","from pengutronix.de (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (Client did not present a certificate)\n (Authenticated sender: mkl-all@blackshift.org)\n by smtp.blackshift.org (Postfix) with ESMTPSA id 264265306B3;\n Thu, 07 May 2026 14:48:25 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org B19016102A","OpenDKIM Filter v2.11.0 smtp4.osuosl.org AD5134115E"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1778165327;\n\tbh=MzCFuRNb8Sslv8kY4I/Dbvw9vys0PYrJGfq6VDvNHpI=;\n\th=Date:From:To:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=ZZz2G2pjpUKP7EokfoAJOJt9kVkcCvRqsrFolou16SxYp0olJQsg9DxNUwK9mo2bU\n\t Hzw9sdOtbHCRl1wJC3AsTwj0yj0K+cKNa/6tUwN6LwhJro5tYzQIIHVGbxkw8h9qH+\n\t cH+ODyVUB5Oh40J0l/GC1fjUz9Ccru/lXU6wEVV0N6vvqM9Z/QG2vQ+Mu/WIWwWOMI\n\t ZWnAAvzR6+84P/uM322PBq/kZ4QbuZ/M1URag3YkGsxMhvuaHoZuYJ24bYJ6gw+UHZ\n\t zAKQcfnZrD8R4fWQW8mAGr9zcfDKF/UvbB2BNF/lEssO6vq6zBvXsNdUo2kcr5Vbhg\n\t 9WYjyyXJRnE8g==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2a0a:edc0:2:b01:1d::104; helo=metis.whiteo.stw.pengutronix.de;\n envelope-from=mkl@pengutronix.de; receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org AD5134115E","Date":"Thu, 7 May 2026 16:48:24 +0200","From":"Marc Kleine-Budde <mkl@pengutronix.de>","To":"Uwe =?utf-8?q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?=\n <u.kleine-koenig@baylibre.com>","Message-ID":"<20260507-dangerous-manipulative-guan-bfd474-mkl@pengutronix.de>","X-AI":"stop_reason: \"refusal\"","References":"<cover.1778149923.git.u.kleine-koenig@baylibre.com>\n <76da4f44d48bdde84580963862bf9616bee5c9e9.1778149923.git.u.kleine-koenig@baylibre.com>\n <20260507-healthy-gainful-fox-500552-mkl@pengutronix.de>\n <afyfa4E4rNbkMYTk@monoceros>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n protocol=\"application/pgp-signature\"; boundary=\"3r5cznssyoe7scuq\"","Content-Disposition":"inline","In-Reply-To":"<afyfa4E4rNbkMYTk@monoceros>","X-SA-Exim-Connect-IP":"2a0a:edc0:0:c01:1d::a2","X-SA-Exim-Mail-From":"mkl@pengutronix.de","X-SA-Exim-Scanned":"No (on metis.whiteo.stw.pengutronix.de);\n SAEximRunCond expanded to false","X-PTX-Original-Recipient":"intel-wired-lan@lists.osuosl.org","X-Mailman-Original-Authentication-Results":"smtp4.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=pengutronix.de","Subject":"Re: [Intel-wired-lan] [PATCH net-next v2 1/2] net: Consistently\n define pci_device_ids using named initializers","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Cc":"Richard Cochran <richardcochran@gmail.com>,\n Marco Crivellari <marco.crivellari@suse.com>,\n Randy Dunlap <rdunlap@infradead.org>, Yonglong Liu <liuyonglong@huawei.com>,\n Kees Cook <kees@kernel.org>, linux-wireless@vger.kernel.org,\n Ian Lin <ian.lin@infineon.com>, brcm80211@lists.linux.dev,\n Daniele Venzano <venza@brownhat.org>, Eric Dumazet <edumazet@google.com>,\n netdev@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,\n MD Danish Anwar <danishanwar@ti.com>, Samuel Chessman <chessman@tux.org>,\n Fan Gong <gongfan1@huawei.com>, Mengyuan Lou <mengyuanlou@net-swift.com>,\n Kevin Curtis <kevin.curtis@farsite.co.uk>, Ingo Molnar <mingo@kernel.org>,\n Michael Grzeschik <mgr@kernel.org>, Ion Badulescu <ionut@badula.org>,\n Yeounsu Moon <yyyynoom@gmail.com>, Manish Chopra <manishc@marvell.com>,\n Colin Ian King <colin.i.king@gmail.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Thomas Fourier <fourier.thomas@gmail.com>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>,\n Denis Kirjanov <kirjanov@gmail.com>, intel-wired-lan@lists.osuosl.org,\n linux-parisc@vger.kernel.org, Jacob Keller <jacob.e.keller@intel.com>,\n Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,\n Steffen Klassert <klassert@kernel.org>,\n Stanislav Yakovlev <stas.yakovlev@gmail.com>, linux-rdma@vger.kernel.org,\n Arend van Spriel <arend.vanspriel@broadcom.com>, nic_swsd@realtek.com,\n Jiri Pirko <jiri@resnulli.us>, Ethan Nelson-Moore <enelsonmoore@gmail.com>,\n Larysa Zaremba <larysa.zaremba@intel.com>, Ido Schimmel <idosch@nvidia.com>,\n Potnuri Bharat Teja <bharat@chelsio.com>, Double Lo <double.lo@cypress.com>,\n Markus Schneider-Pargmann <msp@baylibre.com>,\n Nathan Chancellor <nathan@kernel.org>, Jiawen Wu <jiawenwu@trustnetic.com>,\n Cai Huoqing <cai.huoqing@linux.dev>, Bjorn Helgaas <bhelgaas@google.com>,\n Zilin Guan <zilin@seu.edu.cn>, linux-can@vger.kernel.org,\n Yibo Dong <dong100@mucse.com>, Andy Shevchenko <andriy.shevchenko@intel.com>,\n Petr Machata <petrm@nvidia.com>, Kory Maincent <kory.maincent@bootlin.com>,\n brcm80211-dev-list.pdl@broadcom.com, GR-Linux-NIC-Dev@marvell.com,\n Vadim Fedorenko <vadim.fedorenko@linux.dev>,\n Leon Romanovsky <leon@kernel.org>,\n Denis Benato <benato.denis96@gmail.com>, Rasesh Mody <rmody@marvell.com>,\n David Arinzon <darinzon@amazon.com>, oss-drivers@corigine.com,\n Vincent Mailhol <mailhol@kernel.org>, Mark Bloch <mbloch@nvidia.com>,\n linux-kernel@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,\n Jian Shen <shenjian15@huawei.com>, Jijie Shao <shaojijie@huawei.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>, Thomas Gleixner <tglx@kernel.org>,\n Simon Horman <horms@kernel.org>, Yicong Hui <yiconghui@gmail.com>,\n Mark Einon <mark.einon@gmail.com>, Johannes Berg <johannes@sipsolutions.net>,\n Heiner Kallweit <hkallweit1@gmail.com>, Saeed Mahameed <saeedm@nvidia.com>,\n \"David S. Miller\" <davem@davemloft.net>, Krzysztof Halasa <khc@pm.waw.pl>","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"}},{"id":3688752,"web_url":"http://patchwork.ozlabs.org/comment/3688752/","msgid":"<20260508153452.6a1a9044@kernel.org>","list_archive_url":null,"date":"2026-05-08T22:34:52","subject":"Re: [Intel-wired-lan] [PATCH net-next v2 0/2] Rework pci_device_id\n initialisation","submitter":{"id":77159,"url":"http://patchwork.ozlabs.org/api/people/77159/","name":"Jakub Kicinski","email":"kuba@kernel.org"},"content":"On Thu,  7 May 2026 12:50:18 +0200 Uwe Kleine-König (The Capable Hub)\nwrote:\n>   net: Consistently define pci_device_ids using named initializers\n>   net: nfp: Drop PCI class entries with .class_mask = 0\n\nThere's a transient build failure between these two patches,\nyou should probably reorder them?","headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=Rt542EeK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gC3pc3blSz1yCg\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 09 May 2026 08:35:04 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 97B0384AFA;\n\tFri,  8 May 2026 22:35:02 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 4dvQiIGNHy8m; Fri,  8 May 2026 22:35:00 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id B982184AD9;\n\tFri,  8 May 2026 22:35:00 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 7F5F9272\n for <intel-wired-lan@lists.osuosl.org>; Fri,  8 May 2026 22:34:59 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 653CB41338\n for <intel-wired-lan@lists.osuosl.org>; Fri,  8 May 2026 22:34:59 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id xCXrlYpDqlOc for <intel-wired-lan@lists.osuosl.org>;\n Fri,  8 May 2026 22:34:58 +0000 (UTC)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 96E7941358\n for <intel-wired-lan@lists.osuosl.org>; Fri,  8 May 2026 22:34:58 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by tor.source.kernel.org (Postfix) with ESMTP id 509756024D;\n Fri,  8 May 2026 22:34:56 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id EF80FC2BCB0;\n Fri,  8 May 2026 22:34:52 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org B982184AD9","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 96E7941358"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1778279700;\n\tbh=9rXpqgYqRHyMz6vZjVpFaOyXfnT/1ZA9skwAGxrOXWA=;\n\th=Date:From:To:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=Rt542EeK5+Mehcfxwrc4PbUm14IqkeAaBSy/+gEcIMh0jo32yCGWPrlWF8FBtWWLK\n\t T/jOw7THe7u5NU+l86OPyLGfEzByN8AKEP5nh47Y2Lh8B+pgJxOrIfvQpJAhg/4wL6\n\t BdfxGr5yu+Y3sC/Xn6Uv6q9pW0rFnmbAr915sWeK2b5jYtJsuQQeu3UD44JPIA8M0m\n\t jku7wWw21w1CFYaR4QTocRnia97B1XYkqoFynPMLfSPMsUoft7fjobCBvE6rL5Dcjb\n\t NyPkWamFJExWUJ52eGbslSi9pfGnLvQ8+GKVfY82BeT5qSGdhqAUoQYLUEn0pt+ETa\n\t xlNzahViQ1ucg==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254;\n helo=tor.source.kernel.org; envelope-from=kuba@kernel.org;\n receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 96E7941358","Date":"Fri, 8 May 2026 15:34:52 -0700","From":"Jakub Kicinski <kuba@kernel.org>","To":"\"Uwe =?utf-8?q?Kleine-K=C3=B6nig?= (The Capable Hub)\"\n <u.kleine-koenig@baylibre.com>","Message-ID":"<20260508153452.6a1a9044@kernel.org>","In-Reply-To":"<cover.1778149923.git.u.kleine-koenig@baylibre.com>","References":"<cover.1778149923.git.u.kleine-koenig@baylibre.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1778279696;\n bh=/FqJRBmfOok3Fl/V8liHSdXMD9qTqHxPKI6+SAyQksw=;\n h=Date:From:To:Cc:Subject:In-Reply-To:References:From;\n b=JnJD8WpuGcqHBCKs0Ts4elbdxBbuG1BwAgscLJuNVRziMOm4SDnzTqN3kx1yP6/X+\n GAdeAqIhI9nFlzVHTLX/S1mwIbo19SrwK0wfDhJeidejvlNcoYDlK1SrT/oiL3UYj0\n GIekbaJ56hBFjeEkBXBs+ZV1/MchvLrAP41b6RvmgIFAwNZnLqYwRd6dO+6HhbJbJd\n kxC8LBO1S3SVunqjOv2Wtp8A5+8SXmiVHrPTOd/+4hirtqSKiT2/3p3ywrNsL4bTOE\n TJfm7z3NUrn0fQCLaudtHO7mA8dPHCWP88gD1VhxYK4rvad70qNKJD/NatwmvbNDwF\n jyVcPI/fAlqow==","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=JnJD8Wpu"],"Subject":"Re: [Intel-wired-lan] [PATCH net-next v2 0/2] Rework pci_device_id\n initialisation","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Cc":"Richard Cochran <richardcochran@gmail.com>,\n Marco Crivellari <marco.crivellari@suse.com>,\n Randy Dunlap <rdunlap@infradead.org>, Yonglong Liu <liuyonglong@huawei.com>,\n Kees Cook <kees@kernel.org>, linux-wireless@vger.kernel.org,\n Ian Lin <ian.lin@infineon.com>, brcm80211@lists.linux.dev,\n Daniele Venzano <venza@brownhat.org>, Eric Dumazet <edumazet@google.com>,\n netdev@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,\n MD Danish Anwar <danishanwar@ti.com>, Samuel Chessman <chessman@tux.org>,\n Fan Gong <gongfan1@huawei.com>, Mengyuan Lou <mengyuanlou@net-swift.com>,\n Kevin Curtis <kevin.curtis@farsite.co.uk>, Ingo Molnar <mingo@kernel.org>,\n Michael Grzeschik <mgr@kernel.org>, Ion Badulescu <ionut@badula.org>,\n Yeounsu Moon <yyyynoom@gmail.com>, Manish Chopra <manishc@marvell.com>,\n Colin Ian King <colin.i.king@gmail.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Thomas Fourier <fourier.thomas@gmail.com>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>,\n Denis Kirjanov <kirjanov@gmail.com>, intel-wired-lan@lists.osuosl.org,\n linux-parisc@vger.kernel.org, Jacob Keller <jacob.e.keller@intel.com>,\n Paolo Abeni <pabeni@redhat.com>, Steffen Klassert <klassert@kernel.org>,\n Stanislav Yakovlev <stas.yakovlev@gmail.com>, linux-rdma@vger.kernel.org,\n Arend van Spriel <arend.vanspriel@broadcom.com>, nic_swsd@realtek.com,\n Jiri Pirko <jiri@resnulli.us>, Ethan Nelson-Moore <enelsonmoore@gmail.com>,\n Larysa Zaremba <larysa.zaremba@intel.com>, Ido Schimmel <idosch@nvidia.com>,\n Potnuri Bharat Teja <bharat@chelsio.com>, Double Lo <double.lo@cypress.com>,\n Markus Schneider-Pargmann <msp@baylibre.com>,\n Nathan Chancellor <nathan@kernel.org>, Jiawen Wu <jiawenwu@trustnetic.com>,\n Cai Huoqing <cai.huoqing@linux.dev>, Mark Einon <mark.einon@gmail.com>,\n Bjorn Helgaas <bhelgaas@google.com>, Zilin Guan <zilin@seu.edu.cn>,\n linux-can@vger.kernel.org, Yibo Dong <dong100@mucse.com>,\n Andy Shevchenko <andriy.shevchenko@intel.com>,\n Petr Machata <petrm@nvidia.com>,\n Kory Maincent <kory.maincent@bootlin.com>,\n brcm80211-dev-list.pdl@broadcom.com,\n GR-Linux-NIC-Dev@marvell.com, Vadim Fedorenko <vadim.fedorenko@linux.dev>,\n Leon Romanovsky <leon@kernel.org>, Denis Benato <benato.denis96@gmail.com>,\n Rasesh Mody <rmody@marvell.com>, David Arinzon <darinzon@amazon.com>,\n oss-drivers@corigine.com, Vincent Mailhol <mailhol@kernel.org>,\n Mark Bloch <mbloch@nvidia.com>, linux-kernel@vger.kernel.org,\n Tariq Toukan <tariqt@nvidia.com>, Jian Shen <shenjian15@huawei.com>,\n Jijie Shao <shaojijie@huawei.com>, Andrew Lunn <andrew+netdev@lunn.ch>,\n Thomas Gleixner <tglx@kernel.org>, Simon Horman <horms@kernel.org>,\n Yicong Hui <yiconghui@gmail.com>, Marc Kleine-Budde <mkl@pengutronix.de>,\n Johannes Berg <johannes@sipsolutions.net>,\n Heiner Kallweit <hkallweit1@gmail.com>, Saeed Mahameed <saeedm@nvidia.com>,\n \"David S. Miller\" <davem@davemloft.net>, Krzysztof Halasa <khc@pm.waw.pl>","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"}},{"id":3688811,"web_url":"http://patchwork.ozlabs.org/comment/3688811/","msgid":"<af7WyUi8jEzInj5z@monoceros>","list_archive_url":null,"date":"2026-05-09T06:42:36","subject":"Re: [Intel-wired-lan] [PATCH net-next v2 0/2] Rework pci_device_id\n initialisation","submitter":{"id":88686,"url":"http://patchwork.ozlabs.org/api/people/88686/","name":"Uwe Kleine-König (The Capable Hub)","email":"u.kleine-koenig@baylibre.com"},"content":"On Fri, May 08, 2026 at 03:34:52PM -0700, Jakub Kicinski wrote:\n> On Thu,  7 May 2026 12:50:18 +0200 Uwe Kleine-König (The Capable Hub)\n> wrote:\n> >   net: Consistently define pci_device_ids using named initializers\n> >   net: nfp: Drop PCI class entries with .class_mask = 0\n> \n> There's a transient build failure between these two patches,\n> you should probably reorder them?\n\nI did build test with the first patch only, using gcc on x86 and arm64.\nI guess this is about the ambiguity I mentioned in the cover letter and\nmaybe using clang? I'll try to reproduce and fix.\n\nBest regards\nUwe","headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=3BVj4Eis;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gCGdT0g7Fz1yK7\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 09 May 2026 16:42:50 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 8E20F83D18;\n\tSat,  9 May 2026 06:42:48 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 9UdWoDLdntEE; Sat,  9 May 2026 06:42:46 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id B512083CD1;\n\tSat,  9 May 2026 06:42:46 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 22EA925B\n for <intel-wired-lan@lists.osuosl.org>; Sat,  9 May 2026 06:42:46 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 08995423CF\n for <intel-wired-lan@lists.osuosl.org>; Sat,  9 May 2026 06:42:46 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id QwQTaIK4I12g for <intel-wired-lan@lists.osuosl.org>;\n Sat,  9 May 2026 06:42:45 +0000 (UTC)","from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n [IPv6:2a00:1450:4864:20::330])\n by smtp4.osuosl.org (Postfix) with ESMTPS id C5759423CB\n for <intel-wired-lan@lists.osuosl.org>; Sat,  9 May 2026 06:42:43 +0000 (UTC)","by mail-wm1-x330.google.com with SMTP id\n 5b1f17b1804b1-488ab2db91aso29025705e9.3\n for <intel-wired-lan@lists.osuosl.org>; Fri, 08 May 2026 23:42:43 -0700 (PDT)","from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291])\n by smtp.gmail.com with UTF8SMTPSA id\n 5b1f17b1804b1-48e6db1e1a1sm15355095e9.34.2026.05.08.23.42.37\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 08 May 2026 23:42:38 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org B512083CD1","OpenDKIM Filter v2.11.0 smtp4.osuosl.org C5759423CB"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1778308966;\n\tbh=4fgHjlyy8GzHWAXn0Fq+FtEi3bvrm+LBlHiRLm/LF+E=;\n\th=Date:From:To:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=3BVj4EiswRd1rpZEO2Z3Q0GhSDIzSBbBEY+KZUwyzACU859IWR/F8KYlFfQ1l6t8J\n\t rM8F0pOTUrfQ+BlB9OJ4RedpK2m/I7r4hGnraybE6fRbCvLf7P53d1Ae9JEKuULA7z\n\t d/IbO+/tkS4BggSMe2yg5GV/ddmafAJd+wNM2Ei9Y+LD70m0x9aZ4EdVBv+BK/zk7T\n\t 6eoYgfzlSxSxIyskDnW7dbnnzOCi90JxFTRbiW/OdNiyPubJnxgRf78O8OvUZIm7yW\n\t u8oqDEiUjAubvdxWJ0W/Og03U5TMRGRdeZJTlQrHXN9CRIKNvMkdguGdOgfi+nOBJt\n\t Rie7qHXSG+7Ng==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2a00:1450:4864:20::330; helo=mail-wm1-x330.google.com;\n envelope-from=ukleinek@baylibre.com; receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org C5759423CB","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778308961; x=1778913761;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=4fgHjlyy8GzHWAXn0Fq+FtEi3bvrm+LBlHiRLm/LF+E=;\n b=Zqy30ZLyipqHR2o52CbWHhxFc1is8lRJsSq5LowD/3HBHO/+GJE0cs88+CuGhcT6Dg\n Nc4OWyOmVC9bt1orQaXd6NjDKlRK/5IsQwuV8dS/ZHD3kvUEsQvo4b+ZA/ZJittZo10T\n QHyVJwA6dhV6i9JDD9/ctuhzVnxW4IJEMSRZOCEddAihgPOlCaA0XNF9pU4gfkcFqkgV\n 2tuA5DzhG73tnhq5YdUZLOwRHhP6qyWseFMI8Ogq9ZAt9WGxD35zuEhuqfVp5gN5Vh2I\n T4A9fkqo288+j3pX+u5REXQBMnMR4F0KKMMX0uu8L+1hdG4Qb9xCJZJsDaBRhD8dZ0Vl\n obfw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+TIt3aY9OMT3MSoR6qNIPGjSNJJ4yd3XhAel2WB2oO8nTTc3k3o5ykXHZ+HPGWkZgs4bk/H3OjUCWJDTGJSow=@lists.osuosl.org","X-Gm-Message-State":"AOJu0YzusTFwQTOTiviegkO7jvkgCaTKH//9xKZZ4OHC/6tN0+k9rYz3\n D9fpjmKt8JQ3Oj1OIrH+6/QJPvuXMtBZgfNlWgGw7H85SbX3flUwSLobWG+EEL0BkWI=","X-Gm-Gg":"Acq92OE8QqOsG0J4OW5FQJduDDn+NumSVEXrSqerwtCRBnIlnlMdjqzsKv/ctm4uvj6\n YQ9KEBCLiCGvdyJVRE4DS6KL5fly1zPtAId4q4tY4tyYg0037Rgwx4e8WPSBShKokgP+1D7nY7j\n zySgdyHAN2I0Jo7VTER3zOovSnepZ9XXPj+QTA9cubZW0Wt9cOYxFeaynE9KgpjYI+LpK4q1rkD\n ZkRgF5XbOiJ91EzZt8y74be7JdKmR46pcRhhkkGRlKPzFYUnaDFm/cDSHx6RJGBCIkLoPVq9dfv\n t0b+2ustR1H95xAId+sqaPIRNPQfCFLvUS9jsHsQ14V7xRy9LhEtAqedxZjitf+x05ek/+BXw2z\n AuNm51FRONDvN6CJjXL/pOsYgkhxZeknOM6YGE8aADVG5chUmdAGWJZHKhPpMaKm1e4UBXnfZ1w\n jVYy2CPd9FXoK4n9FY+gTIlxKvoC/n361m4QYVBnM=","X-Received":"by 2002:a05:600c:4f51:b0:48d:1a94:56c with SMTP id\n 5b1f17b1804b1-48e51f3054cmr269055545e9.18.1778308960358;\n Fri, 08 May 2026 23:42:40 -0700 (PDT)","Date":"Sat, 9 May 2026 08:42:36 +0200","From":"Uwe =?utf-8?q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?=\n <u.kleine-koenig@baylibre.com>","To":"Jakub Kicinski <kuba@kernel.org>","Message-ID":"<af7WyUi8jEzInj5z@monoceros>","References":"<cover.1778149923.git.u.kleine-koenig@baylibre.com>\n <20260508153452.6a1a9044@kernel.org>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n protocol=\"application/pgp-signature\"; boundary=\"pa3si5htqwvg7uxg\"","Content-Disposition":"inline","In-Reply-To":"<20260508153452.6a1a9044@kernel.org>","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1778308961;\n x=1778913761;\n darn=lists.osuosl.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=4fgHjlyy8GzHWAXn0Fq+FtEi3bvrm+LBlHiRLm/LF+E=;\n b=WmvPIK9RciQfzyUHKOVrRjydHTXJ3TYVSloB5pfyDvqL6prKISntk0WcHhadIbLrKX\n KdyfxQ8fjFJFwnh+zFKCeuSXkqp8deN09LQi8tPm9IuULPVVsQI46gK8zTCALOl4FhlU\n egJC7FE928N+38n+wM/iPGvrOU8xC7o+9dU9fJ1X5OCKBkn01OH3jGLXK7QmJ8aMnN9R\n H0xu45Py+veMGhf3WgoAQRdnqF3Pr7+OYVlsorR8+8C/6vN/WuZYI/scS9WQDqvbtSYv\n QoyCci6cYmmsvplFVH3YIkpHfO3u4kYe9s6K26uhjdARo0PSDu3l7ln8u7ktihDINOdP\n wgxg==","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=baylibre.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=WmvPIK9R"],"Subject":"Re: [Intel-wired-lan] [PATCH net-next v2 0/2] Rework pci_device_id\n initialisation","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Cc":"Richard Cochran <richardcochran@gmail.com>,\n Marco Crivellari <marco.crivellari@suse.com>,\n Randy Dunlap <rdunlap@infradead.org>, Yonglong Liu <liuyonglong@huawei.com>,\n Kees Cook <kees@kernel.org>, linux-wireless@vger.kernel.org,\n Ian Lin <ian.lin@infineon.com>, brcm80211@lists.linux.dev,\n Daniele Venzano <venza@brownhat.org>, Eric Dumazet <edumazet@google.com>,\n netdev@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,\n MD Danish Anwar <danishanwar@ti.com>, Samuel Chessman <chessman@tux.org>,\n Fan Gong <gongfan1@huawei.com>, Mengyuan Lou <mengyuanlou@net-swift.com>,\n Kevin Curtis <kevin.curtis@farsite.co.uk>, Ingo Molnar <mingo@kernel.org>,\n Michael Grzeschik <mgr@kernel.org>, Ion Badulescu <ionut@badula.org>,\n Yeounsu Moon <yyyynoom@gmail.com>, Manish Chopra <manishc@marvell.com>,\n Colin Ian King <colin.i.king@gmail.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Thomas Fourier <fourier.thomas@gmail.com>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>,\n Denis Kirjanov <kirjanov@gmail.com>, intel-wired-lan@lists.osuosl.org,\n linux-parisc@vger.kernel.org, Jacob Keller <jacob.e.keller@intel.com>,\n Paolo Abeni <pabeni@redhat.com>, Steffen Klassert <klassert@kernel.org>,\n Stanislav Yakovlev <stas.yakovlev@gmail.com>, linux-rdma@vger.kernel.org,\n Arend van Spriel <arend.vanspriel@broadcom.com>, nic_swsd@realtek.com,\n Jiri Pirko <jiri@resnulli.us>, Ethan Nelson-Moore <enelsonmoore@gmail.com>,\n Larysa Zaremba <larysa.zaremba@intel.com>, Ido Schimmel <idosch@nvidia.com>,\n Potnuri Bharat Teja <bharat@chelsio.com>, Double Lo <double.lo@cypress.com>,\n Markus Schneider-Pargmann <msp@baylibre.com>,\n Nathan Chancellor <nathan@kernel.org>, Jiawen Wu <jiawenwu@trustnetic.com>,\n Cai Huoqing <cai.huoqing@linux.dev>, Mark Einon <mark.einon@gmail.com>,\n Bjorn Helgaas <bhelgaas@google.com>, Zilin Guan <zilin@seu.edu.cn>,\n linux-can@vger.kernel.org, Yibo Dong <dong100@mucse.com>,\n Andy Shevchenko <andriy.shevchenko@intel.com>,\n Petr Machata <petrm@nvidia.com>,\n Kory Maincent <kory.maincent@bootlin.com>,\n brcm80211-dev-list.pdl@broadcom.com,\n GR-Linux-NIC-Dev@marvell.com, Vadim Fedorenko <vadim.fedorenko@linux.dev>,\n Leon Romanovsky <leon@kernel.org>, Denis Benato <benato.denis96@gmail.com>,\n Rasesh Mody <rmody@marvell.com>, David Arinzon <darinzon@amazon.com>,\n oss-drivers@corigine.com, Vincent Mailhol <mailhol@kernel.org>,\n Mark Bloch <mbloch@nvidia.com>, linux-kernel@vger.kernel.org,\n Tariq Toukan <tariqt@nvidia.com>, Jian Shen <shenjian15@huawei.com>,\n Jijie Shao <shaojijie@huawei.com>, Andrew Lunn <andrew+netdev@lunn.ch>,\n Thomas Gleixner <tglx@kernel.org>, Simon Horman <horms@kernel.org>,\n Yicong Hui <yiconghui@gmail.com>, Marc Kleine-Budde <mkl@pengutronix.de>,\n Johannes Berg <johannes@sipsolutions.net>,\n Heiner Kallweit <hkallweit1@gmail.com>, Saeed Mahameed <saeedm@nvidia.com>,\n \"David S. Miller\" <davem@davemloft.net>, Krzysztof Halasa <khc@pm.waw.pl>","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"}}]