[{"id":3687462,"web_url":"http://patchwork.ozlabs.org/comment/3687462/","msgid":"<CANCZdfpzNBZv4XseC0KWkVHaPwCRRNgS9sWAHeCrZusqP3V=1Q@mail.gmail.com>","list_archive_url":null,"date":"2026-05-07T02:31:18","subject":"Re: [PATCH 00/25] bsd-user May 2026 pull request","submitter":{"id":1896,"url":"http://patchwork.ozlabs.org/api/people/1896/","name":"Warner Losh","email":"imp@bsdimp.com"},"content":"Please ignore this.\n\nIt was a botched pull request. I've sent the real pull request. My\napologies for the noise.\n\nWarner\n\nOn Wed, May 6, 2026 at 8:24 PM Warner Losh <imp@bsdimp.com> wrote:\n\n> Three patch series were reviewed during the code freeze and are finally\n> ready to\n> head into the tree.\n>\n> (1) Use SPDX identifiers in most places. This makes it easier for me to\n> upstream\n> since I can do almost all of the files in the forked tree and not have it\n> be an\n> issue each time I add a new file.\n>\n> (2) Per discussions in the review, copy thunk.c to bsd-user from\n> linux-user. We\n> will use this in the third set of patches, ioctls. All that changed is the\n> copyright header. This file has style problems, but fixing them would be a\n> worse\n> problem than the style issues since we share it with linux-user and want to\n> track changes there. In the future we may actually share, but for now this\n> was\n> the compromise.\n>\n> (3) All the ioctls that bsd-user supports in FreeBSD. This uses the\n> thunk.c code\n> to translate back and forth between host and target. A number of pedantic\n> changes were made against the blitz branch upstream and were discovered or\n> highlighted by claude code.\n>\n> I used claude to extract all the ioctl code from the blitz branch for\n> upstreaming. I had it review the code and fixed the problems it found\n> (though\n> one was a false positive). I've not tagged these as Assisted-by: since\n> that part\n> of our policy is in flux. No creative output of claude was applied here,\n> though\n> it also suggested the commit messages (that I rewrote in large part, but\n> vestiges of the original remain). To be clear: Claude didn't write any of\n> the actual code.\n>\n> Stacey Son (19):\n>   bsd-user: ioctl: add common definitions\n>   bsd-user: Add FreeBSD tty ioctl definitions\n>   bsd-user: Add FreeBSD file I/O ioctl definitions\n>   bsd-user: Add FreeBSD socket ioctl definitions\n>   bsd-user: Add FreeBSD cryptodev ioctl definitions\n>   bsd-user: Add FreeBSD disk ioctl definitions\n>   bsd-user: Add FreeBSD IPv6 ioctl definitions\n>   bsd-user: Add FreeBSD ioctl type definitions\n>   bsd-user: Add FreeBSD ioctl command table\n>   bsd-user: Add bsd-ioctl.h header\n>   bsd-user: Add target_sockaddr and safe_ioctl to syscall_defs.h\n>   bsd-user: Add bsd-ioctl.c infrastructure and termios conversion\n>   bsd-user: Add log_unsupported_ioctl function\n>   bsd-user: Add do_ioctl_unsupported function\n>   bsd-user: Add target_to_host_sockaddr_in6 function\n>   bsd-user: Add do_ioctl_in6_ifreq_sockaddr_int function\n>   bsd-user: Add do_bsd_ioctl main function\n>   bsd-user: Add init_bsd_ioctl function\n>   bsd-user: Add call to do_bsd_ioctl and add bsd-ioctl.c to the build\n>\n> Warner Losh (6):\n>   bsd-user: Switch to SPDX-License-Expression\n>   bsd-user: Add syscall header generator for FreeBSD\n>   bsd-user: Delete sbrk and sstk system calls.\n>   bsd-user: Create os-syscall.h\n>   bsd-user: Switch to generated syscall_nr.h\n>   bsd-user: Copy linux-user/thunk.c to bsd-user\n>\n>  bsd-user/aarch64/signal.c               |  15 +-\n>  bsd-user/aarch64/target_arch.h          |  16 +-\n>  bsd-user/aarch64/target_arch_cpu.c      |  15 +-\n>  bsd-user/aarch64/target_arch_cpu.h      |  18 +-\n>  bsd-user/aarch64/target_arch_elf.h      |  14 +-\n>  bsd-user/aarch64/target_arch_reg.h      |  19 +-\n>  bsd-user/aarch64/target_arch_signal.h   |  16 +-\n>  bsd-user/aarch64/target_arch_sigtramp.h |  16 +-\n>  bsd-user/aarch64/target_arch_sysarch.h  |  16 +-\n>  bsd-user/aarch64/target_arch_thread.h   |  16 +-\n>  bsd-user/aarch64/target_arch_vmparam.h  |  16 +-\n>  bsd-user/aarch64/target_syscall.h       |  16 +-\n>  bsd-user/arm/signal.c                   |  18 +-\n>  bsd-user/arm/target_arch.h              |  16 +-\n>  bsd-user/arm/target_arch_cpu.c          |  18 +-\n>  bsd-user/arm/target_arch_cpu.h          |  18 +-\n>  bsd-user/arm/target_arch_elf.h          |  18 +-\n>  bsd-user/arm/target_arch_reg.h          |  18 +-\n>  bsd-user/arm/target_arch_signal.h       |  18 +-\n>  bsd-user/arm/target_arch_sigtramp.h     |  18 +-\n>  bsd-user/arm/target_arch_sysarch.h      |  18 +-\n>  bsd-user/arm/target_arch_thread.h       |  18 +-\n>  bsd-user/arm/target_arch_vmparam.h      |  18 +-\n>  bsd-user/arm/target_syscall.h           |  18 +-\n>  bsd-user/bsd-file.h                     |  18 +-\n>  bsd-user/bsd-ioctl.c                    | 436 ++++++++++++++++++++\n>  bsd-user/bsd-ioctl.h                    |  14 +\n>  bsd-user/bsd-mem.c                      |  17 +-\n>  bsd-user/bsd-mem.h                      |  30 +-\n>  bsd-user/bsd-proc.c                     |  17 +-\n>  bsd-user/bsd-proc.h                     |  17 +-\n>  bsd-user/freebsd/meson.build            |  10 +-\n>  bsd-user/freebsd/os-ioctl-cmds.h        | 149 +++++++\n>  bsd-user/freebsd/os-ioctl-cryptodev.h   |  84 ++++\n>  bsd-user/freebsd/os-ioctl-disk.h        |  52 +++\n>  bsd-user/freebsd/os-ioctl-filio.h       |  34 ++\n>  bsd-user/freebsd/os-ioctl-in6_var.h     | 226 +++++++++++\n>  bsd-user/freebsd/os-ioctl-ioccom.h      |  43 ++\n>  bsd-user/freebsd/os-ioctl-sockio.h      | 246 +++++++++++\n>  bsd-user/freebsd/os-ioctl-ttycom.h      | 239 +++++++++++\n>  bsd-user/freebsd/os-ioctl-types.h       | 109 +++++\n>  bsd-user/freebsd/os-misc.h              |  18 +-\n>  bsd-user/freebsd/os-proc.c              |  17 +-\n>  bsd-user/freebsd/os-proc.h              |  18 +-\n>  bsd-user/freebsd/os-stat.c              |  17 +-\n>  bsd-user/freebsd/os-stat.h              |  18 +-\n>  bsd-user/freebsd/os-strace.h            |  19 +-\n>  bsd-user/freebsd/os-syscall.c           |  17 +-\n>  bsd-user/freebsd/os-syscall.h           |  21 +\n>  bsd-user/freebsd/scripts/syscallhdr.sh  |   9 +\n>  bsd-user/freebsd/strace.list            |   4 +\n>  bsd-user/freebsd/syscall_nr.h           | 515 ------------------------\n>  bsd-user/freebsd/target_os_elf.h        |  18 +-\n>  bsd-user/freebsd/target_os_siginfo.h    |  18 +-\n>  bsd-user/freebsd/target_os_signal.h     |   7 +\n>  bsd-user/freebsd/target_os_stack.h      |  18 +-\n>  bsd-user/freebsd/target_os_thread.h     |  18 +-\n>  bsd-user/freebsd/target_os_user.h       |  18 +-\n>  bsd-user/freebsd/target_os_vmparam.h    |  18 +-\n>  bsd-user/i386/signal.c                  |  17 +-\n>  bsd-user/i386/target_arch.h             |  16 +-\n>  bsd-user/i386/target_arch_cpu.c         |  17 +-\n>  bsd-user/i386/target_arch_cpu.h         |  17 +-\n>  bsd-user/i386/target_arch_elf.h         |  18 +-\n>  bsd-user/i386/target_arch_reg.h         |  19 +-\n>  bsd-user/i386/target_arch_signal.h      |  16 +-\n>  bsd-user/i386/target_arch_sigtramp.h    |  16 +-\n>  bsd-user/i386/target_arch_sysarch.h     |  18 +-\n>  bsd-user/i386/target_arch_thread.h      |  18 +-\n>  bsd-user/i386/target_arch_vmparam.h     |  18 +-\n>  bsd-user/i386/target_syscall.h          |  16 +-\n>  bsd-user/meson.build                    |   2 +\n>  bsd-user/qemu-bsd.h                     |  18 +-\n>  bsd-user/syscall_defs.h                 |  50 +--\n>  bsd-user/thunk.c                        | 470 +++++++++++++++++++++\n>  bsd-user/x86_64/signal.c                |  16 +-\n>  bsd-user/x86_64/target_arch.h           |  16 +-\n>  bsd-user/x86_64/target_arch_cpu.c       |  17 +-\n>  bsd-user/x86_64/target_arch_cpu.h       |  17 +-\n>  bsd-user/x86_64/target_arch_elf.h       |  18 +-\n>  bsd-user/x86_64/target_arch_reg.h       |  19 +-\n>  bsd-user/x86_64/target_arch_signal.h    |  17 +-\n>  bsd-user/x86_64/target_arch_sigtramp.h  |  17 +-\n>  bsd-user/x86_64/target_arch_sysarch.h   |  17 +-\n>  bsd-user/x86_64/target_arch_thread.h    |  18 +-\n>  bsd-user/x86_64/target_arch_vmparam.h   |  18 +-\n>  bsd-user/x86_64/target_syscall.h        |  16 +-\n>  87 files changed, 2362 insertions(+), 1526 deletions(-)\n>  create mode 100644 bsd-user/bsd-ioctl.c\n>  create mode 100644 bsd-user/bsd-ioctl.h\n>  create mode 100644 bsd-user/freebsd/os-ioctl-cmds.h\n>  create mode 100644 bsd-user/freebsd/os-ioctl-cryptodev.h\n>  create mode 100644 bsd-user/freebsd/os-ioctl-disk.h\n>  create mode 100644 bsd-user/freebsd/os-ioctl-filio.h\n>  create mode 100644 bsd-user/freebsd/os-ioctl-in6_var.h\n>  create mode 100644 bsd-user/freebsd/os-ioctl-ioccom.h\n>  create mode 100644 bsd-user/freebsd/os-ioctl-sockio.h\n>  create mode 100644 bsd-user/freebsd/os-ioctl-ttycom.h\n>  create mode 100644 bsd-user/freebsd/os-ioctl-types.h\n>  create mode 100644 bsd-user/freebsd/os-syscall.h\n>  create mode 100644 bsd-user/freebsd/scripts/syscallhdr.sh\n>  delete mode 100644 bsd-user/freebsd/syscall_nr.h\n>  create mode 100644 bsd-user/thunk.c\n>\n> --\n> 2.52.0\n>\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bsdimp-com.20251104.gappssmtp.com\n header.i=@bsdimp-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=o5VPyNRb;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9x9Y232Yz1yJq\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 07 May 2026 12:32:33 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wKoWp-00010i-FW; Wed, 06 May 2026 22:31:55 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <wlosh@bsdimp.com>) id 1wKoWV-0008Pl-Ib\n for qemu-devel@nongnu.org; Wed, 06 May 2026 22:31:37 -0400","from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <wlosh@bsdimp.com>) id 1wKoWS-0000mu-SJ\n for qemu-devel@nongnu.org; Wed, 06 May 2026 22:31:35 -0400","by mail-pj1-x1031.google.com with SMTP id\n 98e67ed59e1d1-362e50b4641so178816a91.0\n for <qemu-devel@nongnu.org>; Wed, 06 May 2026 19:31:32 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1778121090; cv=none;\n d=google.com; s=arc-20240605;\n b=cNmJ5u31f2TS4tN6tc1IgRRIlnUSwOMyERh1FMvrIAPhiioIQFnwFjnLWwJHQCfzic\n vyN6Sr+fQP0If3kcRi60dG48P4bTvGkQOEV6W7krY7tJwyqTHjAX7hhCbsOE4NKEJ+C5\n cp+iKtUB9vV4BmymjYP8/dXkJ9F9EKN9XhX5jRLI/LakiRuGBD78u6ExSSwT2m0vjXCL\n yQwjt6rUyVkrNhi+Eg+1BXeTNu1ag/6taBItGSvWcIHQZL3SIWDcQe+FjhWMC0Hr9w1x\n tJoG5LAZqdcbWHFBS4vxl1QwkqenefyDD1HefbidQmdn41VlzXuARStZDi3ybjPPcbkJ\n 3xXQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=UaVZP/5PfmekL5G651lYBnZB6BDDsQk3jPNwZNgJZ4s=;\n fh=d9iMSPgxEhCILQ2/iXvh+ZORujpc1zkJihlswtOhKiE=;\n b=ZWbwaosD3o2OeAI/YPPCN71zciUDkkWE5PDhSv6yi5GrhrNs3b3Vcr/BgJ5gRmKQM+\n S0e9CN1vsinEDEx0fJs/X+OmFrbBUlTIWvXXi/m8RQWQ3VDarO/TrT84v+AM/GaQcnQT\n uXRzRG1s0Nb4R730ATAvSSoZpL/ZfzD2VahdQdKLYT/V0YUdi5WT6xTYQZvY0aJdqaki\n WrP3ZywbLpE5swsIEF341cr8sWeD0tx6ozHvjiH3WFdS2w2gBYeg4wQvfTEBK1A4JVMJ\n GISoUUBqXxLxT6GyYKGRmMC6nRl+BCbJk5mntdIEAlS9M2hJBqnYz4oG/7616Gu8L2no\n B88Q==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=bsdimp-com.20251104.gappssmtp.com; s=20251104; t=1778121090; x=1778725890;\n darn=nongnu.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=UaVZP/5PfmekL5G651lYBnZB6BDDsQk3jPNwZNgJZ4s=;\n b=o5VPyNRbBAmJ7GrIFmPq8kr9k3xm/kQxpWf/fT9eyVI1hQppaVCmPweZank1vCLyoh\n gS+C6fCNDe93h3EcL+vtsGc/3Po1rjlifr0MrpjOCxm+1TOyxyz88G8fYZgCF6jnd0kn\n lOP7gsUI0nMZrHr1xRK0Ob26hW6L4Lcg2rL0Ivy+bmdeojd6zjXqwL6X/ElymTO3aoOI\n OGut83M05RKy4HsJUa3Jl2ABTjdOhYCOvLXbTN7VkRkqeDk9amnxML5oz8249CwmVpoB\n KWFiPqSNklcAV3+Q/1f0D7epyWl6aWn/p8ToISSTcA8NFthiWySdhG6wlKxKZ/KvP6eC\n cMIw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778121090; x=1778725890;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=UaVZP/5PfmekL5G651lYBnZB6BDDsQk3jPNwZNgJZ4s=;\n b=d5bExnlrjT/iFFhUVCxKrQG7OIdak6lp861uYNNkeMhnUmbzrOzdypv6lLm8YG+yQq\n z+1quFDf51rMxXo9W0ARIT9FQ8TycaXvIi6EFnQbzDoYoKCoRtXKnn/PxY9RvEBxRu1L\n 57V23aO0hXtXD168fjMvq2mzeFdSny0uiDWrujEniG/nVpEAQRXvdFI6pgwBYN7YwWdp\n aD9FkNXXfk40Bf+ToaqeFKiBN+6773dOTvRgSWD1TU7V2rdJ4Veq+HuFGwZO90ZhBCxn\n LIpA8XNdkZ2GnxD7SOSrCzEQnx4F0M41a+aC0B5CPbvA8o7Qdvg5lwcZJcoPU9YPoqe3\n VmsQ==","X-Gm-Message-State":"AOJu0YxIY9BvMvRSRp0ypPXqd+Kbbb5GbtaJm3I8oWQ0Ppg07b2V61ai\n fCU1aF8R6TPtxM8iINeeNkIXQqDncoAgGtupatO59f+h5YHPFQXM1vu6qazyRtzcpFqyZT26zKK\n nQFeYKM/KCsqamasuTNYpZdHY4Q6ijflGa9xedQIqJdxvQzOVCETjWvQ=","X-Gm-Gg":"AeBDiet82OgYC6Twh6uQgYmCngzS0Dn00Mnft3oT5yKUDwPDHB+yemvpeKam1pOeHWA\n yAAULjL0H4HrqXZebkEoM7FABf0eZSl0badTyQus8zvCi+GpTtC97GoqtxjGnisiiOROyJ27Acy\n Y6xmnQeE4wvQ41DLN2saaQK2NvXl4ZVuJrNqNjGWGOSD9dKUk5g/ryumV+siBB9UjmYJopTUc3g\n cf1j6ELoiXQTCcCRj0qcqQ+yV88fnnmuctNzP+V6InvQiBaXA3thjd5c2RNFcRUWkx3F2gPzimL\n gXrqjyEaFBC545JhFg==","X-Received":"by 2002:a17:90b:548d:b0:35f:b647:d98a with SMTP id\n 98e67ed59e1d1-365ab9b8c53mr5273284a91.5.1778121089842; Wed, 06 May 2026\n 19:31:29 -0700 (PDT)","MIME-Version":"1.0","References":"<20260507022219.44171-1-imp@bsdimp.com>","In-Reply-To":"<20260507022219.44171-1-imp@bsdimp.com>","From":"Warner Losh <imp@bsdimp.com>","Date":"Wed, 6 May 2026 20:31:18 -0600","X-Gm-Features":"AVHnY4INytWIfzGJ1DhGesiPGg5aNQGH2zlNTZLNuhu7A1v2JPnX6KMgfr5hgPY","Message-ID":"\n <CANCZdfpzNBZv4XseC0KWkVHaPwCRRNgS9sWAHeCrZusqP3V=1Q@mail.gmail.com>","Subject":"Re: [PATCH 00/25] bsd-user May 2026 pull request","To":"qemu-devel@nongnu.org","Cc":"Kyle Evans <kevans@freebsd.org>","Content-Type":"multipart/alternative; boundary=\"000000000000ed94020651311348\"","Received-SPF":"none client-ip=2607:f8b0:4864:20::1031;\n envelope-from=wlosh@bsdimp.com; helo=mail-pj1-x1031.google.com","X-Spam_score_int":"-18","X-Spam_score":"-1.9","X-Spam_bar":"-","X-Spam_report":"(-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001,\n SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]