[{"id":3687501,"web_url":"http://patchwork.ozlabs.org/comment/3687501/","msgid":"<177813267023.2413233.14054842879891768294.b4-review@b4>","list_archive_url":null,"date":"2026-05-07T05:44:30","subject":"Re: [PATCH 0/4] qapi/net: Some doc improvement and cleanup","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"content":"On Wed, 06 May 2026 12:54:17 +0200, Markus Armbruster wrote:\n> qapi/net: Some doc improvement and cleanup\n> \n> This series replaces useless documentation by hopefully useful one.\n> I'm not familiar with this stuff, though. Please review critically.\n> \n> Markus Armbruster (4):\n> qapi/net: Rename NetDevPasstOptions to NetdevPasstOptions\n> qapi/net: Wean passt off QAPI type String to improve documentation\n> qapi/net: Wean SLIRP off QAPI type String to improve documentation\n> qapi/net: Drop unused type String\n> \n> [...]\n\nReviewed-by: Marc-André Lureau ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=UBnrayK/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gB1S93JKtz1yJq\n\tfor ; Thu, 07 May 2026 15:45:27 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wKrXY-0003uo-0M; Thu, 07 May 2026 01:44:52 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKrXU-0003uJ-Aj\n for qemu-devel@nongnu.org; Thu, 07 May 2026 01:44:48 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKrXS-0008Eg-JS\n for qemu-devel@nongnu.org; Thu, 07 May 2026 01:44:48 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-421-DfhDvglVOk-GRqeBkZgReA-1; Thu,\n 07 May 2026 01:44:40 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 8B0CB180034A; Thu, 7 May 2026 05:44:39 +0000 (UTC)","from localhost (unknown [10.44.24.4])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 42CB219560A2; Thu, 7 May 2026 05:44:37 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1778132684;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=pkYT8AJCKe/BtrSvl49OoUVBpR09Ib8DOCTqPdFKQeE=;\n b=UBnrayK/ShipON9xlxougnb2/9ng5NwHh5bh5Eu5NDz/zy+oBhNLocik/ZOUSF0ZbCsM9c\n WpBE6n/RS/TcmVWe8WiRyXs5lyuFTrcSXuBf4zbCcgibR53ofwx6xRWWZrMEp+nq67vnkp\n 33ekJ6/VCE/Is3y+hNb6OVbRlFeQbq8=","X-MC-Unique":"DfhDvglVOk-GRqeBkZgReA-1","X-Mimecast-MFC-AGG-ID":"DfhDvglVOk-GRqeBkZgReA_1778132679","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Subject":"Re: [PATCH 0/4] qapi/net: Some doc improvement and cleanup","From":"marcandre.lureau@redhat.com","To":"Markus Armbruster ","Cc":"qemu-devel@nongnu.org, jasowang@redhat.com, lvivier@redhat.com,\n sbrivio@redhat.com, samuel.thibault@ens-lyon.org,\n marcandre.lureau@redhat.com","In-Reply-To":"<20260506105421.2461117-1-armbru@redhat.com>","References":"<20260506105421.2461117-1-armbru@redhat.com>","Date":"Thu, 07 May 2026 09:44:30 +0400","Message-Id":"<177813267023.2413233.14054842879891768294.b4-review@b4>","X-Developer-Signature":"v=1; a=openpgp-sha256; l=686;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=O7IAiP5mJ8G9d8IwTJTaa+EMlY12BhaZGIyafevvuLg=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp/CbBdfNDVhnYyPGoseEY0aKMfMMkE8LSiFOfb\n avDb6LVIv6JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafwmwQAKCRDa6OEJdZac\n 5XmpEACdsAsq2XCcXZB2Z+/bAN+nf8/EzR0EvOuk0LVRz9HM+u8MLd/1tomvsTKEezJ+p3Ct7DH\n C0Hwng0cptYSUz67dNmPIC8SHJcOkFR49GX17JV5nJRlkas6yHdipy8exOrkZyrfU/x2E4Bpc74\n oms0hmJgMFaB4/zJzdWLnw3FowM5s3I98uVwivhcOfmmyZO8dThLwdhfWB5iwo/B+2fm/nO7vPH\n 988vp48OPdhB+9fPxGmZzcvKRXTB3+pYRsvwvYM3d/k95F7cTv4EXzDE/Ux0MPJrOUgEugiAJUE\n bMGTaC0PANUyuiKfMrn8j4Te5chhnT090PzPSkJpTzerZVYBJRLbKmZTS0DTQObPXHR/yBSdBes\n GjtSjHZnOrJ3TggUgzRdSIcce6mUDRgX/wLN7oyFdApKBKeB05lX3BzQW4j2xo03Z66AbyQ3yqF\n Mb+2hDY94qIhOnAIk3gzCtb6CLvtDHUd4+IyXo/6ivuC5rsotcx2iBnKJTXBLbEPT8qN1/DM1YE\n bQWHQv1Yb7fzjg6pkOrSKgs7HeFGJE80rfCDYgHqYUgfoi0nuIgR+AhS47bUhykDsmxLaKSmAko\n rfceAkZBNkQyQxnpHwHhOKaNqkTsiNdarIAX/87tUkHRP/qISREEje0v5/2xKhyH0UORVPeCHTp\n ZNPo69zEnXpnSHQ==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-24","X-Spam_score":"-2.5","X-Spam_bar":"--","X-Spam_report":"(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.443,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]