[{"id":3689661,"web_url":"http://patchwork.ozlabs.org/comment/3689661/","msgid":"","list_archive_url":null,"date":"2026-05-11T20:23:16","subject":"Re: [RFC v1 0/4] generic pinmux dt_node_to_map implementation","submitter":{"id":92050,"url":"http://patchwork.ozlabs.org/api/people/92050/","name":"Linus Walleij","email":"linusw@kernel.org"},"content":"On Wed, May 6, 2026 at 11:58 AM Conor Dooley wrote:\n\n> Whipped this up last week, at to a first glance it appears to work,\n> although the spacemit platform I've used to implement this has very\n> limited in-tree use of pinctrl so it is hard to be sure.\n\nI like it, if it wasn't RFC I would merge it.\n\n> What I don't love though is how similar the functions\n> pinctrl_generic_pins_function_dt_node_to_map() and\n> pinctrl_generic_pinmux_dt_node_to_map() are - essentially identical\n> other than which function they in turn call.\n\nHm we can maybe think of something more descriptive\nto the first one?\n\nI think the new function is very much to the point. That's what\nit does. pinctrl_generic_pins_function_dt_node_to_map() could\nperhaps be names something that make it evident what is\nspecial about it. Not that I have a good idea.\n\n> Basically, I wanna know if you think that that is acceptable,\n\nLooks Good To Me (TM) no-one else is helping out with pin\ncontrol core work so I'm happy for everything I get.\n\nYours,\nLinus Walleij","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=RpB8bRJB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-36619-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"RpB8bRJB\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gDrnq6NLvz1yHW\n\tfor ; Tue, 12 May 2026 06:25:35 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id E663A306CC7C\n\tfor ; Mon, 11 May 2026 20:23:29 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id C0A5037FF71;\n\tMon, 11 May 2026 20:23:29 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 83DFF37EFF1\n\tfor ; Mon, 11 May 2026 20:23:29 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 421AAC2BCFA\n\tfor ; Mon, 11 May 2026 20:23:29 +0000 (UTC)","by mail-lf1-f45.google.com with SMTP id\n 2adb3069b0e04-5a86e4b950cso3456382e87.0\n for ;\n Mon, 11 May 2026 13:23:29 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778531009; cv=none;\n b=OlaNRnNVTmrMa28E3TIvqEMFLSL8lLs8W5lu4VbJGxIBdxQqsa/4c+hPRt4KnKMTxsCNx4HRBNGVpIJ6icw/cbBIZJ1A4t0gdJzUMRZTgLgZZ/Zyw+LcqDcCJsN3gUOs4DSLpmBifAzktuMeibvSe1/i6Nax24S6piZsBZNKrcY=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778531009; c=relaxed/simple;\n\tbh=Mw4otLNufcyiPgx5PCsJEXIfpLTfBs5wWkfpUHwyxKU=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=WED2fgRVHuXvKbZWA+5o3nURNGQPVwKQ1hL3ZUd/FnoGmMENxkj6nVczhXh2xetP7Ve+T8ALtoU5Brx28mEs4/81f0emBidG5IncUj09mJdSkhPWx46Q82TjwvqtLnBPqGZlfEYsXt8W3bn3wGuDvy6eUwhpMBrLHCZO62WIap8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=RpB8bRJB; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778531009;\n\tbh=Mw4otLNufcyiPgx5PCsJEXIfpLTfBs5wWkfpUHwyxKU=;\n\th=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n\tb=RpB8bRJBrzCFTAcznf4QzQZ6HV51QKaF/wUVny/T7vSt4QbDQhfgY8yHCbhfo8who\n\t wSkiD4jLIU28+QrFV5AQ/6jJKTLxWPnSzIinbDpZlydktxvHP85UrE+iAzdtBrcIOz\n\t YPIfsralVeWzkm3yMuJGxQ91txZOG2Z4d2B4p2X/R5wsSzwWHIgTQqNOZa5yHXdHxC\n\t 0lHUVEdGcUgG0qlJYi8OmEi5e1UzZ5toWZj7/VQiL1nNqmZWSigpBSvBxQcu8mQzRC\n\t PDzVNShCCiQhBPyG4xT+bvICDwXfi//ciGSpP2H6mzXEao7JyJJE5uyhX6fp1AclQ7\n\t 8P4R055DdnIIQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8ydFRxxeLTrNSJ6JGKMneG+dBWidzVqLfrMYG6WfGX7NZv1RzzuDF+ObY4hNI/m5y1gW40GGIQIvUf@vger.kernel.org","X-Gm-Message-State":"AOJu0YxVj+ZNhLKifhDVw693Oje6NpjxAt6+46eHaODw+Ph0RHv5QyuP\n\th4QqoJSV08oP52K/vwuzeIYkZAFhQKPn0HsLaoUoPaqX+ddZX0bPidtMzgPTTWlJy8+GnRA0fcF\n\tkazCS6r51PGjGgvqr/Rr/yVCHoEr6zmw=","X-Received":"by 2002:a05:6512:114b:b0:5a8:6c7b:f9d7 with SMTP id\n 2adb3069b0e04-5a8e31f5ff3mr23278e87.41.1778531007946; Mon, 11 May 2026\n 13:23:27 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260506-energize-dramatize-051909e54256@spud>","In-Reply-To":"<20260506-energize-dramatize-051909e54256@spud>","From":"Linus Walleij ","Date":"Mon, 11 May 2026 22:23:16 +0200","X-Gmail-Original-Message-ID":"\n ","X-Gm-Features":"AVHnY4IP4KN4sVQQCZ4yBVMA5cS0ZkPLASNGKB7mSTEskh3Q63aPn5iBQgOAutg","Message-ID":"\n ","Subject":"Re: [RFC v1 0/4] generic pinmux dt_node_to_map implementation","To":"Conor Dooley ","Cc":"Conor Dooley , Yixun Lan ,\n\tTroy Mitchell , linux-gpio@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,\n\tspacemit@lists.linux.dev","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]