[{"id":3688371,"web_url":"http://patchwork.ozlabs.org/comment/3688371/","msgid":"<67e673f2-8bc6-4461-8fb0-95c59f5573ca@cherry.de>","list_archive_url":null,"date":"2026-05-08T12:01:32","subject":"Re: [PATCH v2 0/4] binman: Tidy up some missing bintool docs","submitter":{"id":88462,"url":"http://patchwork.ozlabs.org/api/people/88462/","name":"Quentin Schulz","email":"quentin.schulz@cherry.de"},"content":"Hi Simon,\n\nOn 5/5/26 8:12 PM, Simon Glass wrote:\n> Some of the bintools are missing documentation. This series adds the\n> missing pieces to bring things up to scratch.\n> \n> Changes in v2:\n> - Add patch to route PKCS#11 test fixtures through the bintools\n> - New patch in v2 (per Quentin's review): replace tools.run() of\n> softhsm2-util, pkcs11-tool and p11-kit in ftest.py with the\n> Bintool.run_cmd() wrapper that already exists\n> - Reword the docstring per Quentin's review: binman uses this bintool\n> only as an availability check, not for runtime PKCS#11 operations\n> \n> Simon Glass (4):\n> binman: Flesh out the p11-kit bintool docstring\n> binman: Flesh out the pkcs11-tool bintool docstring\n> binman: Flesh out the softhsm2-util bintool docstring\n> binman: Use bintool wrappers for PKCS#11 tools in tests\n> \n> tools/binman/btool/p11_kit.py | 11 ++++++-\n> tools/binman/btool/pkcs11_tool.py | 11 ++++++-\n> tools/binman/btool/softhsm2_util.py | 12 +++++++-\n> tools/binman/ftest.py | 46 ++++++++++++++---------------\n> 4 files changed, 54 insertions(+), 26 deletions(-)\n> \n\nTechnically the docstring in patch 1 to 3 is incorrect now that we have \npatch 4 and we use the bintool to call commands on the wrapped binaries.\n\nIt's a detail and I don't have anything else to suggest for rephrasing.\n\nReviewed-by: Quentin Schulz \n\nThanks!\nQuentin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=cherry.de header.i=@cherry.de header.a=rsa-sha256\n header.s=selector1 header.b=dCaX8+d9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=cherry.de","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=cherry.de header.i=@cherry.de header.b=\"dCaX8+d9\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=cherry.de","phobos.denx.de;\n spf=pass smtp.mailfrom=quentin.schulz@cherry.de","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=cherry.de;"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBnly2KSmz1yJq\n\tfor ; Fri, 08 May 2026 22:01:50 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 6B4BE84B1E;\n\tFri, 8 May 2026 14:01:42 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 0FCCD84BBD; Fri, 8 May 2026 14:01:41 +0200 (CEST)","from MRWPR03CU001.outbound.protection.outlook.com\n (mail-francesouthazlp170110003.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c207::3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 31A1584A75\n for ; Fri, 8 May 2026 14:01:39 +0200 (CEST)","from DBBPR04MB7737.eurprd04.prod.outlook.com (2603:10a6:10:1e5::22)\n by VE1PR04MB7406.eurprd04.prod.outlook.com (2603:10a6:800:1ae::13)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.19; Fri, 8 May\n 2026 12:01:34 +0000","from DBBPR04MB7737.eurprd04.prod.outlook.com\n ([fe80::5960:fb4b:9313:2b00]) by DBBPR04MB7737.eurprd04.prod.outlook.com\n ([fe80::5960:fb4b:9313:2b00%3]) with mapi id 15.20.9891.019; Fri, 8 May 2026\n 12:01:34 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=equpJxmA/C5mM367KT9rrArgsxO2OjdyAs5bf40E27E/X222Vi4lacVcR8gzxa0pJf7iHwHNFS57lRfodx2Cp3CALiexHgTFlG8NcAIaF2SZnubPjUyqczYu6nXTG15XvF4jscsNISyln7rL7z6UiT/dBRcnBBF0eCiuBM8iZeLu/gbKH56x2I3AWJ39n7Pggvw2mJ29VAvgf8u4bF7VFQ8Lp1zNAyYbsSaBJYODDXHpjEBu2qDhZQSuRTomFfeFasjduJAqKs0ITin5OzCApAT2jJDue34OaTMiYsUMfYCXTLRSEzsEFv1A+JxbIjCYFQL4FYL+3YR76l4D999iwA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=YutQPyOCYqjjTLBHpATG4TViUn5o7vsV1GJ5M0/7Hxc=;\n b=nJwO2C80yYiOiHlNtBd9BW9R/kPoiuSyATX8yj3eEqPnNQmpjnsd5eCY8KencawEyfY5RfAhs2WsqgW02gGdE1RpvbnwU+NmSUCHdeB2OEUMqa5QvTyRWS10LH9UGZr7wVdOfaLB3mTLSZoNo561ppTU+EdO1h51k2KvIaRLUvkyk8y/4JQjG05eHl/6sbbL2xx5FvlETK8eAv8SmDNi2MJaDqThy8IUdAm5h5UkBVCMlwQsR/BKJA6kEf/5Dy4cLGwTJ49UfpgQp5xIRoqHAfPbKXJ/PyKNYHxl3Nb54hL9DdA7dQhEvP9GTx3+mcAzTGHNwmmpqpfxr2D/YpsiIw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=cherry.de; dmarc=pass action=none header.from=cherry.de;\n dkim=pass header.d=cherry.de; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=cherry.de;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=YutQPyOCYqjjTLBHpATG4TViUn5o7vsV1GJ5M0/7Hxc=;\n b=dCaX8+d9Omm7OyaqB6VlcNv/SHFRCCw6MikccoXcoawy0rVgMbyBoMEmAITZT4/2n2x9FsEsyPed0jIe0v9hF8K9HCy7C8jsKGDjoSdE+wWXPOj0Ne8EbhKgAAbV5ivuO3Arpd5lN0Qg1T0dJZKxH3ksTR3Xfv7NlZbaAkEfnG4=","Message-ID":"<67e673f2-8bc6-4461-8fb0-95c59f5573ca@cherry.de>","Date":"Fri, 8 May 2026 14:01:32 +0200","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 0/4] binman: Tidy up some missing bintool docs","To":"Simon Glass , u-boot@lists.denx.de","Cc":"Heinrich Schuchardt ,\n Alper Nebi Yasak , Bryan Brattlof ,\n Neha Malcom Francis , Peng Fan ,\n Philippe Reynes ,\n Stefan Herbrechtsmeier ,\n Tom Rini , Wojciech Dubowik ,\n Yannic Moog ","References":"<20260505181300.223439-1-sjg@chromium.org>","Content-Language":"en-US","From":"Quentin Schulz ","In-Reply-To":"<20260505181300.223439-1-sjg@chromium.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"FR2P281CA0117.DEUP281.PROD.OUTLOOK.COM\n (2603:10a6:d10:9d::7) To DBBPR04MB7737.eurprd04.prod.outlook.com\n (2603:10a6:10:1e5::22)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DBBPR04MB7737:EE_|VE1PR04MB7406:EE_","X-MS-Office365-Filtering-Correlation-Id":"35c4e345-2029-4b5a-d66f-08deacf98cce","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|366016|7416014|376014|1800799024|3023799003|56012099003|22082099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n mGKwGtn2u+cnhXQl5WH71PGujAO3/nW5SaDtFwPaY+lDXjQD7/m3iUcuPXvo4MXu5ert52rmqVepk4TBcGObJGDy2xWjyVcK7LCULJnG5xJnrOJZK1vJTqIAXBuqjJPcZNwLIIQxGcNz0b6AqLQAkJz+5I2vWnOuxiSBk1WlhiPsY15P91dwT9Nzykzim5bVJ8xBNXGzV+ZNIZXRcQeMy7vv8onmPeMjtPur3nMdRPec9495zToZWUdIXciD5CzG2mxL0Em/fDGSsPEwwsE0ccK4ZgNDmtZRURAP7+4tRfdgwNs0iYWQoZL1o2UAJHL+Xd33LslpJ8xw/7Yhd4ln1hDcLTz7VcvkfBezrnJP7/f2eFXNh9/PkX/x2tlo3i2Tm9qT9KEdJObuFmheqM7+yaREoI7cAeZx2JUwEbvhNoItZIFKJlvl5wOIed0ITp3SYNL2EdGbtbV53s7vAAorjChEndAQ2hasNl51fny26aqrjjTyg4gSAWTsX8EJGs20iGvpPOv8T6m16CxWCfI4q+zhn8ymHkOwZxrg0rwogI9lseYN0FQ7IHemCqRCO6//4liD7SLliAdPls/WhuuNhkEcSYqjkSTCvxI3JXy5NmCN8MupXusu1zPQ5iW1KbKHNY0/VoDslL84TFk0paLTEB08nTOgYpm4y1V9nDur+V0QGr3JjEyVL4HsAXeFUEK5","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DBBPR04MB7737.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(366016)(7416014)(376014)(1800799024)(3023799003)(56012099003)(22082099003)(18002099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?EGEdVsaXxAgEFMV5OwFIrbgD9Q6B?=\n\t=?utf-8?q?7u8KPHflpyg6Lb7QxqW9n7YCVpzaoGK58iGI0MJH1ZO6sTnOQoE/LtIR7+uTcJEXd?=\n\t=?utf-8?q?mXHK7sG/WeowLEV2zOt8LoP9FD+7tn0LprrsRvnHcWTRdOHNwhK9F3H1UxhCHDT9B?=\n\t=?utf-8?q?nSpVl5HFjNg2/DvtynVz7L0noofmXbJh6Nr/NxW2r0oy30kKutPgkNSnrvFzl7a2K?=\n\t=?utf-8?q?VdX//ZJU7hWwPRaOgTCwPolS0fIaSl2dPuAxfPXDnIrs2CTn4XWo4hLxfY+xzMDPR?=\n\t=?utf-8?q?cIqHwMDWpAqlifQh8OzI4/P0+1iK2wx/GfD+zEguQvyMvN6pHIUwWot6yEllsEgjQ?=\n\t=?utf-8?q?4TK9YIIV3898NpXqvSlXgQYcFNzH9A8bcABBqqlidesbwZludXU6ujUUDWJGg4jV7?=\n\t=?utf-8?q?s748+1WYMw/aMhjPWz5DQnxytL2YazaEDVIL8qFYzsQ9eA87ecg7X9EvZUvtHA6C9?=\n\t=?utf-8?q?1dMccs8jIT/XBVXgo5OVGdcLkaFWZZZp1ygC8m6JwnichvArzik/nZEnZyQjMvkG4?=\n\t=?utf-8?q?jeUEO45hQNvAa8SLipI5DtGY94H77yVLKjMvnyECorSdwenumFXoRCpBZ1Okx7vwM?=\n\t=?utf-8?q?okRcHqcO8BVBfBpIxsfKXGBGRE2ypM9RICfddeJ/hFr8124ynSH8/pk2iE4uAbW8T?=\n\t=?utf-8?q?UcvrEHgmsSOAeorqXeCc2lyfPeIPMPpQKVr7Zmj9Vb+uMRjwmB+zEH1MOOT4qv4zR?=\n\t=?utf-8?q?+9Osf36LPwmy16kO30Or4uLEr+3GYGwyILzikHevDKi/3IxUW144AzXFjAFPtzKhN?=\n\t=?utf-8?q?pNXlpsXT5lZXaoGZoSFbyw/7CRSQW3TYPDfYeiY1Ar2KLXrlH3FghHYx5Ea2LfEuI?=\n\t=?utf-8?q?7b3iUJ5ai1b6SzFq3C/PFXzAEhrD9eaBJEGmSAiKvw+QGTgP32zJohVkSxf26Kxsq?=\n\t=?utf-8?q?2eZ2TdabA0SNVxhzbPKaZc+w2tstkUTarVoxtsOSC6Qgbc35N9sTQ2xDkAkp9g0AO?=\n\t=?utf-8?q?BwmG8noRT85O6ie5qv8G7/MzJlgvZtL5GqSbniCf80zYShg5bEBR+Cr+TRCnvvxLh?=\n\t=?utf-8?q?9pN9un6RnD52jMlSd3mC2B/XxEniGzaT/LZ4QfuAVNKzi98DWlyyPur70xn7ECvKC?=\n\t=?utf-8?q?W2jY0OkFiNThRd7VWCrbGOfTQ1O6QgOxs2tVjYQDax3rz/YKUPFmjSy1E8cP0JXgS?=\n\t=?utf-8?q?c8lroqqdvFR9z8awrPpx0u+0Ta2Jab+0n2vrNHQbbaCYF+6TVkyt6ZNN1L0yW6u1v?=\n\t=?utf-8?q?TLH0VsQjJWgtNcdh9QSyPS3nD1FMbYPx57RD68tWzQeJoHleTAYcq5FBgLxeaZrB5?=\n\t=?utf-8?q?q23w8hiVRqKXf2YOtul3LXAvKwR9sgdhCL2No87j0eEtQmhQ7bz5U6AxNQsMsM1kP?=\n\t=?utf-8?q?alnoLDzsLN7oPEPl0jn2osWptMLTAP2izYZqk4JhcvH9tbXpneJFN0Cs+CFeBcOCL?=\n\t=?utf-8?q?c6RfQjY7Sw4fbLl8bUjXHVnjvLqZVs6UBJXdovE30KgAKcTz66+oggeQNm1GSgDkq?=\n\t=?utf-8?q?NhuE1oHM3gTm2hZhbfBKbBI298OC1CX+fYldpwo7dhROTGZ4tBsTMuniDcO8Onz+i?=\n\t=?utf-8?q?YydV1EktjvgBRpb0a+T7JlSoD9JgGBRjZ4HvVuP1+yIFR3Pc/Smosi24hzyb7U+5+?=\n\t=?utf-8?q?MOeHmHxf5yN2vUmSGYJrvRyEVviNItDsAluuVGWlVRhlahEkaCtj17gr/30t1FVfF?=\n\t=?utf-8?q?ln+o9tj+j5hFkmf1K5RmNxZVL4nj26fg=3D=3D?=","X-OriginatorOrg":"cherry.de","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 35c4e345-2029-4b5a-d66f-08deacf98cce","X-MS-Exchange-CrossTenant-AuthSource":"DBBPR04MB7737.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"08 May 2026 12:01:34.4540 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"5e0e1b52-21b5-4e7b-83bb-514ec460677e","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n rZGV44sRTb3C9GZN5FyUJ1WnPDQwHieiSg5wfR5/5nYoYgJnyVgHJ6MGZNxLfJLSaDO66dL7GPTfoWim6/EwCoTHFharw5ZlTcxCkHj6NC0=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VE1PR04MB7406","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]