[{"id":3686476,"web_url":"http://patchwork.ozlabs.org/comment/3686476/","msgid":"<40dde65f-9dc6-465f-a053-31a90d75fce1@linaro.org>","list_archive_url":null,"date":"2026-05-05T13:47:30","subject":"Re: [PATCH v3 0/2] cmd: ufetch: print Net feature when NET_LWIP=y,\n prettyfy if NET=n","submitter":{"id":90679,"url":"http://patchwork.ozlabs.org/api/people/90679/","name":"Casey Connolly","email":"casey.connolly@linaro.org"},"content":"On 05/05/2026 11:14, Quentin Schulz wrote:\n> Make sure the Net feature is printed when NET_LWIP is enabled, not only\n> when NET_LEGACY is.\n> \n> Only print comma and following whitespace as separator if there was a\n> feature printed before feature to be printed.\n> \n> Signed-off-by: Quentin Schulz \n\nReviewed-by: Casey Connolly \n\n> ---\n> Changes in v3:\n> - migrated from bool plus ternary operator for setting the separator per\n> printf to a const char* which contains the separator to print, as\n> suggested by Simon,\n> - Link to v2: https://patch.msgid.link/20260504-ufetch-net-v2-0-01bec4ca7169@cherry.de\n> \n> Changes in v2:\n> - added R-b trailers,\n> - fixed spurious colon character before separator in cat,\n> - Link to v1: https://patch.msgid.link/20260428-ufetch-net-v1-0-5d58c7618239@cherry.de\n> \n> ---\n> Quentin Schulz (2):\n> cmd: ufetch: show net feature when NET_LWIP is selected\n> cmd: ufetch: only show comma separator if there was a previous feature\n> \n> cmd/ufetch.c | 29 ++++++++++++++++++++---------\n> 1 file changed, 20 insertions(+), 9 deletions(-)\n> ---\n> base-commit: 57460fde4ba84d67de4066ee1141e89e8139ed23\n> change-id: 20260428-ufetch-net-1ba7553a20c7\n> \n> Best regards,\n> -- \n> Quentin Schulz \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=xTlw0AoJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"xTlw0AoJ\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org","phobos.denx.de;\n spf=pass smtp.mailfrom=casey.connolly@linaro.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g90FR1XM9z1yK2\n\tfor ; Tue, 05 May 2026 23:47:39 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 0D43184943;\n\tTue, 5 May 2026 15:47:37 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id C67DD84944; Tue, 5 May 2026 15:47:35 +0200 (CEST)","from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com\n [IPv6:2a00:1450:4864:20::32e])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id A6858848B9\n for ; Tue, 5 May 2026 15:47:32 +0200 (CEST)","by mail-wm1-x32e.google.com with SMTP id\n 5b1f17b1804b1-4838c15e3cbso43234905e9.3\n for ; Tue, 05 May 2026 06:47:32 -0700 (PDT)","from [192.168.1.36] (p4fc3dd86.dip0.t-ipconnect.de.\n [79.195.221.134])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48d17ff35f9sm19256955e9.15.2026.05.05.06.47.30\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 05 May 2026 06:47:31 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777988852; x=1778593652; darn=lists.denx.de;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=gatpzQrYyM4GPxVUMdc9l7bPDpLn0PU+92EL5xPFZFg=;\n b=xTlw0AoJH+3qWqOZPLSeWWiAaf7aPcsv1tcD95qU526xPBdFksXX0AiS8my3BSqJTP\n 72TsovOTRwxbyNOFE2fQsO3uj5HObvt7CvXvy1TMPG+oWArNemNcqh0iKXOg3LA8SaeQ\n y0ze99s5Nk9MVi6QOAa2SO/QKLjUZywwZoyC3t++ZwxiXUBPP7za+DqqhC1XNoFiE5Lu\n rb+oXvIdysPwF32uXdAP0t9800shvccCwzjH2LPmmNPhzMemRXnUdNWLIvrh1vcsYgzN\n uIyk83vO4SqVHv6FySU2+V8FoAfW5rxl2P21ttWwWTs0IkPH0qS9uhP2dvNdmjkfGNx9\n /1Pw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777988852; x=1778593652;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=gatpzQrYyM4GPxVUMdc9l7bPDpLn0PU+92EL5xPFZFg=;\n b=YeGt4L4QrnO0ZgJ93dZ5B0Qb6VtEHkIvDFO+poHvDfIeVkYmVkb43E2+8bUhJcKY9A\n EcvkYYXNnb+J6tZalOllPCfJC0QMtR/l1hM2vDNOkciFuDgX5OpxavXjSohQy1YketH9\n 4/6boMoYwiTRPXRoGjW1oZZ+66OVtcc4vNwHhSfqUyqmNfrDxUMO/XHz6ztgn+CTgK85\n 6Vd+xFsnSLMGeqre68c4rF3JpxgQ4Wk/kCOWi5VwDoeMEF2rlogZep2POtYNjkxL5xuc\n ujKiDc6o5alORWIZqdQ7juDuk2tntMr6myDrczlpUARlo4WxMEsIcqeje6D7wzhGHVut\n 7znQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ856741ezmDUzMGg8qMHYB2LEU1FOOLcEE6+kwvlTP4OXKaqwI/tu7Tn3dUO0rgYCzwT1UpONM=@lists.denx.de","X-Gm-Message-State":"AOJu0YxlSMC/LOq7cOADA0RhX6OXzvdQw3//Nb09T8jrQrfluOfuX367\n uUcoJcKfi7p8Apv/taF2+aU02YdrYUWUiLiwZwVzXXSsq+/63o+18zNosIClnVXSNM8=","X-Gm-Gg":"AeBDiev/V1K2nKmBb6WxFNUIaNXS5i/C5vOD+1Ppl6/0tNykC3y1DF/XsbNu7pvB9Bn\n wgGB4mYCADkOLQJfn2i+a/xiLKN4v4qw+tXCPYUcQ+q2OjMs/VOZuuyGCHMFYCJ5Q6kDpMTX8go\n iaINdsE6YvDD1dkVv3jvQdjk/jmTu4wlSNOES5cNQvZhKW5ZyoO59aOZxah+5zYTqdRhBHtNyWH\n m23ryYkZSM1ZlYlvouub9fHXjdgfi5XwcwjOKu8u00/mzbz3rhnOHrdurla3VUfi2KKRpflEk+K\n HL+ay5QoTgL3XEPT7AnV9EP2GU+KusO798vz8fV+NxMaQOd8UxEgBPu68RsHSJ3vUHN0yuIk/5S\n dNGWobXE7fBQS8JIU38g8IZQTVNKp8pNzbMPU0seyvnMgQefSAmg2f98fPHIwDgJx6IxnkRlUax\n /dtjJhuG3P9iABiwAZe37bH+qmDDrEL6vJqdkzxpeSv3zgS2U1aVsxePxiF/5Pe2Gh2Fg30Cv/s\n P9a","X-Received":"by 2002:a05:600c:1551:b0:48a:58ae:9938 with SMTP id\n 5b1f17b1804b1-48a98663ca6mr230548025e9.19.1777988851939;\n Tue, 05 May 2026 06:47:31 -0700 (PDT)","Message-ID":"<40dde65f-9dc6-465f-a053-31a90d75fce1@linaro.org>","Date":"Tue, 5 May 2026 15:47:30 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 0/2] cmd: ufetch: print Net feature when NET_LWIP=y,\n prettyfy if NET=n","Content-Language":"en-US","To":"Quentin Schulz , u-boot@lists.denx.de","Cc":"Tom Rini ,\n Ilias Apalodimas ,\n Andrew Goodbody ,\n Peter Robinson ,\n Heinrich Schuchardt , Simon Glass ,\n Quentin Schulz ","References":"<20260505-ufetch-net-v3-0-eee5eb9ca5ce@cherry.de>","From":"Casey Connolly ","In-Reply-To":"<20260505-ufetch-net-v3-0-eee5eb9ca5ce@cherry.de>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3686502,"web_url":"http://patchwork.ozlabs.org/comment/3686502/","msgid":"<177799046931.839461.1297387191363695345.b4-ty@b4>","list_archive_url":null,"date":"2026-05-05T14:14:29","subject":"Re: [PATCH v3 0/2] cmd: ufetch: print Net feature when NET_LWIP=y,\n prettyfy if NET=n","submitter":{"id":90679,"url":"http://patchwork.ozlabs.org/api/people/90679/","name":"Casey Connolly","email":"casey.connolly@linaro.org"},"content":"On Tue, 05 May 2026 11:14:30 +0200, Quentin Schulz wrote:\n> Make sure the Net feature is printed when NET_LWIP is enabled, not only\n> when NET_LEGACY is.\n> \n> Only print comma and following whitespace as separator if there was a\n> feature printed before feature to be printed.\n> \n> \n> [...]\n\nApplied, thanks!\n\n[1/2] cmd: ufetch: show net feature when NET_LWIP is selected\n https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/b586802913b4\n[2/2] cmd: ufetch: only show comma separator if there was a previous feature\n https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/b61bf7f71dfa\n\nBest regards,","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=hDSJ6j8o;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"hDSJ6j8o\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org","phobos.denx.de;\n spf=pass smtp.mailfrom=casey.connolly@linaro.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g90s85VS2z1yJx\n\tfor ; Wed, 06 May 2026 00:15:08 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 4B928848B7;\n\tTue, 5 May 2026 16:14:36 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 89512848B7; Tue, 5 May 2026 16:14:33 +0200 (CEST)","from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n [IPv6:2a00:1450:4864:20::329])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 4FE1984954\n for ; Tue, 5 May 2026 16:14:31 +0200 (CEST)","by mail-wm1-x329.google.com with SMTP id\n 5b1f17b1804b1-488d2079582so56596085e9.2\n for ; Tue, 05 May 2026 07:14:31 -0700 (PDT)","from lion.localdomain (p4fc3dd86.dip0.t-ipconnect.de.\n [79.195.221.134]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a8eb3427fsm581408135e9.0.2026.05.05.07.14.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 05 May 2026 07:14:29 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777990470; x=1778595270; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:date:message-id:subject\n :references:in-reply-to:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=vZpKNg+hDdxRK/HKYZJ0dsJdkYfrL2j1P+QKCHsU5x8=;\n b=hDSJ6j8oL9W+7qzZj0mDE267BGFE1iDp9+da6UaXHNEWlQNfghWghrgUeT7EFiyUNM\n wY1q9HtQf2ABuvJgtpz9s5VQ6Zq4MoOZorDA7zp/M8bL+E2Tep1b3b4IgTWgQj7gAXnX\n y3pR8gnqtRsfkgm/yiUcwxisF6LwE0ADZ9/SmI+IWIfhLJuiNci7XSVu59oUF8SJYySl\n +zpdf3xTYyFcWTF2D8ApDDgWBOBUcXiLSv1HXc8ggRjC3JaDleFb3x8x6FEeYCbnF+k/\n UZgwCDEUdwZFy8aPOx/jHo5OxoOgumimURC6Gm1xe2+RSZUKvE5U1JgOElnlxefiJmI6\n ClDw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777990470; x=1778595270;\n h=content-transfer-encoding:mime-version:date:message-id:subject\n :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=vZpKNg+hDdxRK/HKYZJ0dsJdkYfrL2j1P+QKCHsU5x8=;\n b=JB1x2Aj80GjgNutUZEwUt0qlQmYYhjLrGtm3GnMyehK4iRSPUBdNbg7u56jIZaarGW\n ZFrYpc6nzkDrTmIK6Hj1nzW0d+94mb9JzfhhxczVn+wpAW4QxanH1JjKt9VMW+eCTPgT\n g5D2g2RXECAKNLk+ZoucpNq0u1/Qt8o+KGxn7aBDsezh2YvLAij4aQnVMTltoRlX5uSs\n 2IiQ/NNnsDTeZLhNuzWDfYOtsySgowzwM8Z6sz+niPJvwNkpun7iO5+SdTnqc3RRlzig\n cqEWVLhWY1pYL0eaEJsFRMJYgj3gi3MRYXUwIR5CXZTSC68huZYWgQjJdxlUIgC6Hjzd\n 5rYQ==","X-Gm-Message-State":"AOJu0YxDL3sQ5d9D43TVkNM0wkjZHshqx2z6jbaT9xR0v+7jEUVaIVfp\n vJhPP3YWBNjkP2H13wb0kg+t8pUWycJMbJhXAUKGPbHkPk8TYBeyir35URN5gzwPJFlZ0Bh4red\n 8GgHhylI=","X-Gm-Gg":"AeBDieuILDSZmRKfAiZNCc8KbXyNOlZZ2Ro5CRtL3WRhzGXi6UnV3iRIx5fMK4wmJx9\n yrikljl4hFFDeoGuUmafQ6Y1b8A1kHG11WbnJeBzDJDQiXYF5eu8PmPlj2fy0zM9hp4jaPNfbSc\n onzttGAHXauuM83KHzpffh5NC8ThJTTuFo3Walw8ta9eTcjV2ljckhBcVub4IkYAQS0rYgUqA2Q\n 86R3nI4RHXohtdLSezSajzPjnF+eGkTzyMAP8Y/2M1yJc8TpsXI0rA+5EA96m5vfD7M4Hlg5YSi\n NoP9zSxHNM0+sH7BM0rVlRfAfJOFGQ1KK1cLqKoDHxS17mipzMwTRV3zPdWlo29hT+UpGNg2jgy\n LfUKlAQTWVh2g/zLGPcNOSAGJx5Y8tFMpK+23xS7FolL30ujUhHeKuHTTsIKZYeLHprnNTzZFvO\n leKemkd+/gYlJUT7YuWSh2w72Ai0QdeZmnE3JxGjFshwCXQ4lYUxyOtlRZ0udrBUsVsZcBZtFNK\n ve7UQY=","X-Received":"by 2002:a05:600c:8590:b0:488:ae6c:42c6 with SMTP id\n 5b1f17b1804b1-48a9865f842mr188790215e9.14.1777990470367;\n Tue, 05 May 2026 07:14:30 -0700 (PDT)","From":"Casey Connolly ","To":"u-boot@lists.denx.de, Quentin Schulz ","Cc":"Tom Rini ,\n Ilias Apalodimas ,\n Andrew Goodbody ,\n Peter Robinson ,\n Heinrich Schuchardt , Simon Glass ,\n Quentin Schulz ","In-Reply-To":"<20260505-ufetch-net-v3-0-eee5eb9ca5ce@cherry.de>","References":"<20260505-ufetch-net-v3-0-eee5eb9ca5ce@cherry.de>","Subject":"Re: [PATCH v3 0/2] cmd: ufetch: print Net feature when NET_LWIP=y,\n prettyfy if NET=n","Message-Id":"<177799046931.839461.1297387191363695345.b4-ty@b4>","Date":"Tue, 05 May 2026 16:14:29 +0200","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","X-Mailer":"b4 0.16-dev","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]