[{"id":3684479,"web_url":"http://patchwork.ozlabs.org/comment/3684479/","msgid":"<3badbe1e-98d8-4ba6-ad2c-bbf4a24afc0b@linaro.org>","list_archive_url":null,"date":"2026-04-30T06:56:35","subject":"Re: [PATCH 0/2] target/or1k: fix arithmetic edge cases","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 29/4/26 19:03, joel@airwebreathe.org.uk wrote:\n> From: Joel Holdsworth \n> \n> This series fixes two bugs in the OpenRISC TCG translation:\n> \n> 1. gen_div: INT_MIN / -1 causes undefined behavior (hardware exception\n> on x86/ARM hosts)\n> 2. gen_mulu: uses signed multiply instead of unsigned, producing\n> incorrect carry flags\n> \n> Note: these patches are AI-generated submissions.\n\nSomeone (you?) should complete that with an AI-generated review.\n\n> Signed-off-by: Joel Holdsworth \n> \n> Joel Holdsworth (2):\n> target/or1k: fix gen_mulu using signed multiply for unsigned operation\n> target/or1k: fix gen_div INT_MIN / -1 undefined behavior\n> \n> target/or1k/translate.c | 24 +++++++++++++++++++-----\n> 1 file changed, 19 insertions(+), 5 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=fIAAWDz3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5lMw2jbyz1yHv\n\tfor ; Thu, 30 Apr 2026 16:57:00 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wILKH-0003BA-VE; Thu, 30 Apr 2026 02:56:45 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wILKC-0003Af-9J\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 02:56:41 -0400","from mail-wm1-x333.google.com ([2a00:1450:4864:20::333])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wILKA-0004kH-QI\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 02:56:40 -0400","by mail-wm1-x333.google.com with SMTP id\n 5b1f17b1804b1-488ff90d6c7so4561885e9.2\n for ; Wed, 29 Apr 2026 23:56:38 -0700 (PDT)","from [192.168.69.210] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a822d4b57sm123924685e9.15.2026.04.29.23.56.36\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 29 Apr 2026 23:56:36 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777532197; x=1778136997; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=lRwYHzx+YRSTdYK8LWGEjBu6KUTxkWOmqQ5WAGfz5QM=;\n b=fIAAWDz3rA8wxSd7EHuy9cfAZLmO/bQaug/bj50TJCz5egRsmIDKaooTggqxUtrkyR\n AWV8td6F299UvAeIWSPTXYyKFDkbOmPpZ+BE3AW1aFAFodFwwxqM8yx76NPjRla0gNTa\n Nq1PfEMKLBY2wH7lFDcAut1h9sEe7N+QIInc868hToLMmDRjnn/mcII6LQyVN0z9dpuZ\n 90g88vgnWGQyiXZ18WJI7o/mqjK/JiXU4NDdfev9LPTAnpSuNBu69U/Z6yBMzgKdHfY4\n FGr+VviFeYqxTp5XL9rS92sFvFEL6N29fKIGelo1qAi6cVfKzO2/YKlPSnBAzQXXzFJD\n bxpg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777532197; x=1778136997;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=lRwYHzx+YRSTdYK8LWGEjBu6KUTxkWOmqQ5WAGfz5QM=;\n b=Kwrouz9V4WnyOSOu7tUGqiTWQGwOaV689E1rCBBVLr+iUkl8MjANMl9C7xuiljmyua\n hCVaKB46mtfvtSO5szghIV/gQi9X29PdBOEF8kPnirRDLaBIH2VILBzbRXWTpiIkPwVH\n FZApfME07NDUoi6clpVRFrP1eRdNHsVM8pDPOu3F3uyGl8VMFq1BDPC8iq6pE6JUnEvR\n pJQLkMZDyQYwL07yGxS3DpuhxKWGZXLli1zPNaovOwG4ruGjZmyklVuc/h4MMNMDf6Zb\n 6fUjXFAE9CqkhFnypoHgQmqseIf71VafFzQcRRioJOvKOLOzpdU2+D8CdPv95gbAyu2V\n pg3Q==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9WgVKdbKBtz6MskiGPohHrvAeYl8cbMQi+1T9lOUk+kUB55pvwLQ/oB76L7ZWrCzijMtjed1zUlFJ4@nongnu.org","X-Gm-Message-State":"AOJu0YxVTp1NxdR6FQHthDo8Fy+dweXbql/N1/9C1NENJRIoY8Z3G5yq\n laQw2fRyVhwfaZVZyAPFL8iiHXpEBi08+Z9WC2KAkXEoUB58d0N00WJjBc4/hTPNiUA=","X-Gm-Gg":"AeBDiet4G6PFrW3wBbNfcAVUoOX5FuU9pzrS20AhJ+cOjuB31sVAASBKgA167PGzfH7\n Jprbxn6X5qRM64QFvD+ggHnnh15hbXvrqqMVuniEzR5ZWLWV4zGfky+ihNb8B11mscKI0g7Jjqy\n 9cpWdeU78SRSrHvCrPngHCKmTCbm55NLoysZwxzd5J6EvAHwGDKyJxkzGXNM+/68mZTqDy6lENw\n 20GDJedyLTNvWsy8WIvNMImYi0iGEVIgG3amMlskcYj2xB/2VtHxhPHmrRMfrjMWRCZE34zdS9I\n fC6cj+r1ZtfBdaR0B7B1EefewyAE5Z5afEMerXJewCvdWMK1TDvalYScfRCaZHNLhIJZth5PkL/\n moTPpXF/Hvyx1J/fTvbyI8DuYJqxT3aEFmZMUr9Oa/JHJlowXXNv8D821EgkdLskMhWd1VhSu3m\n JuAaiwPzemab81DNG8XSDb+SkDQcM1UItScDgYrHX5llfEV8JpW6lWOvVvY7Z062E/qeR6ubGgg\n Jtm","X-Received":"by 2002:a05:600c:628b:b0:485:364e:9328 with SMTP id\n 5b1f17b1804b1-48a84452792mr30292285e9.16.1777532196995;\n Wed, 29 Apr 2026 23:56:36 -0700 (PDT)","Message-ID":"<3badbe1e-98d8-4ba6-ad2c-bbf4a24afc0b@linaro.org>","Date":"Thu, 30 Apr 2026 08:56:35 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 0/2] target/or1k: fix arithmetic edge cases","Content-Language":"en-US","To":"joel@airwebreathe.org.uk, qemu-devel@nongnu.org","Cc":"Stafford Horne ,\n Joel Holdsworth ","References":"<20260429170519.2137725-1-joel@airwebreathe.org.uk>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260429170519.2137725-1-joel@airwebreathe.org.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::333;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3684539,"web_url":"http://patchwork.ozlabs.org/comment/3684539/","msgid":"","list_archive_url":null,"date":"2026-04-30T08:39:55","subject":"Re: [PATCH 0/2] target/or1k: fix arithmetic edge cases","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On Wed, 29 Apr 2026 at 21:06, joel--- via qemu development\n wrote:\n>\n> From: Joel Holdsworth \n>\n> This series fixes two bugs in the OpenRISC TCG translation:\n>\n> 1. gen_div: INT_MIN / -1 causes undefined behavior (hardware exception\n> on x86/ARM hosts)\n> 2. gen_mulu: uses signed multiply instead of unsigned, producing\n> incorrect carry flags\n>\n> Note: these patches are AI-generated submissions.\n\nPlease read our policy on AI submissions:\nhttps://www.qemu.org/docs/master/devel/code-provenance.html#use-of-ai-generated-content\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=FFAGHWIH;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5ngj4gdDz1xqf\n\tfor ; Thu, 30 Apr 2026 18:40:47 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIMwZ-0002jO-45; Thu, 30 Apr 2026 04:40:23 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIMwM-0002hh-33\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 04:40:14 -0400","from mail-yx1-xb133.google.com ([2607:f8b0:4864:20::b133])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wIMwK-0004nD-IS\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 04:40:09 -0400","by mail-yx1-xb133.google.com with SMTP id\n 956f58d0204a3-651b4d09141so977554d50.1\n for ; Thu, 30 Apr 2026 01:40:07 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1777538406; cv=none;\n d=google.com; s=arc-20240605;\n b=XcXuhMzfPwWC6sFPcKIXw0fRJz0Jq/qgffjlVOYrYmd6QGN2pJZllregLXtQVuAPYZ\n MnU2B0U0klzi3MJnIVZ7h9hrYKt+Xp6VDgxQvx6QGBgNJqW4IPl/+GVT/sw3ax0RhwuF\n xcPVCYYWD1278Kv5awh6D+5q1J48+X9Y3JZtZFZ/mwtMTseafcUqm2VC+DpMc/3I9ncs\n Xi1W1fPzWE9MJNrD7ctB7YaS1Z6FTk8+aJsa0vJ5IDcptYkUwJc73BDvrT3nljuwe3/1\n Va4KrIp/yjDpELXSbQ/sMqRRpOHWFS9/eFB2Y/evEtQkZy3EZyocfnoDCajBaeijCuxh\n z2QQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=HPWFPkMaTPBBRwZ5s2tdvNEyjmeAjvkQjBAZyQS1X6c=;\n fh=ih0IwRyM8grDHegggVioxmU5VbmmsD9RF4sNtWxqAb0=;\n b=dXin2jQN8XokUiSNEl9uvYXx58QFzV1YjpDhzRINBXPt6BTvUXIsp/voPKtAJpIHLB\n nofWe2Ho79s6/eVDXOynW4Vj++pnl2tqQC6LYY8zahcTpQ0SNA5xwHt2byLsJClgI65Y\n xmmeX+88qOs+0NNYvARujFGYPaz4Ecc9y3yTAiWNvyQNlzTXdSuGxJecYWUV2LzjuLkK\n jgRxhVyKtZFuFX0DonfmF0AiNeP+F4cri1w0eHaSqVTbvRAUVJCQhbXgZSDzvw1EbI3g\n A+39DjlWO4HPr5udMh0ZpY0Mt3zGNzcp3PFIStZQDLJD5+4VDEVO586WjPGO9UviLVxb\n uzzg==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777538406; x=1778143206; darn=nongnu.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=HPWFPkMaTPBBRwZ5s2tdvNEyjmeAjvkQjBAZyQS1X6c=;\n b=FFAGHWIH/XRru8NV1xGuRs9yOVcWIH39dk88yH4xmXEtWUm4FF6pFQC2QGeCEABEIZ\n trV32nAl2S7MmqlR/mj9si0NZQ58UGd2+MTO2uXxLjvR5HuRwxHVXv/68z/eLXg0hxDi\n un/zFrG5axqXweko5F1rUwGudopq/vXY8PlZR5+L5KuB7NFvcpkPyzHa/ofpHiZ+0gNR\n e9fSMf1BMCyNdukRfGFgpykOo/qXhqWaK+ippXOXlSODxNX00o7NXqa9fZZPh6sFuI71\n 9ZzXxLcYwa8A+9//L2kQfyPI56OeAifvKVr/3wMp2WJBhM11s5dIO3DUrZQrP+m2AAUs\n X18A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777538406; x=1778143206;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=HPWFPkMaTPBBRwZ5s2tdvNEyjmeAjvkQjBAZyQS1X6c=;\n b=YAxEhECRDuWqnrab7r8R0SAm7xqtb0iP63ZWgrXPZEoTvzHz08c5ZT1ibgK1ThlXFw\n aHbMQ7Ln9uPNuvdeiaNEtvBzqq0MNbSnIrrwNL92w6yyHdgHaxcKTTLJqxkVlcZbqjt5\n jcaPgkj5jkH0XBqC4j+V3a3PafmzTYkv0wW5TAnvaTNTceyScwzdkaYxJeYOAoX4GObR\n RnnXlHBUciZaaiR7SzkAGs+aExnEiFLymc5XrTEcAjB+kstaUZ4U32Y8REcXYCZZ3WNM\n H0wXhVnAHAzCGUV5mE3qdDc+bCs4v7HFxXc0vmuI5dR0bspqz5ubft+eBzMiI8EYXv5M\n nfZQ==","X-Gm-Message-State":"AOJu0Yxv7Z4D6XgtcGxy70G1zDX8lpgyMA/2OKaY9IO5sXGDVOL409z4\n 7/m6lsS0Xp91gMJhbZV33dhjVRo+pAua0gV98NTMWDh0Mwz6uandsOXn7gjv9VWgT1EbOJ6uy4b\n jJe3XPZnk7VmU5BsSsNSjjSNdUOAaJLDyGilxysDUNw==","X-Gm-Gg":"AeBDiett30EoPkBEzZdTXacRJWf/YgwAOFnZ509BRF9Wv7tf4pqQD5sncYR2dZn2Tmh\n gB6jRlb28iLdevYceCByki6D+hOERGUR8Yhb8z0bcc4/ZfJ4/Pxs8fzUUGodrA9FzBPgjYCTRJR\n 8gDcqJ564WqrPB6obNaoTOa6IgKhAxbJ/rjLrGzGw8yqsB+sw2B5n04Lv8hsMU/2RsE+sjRrSAn\n /Zr7cJLT2dcUGvRgPiyKtkgWC6PKoQUBXtHRve6IPhYxeNgDjFECMeChXlZ0TcufnlRfrDIn6Yz\n n7bYil64JR4xNKqj/+LwWcUmXJ9sj+OPCcGvwK4GN+voD6w6SJ80AlwcY+iX/0uXnlfP7AbgAAm\n PTw==","X-Received":"by 2002:a05:690e:4187:b0:651:db4c:808f with SMTP id\n 956f58d0204a3-65c1b135d89mr701321d50.45.1777538406493; Thu, 30 Apr 2026\n 01:40:06 -0700 (PDT)","MIME-Version":"1.0","References":"<20260429170519.2137725-1-joel@airwebreathe.org.uk>","In-Reply-To":"<20260429170519.2137725-1-joel@airwebreathe.org.uk>","From":"Peter Maydell ","Date":"Thu, 30 Apr 2026 09:39:55 +0100","X-Gm-Features":"AVHnY4JO7trkTrdcaSs3SUlqr078MQCUDz0wf1dqzDH1pCJaBpJssAYZcOVO7uI","Message-ID":"\n ","Subject":"Re: [PATCH 0/2] target/or1k: fix arithmetic edge cases","To":"joel@airwebreathe.org.uk","Cc":"qemu-devel@nongnu.org, Stafford Horne , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n Joel Holdsworth ","Content-Type":"text/plain; charset=\"UTF-8\"","Received-SPF":"pass client-ip=2607:f8b0:4864:20::b133;\n envelope-from=peter.maydell@linaro.org; helo=mail-yx1-xb133.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]