[{"id":3684187,"web_url":"http://patchwork.ozlabs.org/comment/3684187/","msgid":"","list_archive_url":null,"date":"2026-04-29T17:46:12","subject":"Re: [ovs-dev] [PATCH net 0/2] openvswitch: fix self-deadlock on\n release of tunnel vports","submitter":{"id":70613,"url":"http://patchwork.ozlabs.org/api/people/70613/","name":"Eelco Chaudron","email":"echaudro@redhat.com"},"content":"On 29 Apr 2026, at 17:16, Ilya Maximets wrote:\n\n> Two patches - the fix for the actual bug and the selftest that reproduces it.\n>\n> I missed the self-deadlock in the original patch that introduced the issue,\n> because testing required code modification in the ovs-vswitchd to force it to\n> use legacy tunnel ports. I thought I made the change correctly, but apparently\n> something went wrong and the tests were run with the standard LWT infra instead.\n> The selftest added in this patch set will at least prevent this kind of mistakes\n> in the future.\n>\n> I mentioned, however, that these tunnel vports are legacy and not actually used\n> by ovs-vswitchd. RTM_NEWLINK + COLLECT_METADATA is used in conjunction with the\n> standard OVS_VPORT_TYPE_NETDEV instead since 2017. The code to use the legacy\n> tunnels still exists in ovs-vswitchd however, but only as a fallback for older\n> kernels and we're planning to remove it in the next release. I'll be sending an\n> RFC to remove support for these legacy tunnel types from the kernel, as they\n> serve no real purpose today and only increase the uAPI surface for CVEs, but\n> we need to fix the known bugs for stable versions.\n\nThanks, Ilya, for working on this patch! It looks good to me, assuming you\nremove the unused socket library in v2.\n\nFor the series:\n\nAcked-by: Eelco Chaudron ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=dYL3iS5u;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp3.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=dYL3iS5u","smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp1.osuosl.org; dkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=dYL3iS5u"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5Pqk0ZkGz1xqf\n\tfor ; Thu, 30 Apr 2026 03:46:25 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id EA5A561691;\n\tWed, 29 Apr 2026 17:46:23 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 0WVMefyxq7i2; Wed, 29 Apr 2026 17:46:21 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp3.osuosl.org (Postfix) with ESMTPS id C03056168B;\n\tWed, 29 Apr 2026 17:46:21 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id A4E8EC04FB;\n\tWed, 29 Apr 2026 17:46:21 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists.linuxfoundation.org (Postfix) with ESMTP id F0A8EC04FA\n for ; Wed, 29 Apr 2026 17:46:20 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id D6C4D840B5\n for ; Wed, 29 Apr 2026 17:46:20 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 6baQUT0Z0x-2 for ;\n Wed, 29 Apr 2026 17:46:20 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 9E1138412D\n for ; Wed, 29 Apr 2026 17:46:18 +0000 (UTC)","from mail-ej1-f69.google.com (mail-ej1-f69.google.com\n [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-221-VXDtuhMlNMCvMuqt9lUiog-1; Wed, 29 Apr 2026 13:46:16 -0400","by mail-ej1-f69.google.com with SMTP id\n a640c23a62f3a-ba661b6c550so1128466b.0\n for ; Wed, 29 Apr 2026 10:46:16 -0700 (PDT)","from [10.44.49.209] (5920ab7b.static.cust.trined.nl.\n [89.32.171.123])\n by smtp.gmail.com with ESMTPSA id\n a640c23a62f3a-bb980a6f9d6sm125280266b.10.2026.04.29.10.46.13\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Wed, 29 Apr 2026 10:46:14 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org C03056168B","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9E1138412D"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=echaudro@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 9E1138412D","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777484778;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=or10qtpHF5q4FsYpWyH8aqkdxHYxoqC0I1ML0azCPiE=;\n b=dYL3iS5uYETJ4zADPmWkRrp7cQjfSTMNUX2+9dBovd314LFuqakIyjSmw5g+lEd/E0tfRx\n ZmzIIICMvHtPSlQs4QiCPCpSuspdhrMaIu6KXUTgOshrUeceuUQyFgilCtaqFF8abP4ipx\n F5syzjEAC0X8EjlW2Ynkx4+wviE3yuA=","X-MC-Unique":"VXDtuhMlNMCvMuqt9lUiog-1","X-Mimecast-MFC-AGG-ID":"VXDtuhMlNMCvMuqt9lUiog_1777484775","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777484775; x=1778089575;\n h=mime-version:references:in-reply-to:message-id:date:subject:cc:to\n :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=or10qtpHF5q4FsYpWyH8aqkdxHYxoqC0I1ML0azCPiE=;\n b=sE4kcIWAXSuegyysBJcMAuSSiwRn720A4sbEITK2/Mvb68NPRCkDgxfNcsHjNJ3O92\n 163bYOzh0FFgY7GyVCCL427bU3DVbgeyUnMjI28x2lT5RgEGyDAwInCuLsxooJ5reX5E\n bdFiplwPD49ranOu27ui3m2lLIy0sSO+BH4fGO7IRwLFzWW7bDv2jief9y1S1p5J6zJ9\n UKKLcC4+tFgCVjr5j19bni96pLj/MfLTSk5U5IdNZkgd7AGHnMAbD9DdiVV2TzvZOzEP\n ib+Z7KuiPbDwtLYFyC6oH6PgPSL5JVieb5M5xoleJ8Sg7WC1YfrO16JBIPayZjokiKsZ\n 2/zg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ94eqXJeuFubZMrVHJg3W5N1fLr9h5L3kBkP68t7/tWC5QCTdhS6DudAhIg8/9k7RR88ig=@openvswitch.org","X-Gm-Message-State":"AOJu0Yzal4ImuPfPDRaBNKRTqvGqx/EXEv0anhCFiDGYTvUQomRaNICk\n 1P0vWFqQ8zeRgy9W1QE7/XNaXEwrY/CBs38y3v8Q6ruhvSsj2eLhuf+jXw1+LurYa8ZRIHMGhBy\n i6PLfPKU+2NXYSc6PV9dBej44zMUJcGfMasy+qZWdwudDPx7MqWVPnQ==","X-Gm-Gg":"AeBDieubdtADIRHkn8S9CoeEbdARhkdCdhtvzT+uCmPSmR0GU/gicakTCDYrILnxSy7\n xU9/zend844sO9MjImkBXUAw24AYZjBQNKczW3+XTOZdFh3nR7BxWfwLNa3Yqyd0YAoOi1QYh3E\n iWloLko9+rLbKs0Okb4kMhCXRO47S3Ipc0NDeHe2mPRWzSRTHAvqq3fwSTRmqaHUnGLO9B+I40m\n BQj8iFp/W6xDBRZVbg6uEkEMVAhaYfSPTuVpUj4vlwKkcPV95bsPIQq5GT+7FQqXxAbJj3Dy7Pq\n 0dWH9d4MjYLIdz6czK05o33t6XUClhdAsGzJpJnw/RRVMMN49NoCAt7Dmv/ypl5VfoE9YqJZBK2\n NJoRhmyUrGQo2pX6GgR7F3VScG0dp5wJajRkj3zVdx7bqqN9WyUUmbTav+wTEmdH3IblPBxU54D\n EeRvvQcA==","X-Received":["by 2002:a17:907:1c29:b0:ba7:4cd9:ca12 with SMTP id\n a640c23a62f3a-bb8026bd340mr584861666b.13.1777484775220;\n Wed, 29 Apr 2026 10:46:15 -0700 (PDT)","by 2002:a17:907:1c29:b0:ba7:4cd9:ca12 with SMTP id\n a640c23a62f3a-bb8026bd340mr584857866b.13.1777484774601;\n Wed, 29 Apr 2026 10:46:14 -0700 (PDT)"],"To":"Ilya Maximets ","Date":"Wed, 29 Apr 2026 19:46:12 +0200","X-Mailer":"MailMate (2.0r6292)","Message-ID":"","In-Reply-To":"<20260429151756.4157670-1-i.maximets@ovn.org>","References":"<20260429151756.4157670-1-i.maximets@ovn.org>","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"NeBwVaeYiYlIC5A9ZvGZji-N0dtFxV2Sr484Nb8ryEE_1777484775","X-Mimecast-Originator":"redhat.com","Subject":"Re: [ovs-dev] [PATCH net 0/2] openvswitch: fix self-deadlock on\n release of tunnel vports","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Eelco Chaudron via dev ","Reply-To":"Eelco Chaudron ","Cc":"dev@openvswitch.org, linux-kselftest@vger.kernel.org,\n netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n Yang Yang , Eric Dumazet ,\n Simon Horman , Yuan Tan ,\n Jakub Kicinski , Paolo Abeni ,\n Shuah Khan , \"David S. Miller\" ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "}}]