[{"id":3683221,"web_url":"http://patchwork.ozlabs.org/comment/3683221/","msgid":"","list_archive_url":null,"date":"2026-04-28T08:03:19","subject":"Re: [PATCH v5 0/2] Fix and re-enable GTK clipboard","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"content":"Hi\n\nOn Tue, Apr 28, 2026 at 12:06 AM Jindřich Makovička wrote:\n>\n> The following patches change blocking clipboard retrieval function\n> calls in gtk-clipboard.c to non-blocking variants using callbacks to\n> avoid UI lockup. It is a follow-up to the patch proposed in the GitLab\n> issue\n>\n> https://gitlab.com/qemu-project/qemu/-/work_items/1150\n>\n> This version adds a similar change to gd_clipboard_request that also\n> uses the blocking clipboard API.\n>\n> The second patch removes the gtk-clipboard compile flag, keeping the\n> GTK clipboard always compiled in. By default, clipboard is off,\n> can be enabled by -display gtk,clipboard=on .\n>\n> Signed-off-by: Jindrich Makovicka \n\nReviewed-by: Marc-André Lureau \n\n> ---\n> Changes in v5:\n> - Runtime option added, clipboard still off by default\n> - Link to v4: https://lore.kernel.org/qemu-devel/20260427-gtk-clipboard-v4-0-176ad9919931@gmail.com\n>\n> Changes in v4:\n> - Replace gtk_clipboard_request_contents with\n> gtk_clipboard_request_targets which can utilize GTK's target cache\n> - Link to v3: https://lore.kernel.org/qemu-devel/20260426-gtk-clipboard-v3-0-09555aaeda34@gmail.com\n>\n> Changes in v3:\n> - Use gtk_clipboard_request_contents to avoid text conversion\n> when we only need to check if the text is available.\n> - Link to v2: https://lore.kernel.org/qemu-devel/20260425-gtk-clipboard-v2-0-b098f3cf69cc@gmail.com\n>\n> Changes in v2:\n> - Removed forgotten gtk-clipboard comment in meson_options.txt\n> - Link to v1: https://lore.kernel.org/qemu-devel/20260425-gtk-clipboard-v1-0-6bd99e708e14@gmail.com\n>\n> ---\n> Jindřich Makovička (2):\n> ui/gtk: Use non-blocking clipboard retrieval\n> ui/gtk: Turn clipboard flag into runtime option\n>\n> meson.build | 4 ----\n> meson_options.txt | 7 -------\n> qapi/ui.json | 6 +++++-\n> qemu-options.hx | 9 ++++++---\n> ui/gtk-clipboard.c | 53 ++++++++++++++++++++++++++++++++++++++++-------------\n> ui/gtk.c | 8 +++++---\n> ui/meson.build | 4 +---\n> 7 files changed, 57 insertions(+), 34 deletions(-)\n> ---\n> base-commit: aa15257174da180c6a8a9d58f87319cfe61c5520\n> change-id: 20260425-gtk-clipboard-fdf99db13ac0\n>\n> Best regards,\n> --\n> Jindrich Makovicka\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=f1Zn2OPf;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=PhPnt1S4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Xyf2FjTz1yHv\n\tfor ; Tue, 28 Apr 2026 18:04:24 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHdQ0-0003EC-Aw; Tue, 28 Apr 2026 04:03:44 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHdPx-0003Da-1K\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 04:03:41 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHdPt-00036u-5P\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 04:03:40 -0400","from mail-pl1-f199.google.com (mail-pl1-f199.google.com\n [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-546-Hwwymu6vPwKHp6FK5fDTUA-1; Tue, 28 Apr 2026 04:03:33 -0400","by mail-pl1-f199.google.com with SMTP id\n d9443c01a7336-2b461b36990so120912825ad.3\n for ; Tue, 28 Apr 2026 01:03:32 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777363414;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=BPudrdLn0IK9sImuSyJc3hr6uP5V/FxPl5nefsdVox8=;\n b=f1Zn2OPfyl0GKs7nbOtokh3LO0teNRQmWtF6jOnYjbyElzODRqt/V2LJBECi79cNYe3c29\n 73ASGcMdL9RjP0tLNBe0jzGaRDwMyHEjBjsnJ1WRoUut+us0tHT8attBdJlZ+mo0RLxBVi\n Q2ywUGQJTLNZMo8ER0Co24QiwlTqgLA=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777363412; x=1777968212; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=BPudrdLn0IK9sImuSyJc3hr6uP5V/FxPl5nefsdVox8=;\n b=PhPnt1S4oUmKE9tFbjwldG2Vwa69RDigjCRCynn/xtiFsjy3WJ/0QWPY/dHhk6MT4c\n 93fyKoDJG81k+leNWP2uptf1A8Y8Eqh5bXIQnQ9qktIyqV75Dgft7rF4BS4DI8MVOPNl\n SzL0EsTKuPzRzv8i709vBeEGY6Y6vFun0AQV5uNJ9MOCmcB+GlbaUFN/2985mqTNu9wm\n h/30U6g9PTXgMseWGiGrZ5XajDnvgpe76IoYaah5DA7SUnKE8Yf4p5rUjrVM+5nCJptS\n gJtzOLKj9MorRC3jzvX4APluUmj8QnRUBFxXqVevHoxiYNUw/7UXMLUmpyrXxMq3M/rS\n EK3A=="],"X-MC-Unique":"Hwwymu6vPwKHp6FK5fDTUA-1","X-Mimecast-MFC-AGG-ID":"Hwwymu6vPwKHp6FK5fDTUA_1777363412","ARC-Seal":"i=1; a=rsa-sha256; t=1777363412; cv=none;\n d=google.com; s=arc-20240605;\n b=hRp7IXucmXEOjEQw6MrIfNC6gva3HaUs3v8df2ctFbddxyWCdECWCUEnN36pRV5aBE\n uRlzz2Yzjt97XHHDrAm04Z1Vjao2uCzMaMWw7Oz9kqjY+7VUxu5YTp3M45pPmRbw4WUb\n DcuOPVnPozHv7etu0izi/L51KH6hC8Iq1y9RpLB2GirZgzauZXa2FfkrUsP2beRtuLyh\n Oj0TUenDEA9d1OMbQQnynu13yftnby37WuS0f9m1xFW67nU2QZLofD8lZYgmtWgMpJqZ\n 0huZRuHHBHaLnFqjnzkM/8T5TITVii8FlB5TRcXEBqo59TIXz04qvPSLaMiGmTup7D6z\n nBaw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=BPudrdLn0IK9sImuSyJc3hr6uP5V/FxPl5nefsdVox8=;\n fh=Lp0EzGRgIYJPnfuILsQ/Ksar4E7WyhbafxG8toaFkq8=;\n b=DzrNjbfFSsNpC21pbOwk7ClHmHeOY6JH3ng2tt3WSakRZ/pKtqWAhuRJ3I+85L25pG\n Mg3LtqkMwT/IX7yG0WldBKOov5KE860sv1z7YQClhMByJt/S4ceh+N9vfKZbVK5sVaMe\n 5kgZVyXgHIWQXb5bLj0fH+7H7OMg1Oy9Nx5HZLWmiaP5duuRjXV++YWt1A1unpAVfXvn\n gFQTsELqchfayWtK0oaFsgrE1mVrfAAd2gZE/GS37r1P9VR6G0TsgcIG1IlUEScUzJVa\n sFxyqhXuQjoZ82bPqRBp91TpHwvTqIa+ouTXNKC7FeBEJYPwhkI/BV8MZJ44m3ZQowur\n oELg==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777363412; x=1777968212;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=BPudrdLn0IK9sImuSyJc3hr6uP5V/FxPl5nefsdVox8=;\n b=qstAkKCidAMc6/0yUB3XSgbTKoSLoKHh1rv6UFLMWFQe6XCspYqtWXCoTAIPxSa0CF\n rJ8UVeKFyEV+QoUW18XQpNE0/R+7aMl6s9rHVMgsN3ZIpZXNyh/5XLzNA0lIWbo4zn6d\n CMx5PR1XLwJm2fH9G91v3nK+Yax5XUj2eFAwS0Fhv7xXgeaYhY64L4bGv4ktD/8Bjmh8\n vEVJIeMcc4xhfLxm/VFu58w1NfDTwiYR0EFcV12iR4GDj6or6c6GyVtAMsMOn9jlbXwb\n cLcUetJZK3TkJCwruqPgQoa0HbO9KXcKor2abOu3MTnJ8172N3Ds593Kk6h9mC51lex9\n GBgA==","X-Gm-Message-State":"AOJu0YxVr0hJ0l+B9tjeeyqUHW1VEJFe9zQk3/pMOIkoHMfHHHErU1cW\n hZ2cS2ub86gl8mXLkMc5G8JvndUSvoquZ9HLGNlsTawTRFiUgMDvmS1Bw6VMgP4MDZTzW2rcukh\n UBgMdVth8+TlesDuavZM8O8OXsubHjn0RS0GURPf9XTnaDxOFPL8lJE1+ynK0GCd/ybukMdlW8O\n BArTE/9c23VqvML2zVZ6o5XZ4REsD45bE=","X-Gm-Gg":"AeBDiev7f0GeNupZMoBloQE0jzVZYQr0VUNc2pJBoFg+YOXO4P0IsqlrwsmkO5S9NRp\n flVXGJ/pfev18UFQqq0dzpPVgMHkH1tWiOghHsDA+gkHc9C5TV4YOtgp9hr8W2YWTXybptN+tGF\n DpDCCnasiWQc1Ztb4z9QqAkEHhfr5EyggG5VPm46MGkZ1CH0TnN4UiwzIo7dyF/ZGpvasTyKbGF\n ga4ZdTQEX3Jit0ZdVysm04NThi/DYtw1SmdAuMDf5QDkvlL66+Agzaf0/OQze9ICJtt8FREKO7l\n 9xhhAJnZcWCb2PdeO5Rm+xwSSqCp9qOL2tE=","X-Received":["by 2002:a17:902:ebca:b0:2b9:6a47:787f with SMTP id\n d9443c01a7336-2b97c4ca07bmr19618115ad.40.1777363412018;\n Tue, 28 Apr 2026 01:03:32 -0700 (PDT)","by 2002:a17:902:ebca:b0:2b9:6a47:787f with SMTP id\n d9443c01a7336-2b97c4ca07bmr19617825ad.40.1777363411463; Tue, 28 Apr 2026\n 01:03:31 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260427-gtk-clipboard-v5-0-6968feb31a5d@gmail.com>","In-Reply-To":"<20260427-gtk-clipboard-v5-0-6968feb31a5d@gmail.com>","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Tue, 28 Apr 2026 12:03:19 +0400","X-Gm-Features":"AVHnY4JXx8X6OCdh3KHq1F7XnSM5lV-4QyOKVnXosX8iaFpYR2uAoprjKHW3rS4","Message-ID":"\n ","Subject":"Re: [PATCH v5 0/2] Fix and re-enable GTK clipboard","To":"=?utf-8?q?Jind=C5=99ich_Makovi=C4=8Dka?= ","Cc":"qemu-devel@nongnu.org, Paolo Bonzini , =?utf-8?q?Da?=\n\t=?utf-8?q?niel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Philip?=\n\t=?utf-8?q?pe_Mathieu-Daud=C3=A9?= ,\n Pierrick Bouvier ,\n Eric Blake , Markus Armbruster ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=mlureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]