[{"id":3683645,"web_url":"http://patchwork.ozlabs.org/comment/3683645/","msgid":"","list_archive_url":null,"date":"2026-04-28T18:23:42","subject":"Re: [v2,0/4] fastboot: block: Add GPT/MBR and device selection","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Balaji,\n\nOn 2026-04-27T12:06:41, Balaji Selvanathan\n wrote:\n\n> Patch 2 adds fastboot_flash_gpt_partition_table() and\n> fastboot_flash_mbr_partition_table() helper functions that handle\n> flashing of GPT and MBR partition tables to block devices.\n\nPatch 2 also refactors fb_mmc.c to use the new helpers — please\nmention the MMC conversion here in v3.\n\n> Patch 1 implements device selection syntax allowing users to specify the\n> target block device using 'N:partition' format\n\nSince you are adding a new feature (the N:partition parser, plus\nGPT/MBR flashing on the block backend), please add test coverage. See\ntest/dm/fastboot.c which already exercises\nfastboot_mmc_get_part_info() - you can add cases there for the block\npath: a successful '0:foo' parse, the bare 'foo' fallback to the\ndefault device, and rejection of a leading-colon name like ':gpt'.\nOtherwise the parser and is_partition_table_name() interaction are\neasy to break in future refactors.\n\nBTW the v2 changelog has 'Seperate' (twice) and 'fot' - please tidy this up.\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=K8DDELDT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"K8DDELDT\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4pjY6DpVz1xrS\n\tfor ; Wed, 29 Apr 2026 04:24:01 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id AD406846A8;\n\tTue, 28 Apr 2026 20:23:59 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 1242E846A8; Tue, 28 Apr 2026 20:23:58 +0200 (CEST)","from mail-ej1-x634.google.com (mail-ej1-x634.google.com\n [IPv6:2a00:1450:4864:20::634])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 53C7C8468E\n for ; Tue, 28 Apr 2026 20:23:55 +0200 (CEST)","by mail-ej1-x634.google.com with SMTP id\n a640c23a62f3a-b941762394aso1617202266b.1\n for ; Tue, 28 Apr 2026 11:23:55 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1777400635; cv=none;\n d=google.com; s=arc-20240605;\n b=Vf19QilNp1As479jEUjH7intom9NWXUSG5F0tChsFYKzKRWJmN0uJ45j5ZAr7dP5fc\n iC7eA4f9dhv+JjQqQLQNm28FRTNDvVVnV2jOZ4W3eP8VN8mebjO8cQNYhIFtMReVvHc8\n vksJHXsXmQAD4wWRZmFErRtfHxy3nYwlYGhvdIHbV5+vBjk5pRJYnjhkBlRQp+GxD4/M\n NryF+Y2HExp1mIvZq+7IgWM8LldteH92rt6J9jKRzgDkGLIQcu3q1r42maDWTNh/8CUh\n xLBi7d8roydT8Mr4nxe07bwppToSy34ETIUbPwbKfn5oZ5aVoEuBLvzEnuXKefgCuMBp\n wI3w==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=HZzA+tWF6Ts8EB1Qb7SPrPqPbTNy9tt3OjjkPDJKUu0=;\n fh=roScgQRs/1XQwKZoJDPK2CRWP0QTsH47L7/m3Rpzqtw=;\n b=T1ijfSAm5+kCeYI09/cYMLzn0xhNRr9Q7nSf6g/iFgEhuPXHJqS+2ek42iK0Z+2vsx\n C63vHPhf8X1+HSa4fEFMEeoPg4+3MgsLsk3JcLMvDmoukiPtPoZ5QR9WNHXvY8MbYBHn\n PBiOvP6K8MHwpMfq3JqmNLjmDkSrWPR2gdeDZ/T6gRiLdMvIdMFjS5c/Zb/nxr+awulX\n Myw1IRN2Zzo6VsObuCrq07p8ruyt72KR2SxLMLBeCDpUpXwWdKHFgljqgVvzqcobLrab\n Vs52Pg/j0sP8KveVJaAyKHjZjQW7/m9noEkcJijUH91DJrU8hRiPu9y4DpiSSmhM0PZ9\n Ep3w==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1777400635; x=1778005435; darn=lists.denx.de;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=HZzA+tWF6Ts8EB1Qb7SPrPqPbTNy9tt3OjjkPDJKUu0=;\n b=K8DDELDT7ZLmv5CcPQVsVUsHQn/aU9S2zCEc2eu6EQEzEUz9MACycGOLl7hfxcDbkp\n lb14nQuFhetP9/DaGpuvOk4yKqkgk6Ip4xOr92fJ7G0tRL1qfJ2mjEGHXuREbjA6ZZzl\n 1vkFdCRtT0db7mXKH4jiW9OgVu+3Dx5PkrFcI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777400635; x=1778005435;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=HZzA+tWF6Ts8EB1Qb7SPrPqPbTNy9tt3OjjkPDJKUu0=;\n b=F9LIGuVnQoReI462brrzCrGEEFToW62kKD0FbFYueqYZKRDoiYM2f5F5TKl78AHX57\n RCpoKqZCUDsBJdKHNFJsyb2Q5s+rE8LQS/StqdV6gPwKAWvNE8vDldQ1W4YisCmQ/1Z9\n EpCIkprwVf+UNj3LpJhzBAATFTwGi9ykExWLkDPObx9+b9J6I5YVHw7DaUOncLDD0KyK\n NqXfp0idAxMwjeKmEdfR+SyRLfa+LYxmm3DxFXK4VVzxPJfZriQfx8j51dEA3x14q413\n asjJEjj1YfKtmSxY5/DEz06VLVJztIXeybECZkgM/VdLGlfNfQo+qyR/f8/MAmhN5deu\n P37g==","X-Gm-Message-State":"AOJu0Yyd77aYt4vT/CifJiu6pmf2wF2wi/nqWJb2y+oT0Bb0I0N4InuX\n LdVDK356Tu0RPHDUqAnsSICy+BAN055+yEXt2eycVzyjYtIh5BgUqFgFJnyTJrTTVNlc7o2EIz3\n n4lfPIETlPnyueEMqJVeHyEA8L6RlkklQQcsXXp2I","X-Gm-Gg":"AeBDietjUoMUCb0k+Sy1ameWN1quLbkomfV+P76as8X8o+G+8WLqIYqFJHY8QMF6gY7\n LFBeqOOMP/7gBRNy9JCIp2GsHn+9XaSegkoyh+4SELfkstsuUfBqCgHua5HQ8/osNXSr4bTf4UK\n uvsD2c8xTCnHnCzcgLrQD3bQfhitR+u33rIKKWb3h+YMYpIz1rjmLUhgg1fA2JRTXALBm5Z0q7C\n XmVGDxR/4E8uAfGzqiBX6f/9D7Rcp3jndpjW2mrAOxzYNKhIJvssOiDaDghlAXnYKAYFPUuMJCy\n v9S5vHpoTrNCJkmq","X-Received":"by 2002:a17:907:c48d:b0:baa:2e75:8cd5 with SMTP id\n a640c23a62f3a-bb8023b8ad7mr277480466b.15.1777400634784; Tue, 28 Apr 2026\n 11:23:54 -0700 (PDT)","MIME-Version":"1.0","References":"<20260427-fb_gpt-v2-0-9e7fe3c1649a@oss.qualcomm.com>","In-Reply-To":"<20260427-fb_gpt-v2-0-9e7fe3c1649a@oss.qualcomm.com>","From":"Simon Glass ","Date":"Tue, 28 Apr 2026 12:23:42 -0600","X-Gm-Features":"AVHnY4Lm39jODnpjePwsIgAuApsvgKOAkcD_e8bRkJqIrM8QC04qOIhIbyY5kN0","Message-ID":"\n ","Subject":"Re: [v2,0/4] fastboot: block: Add GPT/MBR and device selection","To":"balaji.selvanathan@oss.qualcomm.com","Cc":"u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]