[{"id":3682363,"web_url":"http://patchwork.ozlabs.org/comment/3682363/","msgid":"","list_archive_url":null,"date":"2026-04-24T15:24:30","subject":"Re: [PATCH v5 2/3] usb: gadget: rcar: Add support for reset\n controller","submitter":{"id":93164,"url":"http://patchwork.ozlabs.org/api/people/93164/","name":"Michele Bisogno","email":"micbis.openwrt@gmail.com"},"content":"On Fri, 24 Apr 2026 at 07:34, Marek Vasut wrote:\n>\n> > #include \n> > #include \n> > #include \n> > +#include \n>\n> Please keep the header list sorted.\n\nOps, OK!\n\n> > #include \"common.h\"\n>\n> [...]\n>\n> clk_enable_bulk() needs to jump to err_clock_enable() on failure, this\n> is a bug in the existing driver .\n>\n> > + ret = reset_get_bulk(dev, &priv->reset_bulk);\n> > + if (ret)\n> > + goto err_clk;\n> > +\n> > + ret = reset_deassert_bulk(&priv->reset_bulk);\n> > + if (ret)\n> > + goto err_clk;\n>\n> This has to jump to fail path which does reset_release_bulk() , i.e.\n>\n> goto err_reset_deassert;\n\nOK!\n\n> > clrsetbits_le32(priv->base + UGCTRL2, UGCTRL2_USB0SEL_MASK, UGCTRL2_USB0SEL_EHCI);\n> > clrsetbits_le16(priv->base + LPSTS, LPSTS_SUSPM, LPSTS_SUSPM);\n> >\n> > ret = generic_setup_phy(dev, &priv->phy, 0, PHY_MODE_USB_OTG, 1);\n> > if (ret)\n> > - goto err_clk;\n> > + goto err_reset;\n> >\n> > priv->phybase = dev_read_addr_ptr(priv->phy.dev);\n> >\n> > priv->usbhs_priv.pdev = &priv->usbhs_dev;\n> > priv->usbhs_priv.base = priv->base;\n> > priv->usbhs_dev.dev.driver_data = &priv->usbhs_priv;\n> > - ret = usbhs_probe(&priv->usbhs_priv);\n> > + ret = usbhs_probe(dev);\n> > if (ret < 0)\n> > goto err_phy;\n> >\n> > @@ -439,8 +452,10 @@ static int usbhs_udc_otg_probe(struct udevice *dev)\n> >\n> > err_phy:\n> > generic_shutdown_phy(&priv->phy);\n> > +err_reset:\n> > + reset_assert_bulk(&priv->reset_bulk);\n>\n> err_reset_deassert:\n> reset_release_bulk(&priv->reset_bulk);\n\nAlright.\n\n> > err_clk:\n> > - clk_disable_bulk(&clk_bulk);\n> > + clk_disable_bulk(&priv->clk_bulk);\n>\n>\n> err_clk_enable:\n> clk_release_bulk(&priv->clk_bulk);\n\nOK.\n\n> > return ret;\n> > }\n> >\n> > @@ -456,6 +471,12 @@ static int usbhs_udc_otg_remove(struct udevice *dev)\n> > usbhs_fifo_remove(&priv->usbhs_priv);\n> > usbhs_pipe_remove(&priv->usbhs_priv);\n> >\n> > + reset_assert_bulk(&priv->reset_bulk);\n> > + reset_release_bulk(&priv->reset_bulk);\n> > +\n> > + clk_disable_bulk(&priv->clk_bulk);\n> > + clk_release_bulk(&priv->clk_bulk);\n> > +\n> > generic_shutdown_phy(&priv->phy);\n> >\n> > return dm_scan_fdt_dev(dev);\n>\n> Thank you for your help!\n\nThanks for your patience! :)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=cRW/wfgA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"cRW/wfgA\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=micbis.openwrt@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g31qf383xz1y2d\n\tfor ; Sun, 26 Apr 2026 06:38:06 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id ADF4084534;\n\tSat, 25 Apr 2026 22:36:32 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id D0FC784496; Sat, 25 Apr 2026 21:30:20 +0200 (CEST)","from mail-dl1-x122c.google.com (mail-dl1-x122c.google.com\n [IPv6:2607:f8b0:4864:20::122c])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 7D12784474\n for ; Sat, 25 Apr 2026 21:30:18 +0200 (CEST)","by mail-dl1-x122c.google.com with SMTP id\n a92af1059eb24-12dbd0f8063so3801620c88.0\n for ; Sat, 25 Apr 2026 12:30:18 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.2 required=5.0 tests=BAYES_00,DATE_IN_PAST_24_48,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD,\n FREEMAIL_FROM,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS\n autolearn=no autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1777145417; cv=none;\n d=google.com; s=arc-20240605;\n b=XnQwHCCJ3Z4yBOaS3G9+M3KdIVZnNM0cD8pfqOKr2V889uYC14XzQ9O8dp8Tfp0SeW\n YUh8rY7k0aQvWtaCFyUxf3VFxJvVjYvTw0yph30dHXCVKTJhmS/D2P7/zmOsIBLRhfJ/\n ATM7bRHVBaqilqD0NP64Toy0uDAcUG70CC6V9/ohwuJJlIJU/R9O2ajwSxhaKBOUONKf\n bCPxUJ2DMp+Cg5snZEa2cvhksmBBc6W0zbb7wZVkcyy7tWvDPl3XIW4/Lrzz+q/lFXNx\n YMq7d0J/NV70+Lu8e5AJWHpPkme7gpeQez5G+vZ/jzQodwvjfTdzRt4sZqTlTU0JMNsd\n DXJQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=boLk94+1uBNOsUP/OAm3IlFY2L0OD0nL/MWwkHQTSvk=;\n fh=byp86q9k6aVMAx+mMqAL5zwz88wFV7x2RVBnut7lUe0=;\n b=Xd4exm4DRbrORo+lJn7qps+1/GHHIhEkgdUqPvMrNvaigtF9BeEk1vS8wwhO/e1Trc\n EJL3dQRqElicZBgjY907TzZJBRxc+CvJeyhIHH9sbgt7g9azl1/CewKVpKZ4iZk5tdbj\n ztIP/aL4YoIkvNopzbZpZq0QaZV0QJqXhw94jiFwCcHOz3J0cGyPf4mOc8+x27znzIND\n ZkZIDAvDNaUH7zk3AwQopZ3lkXCqoWpqlGvQ+n1/dhTKD+l23sQppfN56EQ9/yZJeoVV\n V3Dk9RiLyzm/P6Gwmuw8PtMaVA1Wb9XfS9HsDQrOFdMYueRF46tWubzEIlSotfU8+wPY\n RJMA==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777145417; x=1777750217; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=boLk94+1uBNOsUP/OAm3IlFY2L0OD0nL/MWwkHQTSvk=;\n b=cRW/wfgApjVUWiwxul+NErT4LmxYKAlHLTEVpl+HKeO/034/tc6fCUqbAjBNTwz1IE\n McE5fTEnrpO4vdZK+DvaoVvtK0harz7DDg9SwGPSLWeHYn6H7cJ/HLS98wOWuvU+GMqo\n /sRtdkFQlqBajzwIZvhJVQDDohT+TFjehAPGENjZ1JUh+24862qDp7/IXFNnjFzBwgpY\n aCvx1Lpx0IsOlOLIBHY2pBfdyU7AWLD1WgGZPGA17pxp9VdbbsCovt3ir3AoC/oh0Kb4\n tIO4/ybcKhA3IEz1D40BR/d9HMi/Xpn+Hf8481/AA7Kh2nC5rItCChl9HGcED0zXxsbD\n Xe1g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777145417; x=1777750217;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=boLk94+1uBNOsUP/OAm3IlFY2L0OD0nL/MWwkHQTSvk=;\n b=UtcG39S3TUYkTfLPUUslvLrGxB3xnpNbdgOKwRBwl6QmCOiZmTfh3Wpzerq5j5zmBI\n VfKC/C9BwZQ3EEH07p2WgkRG7hK5F/GGCYrV0DZNsncf5Dst43+9avexovVYUXfUEDpx\n gZqgEWCM9sy3xQE3MD9nD2h9cZX+qICKBKOaAIF6pNr886X8f6IF42/YCHYZtd0ZBg5H\n r7gFpWRGDTdXf9h9Iju4tTERWvTAOSz5OMBldJ4CXXNzWALMZcojOOvsIaS2tGtv/EAo\n dNysEv3/59naaw6jcrDG/x0nUMuQ9ZU8qoC97sDeB5PDIYiFuhwav83pqtsITjStdQT+\n /Bhw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ897Xido3DX597WKrgVac9PQ0hWA3NLjznYy1ITEXTpsyoW97XekZyoRDe5uO+xDpffMrUNAs4=@lists.denx.de","X-Gm-Message-State":"AOJu0Yyuf4NIWBfR+IkyohV+4gUmPQJUGlDtwFagdjG2bToKIBjrKblu\n PEUWQMXJwT+7ZK0V8n0n+2q9L38M1P0yJqRB4SG0SAr9xYbW2Yd7o98xV39MXV6hq8JBboYMbKO\n UuqW/wvn9pfxX0ahL3PxOJHG1xivZRlZjBw==","X-Gm-Gg":"AeBDieu/Pg+w06jTZyiVEqcPUddJkBGIkTVPYWohruCYg0cTDLdL+TU17DKgh95gpyz\n cLplkkqr+Li0u3P5/e+U/rhEVu0pQPpKbVqBJNWRnX+q1uuOafKWMt8X1UT2Jcy3vm0H2LZA72L\n 4yyksWJNr1OxMP6F5u8IlVcfd2f9Nnmq6q9qekDceewToM8oQzEKdnBiLzja1l5SnV78Ar/gqzH\n aSZMmduF6Z/wo60a+sWDGLUl+o0votus367xqYOnMf5VBgBOGb5E4QAduGGG6zN8+WoDAYuVTqs\n l6wQ2NMVppxToJgaD/E=","X-Received":"by 2002:a05:6820:2d08:b0:694:921b:b1b3 with SMTP id\n 006d021491bc7-694921bb3b4mr10688572eaf.26.1777044281467; Fri, 24 Apr 2026\n 08:24:41 -0700 (PDT)","MIME-Version":"1.0","References":"<20260423130323.32533-1-micbis.openwrt@gmail.com>\n <20260423130323.32533-3-micbis.openwrt@gmail.com>\n ","In-Reply-To":"","From":"Michele Bisogno ","Date":"Fri, 24 Apr 2026 17:24:30 +0200","X-Gm-Features":"AQROBzC2uXz76-Hf2i2wS-WvHKX_1up-XDlGjrhl0B2bCDzWXKS69e6uh-92sKc","Message-ID":"\n ","Subject":"Re: [PATCH v5 2/3] usb: gadget: rcar: Add support for reset\n controller","To":"Marek Vasut ","Cc":"Lukasz Majewski ,\n Mattijs Korpershoek ,\n Nobuhiro Iwamatsu , Tom Rini ,\n u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailman-Approved-At":"Sat, 25 Apr 2026 22:36:28 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]