[{"id":3680327,"web_url":"http://patchwork.ozlabs.org/comment/3680327/","msgid":"","list_archive_url":null,"date":"2024-10-24T15:03:25","subject":"Re: [PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","submitter":{"id":93215,"url":"http://patchwork.ozlabs.org/api/people/93215/","name":"ppalka via Sourceware Forge","email":"forge-bot+ppalka@forge-stage.sourceware.org"},"content":"(ppalka) ) commented on the code:\n\n\n> +++ libstdc++-v3/include/std/variant\n> @@ -1431,3 +1426,1 @@\n> - __throw_bad_variant_access(\"std::get: variant is valueless\");\n> - else\n> - __throw_bad_variant_access(\"std::get: wrong index for variant\");\n> + const char* __reasons[] = {\nPerhaps `__reasons` should be `static constexpr`?\n\n\n--\nhttps://forge.sourceware.org/gcc/gcc-TEST/pulls/3#issuecomment-95","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0tP76k99z1yD5\n\tfor ; Wed, 22 Apr 2026 18:56:11 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 135AC4B9DB7E\n\tfor ; Wed, 22 Apr 2026 08:56:10 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id B6E664B9DB4F\n for ; Wed, 22 Apr 2026 08:55:41 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id 67B234052C\n for ; Wed, 22 Apr 2026 08:55:41 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 135AC4B9DB7E","OpenDKIM Filter v2.11.0 sourceware.org B6E664B9DB4F"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org B6E664B9DB4F","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org B6E664B9DB4F","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776848141; cv=none;\n b=kR1rqL1fIU2TsKgn7XDZ33wlGAHXQmdA/3ARgYx9G5bOiNTDf1uFOBzvENJAEAFzbeDKjVnGW7TVqDRXSI8I1jbSmJxXS/9H0T0QBxcAwJk+E+4RK0w2490e52jv2HSw7p10Z1FdgoHUUNdfy48M0jRhuGUoxqQKH+Dnue3CZ5k=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776848141; c=relaxed/simple;\n bh=gczJTqGBLNGjNjs3Fx0MxyktuMnhlQ25mtcvxEoTQqE=;\n h=Subject:From:To:Date:Message-ID:MIME-Version;\n b=IFPniM4Kbv8JnMz4I2KexYZqq11Eygp2Pv0wXKV7x2tKtv4h3Bv+sfVO4St1UOLA97hzPa7YQgaffA2vUpMaeQCSBMWmUoFIBbnLGALSbMtEymPFtNLxfFotbQoXMQMVV1VEG9ekO6OEiW5ahHJEdaU79IWZEpH+ta0KXmBNk4o=","ARC-Authentication-Results":"i=1; server2.sourceware.org","Subject":"Re: [PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","From":"ppalka via Sourceware Forge\n ","To":"gcc-patches mailing list ","Date":"Thu, 24 Oct 2024 15:03:25 +0000","Message-ID":"\n ","In-Reply-To":"\n ","X-Mailer":"batrachomyomachia","X-Requested-Reviewer":"ppalka","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/3","X-Review":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/3#issuecomment-95","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","MIME-Version":"1.0","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3680328,"web_url":"http://patchwork.ozlabs.org/comment/3680328/","msgid":"","list_archive_url":null,"date":"2024-10-24T16:31:28","subject":"Re: [PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","submitter":{"id":93210,"url":"http://patchwork.ozlabs.org/api/people/93210/","name":"Jonathan Wakely via Sourceware Forge","email":"forge-bot+redi@forge-stage.sourceware.org"},"content":"Pushed upstream as 0dbc588acaa27a3a56bc9173bd577e1293f10046\n\n--\nhttps://forge.sourceware.org/gcc/gcc-TEST/pulls/3#issuecomment-124","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0tPG3kHPz1yD5\n\tfor ; Wed, 22 Apr 2026 18:56:18 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 7FE084B9DB7B\n\tfor ; Wed, 22 Apr 2026 08:56:16 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id 8FFA44B9DB70\n for ; Wed, 22 Apr 2026 08:55:44 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id 8E0494052E\n for ; Wed, 22 Apr 2026 08:55:41 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 7FE084B9DB7B","OpenDKIM Filter v2.11.0 sourceware.org 8FFA44B9DB70"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 8FFA44B9DB70","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 8FFA44B9DB70","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776848144; cv=none;\n b=oKLoffpaQ6amZJRaldOW3nW2UNRJzGFnfKS0gg+Uv/BdShBrbeT1vnwFxy8/rCeJoKj+2QNREdg8AXZgofeeBriJO3Ot0PZ97hzJQ0aU4GG3OPGVp1Imyn1Yu8u2QWB/6SP299XpAxdK/BED1xAH8nuPv+gejeOc7d6ifm636PA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776848144; c=relaxed/simple;\n bh=q1ekwWcn7jEP7WP/EfGhgkCyxhxMEsXwraUBaK+Pm5w=;\n h=Subject:From:To:Date:Message-ID:MIME-Version;\n b=M5fb+eonz9dUVkWEA9CPJ79Pf/dU4AIwaRXo4Q9hYUjVj1kHDVDkQXhKo2HYt5un8XeX+tCg8kIAfYjTXPVAbj4Dw69dcy/tEK1dg5bNhBDH5bxRn3mJqS5pJmHHvufKXw2m5+gm8eOzCy46Y7DtIVRCWqXiPr+eaHqHkmW1nbo=","ARC-Authentication-Results":"i=1; server2.sourceware.org","Subject":"Re: [PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","From":"Jonathan Wakely via Sourceware Forge\n ","To":"gcc-patches mailing list ","Date":"Thu, 24 Oct 2024 16:31:28 +0000","Message-ID":"\n ","In-Reply-To":"\n ","X-Mailer":"batrachomyomachia","X-Requested-Reviewer":"ppalka","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/3","X-Comment":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/3#issuecomment-124","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","MIME-Version":"1.0","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3680329,"web_url":"http://patchwork.ozlabs.org/comment/3680329/","msgid":"","list_archive_url":null,"date":"2024-10-23T16:51:27","subject":"Re: [PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","submitter":{"id":93213,"url":"http://patchwork.ozlabs.org/api/people/93213/","name":"Mark Wielaard via Sourceware Forge","email":"forge-bot+mark@forge-stage.sourceware.org"},"content":"Mark Wielaard (mark) ) commented on the code:\n\n\n> +++ libstdc++-v3/include/std/variant\n> @@ -1417,3 +1418,3 @@\n> const char* _M_reason = \"bad variant access\";\n> \n> - friend void __throw_bad_variant_access(const char* __what);\n> + friend void __throw_bad_variant_access(int);\nfriend? Really? bad friend!\n\n\n--\nhttps://forge.sourceware.org/gcc/gcc-TEST/pulls/3#issuecomment-59","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0tQY1WJJz1yD5\n\tfor ; Wed, 22 Apr 2026 18:57:25 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 63FF54B9DB6D\n\tfor ; Wed, 22 Apr 2026 08:57:23 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id 259774B9DB41\n for ; Wed, 22 Apr 2026 08:55:41 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id E76FC40527\n for ; Wed, 22 Apr 2026 08:55:40 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 63FF54B9DB6D","OpenDKIM Filter v2.11.0 sourceware.org 259774B9DB41"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 259774B9DB41","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 259774B9DB41","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776848141; cv=none;\n b=V6BPFhaTxqzoPufu23HpyXTkG40MTGtbBSMRC2+TLwy4ePTmGCub+CexfxsOaafmRmDcU4lBr5RNM0MrDrW6Na1Dd8PEbLOES7zZlbDB5J5xnK29SpV14vRmnpAsuWu3NkmKekqmEe8s1ew17FIl+uoI2hCm92Wuod4P4JEaapA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776848141; c=relaxed/simple;\n bh=eWFfJ1mutwUu0i3jKXEB9Djr7tTdqQ9K2VGejIOw+GU=;\n h=Subject:From:To:Date:Message-ID:MIME-Version;\n b=IL8a9GCe6hyTg1Y0PUNnmtp99EvcxkwEX/L2D+rIrktpo5VfG1PGiaWNO53mbW7GUVRzOyUI/Z0CShbDxIEjsBm8nkDCjIwIhmpLrX84AIW5BYK7XX5Bi3nc5BV7anYKFIfXnQNFr7ABCE1iyeSC8xSzGar0m6IFievw9L/Wb10=","ARC-Authentication-Results":"i=1; server2.sourceware.org","Subject":"Re: [PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","From":"Mark Wielaard via Sourceware Forge\n ","To":"gcc-patches mailing list ","Date":"Wed, 23 Oct 2024 16:51:27 +0000","Message-ID":"\n ","In-Reply-To":"\n ","X-Mailer":"batrachomyomachia","X-Requested-Reviewer":"ppalka","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/3","X-Review":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/3#issuecomment-59","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","MIME-Version":"1.0","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3680330,"web_url":"http://patchwork.ozlabs.org/comment/3680330/","msgid":"","list_archive_url":null,"date":"2024-10-24T15:01:09","subject":"Re: [PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","submitter":{"id":93215,"url":"http://patchwork.ozlabs.org/api/people/93215/","name":"ppalka via Sourceware Forge","email":"forge-bot+ppalka@forge-stage.sourceware.org"},"content":"(ppalka) ) commented on the code:\n\n\n> +++ libstdc++-v3/include/std/variant\n> @@ -1434,0 +1429,4 @@\n> + \"std::visit: variant is valueless\",\n> + \"std::visit: variant is valueless\"\n> + };\n> + _GLIBCXX_THROW_OR_ABORT(bad_variant_access(__reasons[__reason % 4u]));\nI wonder if we'd get an unused variable warning for `__reasons` if `__cpp_exceptions` is not defined and the macro argument gets discarded?\n\n> +++ libstdc++-v3/include/std/variant\n> @@ -1434,0 +1429,4 @@\n> + \"std::visit: variant is valueless\",\n> + \"std::visit: variant is valueless\"\n> + };\n> + _GLIBCXX_THROW_OR_ABORT(bad_variant_access(__reasons[__reason % 4u]));\nWe would, yes, I'll fix it.\n\n> +++ libstdc++-v3/include/std/variant\n> @@ -1434,0 +1429,4 @@\n> + \"std::visit: variant is valueless\",\n> + \"std::visit: variant is valueless\"\n> + };\n> + _GLIBCXX_THROW_OR_ABORT(bad_variant_access(__reasons[__reason % 4u]));\nOops, I added `maybe_unused` to the parameter, but then lost it when moving it to be defined as an inline friend. I'l re-add and re-test.\n\n\n--\nhttps://forge.sourceware.org/gcc/gcc-TEST/pulls/3#issuecomment-91","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0tQd4Xq1z1yD5\n\tfor ; Wed, 22 Apr 2026 18:57:29 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id C3EC04B9DB5E\n\tfor ; Wed, 22 Apr 2026 08:57:27 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id B4B724B9DB4B\n for ; Wed, 22 Apr 2026 08:55:41 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id 5252B4052B\n for ; Wed, 22 Apr 2026 08:55:41 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org C3EC04B9DB5E","OpenDKIM Filter v2.11.0 sourceware.org B4B724B9DB4B"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org B4B724B9DB4B","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org B4B724B9DB4B","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776848141; cv=none;\n b=YCYWPSOKSdOSUEA7m2fPEwh/wWX+1zf/MyTNiGH6xJ/UmR2N2+PmwQYluMLQBd+AKEwvEuGpes2sjQ/Faz6qqBEQ5sNQtlcS3zCLxUOOHgw21RoFU7mXO0eeGUAgCcAWIZ3rV4UxP0foD+GW3C0ihqEptsFv/VCUt3aMuDiu9Sk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776848141; c=relaxed/simple;\n bh=ZAV4ZBky8HtkV+Ox1xuBS7N1NDxGHlDX9L2EHVtD2Ig=;\n h=Subject:From:To:Date:Message-ID:MIME-Version;\n b=EZ9U8KvSvbQ1fx5ytB47zYXyjp4mzBGKVY00iWj46WFEiAM1EPtkqXe2VtzLf+v+35h9TNpUzO8Mn/wE3qik/ILOwxGXFm1PMmvUvK25NALQSk4eYlF4FV1AkB03rDkhKbmzCzwNAAFQRxBnBks8yRkk91OI0WlJ5gGXuwR2bzE=","ARC-Authentication-Results":"i=1; server2.sourceware.org","Subject":"Re: [PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","From":"ppalka via Sourceware Forge\n ","To":"gcc-patches mailing list ","Date":"Thu, 24 Oct 2024 15:01:09 +0000","Message-ID":"\n ","In-Reply-To":"\n ","X-Mailer":"batrachomyomachia","X-Requested-Reviewer":"ppalka","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/3","X-Review":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/3#issuecomment-91","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3680331,"web_url":"http://patchwork.ozlabs.org/comment/3680331/","msgid":"","list_archive_url":null,"date":"2026-04-22T08:55:45","subject":"[SUMMARY] Re: [PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","submitter":{"id":93210,"url":"http://patchwork.ozlabs.org/api/people/93210/","name":"Jonathan Wakely via Sourceware Forge","email":"forge-bot+redi@forge-stage.sourceware.org"},"content":"This is a summary of discussions relative to the merge request created by Jonathan Wakely (redi) titled\nlibstdc++: Simplify std::__throw_bad_variant_access\nsince its creation.\n\nDescription: This removes the overload of `__throw_bad_variant_access` that must be\ncalled with a string literal. This avoids a potential source of\nundefined behaviour if that function got misused. The other overload\nthat takes a bool parameter can be adjusted to take an int describing\nwhich of the four possible string literals to use, and ensure that the\n`std::bad_variant_access` constructor is only called with those. Passing\nan int outside the range [0,3] is bogus, but will still select a valid\nstring literal and avoid undefined behaviour.\n\n```\nlibstdc++-v3/ChangeLog:\n\n\t* include/std/variant (bad_variant_access): Adjust friend\n\tdeclaration.\n\t(__throw_bad_variant_access(const char*)): Remove.\n\t(__throw_bad_variant_access(bool)): Change parameter to int.\n\t(visit, visit): Adjust calls to __throw_bad_variant_access.\n```\n\n\n\nThe full and up to date discussion can be found at https://forge.sourceware.org/gcc/gcc-TEST/pulls/3\n\nThe merge request has been closed without being merged directly on the forge repository.\n\nOn 2024-10-23 16:51:27+00:00, Mark Wielaard (mark) commented on the code:\n\n\n> +++ libstdc++-v3/include/std/variant\n> @@ -1417,3 +1418,3 @@\n> const char* _M_reason = \"bad variant access\";\n> \n> - friend void __throw_bad_variant_access(const char* __what);\n> + friend void __throw_bad_variant_access(int);\nfriend? Really? bad friend!\n\nOn 2024-10-23 17:03:23+00:00, Jonathan Wakely (redi) commented on the code:\n\n\n> +++ libstdc++-v3/include/std/variant\n> @@ -1411,26 +1411,25 @@ namespace __detail::__variant\n> { return _M_reason; }\n> \n> private:\n> + // Must only be called with a string literal\nGithub suggestions don't work here in Forgejo, so you have to paste an inline diff like this:\n\n
\n```diff\n-    // Must only be called with a string literal \n+    // Must *only* be called with a string literal \n```\n
\n\nwhich is rendered like this:\n\n```diff\n- // Must only be called with a string literal \n+ // Must *only* be called with a string literal \n```\n\nIn github that would be:\n\n```suggestion\n // Must *only* be called with a string literal \n```\n\nAnd there's a UI button to auto-fill that from the line above being commented on.\n> +++ libstdc++-v3/include/std/variant\n> @@ -1411,26 +1411,25 @@ namespace __detail::__variant\n> { return _M_reason; }\n> \n> private:\n> + // Must only be called with a string literal\nOops, for the \"in github that would be\" I forgot the `
` tags. I meant to say:\n\n\n
\n```suggestion\n    // Must *only* be called with a string literal \n```\n
\n\n(but I can't edit the previous comment to fix it)\n> +++ libstdc++-v3/include/std/variant\n> @@ -1411,26 +1411,25 @@ namespace __detail::__variant\n>      { return _M_reason; }\n>  \n>    private:\n> +    // Must only be called with a string literal\nhttps://codeberg.org/forgejo/forgejo/issues/3933 requests the github \"suggestion\" feature\n\nOn 2024-10-24 14:57:23+00:00, (ppalka)  commented on the code:\n\n\n> +++ libstdc++-v3/include/std/variant\n> @@ -1426,3 +1424,1 @@\n> -\n> -  inline void\n> -  __throw_bad_variant_access(bool __valueless)\n> +  __throw_bad_variant_access(int __reason)\nWouldn't `unsigned` be better since it represents an array index?\n\nAnd while we're here, shall we mark this function as `[[noreturn]]`? \n> +++ libstdc++-v3/include/std/variant\n> @@ -1426,3 +1424,1 @@\n> -\n> -  inline void\n> -  __throw_bad_variant_access(bool __valueless)\n> +  __throw_bad_variant_access(int __reason)\nmkretz persuaded me that `int` is better because then we don't need to call it with `2u` to avoid `-Wsign-conversion` warnings.\n\nAlthough maybe that's not an issue since we always call it with non-negative constants, or `(int)v.valueless()` which is not negative either? I'll check.\n\nI have a separate patch that adds `noreturn` there (and elsewhere), see https://forge.sourceware.org/redi/gcc/commit/27b93f10cca4e36783cbfc3d9be98d5196199137\n> +++ libstdc++-v3/include/std/variant\n> @@ -1426,3 +1424,1 @@\n> -\n> -  inline void\n> -  __throw_bad_variant_access(bool __valueless)\n> +  __throw_bad_variant_access(int __reason)\nbtw adding `[[noreturn]]` is really annoying. You can't put it on the friend declaration because it's not valid there, but if you _don't_ put it on the friend declaration it's an error because it wasn't present on the first declaration. And you can't move the whole function before the class, because it uses the class. So you have to declare it before the class with `[[noreturn]]` then define it (either inline as a friend, or after the class).\n> +++ libstdc++-v3/include/std/variant\n> @@ -1426,3 +1424,1 @@\n> -\n> -  inline void\n> -  __throw_bad_variant_access(bool __valueless)\n> +  __throw_bad_variant_access(int __reason)\nWe don't get sign-conversion warnings here, and there are so many others in the library it wouldn't make any difference even if we got another one here.\n\nOn 2024-10-24 14:58:17+00:00, (ppalka)  commented on the code:\n\n\n> +++ libstdc++-v3/include/std/variant\n> @@ -1434,0 +1427,4 @@\n> +      \"std::get: wrong index for variant\",\n> +      \"std::get: variant is valueless\",\n> +      \"std::visit: variant is valueless\",\n> +      \"std::visit: variant is valueless\"\nNot sure what you think about trailing commas but we could add one here :)\n> +++ libstdc++-v3/include/std/variant\n> @@ -1434,0 +1427,4 @@\n> +      \"std::get: wrong index for variant\",\n> +      \"std::get: variant is valueless\",\n> +      \"std::visit: variant is valueless\",\n> +      \"std::visit: variant is valueless\"\nSeems reasonable, yeah.\n\nOn 2024-10-24 15:01:09+00:00, (ppalka)  commented on the code:\n\n\n> +++ libstdc++-v3/include/std/variant\n> @@ -1434,0 +1429,4 @@\n> +      \"std::visit: variant is valueless\",\n> +      \"std::visit: variant is valueless\"\n> +    };\n> +    _GLIBCXX_THROW_OR_ABORT(bad_variant_access(__reasons[__reason % 4u]));\nI wonder if we'd get an unused variable warning for `__reasons`  if `__cpp_exceptions` is not defined and the macro argument gets discarded?\n> +++ libstdc++-v3/include/std/variant\n> @@ -1434,0 +1429,4 @@\n> +      \"std::visit: variant is valueless\",\n> +      \"std::visit: variant is valueless\"\n> +    };\n> +    _GLIBCXX_THROW_OR_ABORT(bad_variant_access(__reasons[__reason % 4u]));\nWe would, yes, I'll fix it.\n> +++ libstdc++-v3/include/std/variant\n> @@ -1434,0 +1429,4 @@\n> +      \"std::visit: variant is valueless\",\n> +      \"std::visit: variant is valueless\"\n> +    };\n> +    _GLIBCXX_THROW_OR_ABORT(bad_variant_access(__reasons[__reason % 4u]));\nOops, I added `maybe_unused` to the parameter, but then lost it when moving it to be defined as an inline friend. I'l re-add and re-test.\n\nOn 2024-10-24 15:03:25+00:00, (ppalka)  commented on the code:\n\n\n> +++ libstdc++-v3/include/std/variant\n> @@ -1431,3 +1426,1 @@\n> -      __throw_bad_variant_access(\"std::get: variant is valueless\");\n> -    else\n> -      __throw_bad_variant_access(\"std::get: wrong index for variant\");\n> +    const char* __reasons[] = {\nPerhaps `__reasons` should be `static constexpr`?\n\nOn 2024-10-24 16:09:19+00:00, (ppalka)  approved the changes:\nLGTM\n\n\n\nOn 2024-10-24 16:31:28+00:00, Jonathan Wakely (redi) wrote:\n\nPushed upstream as 0dbc588acaa27a3a56bc9173bd577e1293f10046\n\n\nOn 2026-04-22 08:55:15+00:00, Lichenor Forgejo Bot (forge-bot) wrote:\n\n\nVersion 1 of this pull request has been stored. It includes the following commits:\n- libstdc++: Simplify std::__throw_bad_variant_access - f9cdc7e69f3aa30fb19aec0ee30d31bb43601515\n\n\n\nOn 2026-04-22 08:55:39+00:00, Lichenor Forgejo Bot (forge-bot) wrote:\n\nSent patch series version 1 containing 1 patches to gcc-patches mailing list .\n[Cover letter](https://inbox.sourceware.org/gcc-patches/bmm.hhu8qqul0c.gcc.gcc-TEST.redi.3.1.0@forge-stage.sourceware.org)","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0tQn1Bdxz1yD5\n\tfor ; Wed, 22 Apr 2026 18:57:37 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 2B63C4B9DB7B\n\tfor ; Wed, 22 Apr 2026 08:57:35 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id 54DC54B9DB74\n for ; Wed, 22 Apr 2026 08:55:45 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id 2FB5740527\n for ; Wed, 22 Apr 2026 08:55:45 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 2B63C4B9DB7B","OpenDKIM Filter v2.11.0 sourceware.org 54DC54B9DB74"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 54DC54B9DB74","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 54DC54B9DB74","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776848145; cv=none;\n b=mXsaiFhs/uaY7R8NjC0OY7VsUUaNYLUhzGHrEfi2VF1hu0CF+IL5+58TGBWaeAWrcLPku7A6Cqap9MyxXY7T3wztk01FefXKxqpExPNfzg8dMaZS5gT4cQuTmh//HzeIQXpYFDyYnZqTy3mlATM4XvYTqZ1eQyn7ZHDtNAXVaek=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776848145; c=relaxed/simple;\n bh=1bRrExEeK++jMvYViBTLjKSRY4Qb3EZN7D/bOsUTOVI=;\n h=Subject:From:To:Message-ID:MIME-Version:Date;\n b=g+FttV47rob6NLn1H3yqny+BrI5r0s+9wOG2lpTPY0IZDqh2ACHsGymeOseXpod0u+0GZ08RmQqRW8RcRM+HYVm7xqC/XHTg5Wyy4CgMTEtEa8S6JQ5aF2ZPxeKqp+PkQUj6f+7hX9rqBdbKcvhWEejuxFZcaDpBWXUyR30bpM4=","ARC-Authentication-Results":"i=1; server2.sourceware.org","Subject":"[SUMMARY] Re: [PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","From":"Jonathan Wakely via Sourceware Forge\n ","To":"gcc-patches mailing list ","In-Reply-To":"\n ","Message-ID":"\n ","X-Mailer":"batrachomyomachia","X-Requested-Reviewer":"ppalka","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/3","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","Date":"Wed, 22 Apr 2026 08:55:45 +0000 (UTC)","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3680332,"web_url":"http://patchwork.ozlabs.org/comment/3680332/","msgid":"","list_archive_url":null,"date":"2024-10-24T16:09:19","subject":"Re: [APPROVED][PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","submitter":{"id":93215,"url":"http://patchwork.ozlabs.org/api/people/93215/","name":"ppalka via Sourceware Forge","email":"forge-bot+ppalka@forge-stage.sourceware.org"},"content":"(ppalka)  approved the changes:\nLGTM\n\n\n--\nhttps://forge.sourceware.org/gcc/gcc-TEST/pulls/3#issuecomment-122","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0tQn4lNNz1yHB\n\tfor ; Wed, 22 Apr 2026 18:57:37 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id A9E814BA9026\n\tfor ; Wed, 22 Apr 2026 08:57:35 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id CAE944B9DB50\n for ; Wed, 22 Apr 2026 08:55:41 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id 7E0304052D\n for ; Wed, 22 Apr 2026 08:55:41 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org A9E814BA9026","OpenDKIM Filter v2.11.0 sourceware.org CAE944B9DB50"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org CAE944B9DB50","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org CAE944B9DB50","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776848141; cv=none;\n b=NbclNBKKdOoYq8NrBW2gvx0Y32dFB8x1/D6EBvXolB3Lo+kp3nXCOi5zWlmMNixVrvQ783YG6QZY9ZcoBJT2fR7BX4sxwOoXdW32ccoUM0F4NaKB7xo9Sq03TOL7YJj2g/mDjyy4G0Z+QqDkeaektPxfxNw8BUdRbXtzNbMdsF0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776848141; c=relaxed/simple;\n bh=zFtRKATDGYErZYljBeG+NlaFH1RTtdI18WnfEp2B58w=;\n h=Subject:From:To:Date:Message-ID:MIME-Version;\n b=deeNO3IN2ga34WJuT6yuu1SL0gyEcCAFSI6PUp45fL9IItxDhHlUeSa+ceJpfNpauHsftwbc6b/jVf0U2dScMeqLb0by2IBNOlfxgWDgF3NW6Gc8TkINvV68VfhnHO7DZU06oHtettPBcHJks916wT1iRUv4t/4KdpkG5f44I5E=","ARC-Authentication-Results":"i=1; server2.sourceware.org","Subject":"Re: [APPROVED][PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","From":"ppalka via Sourceware Forge\n ","To":"gcc-patches mailing list ","Date":"Thu, 24 Oct 2024 16:09:19 +0000","Message-ID":"\n ","In-Reply-To":"\n ","X-Mailer":"batrachomyomachia","X-Requested-Reviewer":"ppalka","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/3","X-Review":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/3#issuecomment-122","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","MIME-Version":"1.0","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3680334,"web_url":"http://patchwork.ozlabs.org/comment/3680334/","msgid":"","list_archive_url":null,"date":"2024-10-23T17:03:24","subject":"Re: [PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","submitter":{"id":93210,"url":"http://patchwork.ozlabs.org/api/people/93210/","name":"Jonathan Wakely via Sourceware Forge","email":"forge-bot+redi@forge-stage.sourceware.org"},"content":"Jonathan Wakely (redi) ) commented on the code:\n\n\n> +++ libstdc++-v3/include/std/variant\n> @@ -1411,26 +1411,25 @@ namespace __detail::__variant\n>      { return _M_reason; }\n>  \n>    private:\n> +    // Must only be called with a string literal\nGithub suggestions don't work here in Forgejo, so you have to paste an inline diff like this:\n\n
\n```diff\n-    // Must only be called with a string literal \n+    // Must *only* be called with a string literal \n```\n
\n\nwhich is rendered like this:\n\n```diff\n-    // Must only be called with a string literal \n+    // Must *only* be called with a string literal \n```\n\nIn github that would be:\n\n```suggestion\n    // Must *only* be called with a string literal \n```\n\nAnd there's a UI button to auto-fill that from the line above being commented on.\n\n> +++ libstdc++-v3/include/std/variant\n> @@ -1411,26 +1411,25 @@ namespace __detail::__variant\n>      { return _M_reason; }\n>  \n>    private:\n> +    // Must only be called with a string literal\nOops, for the \"in github that would be\" I forgot the `
` tags. I meant to say:\n\n\n
\n```suggestion\n    // Must *only* be called with a string literal \n```\n
\n\n(but I can't edit the previous comment to fix it)\n\n> +++ libstdc++-v3/include/std/variant\n> @@ -1411,26 +1411,25 @@ namespace __detail::__variant\n>      { return _M_reason; }\n>  \n>    private:\n> +    // Must only be called with a string literal\nhttps://codeberg.org/forgejo/forgejo/issues/3933 requests the github \"suggestion\" feature\n\n\n--\nhttps://forge.sourceware.org/gcc/gcc-TEST/pulls/3#issuecomment-61","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0tS21c1yz1yD5\n\tfor ; Wed, 22 Apr 2026 18:58:41 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id EE92C4B9DB5B\n\tfor ; Wed, 22 Apr 2026 08:58:39 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id 3895A4B9DB43\n for ; Wed, 22 Apr 2026 08:55:41 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id 0B3DE40528\n for ; Wed, 22 Apr 2026 08:55:41 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org EE92C4B9DB5B","OpenDKIM Filter v2.11.0 sourceware.org 3895A4B9DB43"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 3895A4B9DB43","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 3895A4B9DB43","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776848141; cv=none;\n b=sET7rj3fmGyrfOTnrJly+WvdeohKu1DHp8LA4Xt3GA3E7OucyJIn/6k28kzpVcfDDez13HKmmAtbB/4CriFCOR8pMWa/U8J9lsD1wbjGjP/BOameLFpQn3Wf61YCVfjwgTMLTIvwViaepnawbpFFraGWMx4DZxi8wR/b39qgsIQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776848141; c=relaxed/simple;\n bh=wuXz9xl7GJEzLQYgFFpZRjF/qbBiqZsZ5YDR0FcKnpk=;\n h=Subject:From:To:Date:Message-ID:MIME-Version;\n b=LyfbsgYCkJoMmQNSp9RNllI9NAGWIb9QT8B/kQpSKyIP7ck6ZybpBMl3mYDxWbQM+XZZ0M2CAgi4HoH+u4Sazp1i7tZw3huzEIvGYikZ62Uk5x7CvRF/H837E3PzgHX5wXp3Y3faNFR2+bgmpdtcoW7x4HPsQZOge9ReOOHqypk=","ARC-Authentication-Results":"i=1; server2.sourceware.org","Subject":"Re: [PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","From":"Jonathan Wakely via Sourceware Forge\n ","To":"gcc-patches mailing list ","Date":"Wed, 23 Oct 2024 17:03:24 +0000","Message-ID":"\n ","In-Reply-To":"\n ","X-Mailer":"batrachomyomachia","X-Requested-Reviewer":"ppalka","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/3","X-Review":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/3#issuecomment-61","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3680335,"web_url":"http://patchwork.ozlabs.org/comment/3680335/","msgid":"","list_archive_url":null,"date":"2026-04-22T08:55:39","subject":"Re: [PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","submitter":{"id":93212,"url":"http://patchwork.ozlabs.org/api/people/93212/","name":"Lichenor Forgejo Bot via Sourceware Forge","email":"forge-bot+forge-bot@forge-stage.sourceware.org"},"content":"Sent patch series version 1 containing 1 patches to gcc-patches mailing list .\n[Cover letter](https://inbox.sourceware.org/gcc-patches/bmm.hhu8qqul0c.gcc.gcc-TEST.redi.3.1.0@forge-stage.sourceware.org)\n\n--\nhttps://forge.sourceware.org/gcc/gcc-TEST/pulls/3#issuecomment-5492","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0tS64gc7z1yD5\n\tfor ; Wed, 22 Apr 2026 18:58:46 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id AAE494B9DB77\n\tfor ; Wed, 22 Apr 2026 08:58:44 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id D10984B9DB56\n for ; Wed, 22 Apr 2026 08:55:44 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id B080940526\n for ; Wed, 22 Apr 2026 08:55:41 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org AAE494B9DB77","OpenDKIM Filter v2.11.0 sourceware.org D10984B9DB56"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org D10984B9DB56","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org D10984B9DB56","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776848144; cv=none;\n b=TDrUDSyDrjyNfPtgdEMQ1V+tJml4ewPZZvWpuwdPvUQB/+QH3YbQrbGNqNaPbVj+mqLfDQeVmvQCqQQafMF3jNFTFf2GqVHyloSkN2pBd8n5HtnHQ1Zn/JlSai0L2ksosT/rD2M3lE+g9T84nNnKVJJ5KPJbuJfH8VyXr0PHvc0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776848144; c=relaxed/simple;\n bh=y24Bmwh69nekX/jXKSS4VpTtGkJ7L87sXBeCS6k7h4E=;\n h=Subject:From:To:Date:Message-ID:MIME-Version;\n b=UGJwP1l0sTBUQ0VWWIHn4xfFKc5+x7YtlqklQsl97kV/AZ9Ch5iDQqIr8avX6LUnz96s8V5mG5AFOVRvVF9HNzz8yNp84tYASpSsEAn7gTj9yKxLbL0WZpqfgRyEOycvvt6q4jLNLZdOANlZgFQOmbBINkdsbE+xCKBal1D/nHg=","ARC-Authentication-Results":"i=1; server2.sourceware.org","Subject":"Re: [PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","From":"Lichenor Forgejo Bot via Sourceware Forge\n ","To":"gcc-patches mailing list ","Date":"Wed, 22 Apr 2026 08:55:39 +0000","Message-ID":"\n ","In-Reply-To":"\n ","X-Mailer":"batrachomyomachia","X-Requested-Reviewer":"ppalka","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/3","X-Comment":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/3#issuecomment-5492","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3680338,"web_url":"http://patchwork.ozlabs.org/comment/3680338/","msgid":"","list_archive_url":null,"date":"2024-10-24T14:57:23","subject":"Re: [PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","submitter":{"id":93215,"url":"http://patchwork.ozlabs.org/api/people/93215/","name":"ppalka via Sourceware Forge","email":"forge-bot+ppalka@forge-stage.sourceware.org"},"content":"(ppalka) ) commented on the code:\n\n\n> +++ libstdc++-v3/include/std/variant\n> @@ -1426,3 +1424,1 @@\n> -\n> -  inline void\n> -  __throw_bad_variant_access(bool __valueless)\n> +  __throw_bad_variant_access(int __reason)\nWouldn't `unsigned` be better since it represents an array index?\n\nAnd while we're here, shall we mark this function as `[[noreturn]]`? \n\n> +++ libstdc++-v3/include/std/variant\n> @@ -1426,3 +1424,1 @@\n> -\n> -  inline void\n> -  __throw_bad_variant_access(bool __valueless)\n> +  __throw_bad_variant_access(int __reason)\nmkretz persuaded me that `int` is better because then we don't need to call it with `2u` to avoid `-Wsign-conversion` warnings.\n\nAlthough maybe that's not an issue since we always call it with non-negative constants, or `(int)v.valueless()` which is not negative either? I'll check.\n\nI have a separate patch that adds `noreturn` there (and elsewhere), see https://forge.sourceware.org/redi/gcc/commit/27b93f10cca4e36783cbfc3d9be98d5196199137\n\n> +++ libstdc++-v3/include/std/variant\n> @@ -1426,3 +1424,1 @@\n> -\n> -  inline void\n> -  __throw_bad_variant_access(bool __valueless)\n> +  __throw_bad_variant_access(int __reason)\nbtw adding `[[noreturn]]` is really annoying. You can't put it on the friend declaration because it's not valid there, but if you _don't_ put it on the friend declaration it's an error because it wasn't present on the first declaration. And you can't move the whole function before the class, because it uses the class. So you have to declare it before the class with `[[noreturn]]` then define it (either inline as a friend, or after the class).\n\n> +++ libstdc++-v3/include/std/variant\n> @@ -1426,3 +1424,1 @@\n> -\n> -  inline void\n> -  __throw_bad_variant_access(bool __valueless)\n> +  __throw_bad_variant_access(int __reason)\nWe don't get sign-conversion warnings here, and there are so many others in the library it wouldn't make any difference even if we got another one here.\n\n\n--\nhttps://forge.sourceware.org/gcc/gcc-TEST/pulls/3#issuecomment-87","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0tTW6shkz1yD5\n\tfor ; Wed, 22 Apr 2026 18:59:59 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 291684B9DB75\n\tfor ; Wed, 22 Apr 2026 08:59:58 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id 4FE3B4B9DB47\n for ; Wed, 22 Apr 2026 08:55:41 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id 2491440529\n for ; Wed, 22 Apr 2026 08:55:41 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 291684B9DB75","OpenDKIM Filter v2.11.0 sourceware.org 4FE3B4B9DB47"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 4FE3B4B9DB47","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 4FE3B4B9DB47","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776848141; cv=none;\n b=M5q9lxkNw7KeTLdex2VTX2fQOKdzRjzaRPzbTVOBEkHNTZMZe9I9CDxsxtCiNiYx/qUYCwj2eL6Vz0ZXGsUUtKpAIJ6hXPXzhZbZoxCNX5bvgBJ8CO+7CDhgYr3PyaaPmCZxg0NO02sK6WUuaDA7ZeHgC9zLsFZzMbyfj4xpRBg=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776848141; c=relaxed/simple;\n bh=zxB40fwUOBvAm9LcZLxxb1LYQBK8hH0cChxJBmCDb80=;\n h=Subject:From:To:Date:Message-ID:MIME-Version;\n b=av9ZUCUZAxQZk3zPqMSRr+jMLn9Wd+bx9/Fn7GJGmUYkeI9VoG7LaLB9RuVkWHIcBHOqsQF2hoUTWpDq2hFvlUxauk2S/3SA+lC6VEndN2QOGa86NWF0IVMTZub1DUWWpV1SMOWm6M7mwZwT4jS9d1wUizdsRF9ys1nT5W+2KRY=","ARC-Authentication-Results":"i=1; server2.sourceware.org","Subject":"Re: [PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","From":"ppalka via Sourceware Forge\n ","To":"gcc-patches mailing list ","Date":"Thu, 24 Oct 2024 14:57:23 +0000","Message-ID":"\n ","In-Reply-To":"\n ","X-Mailer":"batrachomyomachia","X-Requested-Reviewer":"ppalka","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/3","X-Review":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/3#issuecomment-87","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3680342,"web_url":"http://patchwork.ozlabs.org/comment/3680342/","msgid":"","list_archive_url":null,"date":"2024-10-24T14:58:17","subject":"Re: [PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","submitter":{"id":93215,"url":"http://patchwork.ozlabs.org/api/people/93215/","name":"ppalka via Sourceware Forge","email":"forge-bot+ppalka@forge-stage.sourceware.org"},"content":"(ppalka) ) commented on the code:\n\n\n> +++ libstdc++-v3/include/std/variant\n> @@ -1434,0 +1427,4 @@\n> +      \"std::get: wrong index for variant\",\n> +      \"std::get: variant is valueless\",\n> +      \"std::visit: variant is valueless\",\n> +      \"std::visit: variant is valueless\"\nNot sure what you think about trailing commas but we could add one here :)\n\n> +++ libstdc++-v3/include/std/variant\n> @@ -1434,0 +1427,4 @@\n> +      \"std::get: wrong index for variant\",\n> +      \"std::get: variant is valueless\",\n> +      \"std::visit: variant is valueless\",\n> +      \"std::visit: variant is valueless\"\nSeems reasonable, yeah.\n\n\n--\nhttps://forge.sourceware.org/gcc/gcc-TEST/pulls/3#issuecomment-89","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0tW12H1pz1y2d\n\tfor ; Wed, 22 Apr 2026 19:01:17 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 7DF484BA9026\n\tfor ; Wed, 22 Apr 2026 09:01:15 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id B42D34B9DB49\n for ; Wed, 22 Apr 2026 08:55:41 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id 3CD8F4052A\n for ; Wed, 22 Apr 2026 08:55:41 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 7DF484BA9026","OpenDKIM Filter v2.11.0 sourceware.org B42D34B9DB49"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org B42D34B9DB49","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org B42D34B9DB49","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776848141; cv=none;\n b=Hipxn+XTdgMB4d3fAuYRWOfHL8jcpNggNL3K2L5wlMvdlgsvZfoQPmbSWlleJIP7XYK+kwp8ntaO60AF3W9iGz+gAHf604bW549LziteSwzPR61hKEUUdE19Vv9c+hb9QetVdMhMB2kR1W2cPRb4u12tKqeQC9eN5ogY7UqPmhM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776848141; c=relaxed/simple;\n bh=dgKXJIboIEeOFEfx6tdVoPfSm6eZRrooePuzoo4YQX0=;\n h=Subject:From:To:Date:Message-ID:MIME-Version;\n b=lyKksUZhuJ5nuM9PyLfDBBR/ZnPYHpTbruVOar1ZZNDVnh5Wo8Wa+5N3BgHVlUTT7Tbn7oVlYqKMO/A/wr7vG1o4kV2dngmarDuXV6nzdzhBwCyTTdNjnNN20oM/919nZl2RwE6JqSyiEBIPzZuvpODd3YjapfcqfWgTMbaFLZg=","ARC-Authentication-Results":"i=1; server2.sourceware.org","Subject":"Re: [PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","From":"ppalka via Sourceware Forge\n ","To":"gcc-patches mailing list ","Date":"Thu, 24 Oct 2024 14:58:17 +0000","Message-ID":"\n ","In-Reply-To":"\n ","X-Mailer":"batrachomyomachia","X-Requested-Reviewer":"ppalka","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/3","X-Review":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/3#issuecomment-89","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","MIME-Version":"1.0","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3680346,"web_url":"http://patchwork.ozlabs.org/comment/3680346/","msgid":"","list_archive_url":null,"date":"2026-04-22T08:55:15","subject":"Re: [PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","submitter":{"id":93212,"url":"http://patchwork.ozlabs.org/api/people/93212/","name":"Lichenor Forgejo Bot via Sourceware Forge","email":"forge-bot+forge-bot@forge-stage.sourceware.org"},"content":"\nVersion 1 of this pull request has been stored. It includes the following commits:\n- libstdc++: Simplify std::__throw_bad_variant_access - f9cdc7e69f3aa30fb19aec0ee30d31bb43601515\n\n\n--\nhttps://forge.sourceware.org/gcc/gcc-TEST/pulls/3#issuecomment-5490","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org","sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org","server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0tXW2K9mz1yHB\n\tfor ; Wed, 22 Apr 2026 19:02:35 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 52DE94B9DB6A\n\tfor ; Wed, 22 Apr 2026 09:02:33 +0000 (GMT)","from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id 9BC1E4B9DB72\n for ; Wed, 22 Apr 2026 08:55:44 +0000 (GMT)","from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id A12AF40525\n for ; Wed, 22 Apr 2026 08:55:41 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 52DE94B9DB6A","OpenDKIM Filter v2.11.0 sourceware.org 9BC1E4B9DB72"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 9BC1E4B9DB72","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 9BC1E4B9DB72","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776848144; cv=none;\n b=veATYZGp3IGHFe0E+aJkXl+kVh5wkNQXJ7gJZCIgoorlQnc+6R+A7FwB9VggSSvH+w/u8w1crJFvJRzvrHwB+kz8gQavQekSDs1qAxCVPpxyBpYhMQKiYB60CKAs9pVcszxyhlIf6COgGDV1jWkbU9uZiCUDh7Xf61QHFjmJvNo=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776848144; c=relaxed/simple;\n bh=Uv1vpSoitLTXUWMjCTB4SM9qHqFh98RJKD+FBaGfQw8=;\n h=Subject:From:To:Date:Message-ID:MIME-Version;\n b=tvKsXZDlPUSHLGbpm5tKPJYyp+JBi1WCxSSD6n7/CMmo5qq0df7hIYZPaBDGvcojCSltawQPkNS2ZCmXOudngtjcAxNI53ksrBvMZ1PvQsYMNhAWpbOoINUGBW3ctsJRSOHFxIjSpXsAsmbYxjc2/Tb8XZ1FaeeIxcVMPV+0VVw=","ARC-Authentication-Results":"i=1; server2.sourceware.org","Subject":"Re: [PATCH v1 0/1] libstdc++: Simplify\n std::__throw_bad_variant_access","From":"Lichenor Forgejo Bot via Sourceware Forge\n ","To":"gcc-patches mailing list ","Date":"Wed, 22 Apr 2026 08:55:15 +0000","Message-ID":"\n ","In-Reply-To":"\n ","X-Mailer":"batrachomyomachia","X-Requested-Reviewer":"ppalka","X-Pull-Request-Organization":"gcc","X-Pull-Request-Repository":"gcc-TEST","X-Pull-Request":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/3","X-Comment":"https://forge.sourceware.org/gcc/gcc-TEST/pulls/3#issuecomment-5490","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]