[{"id":3679704,"web_url":"http://patchwork.ozlabs.org/comment/3679704/","msgid":"","list_archive_url":null,"date":"2026-04-21T07:17:16","subject":"ACK/Cmnt: [SRU][N][PATCH 0/1] Revert \"netfilter: conntrack: fix\n erronous removal of offload bit\"","submitter":{"id":2898,"url":"http://patchwork.ozlabs.org/api/people/2898/","name":"Stefan Bader","email":"stefan.bader@canonical.com"},"content":"On 21/04/2026 08:29, Gerald Yang wrote:\n> BugLink: https://bugs.launchpad.net/bugs/2149762\n> \n> [Impact]\n> \n> With this commit:\n> netfilter: conntrack: fix erronous removal of offload bit\n> \n> We hit the regression on PS6/7, all the nodes with this commit hit soft lockup every 1-2 days and need to reboot the nodes to recover, e.g.:\n> \n> [1022567.831263] watchdog: BUG: soft lockup - CPU#352 stuck for 26s! [kworker/u789:13:1036823]\n> [1022567.831271] Modules linked in: scsi_transport_iscsi mlx5_vfio_pci vfio_pci_core vfio_iommu_type1 vfio iommufd vhost_net tap xfs act_csum act_pedit act_ct nf_flow_table act_tunnel_key xt_CT xt_tcpudp nft_compat dm_crypt ebtable_filter ebtables ip6table_raw ip6table_mangle ip6table_nat ip6table_filter ip6_tables iptable_raw iptable_mangle iptable_nat iptable_filter nf_tables veth nf_conntrack_netlink vhost_vsock vmw_vsock_virtio_transport_common vhost vsock nvme_fabrics nvme_keyring act_mirred act_skbedit act_vlan cls_matchall 8021q garp mrp geneve ip6_udp_tunnel udp_tunnel nfnetlink_cttimeout nfnetlink act_gact cls_flower sch_ingress openvswitch nsh nf_conncount nf_nat bridge stp llc bonding sunrpc binfmt_misc intel_rapl_msr intel_rapl_common amd64_edac edac_mce_amd kvm_amd kvm irqbypass rapl ipmi_ssif nls_iso8859_1 joydev input_leds ipmi_si ipmi_devintf k10temp ccp ipmi_msghandler mac_hid mlx5_vdpa vringh vhost_iotlb vdpa dm_service_time sch_fq_codel dm_multipath scsi_dh_rdac scsi_dh_emc scsi_dh_alua nf_conntrack\n> [1022567.831352] nf_defrag_ipv6 nf_defrag_ipv4 efi_pstore ip_tables x_tables autofs4 btrfs blake2b_generic raid456 async_raid6_recov async_memcpy async_pq async_xor async_tx xor raid6_pq libcrc32c raid1 raid0 mlx5_ib ib_uverbs macsec ib_core raid10 hid_generic usbhid ses hid enclosure dax_hmem mlx5_core crct10dif_pclmul crc32_pclmul cxl_acpi polyval_clmulni cxl_port mlxfw polyval_generic ghash_clmulni_intel sha256_ssse3 sha1_ssse3 cxl_core psample nvme mpt3sas ahci raid_class nvme_core tls ast tg3 scsi_transport_sas libahci pci_hyperv_intf nvme_auth i2c_algo_bit xhci_pci xhci_pci_renesas i2c_piix4 aesni_intel crypto_simd cryptd\n> [1022567.831407] CPU: 352 PID: 1036823 Comm: kworker/u789:13 Kdump: loaded Tainted: G L 6.8.0-106-generic #106~22.04.1+hf399032v20260316b0-Ubuntu\n> [1022567.831411] Hardware name: Lenovo ThinkSystem SR665 V3/SB27B75430, BIOS KAE140F-5.70 09/03/2025\n> [1022567.831413] Workqueue: events_power_efficient nf_flow_offload_work_gc [nf_flow_table]\n> [1022567.831425] RIP: 0010:rhashtable_walk_next+0x17/0xd0\n> [1022567.831433] Code: 00 00 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 55 48 89 e5 41 57 41 56 41 55 41 54 53 4c 8b 37 48 89 fb 4c 8b 7f 10 <4c> 8b 6f 08 45 0f b6 66 38 41 80 fc 01 0f 87 e4 b1 98 00 41 83 e4\n> [1022567.831435] RSP: 0018:ff732ea21e2cbda8 EFLAGS: 00000202\n> [1022567.831438] RAX: ff2b1e3b98ea4058 RBX: ff732ea21e2cbde0 RCX: 0000000000000000\n> [1022567.831440] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ff732ea21e2cbde0\n> [1022567.831441] RBP: ff732ea21e2cbdd0 R08: 0000000000000000 R09: 0000000000000000\n> [1022567.831442] R10: 0000000000000000 R11: 0000000000000000 R12: ff2b1cb8611cbee8\n> [1022567.831444] R13: ff2b1cb8611cbe40 R14: ff2b1cb8611cbe48 R15: ff2b1e3b98ea4058\n> [1022567.831445] FS: 0000000000000000(0000) GS:ff2b1fb3bb000000(0000) knlGS:0000000000000000\n> [1022567.831447] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033\n> [1022567.831449] CR2: 0000775a42eee000 CR3: 0000019530ce8003 CR4: 0000000000f71ef0\n> [1022567.831450] PKRU: 55555554\n> [1022567.831452] Call Trace:\n> [1022567.831454] \n> [1022567.831461] nf_flow_offload_work_gc+0x5a/0xf0 [nf_flow_table]\n> [1022567.831468] process_one_work+0x181/0x3a0\n> [1022567.831475] worker_thread+0x306/0x440\n> [1022567.831479] ? __pfx_worker_thread+0x10/0x10\n> [1022567.831481] kthread+0xef/0x120\n> [1022567.831485] ? __pfx_kthread+0x10/0x10\n> [1022567.831487] ret_from_fork+0x44/0x70\n> [1022567.831492] ? __pfx_kthread+0x10/0x10\n> [1022567.831494] ret_from_fork_asm+0x1b/0x30\n> [1022567.831502] \n> [1022568.208115] R13: 0000000000000002 R14: 0000000000000002 R15: 0003a1fef9c1d979\n> [1022568.216666] ? cpuidle_enter_state+0xca/0x720\n> [1022568.222092] ? tick_nohz_stop_tick+0x70/0x210\n> [1022568.227521] cpuidle_enter+0x2e/0x50\n> [1022568.232060] call_cpuidle+0x23/0x60\n> [1022568.236472] cpuidle_idle_call+0x11d/0x190\n> [1022568.241562] do_idle+0x87/0xf0\n> [1022568.245472] cpu_startup_entry+0x2a/0x30\n> [1022568.250357] start_secondary+0x129/0x160\n> [1022568.255243] secondary_startup_64_no_verify+0x184/0x18b\n> [1022568.261586] \n> \n> [Fix]\n> \n> Without this commit, we spent few weeks to confirm PS6/7 nodes running without any lockup.\n> This commit is a follow-up fix for:\n> netfilter: conntrack: rework offload nf_conn timeout extension logic\n> \n> But the call path and logic starting from flow_offload_fixup_ct changed between these 2 commits.\n> Only manually backport this commit without all the changes in the middle causes issue, and the commit message also says what it fixes is harmless.\n> \n> [Test Plan]\n> \n> We have run a test kernel without this commit on PS6/7 for almost 2 weeks without hitting any soft lockup.\n> \n> [Where problems could occur]\n> \n> The commit we revert, its commit message says what it fixes is harmless,\n> and we have already run the kernel without it for almost 2 weeks without any issue, the risk is very low.\n> \n> Gerald Yang (1):\n> Revert \"netfilter: conntrack: fix erronous removal of offload bit\"\n> \n> net/netfilter/nf_flow_table_core.c | 10 ++++------\n> 1 file changed, 4 insertions(+), 6 deletions(-)\n> \nPositive test results and reverted patch was only picked based on \nupstream fixed-by reference. This seems to be incorrect (or at least \nrequire much more work to be applicable).\n\nAcked-by: Stefan Bader ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=MSLFCL7i;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com\n (client-ip=185.125.189.65; helo=lists.ubuntu.com;\n envelope-from=kernel-team-bounces@lists.ubuntu.com;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0DG33g2sz1yGt\n\tfor ; Tue, 21 Apr 2026 17:17:46 +1000 (AEST)","from localhost ([127.0.0.1] helo=lists.ubuntu.com)\n\tby lists.ubuntu.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1wF5MX-0000K8-Vg; Tue, 21 Apr 2026 07:17:37 +0000","from smtp-relay-internal-0.internal ([10.131.114.225]\n helo=smtp-relay-internal-0.canonical.com)\n by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.86_2) (envelope-from )\n id 1wF5MW-0000K1-9u\n for kernel-team@lists.ubuntu.com; Tue, 21 Apr 2026 07:17:36 +0000","from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n [209.85.128.69])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 0EF403FE82\n for ; Tue, 21 Apr 2026 07:17:36 +0000 (UTC)","by mail-wm1-f69.google.com with SMTP id\n 5b1f17b1804b1-488c213b485so32883835e9.2\n for ; Tue, 21 Apr 2026 00:17:36 -0700 (PDT)","from [192.168.2.167] ([89.244.127.40])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fc18bccfsm314144235e9.8.2026.04.21.00.17.33\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 21 Apr 2026 00:17:33 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1776755856;\n bh=XqTSicku2JwfwoazTI9fSOcntODqtwJbbjzcNW3ff30=;\n h=Message-ID:Date:MIME-Version:Subject:To:References:From:\n In-Reply-To:Content-Type;\n b=MSLFCL7iTj92J7Pgs+chWOFag83Oa8JuJ8QYtr68t71LuNAcm5zUGfyluzvRLM5QQ\n FPOWaUn1G++bFzsEdJ0byXEXGgxsELpnv7aOA45t8uPOjFWDn3eV3GtTGTfWuiqynI\n N72D4xyWbO3ZBQyrNzZ6l0ODNw1t7sa0k9Eo3DqWjCsd2NECjNElh/mdrRr7gAuONZ\n 2s7OqqG/P0IqNJHoUvA1wYr9EgduhbUQWPBGwSbhtwTRiP+El84X8M2Dva1OgNty78\n aqOiHOZdiA/tSihamHkp1t8TV6R5sWniMuhBi7yXf/XpzzAcOoaWBBe6ToPba/cikK\n PfIMg4AxQesfqohphnIxPPGxVXVv2V1N9z2XqHQQSwCIGNErEYlvbeGUwBZ8Zyp1Ck\n BnSaFhFROqkmkhUpmg1j0Z6SRHNeM3AN53MKI7lEMv7UGEXpflc2xXz+4cvaNYHvGQ\n VDtiqzMsrVMHyJWMddmf2yWcQOm8f+CDTuO2JINC4K7aWZx6VUyXo/s/iNdL7j4q7U\n J84P93UV228S9p+btVyUpuHGlbqxA4K3jC+zr6U9xL48+ULu+rCqX9NrX4VO58FR/K\n jMb8iE5Fyo+zihbATfNTnPai4/zkJVrdVd5Uypvq0PVvHaByEmaqL9GIZZ4vk6/Cj5\n zOS8KyFdDUmgZSrdUg/uFm7s=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776755855; x=1777360655;\n h=in-reply-to:autocrypt:content-language:from:references:to:subject\n :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state\n :from:to:cc:subject:date:message-id:reply-to;\n bh=XqTSicku2JwfwoazTI9fSOcntODqtwJbbjzcNW3ff30=;\n b=idlyfYa7zwnCd0ZGpmzQHAW/BC5mJRtpYjTym3RFqYV9ksMNd0ziKBffYfuSHC/vTu\n lDEVBpvL3JjoO6n56fP0CmQ70b+O45yPYHHFSmZpnJD2SsYFAZYqXFPUYRhFC7ihi3UE\n B+YkbyYq6oWaUrg+hoiGuJWvSLVlm+q8Kysvda9Dr7MqeoJJbKtpVjJ1bHRfJvxyIABx\n y4Avi60+aSWciFK5QUPUDXHPuujbFoNY7MYwEeDYz4n97DWLpdJV2joZmUoZ5pmJY89k\n FU8s1PxiF0sC3cZsRsR1SgOj1ObXr/9BOazK9m5gMsL7oGN3W2WfnZIfArSpjSwmSlJK\n acsw==","X-Gm-Message-State":"AOJu0YybOUSojKsckyfPu+ZFTMTldcR6qOzfkwBoF112i02B8ZErPGs0\n Yt38mdx7xF31PNVs6XZqOR+UPYZIpxwDOgmmYqskbpkshQ7FWctWpHXafMQ6ryf0o2CkckVP9S9\n QOETaXOd5UHqAzVmW1FAot7XvDkKhYGnF+Qj4B24gxZvPJfbn8mUlV8bbrlqNPK3DFWBxBLnZXb\n QqwPOFWQNSXJpEcQ==","X-Gm-Gg":"AeBDietkJ18lmj7F3/ByPxllOrqbiMqDMEjsxpzGcCUytdDgkLg9iVxdWaH9MDAzdnj\n TOJdg3qePztgqPFQVNjvFT00V5mHGtNp6CDZFGeGngAFPBppmHVL5tbJz5gEGEQzypH5igASmzB\n BiD4qePA5f/75yvxwiqGMZHMCYH16jQKo/hmPPpfBxxCFUOAESGgZkFqEYlosAshNighU1Gisv4\n 9ATm9SBFafTnljA4ghNzNjtlE8YwGhEDGhnOnXumdgDeY22U92ZrsT1lMUPXiEVaYh/LTjdofTt\n NrhTUFKk7sMqbpeYgu+Cgq9OMQwes0EtT7LTYTmc5x8djgr6WqAnTbgewYi7sULMoAmO4FoKC7F\n IcsIy3q+/x0okoGRIi8RE8bhC/xwHARPdEyauUlUllk9MIw==","X-Received":["by 2002:a05:600c:8909:b0:489:1b10:d896 with SMTP id\n 5b1f17b1804b1-4891b10dd45mr101974405e9.0.1776755855390;\n Tue, 21 Apr 2026 00:17:35 -0700 (PDT)","by 2002:a05:600c:8909:b0:489:1b10:d896 with SMTP id\n 5b1f17b1804b1-4891b10dd45mr101973895e9.0.1776755854707;\n Tue, 21 Apr 2026 00:17:34 -0700 (PDT)"],"Message-ID":"","Date":"Tue, 21 Apr 2026 09:17:16 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"ACK/Cmnt: [SRU][N][PATCH 0/1] Revert \"netfilter: conntrack: fix\n erronous removal of offload bit\"","To":"kernel-team@lists.ubuntu.com","References":"<20260421062928.2968600-1-gerald.yang@canonical.com>","From":"Stefan Bader ","Content-Language":"en-US, de-DE","Autocrypt":"addr=stefan.bader@canonical.com; keydata=\n xsFNBE5mmXEBEADoM0yd6ERIuH2sQjbCGtrt0SFCbpAuOgNy7LSDJw2vZHkZ1bLPtpojdQId\n 258o/4V+qLWaWLjbQdadzodnVUsvb+LUKJhFRB1kmzVYNxiu7AtxOnNmUn9dl1oS90IACo1B\n BpaMIunnKu1pp7s3sfzWapsNMwHbYVHXyJeaPFtMqOxd1V7bNEAC9uNjqJ3IG15f5/50+N+w\n LGkd5QJmp6Hs9RgCXQMDn989+qFnJga390C9JPWYye0sLjQeZTuUgdhebP0nvciOlKwaOC8v\n K3UwEIbjt+eL18kBq4VBgrqQiMupmTP9oQNYEgk2FiW3iAQ9BXE8VGiglUOF8KIe/2okVjdO\n nl3VgOHumV+emrE8XFOB2pgVmoklYNvOjaIV7UBesO5/16jbhGVDXskpZkrP/Ip+n9XD/EJM\n ismF8UcvcL4aPwZf9J03fZT4HARXuig/GXdK7nMgCRChKwsAARjw5f8lUx5iR1wZwSa7HhHP\n rAclUzjFNK2819/Ke5kM1UuT1X9aqL+uLYQEDB3QfJmdzVv5vHON3O7GOfaxBICo4Z5OdXSQ\n SRetiJ8YeUhKpWSqP59PSsbJg+nCKvWfkl/XUu5cFO4V/+NfivTttnoFwNhi/4lrBKZDhGVm\n 6Oo/VytPpGHXt29npHb8x0NsQOsfZeam9Z5ysmePwH/53Np8NQARAQABzTVTdGVmYW4gQmFk\n ZXIgKENhbm9uaWNhbCkgPHN0ZWZhbi5iYWRlckBjYW5vbmljYWwuY29tPsLBlwQTAQoAQQIb\n AwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgAIZARYhBNtdfMrzmU4zldpNPuhnXe7L7s6jBQJp\n W2G+BQkdRgtNAAoJEOhnXe7L7s6jKkkQAJVQyg5OSey93jOS5eyVwR2/9OIWllLPx7dfxsqR\n OPB6lWCTSFUPoZDOYyPFCKCtGUDBKopqIFpZcBgCRxzeF9QW9DnGqgMcZj5eUs/s7iNYEaqB\n 2ZwNAZZ9TWdBoTXjgTdpNq/4DrY8DxnI9/6/3QnYQ2sRdWCEzsqIFSRPQw+m94SNytWn8ow4\n PbiycCxYXUbr86j5j/OJmi++JDTEvpidR43Q/oGIOdJi26CKVKjpzyGFwVGOz/O3DPhQDvv9\n gqatT8fwCDHtOW5wEv2vm402jUEROj4wgEDvzak5yv7rgnAFTSZhvyVLbHeiOnamRZgeReGN\n k9jYobAIzA0zn+mm3jvmwvD7zrvaosUdwzaB9m0tkEKaI2seA2UJBiX+XCXIRbFwoOvCMxiU\n +RLcfElVjYMwNcQPkNu8vkk2APDNYpGBEovwX9b8VleOAt8oSMk/wMip+fEcPgdCO9mnVjb6\n R6VuUTTrnqzGMurA3M1b3OQApSQqHt9mEyNCjWEXm8IPzg+b3gsNGLD6N8eYE8zpoG/afCMQ\n ihrg6BOpiRUwIo0FuTteEyKqW7WCT8Dz6Y2mKRYTETAetshOgb7IeYIbf71olfTNZW/VWaUC\n A/KBqtzKPCKz7ymQwMSO/EkFt3MvyTdkIk1OU7wwudMe71ml0new05FeZ/reP1VSC5zWzsFN\n BE5mmXEBEADCkRfuS1cAx02yTsk9gyAapcQnpb6EBay40Ch/IPrMF2iG4F0CX6puKubjjVbq\n L6jEKyksqPb57Vu9WAufy4Rlv3OwzaymmWk00CROCVSuEV+3bikBTnF/l+VVCvccNlpHsADM\n LncaATvSOj1iCXeikxNAk2LA3g9H8uz7lQUhjni05ixBZGDGbaxB6Odmh58q8k/iooREHyqf\n leSg1zpuBxYGKVug2daXLSvQI7w59eYO/L1YpLtu1sMzqRyYdSUyCiNcXDO/Ko221o2NfdqQ\n 9KET1az8QTsBnZeTsjsk4VnYwjc9ZEYN7LATWrhz8vgI2eP80lXxXm9kx81NubnOPxna5vg9\n DhxZEjo8A+zE4c5bQuSCJ3GTnOalXsAz0Lwk1H1nFwizUqvmPI8eAqZGeZoJ409uDcNi2BrR\n +W7MjXxPM5k4M2zMiNfIvNBjclBLE/m7nrcxNLOk1z/KQiFVZQhtHXoOTUWmINZ+E3GIJT2D\n ToFxUoaEW2GdX0rjqEerbUaoo6SBX7HxmjAzseND9IatGTxgN+EhJUiIWK4UOH343erB7Hga\n 98WeEzZTq7W2NvwnqOVAq2ElnPhHrD98nWIBZPOEu6xgiyvVFfXJGmRBMRBR+8hBjfX0643n\n Lq3wYOrZbNfP8dJVQZ4GxI6OLTcwYNgifqp/SIJzE1tgkwARAQABwsF8BBgBCgAmAhsMFiEE\n 2118yvOZTjOV2k0+6Gdd7svuzqMFAmlbYgMFCRz28ZIACgkQ6Gdd7svuzqPdcA/+O2pTiwcb\n DcmERqn1LG1ew8QruGyUXa2sUYGXM239ARnKCaAqJVV0E9pn3oYG6cJ73k/JSvkWJD9iCFcX\n TAwhSrLnC/qT/rzCIHdSUK7PKoj3ixhwwC0rE8ZabzRQyMnoCJ2MusB2MVOA5uJjS3FEEkt1\n bHZ9qti4koRpaNlQHFuNM9CGAIYC+qhlkoVSM+B8YOvH+ymkM6RF8OgJKr+OfziPcPQWEPfs\n TNZ7goRQGbnc+NOHmAtPIF8NHqhCzBEM98pZUz+YAg3HZ0+9KMih4GYI/O5akTA2AtSfLJp8\n VVLL5Nu1uaAfB/B6kFI5MWz7RnewHpkowc6vNJoI/t0tQ8Unp1HKd2vVzbCihcVknuSz6gwx\n /RM/XoZQ/2MfwsOShxt4QI33/WG8Im1+w8bO029xPFaeays27c1WjReTMeorA6JUTDZgoMb+\n EL0u6D0Zkew96rJ+a8BeG/ea+GdOv6+/vICN8QwHqjS1r7bpubzSvxazTVS+mzUABVtYuQPV\n 6E5Svu/b2LFShW+WHItDH7PqfTCWxE+aRhSAMibc/ARaOrzIk5be0wIm3cnUueCPwwqUrIQB\n is3PUWiiBpRwBt8Mcbve8k1zit65Uf1DiBAtO1G31SSpAYgllSe/dWoMPYXzGUCTjCZ3XhSX\n fISKRVkgJQbqVAT2/tZuJz1SvPQ=","In-Reply-To":"<20260421062928.2968600-1-gerald.yang@canonical.com>","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"multipart/mixed; boundary=\"===============1297983301094775220==\"","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}},{"id":3679727,"web_url":"http://patchwork.ozlabs.org/comment/3679727/","msgid":"<87y0igohuq.fsf@gmail.com>","list_archive_url":null,"date":"2026-04-21T08:09:01","subject":"ACK: [SRU][N][PATCH 0/1] Revert \"netfilter: conntrack: fix erronous\n removal of offload bit\"","submitter":{"id":89305,"url":"http://patchwork.ozlabs.org/api/people/89305/","name":"Mehmet Basaran","email":"mehmet.basaran@canonical.com"},"content":"Acked-by: Mehmet Basaran \nGerald Yang writes:\n\n> BugLink: https://bugs.launchpad.net/bugs/2149762\n>\n> [Impact]\n>\n> With this commit:\n> netfilter: conntrack: fix erronous removal of offload bit\n>\n> We hit the regression on PS6/7, all the nodes with this commit hit soft lockup every 1-2 days and need to reboot the nodes to recover, e.g.:\n>\n> [1022567.831263] watchdog: BUG: soft lockup - CPU#352 stuck for 26s! [kworker/u789:13:1036823]\n> [1022567.831271] Modules linked in: scsi_transport_iscsi mlx5_vfio_pci vfio_pci_core vfio_iommu_type1 vfio iommufd vhost_net tap xfs act_csum act_pedit act_ct nf_flow_table act_tunnel_key xt_CT xt_tcpudp nft_compat dm_crypt ebtable_filter ebtables ip6table_raw ip6table_mangle ip6table_nat ip6table_filter ip6_tables iptable_raw iptable_mangle iptable_nat iptable_filter nf_tables veth nf_conntrack_netlink vhost_vsock vmw_vsock_virtio_transport_common vhost vsock nvme_fabrics nvme_keyring act_mirred act_skbedit act_vlan cls_matchall 8021q garp mrp geneve ip6_udp_tunnel udp_tunnel nfnetlink_cttimeout nfnetlink act_gact cls_flower sch_ingress openvswitch nsh nf_conncount nf_nat bridge stp llc bonding sunrpc binfmt_misc intel_rapl_msr intel_rapl_common amd64_edac edac_mce_amd kvm_amd kvm irqbypass rapl ipmi_ssif nls_iso8859_1 joydev input_leds ipmi_si ipmi_devintf k10temp ccp ipmi_msghandler mac_hid mlx5_vdpa vringh vhost_iotlb vdpa dm_service_time sch_fq_codel dm_multipath scsi_dh_rdac scsi_dh_emc scsi_dh_alua nf_conntrack\n> [1022567.831352] nf_defrag_ipv6 nf_defrag_ipv4 efi_pstore ip_tables x_tables autofs4 btrfs blake2b_generic raid456 async_raid6_recov async_memcpy async_pq async_xor async_tx xor raid6_pq libcrc32c raid1 raid0 mlx5_ib ib_uverbs macsec ib_core raid10 hid_generic usbhid ses hid enclosure dax_hmem mlx5_core crct10dif_pclmul crc32_pclmul cxl_acpi polyval_clmulni cxl_port mlxfw polyval_generic ghash_clmulni_intel sha256_ssse3 sha1_ssse3 cxl_core psample nvme mpt3sas ahci raid_class nvme_core tls ast tg3 scsi_transport_sas libahci pci_hyperv_intf nvme_auth i2c_algo_bit xhci_pci xhci_pci_renesas i2c_piix4 aesni_intel crypto_simd cryptd\n> [1022567.831407] CPU: 352 PID: 1036823 Comm: kworker/u789:13 Kdump: loaded Tainted: G L 6.8.0-106-generic #106~22.04.1+hf399032v20260316b0-Ubuntu\n> [1022567.831411] Hardware name: Lenovo ThinkSystem SR665 V3/SB27B75430, BIOS KAE140F-5.70 09/03/2025\n> [1022567.831413] Workqueue: events_power_efficient nf_flow_offload_work_gc [nf_flow_table]\n> [1022567.831425] RIP: 0010:rhashtable_walk_next+0x17/0xd0\n> [1022567.831433] Code: 00 00 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 55 48 89 e5 41 57 41 56 41 55 41 54 53 4c 8b 37 48 89 fb 4c 8b 7f 10 <4c> 8b 6f 08 45 0f b6 66 38 41 80 fc 01 0f 87 e4 b1 98 00 41 83 e4\n> [1022567.831435] RSP: 0018:ff732ea21e2cbda8 EFLAGS: 00000202\n> [1022567.831438] RAX: ff2b1e3b98ea4058 RBX: ff732ea21e2cbde0 RCX: 0000000000000000\n> [1022567.831440] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ff732ea21e2cbde0\n> [1022567.831441] RBP: ff732ea21e2cbdd0 R08: 0000000000000000 R09: 0000000000000000\n> [1022567.831442] R10: 0000000000000000 R11: 0000000000000000 R12: ff2b1cb8611cbee8\n> [1022567.831444] R13: ff2b1cb8611cbe40 R14: ff2b1cb8611cbe48 R15: ff2b1e3b98ea4058\n> [1022567.831445] FS: 0000000000000000(0000) GS:ff2b1fb3bb000000(0000) knlGS:0000000000000000\n> [1022567.831447] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033\n> [1022567.831449] CR2: 0000775a42eee000 CR3: 0000019530ce8003 CR4: 0000000000f71ef0\n> [1022567.831450] PKRU: 55555554\n> [1022567.831452] Call Trace:\n> [1022567.831454] \n> [1022567.831461] nf_flow_offload_work_gc+0x5a/0xf0 [nf_flow_table]\n> [1022567.831468] process_one_work+0x181/0x3a0\n> [1022567.831475] worker_thread+0x306/0x440\n> [1022567.831479] ? __pfx_worker_thread+0x10/0x10\n> [1022567.831481] kthread+0xef/0x120\n> [1022567.831485] ? __pfx_kthread+0x10/0x10\n> [1022567.831487] ret_from_fork+0x44/0x70\n> [1022567.831492] ? __pfx_kthread+0x10/0x10\n> [1022567.831494] ret_from_fork_asm+0x1b/0x30\n> [1022567.831502] \n> [1022568.208115] R13: 0000000000000002 R14: 0000000000000002 R15: 0003a1fef9c1d979\n> [1022568.216666] ? cpuidle_enter_state+0xca/0x720\n> [1022568.222092] ? tick_nohz_stop_tick+0x70/0x210\n> [1022568.227521] cpuidle_enter+0x2e/0x50\n> [1022568.232060] call_cpuidle+0x23/0x60\n> [1022568.236472] cpuidle_idle_call+0x11d/0x190\n> [1022568.241562] do_idle+0x87/0xf0\n> [1022568.245472] cpu_startup_entry+0x2a/0x30\n> [1022568.250357] start_secondary+0x129/0x160\n> [1022568.255243] secondary_startup_64_no_verify+0x184/0x18b\n> [1022568.261586] \n>\n> [Fix]\n>\n> Without this commit, we spent few weeks to confirm PS6/7 nodes running without any lockup.\n> This commit is a follow-up fix for:\n> netfilter: conntrack: rework offload nf_conn timeout extension logic\n>\n> But the call path and logic starting from flow_offload_fixup_ct changed between these 2 commits.\n> Only manually backport this commit without all the changes in the middle causes issue, and the commit message also says what it fixes is harmless.\n>\n> [Test Plan]\n>\n> We have run a test kernel without this commit on PS6/7 for almost 2 weeks without hitting any soft lockup.\n>\n> [Where problems could occur]\n>\n> The commit we revert, its commit message says what it fixes is harmless,\n> and we have already run the kernel without it for almost 2 weeks without any issue, the risk is very low.\n>\n> Gerald Yang (1):\n> Revert \"netfilter: conntrack: fix erronous removal of offload bit\"\n>\n> net/netfilter/nf_flow_table_core.c | 10 ++++------\n> 1 file changed, 4 insertions(+), 6 deletions(-)\n>\n> -- \n> 2.43.0\n>\n>\n> -- \n> kernel-team mailing list\n> kernel-team@lists.ubuntu.com\n> https://lists.ubuntu.com/mailman/listinfo/kernel-team","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=ACjJXFvk;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com\n (client-ip=185.125.189.65; helo=lists.ubuntu.com;\n envelope-from=kernel-team-bounces@lists.ubuntu.com;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0FPP4R4dz1yCv\n\tfor ; Tue, 21 Apr 2026 18:09:13 +1000 (AEST)","from localhost ([127.0.0.1] helo=lists.ubuntu.com)\n\tby lists.ubuntu.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1wF6AN-0003yC-T2; Tue, 21 Apr 2026 08:09:07 +0000","from smtp-relay-internal-0.internal ([10.131.114.225]\n helo=smtp-relay-internal-0.canonical.com)\n by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.86_2) (envelope-from )\n id 1wF6AL-0003y5-V0\n for kernel-team@lists.ubuntu.com; Tue, 21 Apr 2026 08:09:06 +0000","from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n [209.85.128.69])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id BBEA53F7F9\n for ; Tue, 21 Apr 2026 08:09:05 +0000 (UTC)","by mail-wm1-f69.google.com with SMTP id\n 5b1f17b1804b1-488c0120047so20867905e9.0\n for ; Tue, 21 Apr 2026 01:09:05 -0700 (PDT)","from localhost ([151.135.39.228]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fc10019bsm356238935e9.4.2026.04.21.01.09.03\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 Apr 2026 01:09:03 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1776758945;\n bh=L1cbYE6wkBfMlpa2UcCTWem2kxPYM9ObYM6hBtPBGmk=;\n h=From:To:Subject:In-Reply-To:References:Date:Message-ID:\n MIME-Version:Content-Type;\n b=ACjJXFvk7qs/4pOK8QKe4pGiGaxV9fUVo+dPv6dy6pHIlZ+072RX0qEq9ERYpk9IH\n E8mBwALopq3An6aVJK17MHRoqf8RDfofXmKtHoKQfSEWfADw2YPVOI6j6keqTxY8fh\n 7OqjdXPKFhMmX6M6FX6tzLEWa1WSztP7ytgDqWnfXh1Iz/xVxBBs11POrrY872DlOE\n /xkj7g0gqL45zEoyarGdYA7IwvJKA1enBLZBAMlm5Pstu42dNKxeyjLBWACJiHNwf0\n ZCQTL9X01yARnfMN5gWQ4wgJEgfFH9Xp6R+lG0PMqctXhocUtw7z0ekj94gFuX3C8R\n ktYQhXLW34i6Dvi9yAJFl9PpLHZXQT6xjyuZRXQcRy4euMydd5wCg6pjPfNMh8NP1K\n qHVLAfrZR0sK7biLOJ04198dhONckqJ8hCc2t82lzE0T4Jvr6SNdLCCAcs0VxFhP99\n 5qqhr76wGWNBJi7w1mcIp16vK7lpozk7ezUwH03Obw5YbQbjeK9g/EmwzopqtMuniG\n vztJ5w8dtrSjCckZ4kvGCKQ4IWY7gEm3iXk5eOCFWy7oxx4dx5spJxDiq4n3ZzRwme\n FEpFLDvpeU8ROi3hGT6kc7trBDQgWJ8uyEq8N/39ooDnHEgJN4kemkKPslsHuYhZxI\n M/BNfd/y1QrW1URPJq/NELZ4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776758945; x=1777363745;\n h=mime-version:message-id:date:references:in-reply-to:subject:to:from\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=L1cbYE6wkBfMlpa2UcCTWem2kxPYM9ObYM6hBtPBGmk=;\n b=UWeNTSL1DVCr4buNwE0vtkSOPuIRDEynQVqRy53hUPCcBSn6sCMGoqflivQOsQeo42\n D6Qn48gRSbWuqiWHY5Z3c90tDM3ezeTBY6DpFaT3VR/4Qf5ICT4QqM26CkSTVaxyj/ZZ\n iJT+sZ3l2hzIt395eM8e4nb4IWn8T7W7ixmmDw+VZ3LzjvAjo7HjCgsL+0veCKrlhNA9\n +TISZRszMjzXKt+uCGgLhIZTtNe+X/uWwoPuBPBth94ZCQt1rXNb6TAfGI3pZskdv/+w\n 9x1zegSi2hgyM54YyQFm9PIUYujuSEtJKfXYxTUxHWcSLuEk2Un0B8y2LBbFo1BX3/+l\n d0bQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8csR9NubCziOr9ISl9dD6BSTfHio2SiKpYpiu22bTizVSOnnBAl4w5pMaABiusV5Id0uOm52YVMxsIOA==@lists.ubuntu.com","X-Gm-Message-State":"AOJu0Yxp5mYacNXnbwX+Dqs7EuTA8Q7i2o5neudv6DAd/2AdOe1xHiP5\n mX/hcQHhtXNhhboByfuFuFCdQc5dM9NSW7ozDrFV8MquWSL1BcEw5Gq6gkCCi4b7Nsw9YQHi63q\n 2oXREaRgl2chrcCiPICDpjD8Dd/DoTYjy8vPMktALa6ZiKKT9h93CejWAY9523F1Yyueoni+I+L\n YpskeegF4DR2ws30Jw","X-Gm-Gg":"AeBDietXf17FTeyv0Temy2l5bCUPGifWLYWnPne4DB4dbJn3jIL5654Grwi7jU8usNA\n Z8wMDxB5UuEuOUe5co+Itz5xyOdaoM+wJPaSF/8FnR4FAd150RCA5OZRAlVqVfnHuBltUup3QJH\n MZvGmx9cer5w14+Pk7x9QO9BwTPKTPLc6LbC3EahAMV/+eKjmKk8BwC6RaiGFH81FrOoRk3SUZl\n vEaCbxQYxn0hCNoyyMSsMHPOcHsfAJwQjDCbdzP67jZMdReJ6jCQnRyRcAkiVQzSVheVrDFyxur\n otFiIp+am+VwA5lVXF+AT7uElMGR9JMenBMEXDZhH5PBiQvZ5NtpF0TdmElDpiA1HueEsKB37kr\n zXLtmsliNRUDQHXb+tRh8QlMUPGzlNhhdTpXJX1vCuw==","X-Received":["by 2002:a05:600c:3110:b0:485:3abe:ab86 with SMTP id\n 5b1f17b1804b1-488fb739ce4mr240530225e9.4.1776758944864;\n Tue, 21 Apr 2026 01:09:04 -0700 (PDT)","by 2002:a05:600c:3110:b0:485:3abe:ab86 with SMTP id\n 5b1f17b1804b1-488fb739ce4mr240529765e9.4.1776758944398;\n Tue, 21 Apr 2026 01:09:04 -0700 (PDT)"],"From":"Mehmet Basaran ","To":"Gerald Yang , kernel-team@lists.ubuntu.com","Subject":"ACK: [SRU][N][PATCH 0/1] Revert \"netfilter: conntrack: fix erronous\n removal of offload bit\"","In-Reply-To":"<20260421062928.2968600-1-gerald.yang@canonical.com>","References":"<20260421062928.2968600-1-gerald.yang@canonical.com>","Date":"Tue, 21 Apr 2026 11:09:01 +0300","Message-ID":"<87y0igohuq.fsf@gmail.com>","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"=-=-=\"","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}},{"id":3679775,"web_url":"http://patchwork.ozlabs.org/comment/3679775/","msgid":"<87o6jcodgd.fsf@gmail.com>","list_archive_url":null,"date":"2026-04-21T09:44:02","subject":"APPLIED: [SRU][N][PATCH 0/1] Revert \"netfilter: conntrack: fix\n erronous removal of offload bit\"","submitter":{"id":89305,"url":"http://patchwork.ozlabs.org/api/people/89305/","name":"Mehmet Basaran","email":"mehmet.basaran@canonical.com"},"content":"Applied to noble:linux master-next branch. Thanks.\nGerald Yang writes:\n\n> BugLink: https://bugs.launchpad.net/bugs/2149762\n>\n> [Impact]\n>\n> With this commit:\n> netfilter: conntrack: fix erronous removal of offload bit\n>\n> We hit the regression on PS6/7, all the nodes with this commit hit soft lockup every 1-2 days and need to reboot the nodes to recover, e.g.:\n>\n> [1022567.831263] watchdog: BUG: soft lockup - CPU#352 stuck for 26s! [kworker/u789:13:1036823]\n> [1022567.831271] Modules linked in: scsi_transport_iscsi mlx5_vfio_pci vfio_pci_core vfio_iommu_type1 vfio iommufd vhost_net tap xfs act_csum act_pedit act_ct nf_flow_table act_tunnel_key xt_CT xt_tcpudp nft_compat dm_crypt ebtable_filter ebtables ip6table_raw ip6table_mangle ip6table_nat ip6table_filter ip6_tables iptable_raw iptable_mangle iptable_nat iptable_filter nf_tables veth nf_conntrack_netlink vhost_vsock vmw_vsock_virtio_transport_common vhost vsock nvme_fabrics nvme_keyring act_mirred act_skbedit act_vlan cls_matchall 8021q garp mrp geneve ip6_udp_tunnel udp_tunnel nfnetlink_cttimeout nfnetlink act_gact cls_flower sch_ingress openvswitch nsh nf_conncount nf_nat bridge stp llc bonding sunrpc binfmt_misc intel_rapl_msr intel_rapl_common amd64_edac edac_mce_amd kvm_amd kvm irqbypass rapl ipmi_ssif nls_iso8859_1 joydev input_leds ipmi_si ipmi_devintf k10temp ccp ipmi_msghandler mac_hid mlx5_vdpa vringh vhost_iotlb vdpa dm_service_time sch_fq_codel dm_multipath scsi_dh_rdac scsi_dh_emc scsi_dh_alua nf_conntrack\n> [1022567.831352] nf_defrag_ipv6 nf_defrag_ipv4 efi_pstore ip_tables x_tables autofs4 btrfs blake2b_generic raid456 async_raid6_recov async_memcpy async_pq async_xor async_tx xor raid6_pq libcrc32c raid1 raid0 mlx5_ib ib_uverbs macsec ib_core raid10 hid_generic usbhid ses hid enclosure dax_hmem mlx5_core crct10dif_pclmul crc32_pclmul cxl_acpi polyval_clmulni cxl_port mlxfw polyval_generic ghash_clmulni_intel sha256_ssse3 sha1_ssse3 cxl_core psample nvme mpt3sas ahci raid_class nvme_core tls ast tg3 scsi_transport_sas libahci pci_hyperv_intf nvme_auth i2c_algo_bit xhci_pci xhci_pci_renesas i2c_piix4 aesni_intel crypto_simd cryptd\n> [1022567.831407] CPU: 352 PID: 1036823 Comm: kworker/u789:13 Kdump: loaded Tainted: G L 6.8.0-106-generic #106~22.04.1+hf399032v20260316b0-Ubuntu\n> [1022567.831411] Hardware name: Lenovo ThinkSystem SR665 V3/SB27B75430, BIOS KAE140F-5.70 09/03/2025\n> [1022567.831413] Workqueue: events_power_efficient nf_flow_offload_work_gc [nf_flow_table]\n> [1022567.831425] RIP: 0010:rhashtable_walk_next+0x17/0xd0\n> [1022567.831433] Code: 00 00 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 55 48 89 e5 41 57 41 56 41 55 41 54 53 4c 8b 37 48 89 fb 4c 8b 7f 10 <4c> 8b 6f 08 45 0f b6 66 38 41 80 fc 01 0f 87 e4 b1 98 00 41 83 e4\n> [1022567.831435] RSP: 0018:ff732ea21e2cbda8 EFLAGS: 00000202\n> [1022567.831438] RAX: ff2b1e3b98ea4058 RBX: ff732ea21e2cbde0 RCX: 0000000000000000\n> [1022567.831440] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ff732ea21e2cbde0\n> [1022567.831441] RBP: ff732ea21e2cbdd0 R08: 0000000000000000 R09: 0000000000000000\n> [1022567.831442] R10: 0000000000000000 R11: 0000000000000000 R12: ff2b1cb8611cbee8\n> [1022567.831444] R13: ff2b1cb8611cbe40 R14: ff2b1cb8611cbe48 R15: ff2b1e3b98ea4058\n> [1022567.831445] FS: 0000000000000000(0000) GS:ff2b1fb3bb000000(0000) knlGS:0000000000000000\n> [1022567.831447] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033\n> [1022567.831449] CR2: 0000775a42eee000 CR3: 0000019530ce8003 CR4: 0000000000f71ef0\n> [1022567.831450] PKRU: 55555554\n> [1022567.831452] Call Trace:\n> [1022567.831454] \n> [1022567.831461] nf_flow_offload_work_gc+0x5a/0xf0 [nf_flow_table]\n> [1022567.831468] process_one_work+0x181/0x3a0\n> [1022567.831475] worker_thread+0x306/0x440\n> [1022567.831479] ? __pfx_worker_thread+0x10/0x10\n> [1022567.831481] kthread+0xef/0x120\n> [1022567.831485] ? __pfx_kthread+0x10/0x10\n> [1022567.831487] ret_from_fork+0x44/0x70\n> [1022567.831492] ? __pfx_kthread+0x10/0x10\n> [1022567.831494] ret_from_fork_asm+0x1b/0x30\n> [1022567.831502] \n> [1022568.208115] R13: 0000000000000002 R14: 0000000000000002 R15: 0003a1fef9c1d979\n> [1022568.216666] ? cpuidle_enter_state+0xca/0x720\n> [1022568.222092] ? tick_nohz_stop_tick+0x70/0x210\n> [1022568.227521] cpuidle_enter+0x2e/0x50\n> [1022568.232060] call_cpuidle+0x23/0x60\n> [1022568.236472] cpuidle_idle_call+0x11d/0x190\n> [1022568.241562] do_idle+0x87/0xf0\n> [1022568.245472] cpu_startup_entry+0x2a/0x30\n> [1022568.250357] start_secondary+0x129/0x160\n> [1022568.255243] secondary_startup_64_no_verify+0x184/0x18b\n> [1022568.261586] \n>\n> [Fix]\n>\n> Without this commit, we spent few weeks to confirm PS6/7 nodes running without any lockup.\n> This commit is a follow-up fix for:\n> netfilter: conntrack: rework offload nf_conn timeout extension logic\n>\n> But the call path and logic starting from flow_offload_fixup_ct changed between these 2 commits.\n> Only manually backport this commit without all the changes in the middle causes issue, and the commit message also says what it fixes is harmless.\n>\n> [Test Plan]\n>\n> We have run a test kernel without this commit on PS6/7 for almost 2 weeks without hitting any soft lockup.\n>\n> [Where problems could occur]\n>\n> The commit we revert, its commit message says what it fixes is harmless,\n> and we have already run the kernel without it for almost 2 weeks without any issue, the risk is very low.\n>\n> Gerald Yang (1):\n> Revert \"netfilter: conntrack: fix erronous removal of offload bit\"\n>\n> net/netfilter/nf_flow_table_core.c | 10 ++++------\n> 1 file changed, 4 insertions(+), 6 deletions(-)\n>\n> -- \n> 2.43.0\n>\n>\n> -- \n> kernel-team mailing list\n> kernel-team@lists.ubuntu.com\n> https://lists.ubuntu.com/mailman/listinfo/kernel-team","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=pdJ3kCx8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com\n (client-ip=185.125.189.65; helo=lists.ubuntu.com;\n envelope-from=kernel-team-bounces@lists.ubuntu.com;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0HW64yZQz1yGs\n\tfor ; Tue, 21 Apr 2026 19:44:17 +1000 (AEST)","from localhost ([127.0.0.1] helo=lists.ubuntu.com)\n\tby lists.ubuntu.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1wF7eK-0000NH-Gn; Tue, 21 Apr 2026 09:44:08 +0000","from smtp-relay-internal-1.internal ([10.131.114.114]\n helo=smtp-relay-internal-1.canonical.com)\n by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.86_2) (envelope-from )\n id 1wF7eJ-0000NA-3q\n for kernel-team@lists.ubuntu.com; Tue, 21 Apr 2026 09:44:07 +0000","from mail-wm1-f71.google.com (mail-wm1-f71.google.com\n [209.85.128.71])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id BE3153F9B2\n for ; Tue, 21 Apr 2026 09:44:06 +0000 (UTC)","by mail-wm1-f71.google.com with SMTP id\n 5b1f17b1804b1-48906aa28cbso18094245e9.0\n for ; Tue, 21 Apr 2026 02:44:06 -0700 (PDT)","from localhost ([151.135.39.228]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fb74c7a2sm112359965e9.1.2026.04.21.02.44.04\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 Apr 2026 02:44:04 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1776764646;\n bh=tYy4uGWXFBf16FBgQVqHLwPENwY6QizZcPBwxv3eJ24=;\n h=From:To:Subject:In-Reply-To:References:Date:Message-ID:\n MIME-Version:Content-Type;\n b=pdJ3kCx8VC74+RtVs8BhiC/p+UiCE0X3jYCJNrf4/DsnQgUM5t5CpabUcCqma8MFX\n DHKDqP0O7u5t74H1t1WHv+j280/Y8tHsd76SqaQSiOnCX096/+JbYHq6+uv6e2iOe9\n XfmlfYJk2nmqlsKWV0/hwz3Bk/adaCyE+fgeohpsZIaNMsUAPSv8kFktVCQFaEn/tq\n Q/jXzt+9cvOTrKvhDQd3yNfqUfmzP1/zBMbqkMDtcuO0SikNI7CA20LCuYo/gRA0KY\n EBvhpxgK9LSX6w2hbMM6u/oCileXpayxBNiAMVSAC7OlmZ7dJHtO46Ge86/GTyp7qU\n YwDPS5stkmcGu6p3WJh9Iws75ygevVh3YXmlIwWi4V+iRqLGQ+i0tZ+s5eqGGRXnJy\n aiPOb/4qecxnJDZYttqBRcIzBLZtJdoudhIil2JnpxGHmz0jWKA/NGGZurbrbwBe1V\n iQFPqz1K6//+BLud/HJ98xcNbWS6I7MDPiC2ZckOQLUjE1ya8aaAYvPyCPGedSc4eT\n dechSTLouaZcGGpu2UyjSEZR1TJlckeCKw2bHK8UAfL1GNkeC3aC2Go31LWm7VbFvT\n 35L6TTIdh6w0kuLj1wS+GQVFzbQxCR8QCzzyyw95UDWIEjFeChGqdHIjuYLWoijdMC\n wrdZyEGJACduw3bwbZdy8feI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776764646; x=1777369446;\n h=mime-version:message-id:date:references:in-reply-to:subject:to:from\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=tYy4uGWXFBf16FBgQVqHLwPENwY6QizZcPBwxv3eJ24=;\n b=mtYnw9dlRvRG0q/ZzMcRFMYeGHC/wua6amniCyvBZB+3R9XV48/gr0fV9IPbsNCx3L\n xrwLfrdPCAwq1XlYNHkB52pZPmZH6mu+t/Ng2SQ4FeeSJ26eR6iWXAL4vDwkJ1oUAzf6\n SzzB7eGR9kr87Lvme2BfZQqt5rb6Y+N/ziY+cVwGCGreKDcBlPHgITSrOMdRSkgWkcU3\n R85bMC2LYQWVseU+9xI71rvSItJoXSlE5Kd+9uVSDDqHh/8ltk9f6MOMMV++JLWvj+2W\n vh/nwRRULJpIVNN08xz3X0/S7x4uvAvLsvTjZ1K7Om6Yf/Nyl2oqIOZmVf1cU2H60DR/\n 6P1A==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8d4l3j2tq/lCNaSDW/2W1jyESBHZdQWWbyJ7kkDYmVtLEcYJUHQJo6/zeO/fO80QV/2XAhkhdRzKdEKw==@lists.ubuntu.com","X-Gm-Message-State":"AOJu0YzEUgT/CoHxYqXBsRYHTZ8WiOS1JZTjBYiIqwd1H+wRE2sDj81G\n B1LDrV+xBzdz3AvuDIAQGdTM0l+OT7KBy/NPtb9KHxUOBzzMS4kCQbWzaE6fHS2F/sN8x5MtYUh\n HG2t6uH5fxw+jFQoAfc9r8zU9UwIKfnNFj/A6gTMkS+mgnwddkX8iS29Pr8IMFL0vXDBiCH1dp+\n 1jSmkKgFbRXgYA3RfX","X-Gm-Gg":"AeBDieulujwjM6mONmkhDqooenA1Bg4cFrQ5OsUdvwiwjFg2v/Nzof+alPfMcnjRkzh\n VZ0iIpCG7mJHEkRKx5JPWX2PT2nOvBbb3oQa0CVpeoXFcG+WtGBgM/kUwfEp0bUPg7oK25KWCLM\n WmkTTXWaWw8LpeJ0JGgmJsReyICqX+3+884fyNy4svE9X05OzJLzfDYaABB+iKP9VCdo6xtkczj\n qZMoNhJ2Vd70qpqkTm1Xm4aEcJqagfKYCkT21hobDuvgtLwikT5yfBm5m3VSMK4JT3qldqOVIbR\n 3Wo7IRlpnmLUgyF3LLhPol/K1DiNH73c9lPOfMD8nAh4aPGSXwADkfS5Cz392MyiSNJJoxDmRTs\n Qz6Jqj0rebopXJPsW/uaZuCqm1DeagXjDBZ5eQgvc4g==","X-Received":["by 2002:a05:600c:1d05:b0:489:1baf:8c03 with SMTP id\n 5b1f17b1804b1-4891baf8d2cmr107716415e9.11.1776764645808;\n Tue, 21 Apr 2026 02:44:05 -0700 (PDT)","by 2002:a05:600c:1d05:b0:489:1baf:8c03 with SMTP id\n 5b1f17b1804b1-4891baf8d2cmr107716145e9.11.1776764645340;\n Tue, 21 Apr 2026 02:44:05 -0700 (PDT)"],"From":"Mehmet Basaran ","To":"Gerald Yang , kernel-team@lists.ubuntu.com","Subject":"APPLIED: [SRU][N][PATCH 0/1] Revert \"netfilter: conntrack: fix\n erronous removal of offload bit\"","In-Reply-To":"<20260421062928.2968600-1-gerald.yang@canonical.com>","References":"<20260421062928.2968600-1-gerald.yang@canonical.com>","Date":"Tue, 21 Apr 2026 12:44:02 +0300","Message-ID":"<87o6jcodgd.fsf@gmail.com>","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"=-=-=\"","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}}]