[{"id":3680110,"web_url":"http://patchwork.ozlabs.org/comment/3680110/","msgid":"","list_archive_url":null,"date":"2026-04-21T22:48:36","subject":"Re: [0/4] acpi: handle duplicate tables in acpi dump","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Heinrich,\n\nOn 2026-04-20T22:08:00, Heinrich Schuchardt\n wrote:\n\n> @index: 1-based index number to find\n\nThe header comment says 1-based, but the implementation is 0-based —\nthe function returns when index reaches 0, and all callers pass 0 for\nthe first table. Please can you fix this to say '@index: 0-based index\nnumber to find'?\n\n> Update all callers to pass index 1.\n\nShould say 'pass index 0'.\n\n> ACPI tables like SSDT may have multiple indexs.\n\nTypo: 'indexs' should be 'indices'.\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=SxG+2ig9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"SxG+2ig9\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0cwX1CcKz1y2d\n\tfor ; Wed, 22 Apr 2026 08:49:00 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 1916183AC5;\n\tWed, 22 Apr 2026 00:48:58 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id B321D83AC5; Wed, 22 Apr 2026 00:48:56 +0200 (CEST)","from mail-ej1-x632.google.com (mail-ej1-x632.google.com\n [IPv6:2a00:1450:4864:20::632])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E451C842FC\n for ; Wed, 22 Apr 2026 00:48:53 +0200 (CEST)","by mail-ej1-x632.google.com with SMTP id\n a640c23a62f3a-ba9ad0fbc3aso169257166b.1\n for ; Tue, 21 Apr 2026 15:48:53 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776811733; cv=none;\n d=google.com; s=arc-20240605;\n b=es+koEYQZ77v+X37usXF/AvdZ9am7TcrkbGWPxUvK36yF2eDtmdThKY1mYQsBY0Ntu\n BPIDtj4TOxQ+RYM1zdKgOPoLuk5tHwNM87cAQKqbB7+YmgwOsTW5F+fnMNLdba8PKEdQ\n F9fTRNqtkCue3JOnxbPBBCsxryoE6dbbUnz30ya1QshQzT6pqJhGEBAz3qQLaisc3y/5\n 28VmaOI7Ko6Jey1elKlx+4jrNFxX+Oed1l75xhmd8T0wn2h5fMcLbX8q3J9GxIRWeVoi\n 1ZrrxC3v4mNvxHxQx0NH9mzjChQ+lt+R1q7gDvjyjPnJT2eNwV5GTtWpVLTB9rESJcdt\n zMKw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=kvWKAbGk2NEMKFfkfXNG8PlpuqwkUGnybDNlrXRWis0=;\n fh=Iu3q8pU/HxKUxgIX3o2NhCmX5QQC75oOn2rrUk5yUdU=;\n b=P72pzlYb0l7OiZo0A4Nzl5o3CQ4UY+OUQN0ZtNKJxUXfpye44UHwQM77uSm8s5cOM2\n yWeOGBM/mb5L+kLV+nPrET2MbJWVtUrz1dVc0KGZz5Vwd1+yq9COYZR72FnTqaDZYtYh\n x83x2LqLJXG9KF0u5qa79wzsQGI6Dp2CSC9/AKYvNyXF7V81wd3jdNTWGg1H+deASS3t\n FBpyfGeAwhqAyWHEVn2OjjsBvBVg2EpFoautxHo3tgA5jfLWWN7BPVOlr4XAb2WBc7I6\n jZvv825MRLalaxMD1S2nEaXTXR44m9E6DiAM3vnZz3j1hxvToWHkrCcCFxSj0yEjtv83\n xu+w==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776811733; x=1777416533; darn=lists.denx.de;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=kvWKAbGk2NEMKFfkfXNG8PlpuqwkUGnybDNlrXRWis0=;\n b=SxG+2ig9gSHkQt9DB82dT37qvN7H0BHveUrgmgD6xMC8Ig6/kq9Ms62eIzl7bLdW5F\n KssM9Q1U413LyM5SoyUiwcnFXDh7/4bjtRHEheAhzBb5pnG7kQW/p0ZsOAgEdYr9UjzI\n OPYYKtLYs+Z/ED2VCnrG7XkBCvv36lS94EVmQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776811733; x=1777416533;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=kvWKAbGk2NEMKFfkfXNG8PlpuqwkUGnybDNlrXRWis0=;\n b=izGmO1dg96F7D8zC3LJN2V5I/pcVLM7yrmjm1x/zHpm98oUZPPVQFtwxXioYY5HIaI\n CDz/72p0J082yZh8aEaR06LFaT1kZ51q7ACAecLYDyR8Xhc0OFUQPxinor2RkaJGFvTq\n kWECAPOyhCJ/7nKPiESMQkYXteuZHNDU9HZJNyUf2vgd+2gHkmWDyb6FxkQLeQhjPEm0\n /BKXsC9bFoJZEgtG3CZDqJhnoGnJl74TcGF2j5pl0o+XSe5mL6Dno4tW11jNBG8nmVlh\n PZJjD7mYZ4MloU6rqiBYa5qt5FU5Jp2Znam9AyvXgoRQRqK2PZn8UAMwQScse2bIIpCZ\n BfsA==","X-Gm-Message-State":"AOJu0Yx6j7SN6CSlWOKUe651Bbd4xPDt5DYxIq/OsaoSyK5Y6EQsh8Ws\n 370AbnimodMAOvfAousdGQ94uy8ZIDpsy46Z/1MJOh+yMfD7fXFsw0I0STeer//tM9ZgVMo11jr\n jS1zvIxTxhWZlCcvfYdmKsaHQRsByItXaZH3dOYl5lJ/TPMVPTE8ywQ==","X-Gm-Gg":"AeBDiesRw18HCvkQK9cD0TwkMoeIG28NBQai8HIcbb5nqguPUDg1Afk/g9Wy8QCees6\n GoXpRysS8Ug0PuHX+NwPaqRv6OuxPowbPI9UicGDajG5EPsOq6NO0Gz3Fs6A6RzmqjyihdZCNed\n /wjDhh42yNjLxJuQYUp23eDYJDC5/hX1FkMLdpy6uFpXLK4apjJlIcMpgFt8JKna9TF5/tXMecj\n iSaPSMIOTjGb6xflAL/MrVvVhb4cyvwV/E0UraSVKCEl839g0jkqskxbBnfCjN4ELELg0avZ5k1\n 2KV7vZEKyrrGa4kzGOwE","X-Received":"by 2002:a17:907:c30a:b0:b9b:7bf8:800b with SMTP id\n a640c23a62f3a-ba41afe998emr941114566b.40.1776811733267; Tue, 21 Apr 2026\n 15:48:53 -0700 (PDT)","MIME-Version":"1.0","References":"<20260420220804.71564-1-heinrich.schuchardt@canonical.com>","In-Reply-To":"<20260420220804.71564-1-heinrich.schuchardt@canonical.com>","From":"Simon Glass ","Date":"Wed, 22 Apr 2026 10:48:36 +1200","X-Gm-Features":"AQROBzC6W9Vc-RueIov-Kg00zDfhHVouMOFz02JiKxFS13ZzD98ja3DAOQ0UONA","Message-ID":"\n ","Subject":"Re: [0/4] acpi: handle duplicate tables in acpi dump","To":"heinrich.schuchardt@canonical.com","Cc":"u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]