[{"id":3679408,"web_url":"http://patchwork.ozlabs.org/comment/3679408/","msgid":"<aeYsA_UOFIg0BZOx@sumit-xelite>","list_archive_url":null,"date":"2026-04-20T13:37:07","subject":"Re: [PATCH v3 0/5] Add partition type GUID support for environment","submitter":{"id":90400,"url":"http://patchwork.ozlabs.org/api/people/90400/","name":"Sumit Garg","email":"sumit.garg@kernel.org"},"content":"On Sun, Apr 19, 2026 at 03:54:02PM +0530, Balaji Selvanathan wrote:\n> This series adds support for locating partitions using GPT partition\n> type GUID instead of unique partition UUID. This enables the saveenv\n> command to work with partitions identified by their type rather than\n> unique identifiers, providing flexibility for systems where partition\n> UUIDs may vary across devices but types remain constant.\n\nWhy don't we rather rely on partition name/label instead? That can be\ncommon across platforms too. I would rather prefer a config fragment for\neg. UFS based environment or eMMC based environment and so on.\n\n-Sumit\n\n> \n> Patch 1 adds part_get_info_by_type_guid() function support\n> Patch 2 adds scsi_get_blk_by_type_guid() function support\n> Patch 3 adds support for partition type GUID based environment\n> Patch 4 enables partition type GUID configs for QCM6490 and QCS615\n> Patch 5 adds unit test for the partition type GUID lookup functionality\n> \n> Signed-off-by: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>\n> ---\n> Changes in v3:\n> - Addressed minor corrections in Patch 1 in part_get_info_by_type_guid function\n> - Refactor env_scsi_get_part and env_scsi_load functions based\n>   on the choice configs in Patch 3\n> - Add unit test for the partition type GUID lookup functionality in Patch 5\n> - Link to v2: https://lore.kernel.org/u-boot/20260109070912.4106466-1-balaji.selvanathan@oss.qualcomm.com/\n> \n> Changes in v2:\n> - Compute blk_find_max_devnum(UCLASS_SCSI) only once in scsi_get_blk_by_type_guid()\n> - Introduce a Kconfig choice config to select between UUID-based\n> and type GUID-based partition lookup methods.\n> - Enable above new config in qcom_qcs615_defconfig and qcm6490_defconfig\n> - Link to v1: https://lore.kernel.org/u-boot/20260108064947.3237361-1-balaji.selvanathan@oss.qualcomm.com/\n> \n> ---\n> Balaji Selvanathan (5):\n>       disk: Add partition lookup by type GUID functionality\n>       scsi: Add partition lookup by type GUID for SCSI devices\n>       env: scsi: Add support for partition type GUID based environment\n>       configs: Enable partition type GUID for QCM6490 and QCS615 boards\n>       test: dm: Add partition type GUID lookup test\n> \n>  configs/qcm6490_defconfig     |  5 +++++\n>  configs/qcom_qcs615_defconfig |  5 +++++\n>  disk/part.c                   | 37 +++++++++++++++++++++++++++++++\n>  drivers/scsi/scsi-uclass.c    | 28 ++++++++++++++++++++++--\n>  env/Kconfig                   | 51 ++++++++++++++++++++++++++++++++++++-------\n>  env/scsi.c                    | 45 +++++++++++++++++++++++---------------\n>  include/part.h                | 21 ++++++++++++++++++\n>  include/scsi.h                | 11 ++++++++++\n>  test/dm/part.c                | 48 ++++++++++++++++++++++++++++++++++++++++\n>  9 files changed, 223 insertions(+), 28 deletions(-)\n> ---\n> base-commit: e3405917a1806971d9e72a94186b299f05581e1a\n> change-id: 20260419-type-c6a48a1c273d\n> \n> Best regards,\n> -- \n> Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>\n>","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=QH+6QATz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"QH+6QATz\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sumit.garg@kernel.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzmkd26tcz1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 20 Apr 2026 23:37:28 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E0F57843D6;\n\tMon, 20 Apr 2026 15:37:25 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 794DA843E0; Mon, 20 Apr 2026 15:37:24 +0200 (CEST)","from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E30C2843D1\n for <u-boot@lists.denx.de>; Mon, 20 Apr 2026 15:37:21 +0200 (CEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by sea.source.kernel.org (Postfix) with ESMTP id 47A4A43FF9;\n Mon, 20 Apr 2026 13:37:20 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 3B0ABC19425;\n Mon, 20 Apr 2026 13:37:10 +0000 (UTC)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1776692240;\n bh=YAJWm/RtpO1Y/KRnBbrCK4jWhLznlYZi/JqTR6YZpoQ=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=QH+6QATzMfe64HD15hHrBobeCYaqUfrbSabxSDBMgRw6FCv8HAO5EsaVfpdKRdnxt\n S66DQtK9iY8TaQ1erNTWDKsZtUHo7JpGDdy7YOeD4icMKGZ2ekpFgvYoWMsm7DeJV8\n pSiI5fJF5V5a4eTxDhfsNrNfK15u8AJcOJw4MCCcDi4Wj/tbwg7iTorif34Wq0xn+h\n ZrlAhMPx2bKxghxuthJClvLBiiissiM7HmHeD2klzK5N8zu4wyp0y0vKcYbXvT+OKo\n P6xcWgzi3OZTOTLX7c2RZhkcRTLaan1Io1M+02pUOu1wGUe9Rl3lNizvq5/a7C5zeF\n fDOToJbDsDDzA==","Date":"Mon, 20 Apr 2026 19:07:07 +0530","From":"Sumit Garg <sumit.garg@kernel.org>","To":"Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>","Cc":"u-boot@lists.denx.de, u-boot-qcom@groups.io,\n Tom Rini <trini@konsulko.com>, Quentin Schulz <quentin.schulz@cherry.de>,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Javier Tia <javier.tia@linaro.org>,\n Varadarajan Narayanan <quic_varada@quicinc.com>,\n Rasmus Villemoes <ravi@prevas.dk>,\n Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,\n Javier Martinez Canillas <javierm@redhat.com>,\n Miquel Raynal <miquel.raynal@bootlin.com>,\n =?iso-8859-1?q?Jo=E3o?= Marcos Costa <joaomarcos.costa@bootlin.com>,\n Tien Fong Chee <tien.fong.chee@altera.com>,\n Richard Genoud <richard.genoud@bootlin.com>,\n Jan Kiszka <jan.kiszka@siemens.com>, David Lechner <dlechner@baylibre.com>,\n Casey Connolly <casey.connolly@linaro.org>,\n Simon Glass <simon.glass@canonical.com>,\n Marek Vasut <marek.vasut+renesas@mailbox.org>,\n Christian Marangi <ansuelsmth@gmail.com>, Michael Walle <mwalle@kernel.org>,\n Sumit Garg <sumit.garg@oss.qualcomm.com>,\n Neil Armstrong <neil.armstrong@linaro.org>,\n Aswin Murugan <aswin.murugan@oss.qualcomm.com>,\n Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>,\n Simon Glass <sjg@chromium.org>,\n Mattijs Korpershoek <mkorpershoek@kernel.org>,\n Jerome Forissier <jerome.forissier@arm.com>","Subject":"Re: [PATCH v3 0/5] Add partition type GUID support for environment","Message-ID":"<aeYsA_UOFIg0BZOx@sumit-xelite>","References":"<20260419-type-v3-0-ec49acd6870e@oss.qualcomm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260419-type-v3-0-ec49acd6870e@oss.qualcomm.com>","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]