[{"id":3679227,"web_url":"http://patchwork.ozlabs.org/comment/3679227/","msgid":"","list_archive_url":null,"date":"2026-04-20T06:00:51","subject":"Re: [PATCH 0/2] efi_loader: centralize messaging for\n efi_init_obj_list","submitter":{"id":74147,"url":"http://patchwork.ozlabs.org/api/people/74147/","name":"Ilias Apalodimas","email":"ilias.apalodimas@linaro.org"},"content":"On Sat, 18 Apr 2026 at 20:58, Heinrich Schuchardt\n wrote:\n>\n> If efi_init_obj_list() fails we cannot use the UEFI sub-system.\n>\n> * Instead of having messages for this everywhere write an error message\n> in efi_init_obj_list().\n> * Always use (ret =! EFI_SUCCESS) when checking the return value of\n> efi_init_obj_list().\n> * Remove the return code from the error message as it does not help\n> users to understand which initialization went wrong.\n>\n> In do_bootefi() move the check to the start of the function.\n\nFor the series\n\nReviewed-by: Ilias Apalodimas \n\n>\n> Heinrich Schuchardt (2):\n> cmd/bootefi: move efi_init_obj_list() to the start of do_bootefi\n> efi_loader: centralize messaging for efi_init_obj_list\n>\n> boot/bootmeth_efi_mgr.c | 4 ++--\n> cmd/bootefi.c | 13 +++++--------\n> cmd/bootmenu.c | 6 +-----\n> cmd/eficonfig.c | 6 +-----\n> cmd/efidebug.c | 5 +----\n> cmd/nvedit_efi.c | 10 ++--------\n> lib/efi_loader/efi_bootbin.c | 5 +----\n> lib/efi_loader/efi_bootmgr.c | 5 +----\n> lib/efi_loader/efi_setup.c | 2 ++\n> 9 files changed, 16 insertions(+), 40 deletions(-)\n>\n> --\n> 2.53.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=A8aM3jgn;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"A8aM3jgn\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org","phobos.denx.de;\n spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzZcl2wYdz1yGs\n\tfor ; Mon, 20 Apr 2026 16:01:43 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 01E2B840D8;\n\tMon, 20 Apr 2026 08:01:35 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 46200840D8; Mon, 20 Apr 2026 08:01:33 +0200 (CEST)","from mail-yx1-xb12b.google.com (mail-yx1-xb12b.google.com\n [IPv6:2607:f8b0:4864:20::b12b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 9372183B99\n for ; Mon, 20 Apr 2026 08:01:29 +0200 (CEST)","by mail-yx1-xb12b.google.com with SMTP id\n 956f58d0204a3-651c5d525f6so2312702d50.3\n for ; Sun, 19 Apr 2026 23:01:29 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776664888; cv=none;\n d=google.com; s=arc-20240605;\n b=NNjL7d69mve/YVAPs5THI2E4dBIb0v5U237f6pMsc8g77XlEacYZlxgDDolcWSs1AK\n dk11LidVke9xNduKpgc0xOcMj2tUtlt+LapJUdy7C40tmUgYKOaCiD8iBluddfW9gckq\n PRsMC3c1e1JRrp44tssFQLQcA8QMy5jT94htfyCoiqrnebNl19X56i79XzjUH4BT+DAM\n VsRqsQuOl9YGhUGEwWuheOWka+UXDsGL9vkSc4GEWAIdq3BqmhrtEpHhPjEYhc+ELcLT\n EM6pnu8WkbPHYjPSsdoCWtWTLnkISdjP59259umTGrnjxOhR9k7kvPyid2hFvSxUmsPS\n 3w1A==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=Yjh3k4kz0vZB6GdZdE+MEdiW7SveUF/86EhuCLTqmzg=;\n fh=Jr2IUJfenNIzBR7WHABSUI04S/zkmmz2UU6+UrwUYUk=;\n b=gJ8bMrXAZX8ASoPsCRioQVvBmQcQGmrKWo594NSPxbMgBa9EfpuuvjpVOGpUNt6+Th\n Nrm0/eFuVAEwukq8wrg/Lff8K6zRRvY0pLTLwbGzHE2M/zUZZ/wEUIOq4q0fxv064/oh\n 95fjxZJ5sqr32xt85rplxdf46NcKKs6FV+Pc9Ku1EuPdPZkyb4jtmmMczniklHRKwNFw\n b3phY0UYKQuxFFF6WmLvHQ0ujTbzUi4BwspMcUo7CXkUTBV1YmJkFsaJOwn++7+Ef9x0\n 7lqsMVrHTmiDUIhs6l3B1a+WPhzRCmOrsYYZobj7scYnd3NLU7OUAmVMxzCa2+yo8ma5\n sw2g==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776664888; x=1777269688; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=Yjh3k4kz0vZB6GdZdE+MEdiW7SveUF/86EhuCLTqmzg=;\n b=A8aM3jgnwT2tYvifgoNOAaJdyOJc3Sglv21o3E72Czjz6IlhZJsAcGTwYPZkOV1mRC\n Lp9OGOpTUT3SMaEDAIcPZLsjBf/KOPiLRtmOObGS6a4kJ9Ku8J9t1Zmobo3tntobTpSN\n SJ77HwXvVBK0DU/vff2SPySjP4SWt607HljTo1UYyTga4TKFv3qmHarsRW9lSZW1rbmP\n BRzmGoH2bOdwhLSWzJzxHSQ7VzyoSYpCCHb9HcTCmBTt7oqWfAOvMq43yqualPgs+MaA\n YRyRkYKCfmU04Phw/xIF6nUluh2zgH8v4jUCLbNwxgLO5IAuGKmwAbbSw9FDmpB5lDl/\n XRNA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776664888; x=1777269688;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Yjh3k4kz0vZB6GdZdE+MEdiW7SveUF/86EhuCLTqmzg=;\n b=Pu8MDAk2hsHtKU2CFae4+D7EdZ2s9dNlmhKIG3QkiqAIeepoz0usw4LrT5pKjE26Ef\n jp68sJ80flOVwYybKQGB5hqzoB172Si2o1eaaQAs2Iwc+gt4SJLunCJQCY/iGHgmWSaB\n MSHgKJO3CBnPSeqkRV224ZVobE0vOj7UqliEyriuva5ii4MtjnwFkHrrW6lk4xZX6SE3\n IBw/RjxgsxfhsS0cdAizrkk1K/O+BmfJ+hfoszu9EQ3b5exwRq/6qzDMnuDUwfLgL9yz\n em19b620fJy0Y3HUaPQs89hqJ0u7c8dROmgByLQMp4FyKgAcY0ZPSzyT5VD24bcEGKne\n oAFA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+tiKNXKBM9roq63WmNtYHUrLd0k/S7bNYQzzDFC+vmCd+fSJelqPO9503vd+XMTsY/C7Eokug=@lists.denx.de","X-Gm-Message-State":"AOJu0Yx1UYYtDbxdBI0EN4aZlzSUkcwDAyvapR102YSMoDagJe1SabEo\n 6RVIvNjMyl7uRQ5X5UI53jcAgWRpRdWurhXpOxstMQe29I8aAhMi5eiQKZ9DANCrgxBa+V6rfzM\n LFjXwZnsnBVaR0VtHn+I922TF89PGDQkQcW6rd+nDlA==","X-Gm-Gg":"AeBDiett9f70NKi1cg624SQTQ2lCVQEXef1Q3x3N/k/IQuX27H38gcVw1PEcmgksUXs\n lX62lFOxyOnQfvRKFObjQ2INg2AKix/gEjGS/HWxnV3r8ib1iQDz/M9zCzOFp6eEESSbzJlO3ot\n 3S1sSxiQmFPR1YHgud1ngmqSKl/V6lqvkc4tS7snMeYkgsIpOthrXawtfK/Xvwp3i1mT1/FvWm6\n r8x7wdI4rllyqRFKHTR0lmOQHTDWPjUGlGc1gZyDZgJeut2jp4NSmM1hWI6s4N7PWV4bg3xQqyP\n paJ9C2zq7J9eTR+cgSq8GfPmeahrJMG16SrQyUagJxbIBmpOrbgm5eY81fvndvH4yoH6MkgEKL+\n hgRGiXqiglf0xVAf2fgkXRFmTNX4Jx0SVMh+SucBZD40zMQCuP51hdJOr6I1Ws0AJ4zxEH+76zi\n Fy17iU6gq1T0KoSge6z6pVP9og/qeQ+I/whzOUaQ/lZ1Sux3ExM+p3IHMNU3R9/sf84lQqmhVTn\n It7jpvJbvw5FqtlphVwhcB0OEADAgEfyCyq2v4xv6DiGNwDyXeIwATsHA4CpuHtr7sbNBahcP+Z\n HsT+2zmCqD89Gk3QQDYWxW6CJ0f0AfQd1F6lXrxRWSeGSTm/R3VaF/VCaBJtC0b5KA==","X-Received":"by 2002:a05:690e:130d:b0:64a:d6fe:5e18 with SMTP id\n 956f58d0204a3-65314f8fa23mr10811023d50.64.1776664888315; Sun, 19 Apr 2026\n 23:01:28 -0700 (PDT)","MIME-Version":"1.0","References":"<20260418175814.5731-1-heinrich.schuchardt@canonical.com>","In-Reply-To":"<20260418175814.5731-1-heinrich.schuchardt@canonical.com>","From":"Ilias Apalodimas ","Date":"Mon, 20 Apr 2026 09:00:51 +0300","X-Gm-Features":"AQROBzB_hPJYJ86t-CFlOxYod6Z01WXltHIX9wySqVzzkSEEiifnpXlEt5H6yZE","Message-ID":"\n ","Subject":"Re: [PATCH 0/2] efi_loader: centralize messaging for\n efi_init_obj_list","To":"Heinrich Schuchardt ","Cc":"Simon Glass , Tom Rini ,\n Mark Kettenis ,\n Patrice Chotard , Peng Fan ,\n Christian Marangi ,\n Sughosh Ganu ,\n Casey Connolly ,\n =?utf-8?q?Vincent_Stehl=C3=A9?= ,\n Adriano Cordova , Javier Tia ,\n Jerome Forissier ,\n Ying-Chun Liu , u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]