[{"id":3678654,"web_url":"http://patchwork.ozlabs.org/comment/3678654/","msgid":"<20260417104136.GA1524638@rocinante>","date":"2026-04-17T10:41:36","subject":"Re: [PATCH v5 00/23] PCI: Convert all dynamic sysfs attributes to\n static","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/people/86709/","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"content":"Hello,\n\n> This series converts every dynamically allocated PCI sysfs attribute to\n> a static const definition. After the full series, pci_sysfs_init() and\n> sysfs_initialized are gone, and every sysfs file is created by the\n> driver model at device_add() time.\n\nA note on testing:\n\n 0-day bot (recent test runs; newer builds will arrive later):\n - https://lore.kernel.org/linux-pci/202604161928.DzuHQmeM-lkp@intel.com\n - https://lore.kernel.org/linux-pci/202604121312.sF0Ua4gP-lkp@intel.com\n - https://lore.kernel.org/linux-pci/202604111631.lrwAylMM-lkp@intel.com\n - https://lore.kernel.org/linux-pci/202603170336.zSLrDvlj-lkp@intel.com\n - https://lore.kernel.org/linux-pci/202603122052.tMV5rzNq-lkp@intel.com\n - https://lore.kernel.org/linux-pci/202603081334.b91RGVS6-lkp@intel.com\n - https://lore.kernel.org/linux-pci/202603060207.pnGfKgGa-lkp@intel.com\n\n KernelCI (for the \"for-kernelci\" branch):\n - https://dashboard.kernelci.org/tree/linux-pci/for-kernelci/683e66b11da157f730101f6919c7468a09cf3e3f\n - https://dashboard.kernelci.org/tree/linux-pci/for-kernelci/209e2cfd205a8aad4bae32e6f82b96b20902aa74\n - https://dashboard.kernelci.org/tree/linux-pci/for-kernelci/70293477e2c0ae8cbc250098818e726e1d658b53\n - https://dashboard.kernelci.org/tree?ts=pci\n\n Sashiko's feedback:\n - https://sashiko.dev/#/patchset/20260416180107.777065-1-kwilczynski%40kernel.org\n - https://sashiko.dev/#/patchset/20260411080148.471335-1-kwilczynski%40kernel.org\n - https://sashiko.dev/#/patchset/20260410055040.39233-1-kwilczynski%40kernel.org\n\nI sadly do not own any Alpha or PowerPC hardware, so when I was testing\nthese architectures while working on the series, it would be only under\nQEMU.\n\nThat said, Magnus Lindholm was able to test the series on the Alpha\nhardware he owns, see:\n\n - https://lore.kernel.org/linux-pci/CA+=Fv5Q1tZQwnanw99NbvzT-QenfYz7vUdY02_TuPqHX32ZAiA@mail.gmail.com\n\nLorenzo Pieralisi did some testing reported outside the mailing list (we\ntalked on IRC), on the platform he had issues before, and while the issues\nwere more with procfs races, similar to the sysfs ones this series aims to\nfix, he didn't notice regressions when having this series applied.\n\nThank you!\n\n\tKrzysztof","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=TtPgyx4s;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19827-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c04:e001:324:0:1991:8:25\"","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=TtPgyx4s;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org;\n envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxrzD5Tmrz1yD3\n\tfor ; Fri, 17 Apr 2026 20:41:44 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fxrzC5Q4Lz2xc8;\n\tFri, 17 Apr 2026 20:41:43 +1000 (AEST)","from tor.source.kernel.org (tor.source.kernel.org\n [IPv6:2600:3c04:e001:324:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fxrzB23cmz2xS3\n\tfor ; Fri, 17 Apr 2026 20:41:42 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 0CAD160128;\n\tFri, 17 Apr 2026 10:41:39 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 59875C19425;\n\tFri, 17 Apr 2026 10:41:38 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776422503;\n\tcv=none;\n b=lKQTBGK7uPYy2rsWahmqWEG3khH92JIrG0ZDMZIdWxRMo3bGEfLqpxxLLiEqWzE6TBXU2IsEWFKhAo+4y8FdRzUCpyPXEIVNcMNHZk2r11TsdSphWJW98xcI+M1kU8GPyFDdTqaYRDP71Own6zYbPoejtaeorVI/ektR5+B/utW56qnVS1VSap43dVBcO69RzLakYozMcqcc9qjg0kE6psCDJ5aqEN0tErhdc3fP7mrT+j24ysHORekS/fitPsOX3uSks/pgtoQQJVHc0hnzzsnSyBGYw/AAAsOsQ3p2r/tsbYsJfD9Jn5HDIOjPFGMIXTiCNP/q3ZdL2sGe5anU8w==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776422503; c=relaxed/relaxed;\n\tbh=yOoUBIUqhCIVLOdAqGhaBWNMye351UmLYnIENehpwOg=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=bvKd7j/rR5gyjx6wHQ3XGlY8uCwYE5vCOBRhH3TXYuVFpW3Kw4BFsqz/OpTBa8fOtuWUvq3fPvRA/HX96aafpV84zBWyIeS4dh6nIcjTj9DsN4dGYUAkUjbm7MgpNwi71X+ToHJGFu3iQhjJV/f3XyTpznAzlRnNLTEhgXgaKBAKwpBsUzHECnvJwD94XMaIxW+aLS19INAsdNbDRJfzey5+KJ6xbaJWTxoTTa/UiPTfGB1Lqj/Roa/2mI0cUERNOO/jSAwR9SItayPneotaWFZP7I913jzPgVd8VwaeIM1OgWZL+1b8tACcbvtYgh0G3Npq/ez7oNGH+ReaPq1wyw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=TtPgyx4s; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:324:0:1991:8:25;\n helo=tor.source.kernel.org; envelope-from=kwilczynski@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776422498;\n\tbh=L0GTYKccieNMJTwUsBo2lGzUOj3BIShZ21D9v4UZBhs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=TtPgyx4sEoslirAFE1xOCCdvIzjXlIjN54E+c8UrNTbbbHeVbnL/3O7TGX2obODny\n\t MJy0RbFLJn2cB1Y7/bznD8F6Lmel7w7rY8sRGAMaGrW5reJeqH2pt4DTdOTtUh5JFW\n\t +bX/1in7EvNP/3fRBdmr/Nnbqt03Z09y1e8DLfOnXCiTsrsxGW7Qnm2Y7TTcdfrmFl\n\t InRRB4TZ8CsrvL5dm4KFtT6uPCtuYzVThV70NnPqP27OMJcIPLoNAXwJvDzdOREY+t\n\t CiK8hNtMffvkBGlAxw9Gt7NnHqErYrjGdZ9H/vbdtPN5eutVtkF2M5n2QDq18LGps9\n\t 3yWIZMCNnEIug==","Date":"Fri, 17 Apr 2026 19:41:36 +0900","From":"Krzysztof =?utf-8?q?Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n Krzysztof =?utf-8?q?Ha=C5=82asa?= ,\n Lukas Wunner , Oliver O'Halloran ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n Ilpo =?utf-8?b?SsOkcnZpbmVu?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH v5 00/23] PCI: Convert all dynamic sysfs attributes to\n static","Message-ID":"<20260417104136.GA1524638@rocinante>","References":"<20260416180107.777065-1-kwilczynski@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260416180107.777065-1-kwilczynski@kernel.org>","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]