[{"id":3678166,"web_url":"http://patchwork.ozlabs.org/comment/3678166/","msgid":"<aeDi56YWCQtPiQ1P@cicciput>","list_archive_url":null,"date":"2026-04-16T13:23:51","subject":"ACK: [SRU][N:linux-bluefield][PATCH v1 0/2] UBUNTU: SAUCE: vfio:\n Export vfio device get and put registration helpers","submitter":{"id":91694,"url":"http://patchwork.ozlabs.org/api/people/91694/","name":"Alessio Faina","email":"alessio.faina@canonical.com"},"content":"On Thu, Apr 16, 2026 at 03:14:04PM +0300, Stav Aviram wrote:\n> BugLink: https://bugs.launchpad.net/bugs/2148554\n> \n> SRU Justification:\n> \n> [IMPACT]\n> A kernel NULL pointer dereference occurs on Nvidia BlueField DPUs running Ubuntu 24.04\n> (Noble) with linux-bluefield-6.8. The crash is triggered when closing a dma_buf file\n> descriptor associated with a vfio_pci device. The root cause is that\n> vfio_pci_dma_buf_release() and vfio_pci_dma_buf_cleanup() call vfio_put_device() to\n> release a reference, but the reference was acquired with vfio_device_get(), which uses\n> a separate refcount (device->refcount). Using vfio_put_device() incorrectly decrements\n> the kobject refcount, triggering a refcount underflow and kernel crash.\n> \n> [FIX]\n> Two custom patches are submitted:\n> - UBUNTU: SAUCE: vfio: Export vfio device get and put registration helpers — exports\n>   vfio_device_try_get_registration and vfio_device_put_registration via\n>   EXPORT_SYMBOL_GPL in vfio_main.c and adds their declarations to vfio.h, making them\n>   available to other VFIO modules.\n> - UBUNTU: SAUCE: vfio/pci: Use the correct ref count — fixes\n>   vfio_pci_dma_buf_release() and vfio_pci_dma_buf_cleanup() to call\n>   vfio_device_put_registration() instead of vfio_put_device(), correctly matching the\n>   reference acquisition done via vfio_device_get().\n> \n> [TEST CASE]\n> Compile tested on linux-bluefield-6.8 on the master-next branch.\n> Functionally verified: the NULL pointer dereference no longer reproduces after applying\n> the fix.\n> \n> [Regression Potential]\n> Low. The change corrects an incorrect function call in the release path, and the fix\n> has been functionally verified on the affected setup.\n> \n> Amir Tzin (1):\n>   UBUNTU: SAUCE: vfio/pci: Use the correct ref count\n> \n> Vivek Kasireddy (1):\n>   UBUNTU: SAUCE: vfio: Export vfio device get and put registration\n>     helpers\n> \n>  drivers/vfio/pci/dma_buf.c | 4 ++--\n>  drivers/vfio/vfio_main.c   | 2 ++\n>  include/linux/vfio.h       | 2 ++\n>  3 files changed, 6 insertions(+), 2 deletions(-)\n> \n> -- \n> 2.38.1\n> \n> \n> -- \n> kernel-team mailing list\n> kernel-team@lists.ubuntu.com\n> https://lists.ubuntu.com/mailman/listinfo/kernel-team\n\nAcked-by: Alessio Faina <alessio.faina@canonical.com>","headers":{"Return-Path":"<kernel-team-bounces@lists.ubuntu.com>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=YE2JBhOM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com\n (client-ip=185.125.189.65; helo=lists.ubuntu.com;\n envelope-from=kernel-team-bounces@lists.ubuntu.com;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxJd25MtTz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 23:24:06 +1000 (AEST)","from localhost ([127.0.0.1] helo=lists.ubuntu.com)\n\tby lists.ubuntu.com with esmtp (Exim 4.86_2)\n\t(envelope-from <kernel-team-bounces@lists.ubuntu.com>)\n\tid 1wDMhH-0005KA-08; Thu, 16 Apr 2026 13:23:55 +0000","from smtp-relay-internal-0.internal ([10.131.114.225]\n helo=smtp-relay-internal-0.canonical.com)\n by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.86_2) (envelope-from <alessio.faina@canonical.com>)\n id 1wDMhG-0005K1-7f\n for kernel-team@lists.ubuntu.com; Thu, 16 Apr 2026 13:23:54 +0000","from mail-wm1-f71.google.com (mail-wm1-f71.google.com\n [209.85.128.71])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 1CE473F7D2\n for <kernel-team@lists.ubuntu.com>; Thu, 16 Apr 2026 13:23:54 +0000 (UTC)","by mail-wm1-f71.google.com with SMTP id\n 5b1f17b1804b1-488d9e1e61aso44190725e9.0\n for <kernel-team@lists.ubuntu.com>; Thu, 16 Apr 2026 06:23:54 -0700 (PDT)","from localhost (93-35-126-76.ip55.fastwebnet.it. [93.35.126.76])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488f581d836sm50904385e9.7.2026.04.16.06.23.52\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 16 Apr 2026 06:23:52 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1776345834;\n bh=7iaUawhZE9HVeU26XtpYnk4ntlAulEEFDV+lJgzkl20=;\n h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n Content-Type:In-Reply-To;\n b=YE2JBhOMkjtyQRej4G712WhaotteM1UN05Snj76aRIUmfkBS/BEp/IMRk3V2hVVuj\n ZGFQq9cywuaU0t0/KR1JOZ/0dkDfEhrl9G43InnNEZEpBO5O/Bi4Pc1LPO8ARqueDp\n UOPbG0KA+JmSGlT96ncA0SWZHTUGpE+GA3PmRAp2jwlrc5guBTgDm7d8Q1ao3whBfo\n M1cvaec2OIHxROU96u05CAlj1ybnWLPoMWrVs4VeBhaDHKubKU1WUkmIz4VS/hvwpJ\n ZyJtpl0qesJlOJ+aPRAxIkfGzzy12hIDqtHY+hLtMBvk+B9VWJcIWpPkIzOq7oYlmX\n W3ptXPb4qfy9A/sb8i0g7VYZp3evPfi1DAbruWCqaR9hRVP4sdus4T681wa7uGGI5S\n oS7IbYS2mq/7ktwGD3O+dGW323SEYTDKoNBJ3xjds7TxQK+1SodXg+/fskuqeZoTbF\n glQ7pnLA9Fnq0NfbEZSB5RAelj3+hRqggZV4eDWpIxgC1oA4CZYt3atq3qZ5kJ+3fa\n LRCCupLt6aGNSsnL6SoRuB8j/o2Opo/ahNWUkQ59jP6+BrXZSKdXgj1MFBVB258TYS\n of3xCnCjp2GvO0NHLqTGmG6SJWFCVkwYwC/uZOt13oAgWV+t3UN8vK9pAyv9NmE+p8\n btikQAIcvudCRUT5yaW7UGvo=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776345834; x=1776950634;\n h=in-reply-to:content-transfer-encoding:content-disposition\n :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=7iaUawhZE9HVeU26XtpYnk4ntlAulEEFDV+lJgzkl20=;\n b=AeEGkmOIjXQUDWQzgPwWlo7fxemOlz0MLJkzbqr+WfjpM6Gh9htb6LwRy0ybMAc/Jj\n eoXu6BVtOXjkalRl+Oc8bNYnpvtkwsUHTFTzE6Ih9HnnQ7kqwRVNittybi5nPSijrTOA\n sfe9YBKh0Dk2EJ/a1POI2kKjb/WAs1zrFWMI6lulKQsD8A7n2tv94M9RNjcBC6KZWNRF\n M3EbTySlICJD0W40WdAn587ufjKxGVUIy2MHKvWGuyDdtMlCplE6zD1B4d1QvyEHpjng\n qNvfqTxUZLMZ0l98cyF/wmamKm19/eDeK7BqwomE55mncZLGqixlettYKAfxmnjx/J5a\n RIEw==","X-Gm-Message-State":"AOJu0Yz7U47bcLTl7beBpFMzJb/Dv/OpGmvgsc+T4s6t0VL5B3Rteod5\n XqpzqYkh/kFO2+rIUuBPlnJacHyzjuzM87tLlhMJmEVXJr0rDH2lMkM/E+lS/ASBx0lLnyOtM4Q\n d01hZQ8KJhBQh0vMk9rEM11HzD/g6WbUwO8yu7J578yj1TdzmHNSH++auvIVd8x+nP2shzezapN\n MH/Ke2LOR0JAIumA==","X-Gm-Gg":"AeBDievvsPagPt6dF59uc19eVZCPToGIzuvCBsWSqKAbNTjoMUd69i2zctoCI+4HSM4\n iemUDisKSLlRSgsGyK99fJ1tH4bCIKioFKQkUAKpss2HpSmF/cIwYH7yDCT7lbs3FDpj8+xDKDF\n RxmVra+ugRsrYDMrc56XgsXaM+cHwiI8+/ItwOifw56a/saKDs3S+/paHCtStKAG68lJFJVJW/T\n tTxMieZ8hOK2oQ3XgRgbNvV+elKaEOdZ+U+DMwxsUHI9L3fmpZshWzbgGOH6Sz7qpKN2ILN2ZPT\n yzpDA1X1yVcGhxKIeiuqb/4PPkgxiBpMUbzPlyRGl9EuitiNnAhb80+C6HCI9Pg89KO0STg89ws\n zNuI34abj08jRZXDBU7RK5yYJyUfa2+4284z7CEy2ai0sJ54xFRctGuFfleRUPkjxhMHIGrr/sv\n 1fjL3DJLZNUbeld7OK","X-Received":["by 2002:a05:600c:331e:b0:486:fba7:b150 with SMTP id\n 5b1f17b1804b1-488d684323amr211940565e9.15.1776345833547;\n Thu, 16 Apr 2026 06:23:53 -0700 (PDT)","by 2002:a05:600c:331e:b0:486:fba7:b150 with SMTP id\n 5b1f17b1804b1-488d684323amr211940305e9.15.1776345833083;\n Thu, 16 Apr 2026 06:23:53 -0700 (PDT)"],"Date":"Thu, 16 Apr 2026 15:23:51 +0200","From":"Alessio Faina <alessio.faina@canonical.com>","To":"Stav Aviram <saviram@nvidia.com>","Subject":"ACK: [SRU][N:linux-bluefield][PATCH v1 0/2] UBUNTU: SAUCE: vfio:\n Export vfio device get and put registration helpers","Message-ID":"<aeDi56YWCQtPiQ1P@cicciput>","References":"<cover.1776340676.git.saviram@nvidia.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<cover.1776340676.git.saviram@nvidia.com>","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions <kernel-team.lists.ubuntu.com>","List-Unsubscribe":"<https://lists.ubuntu.com/mailman/options/kernel-team>,\n <mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe>","List-Archive":"<https://lists.ubuntu.com/archives/kernel-team>","List-Post":"<mailto:kernel-team@lists.ubuntu.com>","List-Help":"<mailto:kernel-team-request@lists.ubuntu.com?subject=help>","List-Subscribe":"<https://lists.ubuntu.com/mailman/listinfo/kernel-team>,\n <mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe>","Cc":"kernel-team@lists.ubuntu.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" <kernel-team-bounces@lists.ubuntu.com>"}},{"id":3678184,"web_url":"http://patchwork.ozlabs.org/comment/3678184/","msgid":"<2f515788-8a57-4046-9be1-756a061a1e92@canonical.com>","list_archive_url":null,"date":"2026-04-16T13:43:57","subject":"ACK: [SRU][N:linux-bluefield][PATCH v1 0/2] UBUNTU: SAUCE: vfio:\n Export vfio device get and put registration helpers","submitter":{"id":90485,"url":"http://patchwork.ozlabs.org/api/people/90485/","name":"Edoardo Canepa","email":"edoardo.canepa@canonical.com"},"content":"Acked-by: Edoardo Canepa <edoardo.canepa@canonical.com>\n\nOn 4/16/26 14:14, Stav Aviram wrote:\n> BugLink: https://bugs.launchpad.net/bugs/2148554\n>\n> SRU Justification:\n>\n> [IMPACT]\n> A kernel NULL pointer dereference occurs on Nvidia BlueField DPUs running Ubuntu 24.04\n> (Noble) with linux-bluefield-6.8. The crash is triggered when closing a dma_buf file\n> descriptor associated with a vfio_pci device. The root cause is that\n> vfio_pci_dma_buf_release() and vfio_pci_dma_buf_cleanup() call vfio_put_device() to\n> release a reference, but the reference was acquired with vfio_device_get(), which uses\n> a separate refcount (device->refcount). Using vfio_put_device() incorrectly decrements\n> the kobject refcount, triggering a refcount underflow and kernel crash.\n>\n> [FIX]\n> Two custom patches are submitted:\n> - UBUNTU: SAUCE: vfio: Export vfio device get and put registration helpers — exports\n>    vfio_device_try_get_registration and vfio_device_put_registration via\n>    EXPORT_SYMBOL_GPL in vfio_main.c and adds their declarations to vfio.h, making them\n>    available to other VFIO modules.\n> - UBUNTU: SAUCE: vfio/pci: Use the correct ref count — fixes\n>    vfio_pci_dma_buf_release() and vfio_pci_dma_buf_cleanup() to call\n>    vfio_device_put_registration() instead of vfio_put_device(), correctly matching the\n>    reference acquisition done via vfio_device_get().\n>\n> [TEST CASE]\n> Compile tested on linux-bluefield-6.8 on the master-next branch.\n> Functionally verified: the NULL pointer dereference no longer reproduces after applying\n> the fix.\n>\n> [Regression Potential]\n> Low. The change corrects an incorrect function call in the release path, and the fix\n> has been functionally verified on the affected setup.\n>\n> Amir Tzin (1):\n>    UBUNTU: SAUCE: vfio/pci: Use the correct ref count\n>\n> Vivek Kasireddy (1):\n>    UBUNTU: SAUCE: vfio: Export vfio device get and put registration\n>      helpers\n>\n>   drivers/vfio/pci/dma_buf.c | 4 ++--\n>   drivers/vfio/vfio_main.c   | 2 ++\n>   include/linux/vfio.h       | 2 ++\n>   3 files changed, 6 insertions(+), 2 deletions(-)\n>","headers":{"Return-Path":"<kernel-team-bounces@lists.ubuntu.com>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=cCR4FmqA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com\n (client-ip=185.125.189.65; helo=lists.ubuntu.com;\n envelope-from=kernel-team-bounces@lists.ubuntu.com;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxK4D35Y9z1yHP\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 23:44:11 +1000 (AEST)","from localhost ([127.0.0.1] helo=lists.ubuntu.com)\n\tby lists.ubuntu.com with esmtp (Exim 4.86_2)\n\t(envelope-from <kernel-team-bounces@lists.ubuntu.com>)\n\tid 1wDN0l-0000JJ-F5; Thu, 16 Apr 2026 13:44:03 +0000","from smtp-relay-internal-1.internal ([10.131.114.114]\n helo=smtp-relay-internal-1.canonical.com)\n by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.86_2) (envelope-from <edoardo.canepa@canonical.com>)\n id 1wDN0k-0000JC-C9\n for kernel-team@lists.ubuntu.com; Thu, 16 Apr 2026 13:44:02 +0000","from mail-wr1-f69.google.com (mail-wr1-f69.google.com\n [209.85.221.69])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 2E37E3F859\n for <kernel-team@lists.ubuntu.com>; Thu, 16 Apr 2026 13:44:02 +0000 (UTC)","by mail-wr1-f69.google.com with SMTP id\n ffacd0b85a97d-43d73770e7bso711098f8f.1\n for <kernel-team@lists.ubuntu.com>; Thu, 16 Apr 2026 06:44:02 -0700 (PDT)","from [192.168.0.180] (host-82-59-155-169.retail.telecomitalia.it.\n [82.59.155.169]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43ead33d518sm14109576f8f.6.2026.04.16.06.43.59\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 16 Apr 2026 06:44:00 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1776347042;\n bh=yYM2UARQizsGevmjOA6JsfiJJdZjeQziuK0WGFbjkf0=;\n h=Message-ID:Date:MIME-Version:Subject:To:References:From:Cc:\n In-Reply-To:Content-Type;\n b=cCR4FmqArYe1InH9OnSmxjzQb6S8OdB7A/+4QDp3qYGV1zFiF2XLvYCf92+zVgMpL\n iahoELaYplpIsSNT53fRm8VGWYA3+/pZRJj8F/xVivGH/Ifv8pMHuclvZziLbRdNtY\n 6v9UDtyKmB9JTbSX9GS133F5J2GVxqzFI5XKtqDXnEdzNDFABgth7hEhsJuMxOMyE6\n YXgO3NzGYKSOt0Uivusyelrs8z4rZ/TmWXzDyEZIPj4AJzIZseaii05V4NBtrnUFD3\n SRbPntrvo15sT3ZpoONu8Tz6iMaTnzNZIqaqmRwmT/iWDIKeuxx5h2Qhv9ej/oxd+F\n NnDGGHQMpVWdT4V84gQVNkuFjmnE7BdJ/4f8sD1O2NvTYZoVxTul9HYROG7HHD9Cbm\n OcuarGj+5I3ETPtyIUH7dS9VeHBVJYhOhZCuhVH5afRosi0/UY5mFm12zlDJ4L+L7/\n iCRxDdfwuP3Uu3tGFpD4VaUES2uU6oAFtwT44W1ahZ6ujl2hKl8DDSyAmIJVNpRnwx\n K8Vhxi8TF4ugo8XHdZMMp1v9qHCVU0UEIWBWK83MtfVhOvs3q4gAR561/wLvHsRsHh\n kIyy+9nmdJsaYhj7YQXVH2YTjmWXJ5JJ6UuPlb3C+UdjKCKKke0Kllt/Qp1lpV+3Oc\n f54+X/5n0dJXPw9R7hlFr/bs=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776347042; x=1776951842;\n h=in-reply-to:autocrypt:cc:content-language:from:references:to\n :subject:user-agent:mime-version:date:message-id:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=yYM2UARQizsGevmjOA6JsfiJJdZjeQziuK0WGFbjkf0=;\n b=oGkhjlgjQguAjUyQxW6lAjPsze5JuUl7hZ0vTyt3+DsFxo+Q6MlsdnWR+AhaCAzKCQ\n ubFu8DmYIH8iSs0w/iEoQO7lvj9lXwSPhgFdRA2c8Dlr/DobQMgYwkIeAjSR4vzJtylw\n +JFZ+LQezEy1PnY+hdkEcW8r9yCZRMeuTohmXQNcIUrFRlhmq9SPsupRuzzdn1UfAWBa\n qNzwT8YNL8TovMixwPVnL5yv6RFVfvyQ1NAkAyXqppGeeLAmrfCATBrR5vqh/PILkzJV\n bz4d+qpdRi6EPzKSjI9Kdgt2BngxbTQMVTkGdY9Y9igrHa9IcHLEtKsLNtnGuTZZ/DWS\n TmWg==","X-Gm-Message-State":"AOJu0YyInBvEl3bJiuK+Uf+bLf0LoVPt0rPhOiKWTabenJIX3vFwL4F+\n h4W4H9h4TIQf1cFGV+Qqlv73p55Y+8FlmtfDuLG2iv1iQa5fol2TmqRi48ADVE+olm9jzIhE/Xu\n AnENKOa9GACrO5gYJbpLc8GgGMI8GUx+NGVzmMjJsNrqGvILwXLXThdHGfJCLu0za4bByl8P7+a\n bYypotASb9w11Ebg==","X-Gm-Gg":"AeBDievZzWMCi3bvyUkUbfp0ZyrsOTa5gOO6jOu0ai80iDTcl+Ain62awXlEYt2vt6x\n USgTUxANw0Y0WVCrS6cFhtjfL+Zre702RXwJRAVrJndLTsv19shl8wZyvaNwcWq4mB7YfBaFuyK\n pAmwf452ERthW5PoqNX3Tp0cjMFZRwb1YRdDHgAzoAwcB1NkIae6KdYnBDG7lP2uHRbslTtyWgQ\n ugzgWN90umvaeg+wVYU+fLB7iw7f66gQb/qUl46D+6ZnBqHdf3TQxeWt4lShdQRm+w2yCzLh8g7\n HXn/jEUR9J3gi8EKQPLflzdLQaYZLDYWP+bwVuuzlnXxcYMfn9Jv9DGuT7i1edMn1WoyDVPgyfm\n 30sTtUMrxr444DqWn4yqOT7Z6W5zUHdDDxlcrjLgrRHNqaaMZSh0lJiYkV59kxJXOMYZnabnKP+\n 1H36TLawh3hw==","X-Received":["by 2002:a05:600c:1909:b0:485:358b:e7ee with SMTP id\n 5b1f17b1804b1-488f5ab8ea3mr18237705e9.0.1776347041557;\n Thu, 16 Apr 2026 06:44:01 -0700 (PDT)","by 2002:a05:600c:1909:b0:485:358b:e7ee with SMTP id\n 5b1f17b1804b1-488f5ab8ea3mr18237495e9.0.1776347041057;\n Thu, 16 Apr 2026 06:44:01 -0700 (PDT)"],"Message-ID":"<2f515788-8a57-4046-9be1-756a061a1e92@canonical.com>","Date":"Thu, 16 Apr 2026 15:43:57 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"ACK: [SRU][N:linux-bluefield][PATCH v1 0/2] UBUNTU: SAUCE: vfio:\n Export vfio device get and put registration helpers","To":"kernel-team@lists.ubuntu.com","References":"<cover.1776340676.git.saviram@nvidia.com>","From":"Edoardo Canepa <edoardo.canepa@canonical.com>","Content-Language":"en-US","Autocrypt":"addr=edoardo.canepa@canonical.com; keydata=\n xsFNBGe8ST0BEADYJHhojXYD38nREU7XXye+1ufXZlUvoDBZwcyqvaiaHj6r8sVdhnp2IDnq\n /Be+Z1NddlKmBBr9W6dSFKfqdK/MheuiG7Pp3Rt1KhqAPgDdQu3gga+YkG5/ALaUwbgj56Ov\n 4Xr1AGccuz4C0Qo0q4nuOGWeLars8Q4hovBc/itG7go1D4x9YPX5uBOin3ZeVtA3JIhiZ5Ud\n dUXaIqwpNJkE8o9EdGTFhVXok9vrGLlJpUfOJLIcx0WUe3n41N0t3k8UF+rPCOzRkY9WqyAx\n ZCIufFnAwCaGM1pKNLwz4PFb/YjfbKmvSItUhoCgF+Uk+SAwXhByEI/8lpbMkcMASNFigEqZ\n h8mpIL2X4arpaepZ8Xgr69QYRRbvfLVsruNdHjIrah4qYTLcIhd1gCfkVEX9kJxmGkFL4BGc\n goQcH8mPTB80nJQUYvA6TI6Nz/v9ghm52SEdwap8MQUqS0V7Vs+wc2XIoVwqcxvfCTQDxxmQ\n WdJlDjm7xs1WmVLhQ9gP/B7CjZY7hy1ZPHp+J4BdVKl7iMvW+nW3yqqV51MZ+wszk2eovdFH\n EnoYyuLoknnycoBLr+NbHV2F2+jld4+xUdmocPUWQ7mfEKxQE5Ksm5zdPMYn1WcErqZO6QoZ\n TBFqDyZkrxh/HAYlOv//bbccMql+ipon72xk1ZYJZF5xQrww+QARAQABzTlFZG9hcmRvIENh\n bmVwYSAoQ2Fub25pY2FsKSA8ZWRvYXJkby5jYW5lcGFAY2Fub25pY2FsLmNvbT7CwZEEEwEK\n ADsWIQQw/83NBx8WWazslyog+IFy4U9nhAUCZ7xJPQIbAwULCQgHAgIiAgYVCgkICwIEFgID\n AQIeBwIXgAAKCRAg+IFy4U9nhO/pEACwQG0MLkYHWT+hDwIwFD5Z1yje6V1C4zGB6AyZhTF8\n RGWvYgekF5b/0mNLO7tHEAOOOr+GVN+AiPs7z/Evj5390a1plgjhNAmqpnb4NBJD4ug7iKkE\n Kz5LrRURVi7AZB3GQ7fMBx7NSmMKUsUYjgdbP2LoGkHZMslrZcjeWE+V6OtVm+At9XgN0CFe\n b+5SaM0wlXpNjL+mc4K9dw4YYaKQXFwoEUuAULMkhruL2nN3IuPWU+prIWhK8qz7OhERawNW\n ruw7JRK9cJKK/wewy4YVSkDUAK6pqoU70Rkwy6gB2FBwBgXRDlNyqdqXmtZJYBrxtH3cvcCM\n ySJ9gOscRQRzI6wYmbwPiYn7wgNLhnyCbpNwjk7E0KzrMiboEgmjH1LZI2tAqQugVZMjOekb\n N9HCYifZyaPGPzCs3ZzrmUr9exjZTj2KkM1qj5mlEHmFTvs6V8DFvL6nBnS4n/UCxEsScHZm\n HRzow2itob6v5sN39BbyXuPJCwZZYDOovdCr8m5uaDKMlOexD04CUEIaDiftytYYsPReMiRc\n /rVIcgWIT+jTGlDWNE231tZSD6+rLgclFl5V9CElQxnK6q2BG2VoDfHI0GIp//zgcDCnOudl\n HEfD5JqfFDTkorBD/uAmwb71/4Nprc6c5oi3ivPUZ2a2hxp1LNI840YBkSBbf44CqM7BTQRn\n vEk9ARAAyCAebr3QTSoC8WWWOljnkPMpckUgV5ehSfLsMJk7F9jSS6Gbjtnnn+YHcXc3Lwkf\n Lhg5Ydf2pX0jb/P7wnAF7iE1uK2ypc3KchxBiVekELyWbmY0m2vE/NkRbIILB38Z6inl9Ek/\n jkEnSHAi6PTuzsk2SKbwrUDovXO2rsX4nyyJ3JaohqgN8ddBVivq2AEtm13O1BOSPnKgwv1w\n PjftpA4ZZA/1qWpiQK0zHYVG5gdcJskJYmfcXqBgQtvdObRuN4WWK2S8LSJaERbn84BvFNoX\n OlVts1I8IM+Ok4BPZ4hXo/7LZ3nfxnVwAEM5CvssE7oogRkzMwS/ULYaGJ5cwFFKMxV7tEVG\n MQBlIkXn03btn2cp6xJFKu1A5U2s7s4KOrxP+XmONLeb0gzP3Rfc4fawInn1PAuNKbGpCwAB\n D7spmf49n1AneiiEFGm55Z/k/733RQ42TGvSboPrUZFEN7W6ZMBYVb4dUcWq0m0i7G4K4Gb7\n VvVVIA2BrybL5ZwIX7w/noUmlKCu1hnApGfAb/sW5uiurubn3IMjvGD0tJkH3HOMrMlqMD9k\n O1EksIlUqidMol7PoMLvz4sW9q+f1Vv68TidT/4bnyOS41XBsIAeWAyAXqWVNuuj985Ihv2f\n BZmoMpIlYD0fvg+pUVfzAKKAz1F+IlpyBafRg8NBe80AEQEAAcLBdgQYAQoAIBYhBDD/zc0H\n HxZZrOyXKiD4gXLhT2eEBQJnvEk9AhsMAAoJECD4gXLhT2eEBdUP/2hCPA6ww4X+EW/GBox+\n /1SLxsbek48U6Lhl3jis/n4ybo9/TW/2V+AlAdO+v/eF0tNEitLRt5RFq/yxlRguh3Brr5DM\n 3rbXt9f2vyfhaGRp7JPT2vVSL7IVnOZuCWTsNyzoEYHP6uSS8CTBoS+pNqNXrERbQz4wy6SM\n Ym4Pg87yDOErsGPxFP5/16V/ifTFSVJAPbnvxn9LnfZoXcf7J1yNsbtZtxQhUaQPtpoYGOJk\n CmUAi9HO2aeALLoMJUrLDQutDhEltXAxssp70EZCZ/HwxQ1bBnvfkMJhkp1mfA2zXGbNqEJC\n 6cnTWvd6NgUmNzMZkyeTAawsKUcJ7wrQngMe+jFelgeIeVVocMQrOgdKokbzjE60HQIvd/Cj\n vMSqEvpt5fYlAl3NAmnah216YSLJI68+6Nh2299anoDBCTquUAv/fhfcaCsK+IbHvv46Qmm4\n fdJk6gGOgOB2ybVeqFrakpGSFV4jP5R+I0oDi69CFbyllpFiClhLrSh8WDvXiUlREIO1LXjJ\n fKsjy8xLzes06RDbLWm8Ke07N//LzgThJVm+TWUsirje44HAKZSkWoVA82BcfYrubJL/1+8n\n VYnh8AQH0TRTaYWMLqd+0WWI036wj0fOvgmrKJWgurjSZuYW1ggrEWE2sk1AsS4HBBXEbavZ\n dY9caht83AICwsvW","In-Reply-To":"<cover.1776340676.git.saviram@nvidia.com>","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions <kernel-team.lists.ubuntu.com>","List-Unsubscribe":"<https://lists.ubuntu.com/mailman/options/kernel-team>,\n <mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe>","List-Archive":"<https://lists.ubuntu.com/archives/kernel-team>","List-Post":"<mailto:kernel-team@lists.ubuntu.com>","List-Help":"<mailto:kernel-team-request@lists.ubuntu.com?subject=help>","List-Subscribe":"<https://lists.ubuntu.com/mailman/listinfo/kernel-team>,\n <mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe>","Content-Type":"multipart/mixed; boundary=\"===============2531091258610605204==\"","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" <kernel-team-bounces@lists.ubuntu.com>"}},{"id":3678521,"web_url":"http://patchwork.ozlabs.org/comment/3678521/","msgid":"<aeHZZiTnjLRRVvgO@cicciput>","list_archive_url":null,"date":"2026-04-17T06:55:34","subject":"APPLIED: [SRU][N:linux-bluefield][PATCH v1 0/2] UBUNTU: SAUCE: vfio:\n Export vfio device get and put registration helpers","submitter":{"id":91694,"url":"http://patchwork.ozlabs.org/api/people/91694/","name":"Alessio Faina","email":"alessio.faina@canonical.com"},"content":"On Thu, Apr 16, 2026 at 03:14:04PM +0300, Stav Aviram wrote:\n> BugLink: https://bugs.launchpad.net/bugs/2148554\n> \n> SRU Justification:\n> \n> [IMPACT]\n> A kernel NULL pointer dereference occurs on Nvidia BlueField DPUs running Ubuntu 24.04\n> (Noble) with linux-bluefield-6.8. The crash is triggered when closing a dma_buf file\n> descriptor associated with a vfio_pci device. The root cause is that\n> vfio_pci_dma_buf_release() and vfio_pci_dma_buf_cleanup() call vfio_put_device() to\n> release a reference, but the reference was acquired with vfio_device_get(), which uses\n> a separate refcount (device->refcount). Using vfio_put_device() incorrectly decrements\n> the kobject refcount, triggering a refcount underflow and kernel crash.\n> \n> [FIX]\n> Two custom patches are submitted:\n> - UBUNTU: SAUCE: vfio: Export vfio device get and put registration helpers — exports\n>   vfio_device_try_get_registration and vfio_device_put_registration via\n>   EXPORT_SYMBOL_GPL in vfio_main.c and adds their declarations to vfio.h, making them\n>   available to other VFIO modules.\n> - UBUNTU: SAUCE: vfio/pci: Use the correct ref count — fixes\n>   vfio_pci_dma_buf_release() and vfio_pci_dma_buf_cleanup() to call\n>   vfio_device_put_registration() instead of vfio_put_device(), correctly matching the\n>   reference acquisition done via vfio_device_get().\n> \n> [TEST CASE]\n> Compile tested on linux-bluefield-6.8 on the master-next branch.\n> Functionally verified: the NULL pointer dereference no longer reproduces after applying\n> the fix.\n> \n> [Regression Potential]\n> Low. The change corrects an incorrect function call in the release path, and the fix\n> has been functionally verified on the affected setup.\n> \n> Amir Tzin (1):\n>   UBUNTU: SAUCE: vfio/pci: Use the correct ref count\n> \n> Vivek Kasireddy (1):\n>   UBUNTU: SAUCE: vfio: Export vfio device get and put registration\n>     helpers\n> \n>  drivers/vfio/pci/dma_buf.c | 4 ++--\n>  drivers/vfio/vfio_main.c   | 2 ++\n>  include/linux/vfio.h       | 2 ++\n>  3 files changed, 6 insertions(+), 2 deletions(-)\n> \n> -- \n> 2.38.1\n> \n> \n> -- \n> kernel-team mailing list\n> kernel-team@lists.ubuntu.com\n> https://lists.ubuntu.com/mailman/listinfo/kernel-team\n\nApplied to n:linux-bluefield \n\nThanks!\n- Alessio Faina","headers":{"Return-Path":"<kernel-team-bounces@lists.ubuntu.com>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=WClTJx2S;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com\n (client-ip=185.125.189.65; helo=lists.ubuntu.com;\n envelope-from=kernel-team-bounces@lists.ubuntu.com;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxlyR1tmVz1yGt\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 16:55:43 +1000 (AEST)","from localhost ([127.0.0.1] helo=lists.ubuntu.com)\n\tby lists.ubuntu.com with esmtp (Exim 4.86_2)\n\t(envelope-from <kernel-team-bounces@lists.ubuntu.com>)\n\tid 1wDd73-0005Tc-Mr; Fri, 17 Apr 2026 06:55:37 +0000","from smtp-relay-internal-1.internal ([10.131.114.114]\n helo=smtp-relay-internal-1.canonical.com)\n by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.86_2) (envelope-from <alessio.faina@canonical.com>)\n id 1wDd72-0005T4-W6\n for kernel-team@lists.ubuntu.com; Fri, 17 Apr 2026 06:55:37 +0000","from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n [209.85.128.70])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id D87693F620\n for <kernel-team@lists.ubuntu.com>; Fri, 17 Apr 2026 06:55:36 +0000 (UTC)","by mail-wm1-f70.google.com with SMTP id\n 5b1f17b1804b1-488c0120047so1669645e9.0\n for <kernel-team@lists.ubuntu.com>; Thu, 16 Apr 2026 23:55:36 -0700 (PDT)","from localhost (93-34-57-252.ip48.fastwebnet.it. [93.34.57.252])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e46471sm1744362f8f.28.2026.04.16.23.55.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 16 Apr 2026 23:55:35 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1776408936;\n bh=TCkQxAFSyd5Vore4cU1Bdb5IdCH3Ut2atNJgCCQAn94=;\n h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n Content-Type:In-Reply-To;\n b=WClTJx2SDeFqTrzIYatfL6gHbbSOnPFrvCHgaUDFm4OpYPoyynW77+jjvVNEDR9X7\n F/EiHDVxbM8FkRXCHgW59sWmNcvHzfvqsvCucgt7JQwt1avtRtw2tILMSKSXpjyBbV\n 6NF/grj0h4AxbL+G9Sq3GgjhDpAl3adSqazmqSbXhJEXY0+1qCZxj22vXhiTvsz4wU\n R8Cvvn2zBvVbiXYjLg8UAbBVhAiUKeR/Qqw5rCkh8oBb27yATEySGmRegVE3D8cGMD\n BCQj2L2XTdIu2QuoIbUTKiZh8Gz2XJ+5/i+c2V485v58A8BqhO9j3AMNSmoVgFO2WL\n Lo0mJaXWNEZIyapWJhV2yI51fHXhAF4Noxf1wSMdd/win/5HIqQ36jWpAClgXCsK2R\n 5d6RKmsAs/d6YQPag9Kvrwh5VjGKjfMokv79k81TAjn+5bDN4I3L90WpXGydScU9Tc\n ok+ahMSI9lV7bISSBB+xpkasTVyQDVJiO+FONOXJ3UVpNvfahX4yAtbIWcPnRvq/pW\n yVaJiovvF/eSJwnpNJOm6j6wU7nyVK0mKMB1P648q/tc8gEm4tRUs93sTQgVXMh4Kx\n juuYcPhz+Me21FigvWs/sZoPxxk0d9D7Q/cUqrL0+x+WA9A5ZQnNZGNVFsGlzLcngX\n nTSpWhe+JxOjcoRTtlQS6HJc=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776408936; x=1777013736;\n h=in-reply-to:content-transfer-encoding:content-disposition\n :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=TCkQxAFSyd5Vore4cU1Bdb5IdCH3Ut2atNJgCCQAn94=;\n b=C0bnmGsITrquXxo6xE0phny7WIW32a45IHYxx5/4Si5L78PrRHl/U2y8jcRajTYjCh\n dtCm3WbWM/3AbGwETnivXTNnzglrOUkVRbZkYjBco6qQFalTBmFpPC0ExuP4s+G+sl6P\n 2FwyZIaWex2VwlLwuCoWN6kgT3yz1HNbbhB37jk2NnpTaG1aCQ/4TJfUIs6NWmILqZk2\n UowbUp1u2zva8x7PAu9FEJ8tcArUP+k6rNr1hQZt9xMLbyQZz4CiTDjS1U7uD/gjZGlC\n yKnWMi7XW6+biZNd6mn7uRAgqfd7JdeqFft+genmIbSWHHcmmO366DjjZ3h4AMeW7nP2\n xyoQ==","X-Gm-Message-State":"AOJu0Yyl5MQHLlCXaQv3JgWuX/k0gfs8foe1L97pCqaDDUjq9szFbn7f\n oEoAYhjYdEMQtZ8FOndybMQwhsaYqY6qrwqlUrTmnZJ793VuZgo0ahM0j+B0ZpDZcSA0m/hsEiO\n n+odSJjQgqP+sO8IvN3cbTsthGh5YcTHvyqy0W4g4rtRKgACPFgw4hLKRTiwURyk/OpdrF2/ha6\n CPfzdyVw==","X-Gm-Gg":"AeBDievXzXOPlC4Aue8Uvc1BQx6tZjpkImz/T9E0wVfEA2ZBVKuOsNISQeeEFUHxnmA\n X0tMa6KEptnl7KHP6TgKmOfunQYVum1+zc2Sph76F1QwFBav7HqrW8VZV3o6FmwJBm9VD6JgFjm\n mchnCOd33KaLT6h34R8TTylD2s4wXb4iIx1BCG6AobcmRgp9hbPjcoDjlvlj15XMezULdfHiQA5\n XUtuM7mEN+TjMHohIBQYP1lIK+bsJoE9FIwXcS/O9qW/5JvnddM1q9gSie3oQlIWK+oS8fW/oNX\n 2PCQbC2vMt96vBmt9wWcZdXGNUMaoH5Kf2VRvKk7JcDA8ch4mPP3fOZbuX8EcaTX3CpSw8ucksr\n RfG7pBAUBzL0hUPgIsTc2anh1IlpdwC2gpSi2yn+V0OguKC4sdUdLhbgqbsPFbm6pNwkwnZl9DW\n HxRHSkhFL0FOqPtEvv4XVZYr24TNg=","X-Received":["by 2002:a05:600c:1da1:b0:488:79a3:f04c with SMTP id\n 5b1f17b1804b1-488fb7863femr20900905e9.27.1776408936328;\n Thu, 16 Apr 2026 23:55:36 -0700 (PDT)","by 2002:a05:600c:1da1:b0:488:79a3:f04c with SMTP id\n 5b1f17b1804b1-488fb7863femr20900505e9.27.1776408935851;\n Thu, 16 Apr 2026 23:55:35 -0700 (PDT)"],"Date":"Fri, 17 Apr 2026 08:55:34 +0200","From":"Alessio Faina <alessio.faina@canonical.com>","To":"Stav Aviram <saviram@nvidia.com>","Subject":"APPLIED: [SRU][N:linux-bluefield][PATCH v1 0/2] UBUNTU: SAUCE: vfio:\n Export vfio device get and put registration helpers","Message-ID":"<aeHZZiTnjLRRVvgO@cicciput>","References":"<cover.1776340676.git.saviram@nvidia.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<cover.1776340676.git.saviram@nvidia.com>","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions <kernel-team.lists.ubuntu.com>","List-Unsubscribe":"<https://lists.ubuntu.com/mailman/options/kernel-team>,\n <mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe>","List-Archive":"<https://lists.ubuntu.com/archives/kernel-team>","List-Post":"<mailto:kernel-team@lists.ubuntu.com>","List-Help":"<mailto:kernel-team-request@lists.ubuntu.com?subject=help>","List-Subscribe":"<https://lists.ubuntu.com/mailman/listinfo/kernel-team>,\n <mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe>","Cc":"kernel-team@lists.ubuntu.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" <kernel-team-bounces@lists.ubuntu.com>"}}]