[{"id":3682339,"web_url":"http://patchwork.ozlabs.org/comment/3682339/","msgid":"<20260425193152.38f80bf1@jic23-huawei>","list_archive_url":null,"date":"2026-04-25T18:31:52","subject":"Re: [PATCH v8 0/6] iio: adc: ad4691: add driver for AD4691\n multichannel SAR ADC family","submitter":{"id":10151,"url":"http://patchwork.ozlabs.org/api/people/10151/","name":"Jonathan Cameron","email":"jic23@kernel.org"},"content":"On Thu, 16 Apr 2026 12:18:45 +0300\nRadu Sabau via B4 Relay wrote:\n\n> This series adds support for the Analog Devices AD4691 family of\n> high-speed, low-power multichannel successive approximation register\n> (SAR) ADCs with an SPI-compatible serial interface.\n> \n> The family includes:\n> - AD4691: 16-channel, 500 kSPS\n> - AD4692: 16-channel, 1 MSPS\n> - AD4693: 8-channel, 500 kSPS\n> - AD4694: 8-channel, 1 MSPS\n> \n> The devices support two operating modes, auto-detected from the device\n> tree:\n> - CNV Burst Mode: external PWM drives CNV independently of SPI;\n> DATA_READY on a GP pin signals end of conversion\n> - Manual Mode: CNV tied to SPI CS; each SPI transfer reads\n> the previous conversion result and starts the\n> next (pipelined N+1 scheme)\n> \n> A new driver is warranted rather than extending ad4695: the AD4691\n> data path uses an accumulator-register model — results are read from\n> AVG_IN registers, with ACC_MASK, ADC_SETUP, DEVICE_SETUP, and\n> GPIO_MODE registers controlling the sequencer — none of which exist\n> in AD4695. CNV Burst Mode (PWM drives CNV independently of SPI) and\n> Manual Mode (pipelined N+1 transfers) also have no equivalent in\n> AD4695's command-embedded single-cycle protocol.\n> \n> The series is structured as follows:\n> 1/6 - DT bindings (YAML schema) and MAINTAINERS entry\n> 2/6 - Initial driver: register map via custom regmap callbacks,\n> IIO read_raw/write_raw, both operating modes, single-channel\n> reads via internal oscillator (Autonomous Mode)\n> 3/6 - Triggered buffer support: IRQ-driven (DATA_READY on a GP pin\n> selected via interrupt-names) for CNV Burst Mode; external IIO\n> trigger for Manual Mode to handle the pipelined N+1 SPI protocol\n> 4/6 - SPI Engine offload support: DMA-backed high-throughput\n> capture path using the SPI offload subsystem\n> 5/6 - Per-channel oversampling ratio support for CNV Burst Mode\n> 6/6 - Driver documentation (Documentation/iio/ad4691.rst)\n> \n> Datasheets:\n> https://www.analog.com/en/products/ad4691.html\n> https://www.analog.com/en/products/ad4692.html\n> https://www.analog.com/en/products/ad4693.html\n> https://www.analog.com/en/products/ad4694.html\n> \n> Signed-off-by: Radu Sabau \ndrivers/iio/adc/ad4691.c: note: in included file: \n./include/linux/bitmap.h:845:55: warning: shift too big (64) for type unsigned long \n./include/linux/bitmap.h:845:55: warning: shift too big (64) for type unsigned long \n./include/linux/bitmap.h:845:55: warning: shift too big (64) for type unsigned long \n./include/linux/bitmap.h:845:55: warning: shift too big (64) for type unsigned long\n\nFrom sparse. I think it's a false positive.\nIt's the bitmap_read() calls - probably the the nbits parameter.\nUsing bitmap_read() to copy the whole bitmap is unusual so maybe this is a corner\ncase that isn't handled. \n\nAny ideas? I'm going to assume it's a false positive due to the ACCESS_PRIVATE()\nconfusing sparse.\n\nSo with that in mind, series applied to the testing branch of iio.git.\n\nthanks,\n\nJonathan","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pwm@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ZmpgNkeJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pwm+bounces-8693-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"ZmpgNkeJ\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2z8W5sSqz1y2d\n\tfor ; Sun, 26 Apr 2026 04:37:31 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 9AC023069642\n\tfor ; Sat, 25 Apr 2026 18:32:13 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 289D6372689;\n\tSat, 25 Apr 2026 18:32:07 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 00F8F1A9F8C;\n\tSat, 25 Apr 2026 18:32:06 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id AC239C2BCB0;\n\tSat, 25 Apr 2026 18:31:57 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777141927; cv=none;\n b=rjbhcpQxtzLpOZjOuhlaGURETCfd1A1YUwpT3xEs2e4GyAhIGm2R69fhlsfUT2SgNc1A8gZivP1n+Wa0xNUvb48lj9VAhhJ2m7xyt2BhgMnJrw2k6e1OXEkl4ZwVLPq0rSODm+pR/mAEPDu8HmVZVCh9GJk5NnsUyqbz1hDWLc4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777141927; c=relaxed/simple;\n\tbh=FLjGSUxfmVrj9s85Y91kN/Rh54l5tbngbBRVZAeMXLw=;\n\th=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=kuKQVZ5URJgUbf1aafZ/mlqTxidw6Cvn+uOjHHUnCP5xwvJ9MTfrvq+VwV3QN9agU9jEMc2VnavzlxJ8/8uQAQVmOFGR8wiPnrCNX5K3BHaHKezAXE/isaAZL8H+3+TbsV1D4cZt4E+tcDja6cd7kF4W3wv+ShzAD4yU1CNz4yE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=ZmpgNkeJ; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777141926;\n\tbh=FLjGSUxfmVrj9s85Y91kN/Rh54l5tbngbBRVZAeMXLw=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:References:From;\n\tb=ZmpgNkeJr2QlntRxed9Wzx9+sM6vLXZ1VOI4M15lJq7Wa+ueFM58tml3IcwNgY54A\n\t j3rhEo3MPaqtBDPRkScLx13JGB2m3dNYRmOan3qXtd3FS/FGUuFYNYABp2EtP2INrZ\n\t af0L5QMjyXsIZ28oiv/TqxFl+Ld4zc+NO9dCMVhJLhX1+9N5XUGXqwYgTvJoVpXMD2\n\t YcvI9THChERbyois++w5mFDqLEALKDSAm/fJw21FW8Jt1XZCLtq+NxVGzX3N3YTJVz\n\t kbSKhpyRP0VpPjZUchF/BS0FlFEtpp+nkhUOX/kG2aAkpAPU8thPaJ7wSmGtFjLtSC\n\t 2oGpqTDbCm4Rw==","Date":"Sat, 25 Apr 2026 19:31:52 +0100","From":"Jonathan Cameron ","To":"Radu Sabau via B4 Relay ","Cc":"radu.sabau@analog.com, Lars-Peter Clausen ,\n Michael Hennerich ,\n David Lechner ,\n Nuno =?utf-8?b?U8Oh?= ,\n Andy Shevchenko , Rob Herring ,\n Krzysztof Kozlowski , Conor Dooley ,\n Uwe =?utf-8?q?Kleine-K=C3=B6nig?= ,\n Liam Girdwood , Mark Brown ,\n Linus Walleij , Bartosz Golaszewski ,\n Philipp Zabel , Jonathan Corbet ,\n Shuah Khan , linux-iio@vger.kernel.org,\n devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org,\n linux-doc@vger.kernel.org, Conor Dooley ","Subject":"Re: [PATCH v8 0/6] iio: adc: ad4691: add driver for AD4691\n multichannel SAR ADC family","Message-ID":"<20260425193152.38f80bf1@jic23-huawei>","In-Reply-To":"\n <20260416-ad4692-multichannel-sar-adc-driver-v8-0-c415bd048fa3@analog.com>","References":"\n <20260416-ad4692-multichannel-sar-adc-driver-v8-0-c415bd048fa3@analog.com>","X-Mailer":"Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu)","Precedence":"bulk","X-Mailing-List":"linux-pwm@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable"}}]