[{"id":3677832,"web_url":"http://patchwork.ozlabs.org/comment/3677832/","msgid":"<94bf8494-1ad5-44de-9669-865223c08875@oss.qualcomm.com>","list_archive_url":null,"date":"2026-04-15T22:01:04","subject":"Re: [PATCH 0/8] cocci: Do not initialize variable used by *FOREACH*()\n macro","submitter":{"id":93152,"url":"http://patchwork.ozlabs.org/api/people/93152/","name":"Pierrick Bouvier","email":"pierrick.bouvier@oss.qualcomm.com"},"content":"On 4/15/2026 2:55 PM, Philippe Mathieu-Daudé wrote:\n> Most of our *FOREACH*() macros take a pointer argument,\n> then assign it upon entry before iterating. Thus there\n> is no need to initialize the variable used as argument.\n> But sometimes we do, which is confusing (for example\n> &first_cpu). This series uses a Coccinelle script to\n> clean these unnecessary usages. (and 2 bonus cleanup\n> patches at the end).\n> \n> Philippe Mathieu-Daudé (8):\n> cocci: Do not initialize variable used by QLIST_FOREACH macro\n> cocci: Do not initialize variable used by QSLIST_FOREACH macro\n> cocci: Do not initialize variable used by QSIMPLEQ_FOREACH macro\n> cocci: Do not initialize variable used by QTAILQ_FOREACH macro\n> cocci: Do not initialize variable used by RAMBLOCK_FOREACH* macro\n> cocci: Do not initialize variable used by CPU_FOREACH macro\n> target/mips: Reduce CPUState scope when used with CPU_FOREACH()\n> target/riscv: Iterate vCPUs using CPU_FOREACH() macro\n> \n> target/mips/internal.h | 11 ++++++-----\n> block/blkdebug.c | 2 +-\n> block/blkio.c | 2 +-\n> block/gluster.c | 4 ++--\n> ebpf/ebpf.c | 2 +-\n> hw/arm/virt-acpi-build.c | 2 +-\n> hw/i386/xen/xen-hvm.c | 4 ++--\n> hw/misc/mips_cpc.c | 4 ++--\n> hw/ppc/spapr.c | 2 +-\n> hw/ppc/spapr_events.c | 4 ++--\n> hw/riscv/boot.c | 9 +++++----\n> hw/riscv/riscv-iommu.c | 2 +-\n> hw/vfio/cpr-legacy.c | 2 +-\n> hw/vfio/listener.c | 4 ++--\n> hw/xen/xen_pt_config_init.c | 4 ++--\n> migration/block-dirty-bitmap.c | 2 +-\n> migration/dirtyrate.c | 4 ++--\n> net/colo-compare.c | 4 ++--\n> net/net.c | 2 +-\n> target/mips/tcg/system/cp0_helper.c | 28 ++++++++++++++++------------\n> target/mips/tcg/system/tlb_helper.c | 7 +++----\n> target/s390x/kvm/stsi-topology.c | 2 +-\n> 22 files changed, 56 insertions(+), 51 deletions(-)\n> \n\nFor the series:\nReviewed-by: Pierrick Bouvier ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=eYz82mUC;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=HvF6oqLy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fww934rm6z1yG9\n\tfor ; Thu, 16 Apr 2026 08:01:57 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wD8IQ-0007vc-Qn; Wed, 15 Apr 2026 18:01:18 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wD8IL-0007up-5r\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 18:01:14 -0400","from mx0b-0031df01.pphosted.com ([205.220.180.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wD8IH-0004po-Mc\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 18:01:12 -0400","from pps.filterd (m0279870.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63FFFo7h1792541\n for ; Wed, 15 Apr 2026 22:01:07 GMT","from mail-dl1-f70.google.com (mail-dl1-f70.google.com\n [74.125.82.70])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djd5ps84u-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for ; Wed, 15 Apr 2026 22:01:07 +0000 (GMT)","by mail-dl1-f70.google.com with SMTP id\n a92af1059eb24-1273dfdaf5dso52540c88.0\n for ; Wed, 15 Apr 2026 15:01:07 -0700 (PDT)","from [192.168.1.170] (216-71-219-44.dyn.novuscom.net.\n [216.71.219.44]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2de8f569f4bsm4413086eec.21.2026.04.15.15.01.04\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 15 Apr 2026 15:01:05 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n Bh3eSiFjGrGUzXTANPTKFs94mGxC5Gtrw/UPDWVy1YE=; b=eYz82mUC7HYsxL+p\n EEuOETNMccpBMAlybz9j1wgfDRumUxzBmI57qVPrkENx0AUzLnKURE1zSO3wB2u1\n TxTse8oFEVnDRkXWXKV4m5g59URiecZ45kkMvBL72ZkxzxBhnL6MPIcUrE3rV2MU\n zsjlNWrZUqXp0DydKjNnweByCg549ncE+8MbbPYGdiv5juwRf1+G4E+R23zbdKgU\n N/cLU8N5SpqTcn0JpaDkX5gMCgDO+Jf/Q1JGb6ZDBWGYmoySdFfyZ6wmVy9I9E3+\n 7QdwngV2m2DRnoHVnTIz8eXdLefdDbxSP24wWSLx/mgK8Rb/+5Uk/x4bM85JBeXo\n S2QZ/g==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1776290467; x=1776895267; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=Bh3eSiFjGrGUzXTANPTKFs94mGxC5Gtrw/UPDWVy1YE=;\n b=HvF6oqLy/3Ubv/PNrJaaZRK8V7xH8uScvhqhvIefp9HaDKN771E8a09vprdjFnQYXX\n 6+s4llGPdND+KklkZdSv8oHqGTnOKv7Hf55Sn0b5EBKcdOGYp/tjFGttwDhVvFTVhZ76\n evzOMRAmyDM6OUBw4CZ32fdfwQFoQboEaK3dD0z4MLZtPBRFLCfonSxn/Ywhhw+mM4Dd\n EvN2/yplnu2U+fvIL60KT5GqEyGECaOs9lI7DCB1QGDhosbNMLVHV5wotbJffppL80SW\n OhCfAuoROhoVERMY/tg3etvEYd16lDv7m2dPtIB4B2EsVul1q8OtY42PDFp5MB7VTemU\n IPHQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776290467; x=1776895267;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=Bh3eSiFjGrGUzXTANPTKFs94mGxC5Gtrw/UPDWVy1YE=;\n b=XCx2rieEIj2On8B+HvLAaZqlKhrWrVHfZR/nijN87cdOuFToafTlzj1vpQbqedXsmh\n gEpJ5yubL8lXB0HmnTof2fIgpny+aV1AEYAbnMw/ZjjPT55gEHYlc/+g9nIgscwc+nGd\n fTWIsET82kWFtdIDewLZdrQw0s/UsxK5o9Yl8X357GUePvLoS5W9/EjiLfI4S3e4swRi\n X10Z5vm9FMv4ycD0V4KdownECQBZCG9SXj4qtbf0n8zPFPjtnkFR4MpumShhN3GgjywA\n Zq1BJfi4VqtBPoB49o8IcDxujjVjQNVQnF2lDgkH1FeALjUPoDKDfCNyqniP2hI4M5O1\n 0idA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+ybdJuO0dEfySE542rfT3krWyfQPZqklLL1ayiPN3W7pxBgjayF74y+6lYxug1dhCMvgoFuyCTnAAm@nongnu.org","X-Gm-Message-State":"AOJu0YyJsBSnsCmL/faRJeQQlM2LW+3BUqRg5zJcaM/zLQt4jB3CznuG\n kjFuVernWJbVWpHrNAn3XdUimVsqMww3kdlswT0hvwvXc7OcH1jODjbfN697heVgOcSZTa1uI/f\n xkN2LZSDyuuCdzdszyqYQA2HpAurn71Q+ruYGD0zv77jJSx5rosL3JLeVcw==","X-Gm-Gg":"AeBDiesAPX9nNIfR7RtE4BqNAE/l38J6icq23FeUuYnPzeSjVCJk3Hw/7RyTDPk1vRc\n FPEOaDrX5DnsyaOq1rtF/InYrPDd5mtuS95gm2DaC4KUmwKIms/816/YjRTcjm5aumZc326FjL3\n +m+uBQHDbnvMbv3v+eRZTSRrUcJhjjZ1lq5rpUt/InF4iIWCrV7X1eFEfbmMUyoQCNkyC4usp0B\n ML0yiWYkRlhZc+Zw8vKkLIvJrKoDA/V12T/nntVJbnUjm7OpdZMjTdJ1HPDniIWVEOmNjFfowBn\n RZYCMgj4MbYeg4FVJDBKwUvtlMDgsuLa6ZtAKhd+N4Xvd0y8N5K4gi3vMOYC9ffkG2ku0vDjjRl\n wxxAtr7CCuMbPpeECV1uQdve5q08Gp9c9mrJxruoKYZWm534md5uddXsWCj+wYzYVA4WRB4mcgR\n 2nshg0VxqSPw==","X-Received":["by 2002:a05:7022:128b:b0:11a:fb0a:ceca with SMTP id\n a92af1059eb24-12c631217a9mr687537c88.16.1776290466166;\n Wed, 15 Apr 2026 15:01:06 -0700 (PDT)","by 2002:a05:7022:128b:b0:11a:fb0a:ceca with SMTP id\n a92af1059eb24-12c631217a9mr687509c88.16.1776290465444;\n Wed, 15 Apr 2026 15:01:05 -0700 (PDT)"],"Message-ID":"<94bf8494-1ad5-44de-9669-865223c08875@oss.qualcomm.com>","Date":"Wed, 15 Apr 2026 15:01:04 -0700","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 0/8] cocci: Do not initialize variable used by *FOREACH*()\n macro","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org, qemu-s390x@nongnu.org, qemu-riscv@nongnu.org,\n qemu-block@nongnu.org","References":"<20260415215539.92629-1-philmd@linaro.org>","From":"Pierrick Bouvier ","Content-Language":"en-US","In-Reply-To":"<20260415215539.92629-1-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-Proofpoint-ORIG-GUID":"b0OYnlV6iy6QYdY5TggOUyryAXdAQphV","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDE1MDIwNiBTYWx0ZWRfX4p7FnnWbiwAP\n ZV0asj7WxD9JDrTcvt94f+V0YfZMF189UHc2rb7OE8BaavjVww0xa5ceIWqipdU384SEnYHPsid\n VydY3MRimzTxbl2LuYMEhZO42qZyNUQjyOVjLX/ERTLgbT9XIHb8CU90SFZp4+YDnOuX6ZrGOYS\n ZYuEd3vr/9QIe8ZzqdBGcwybR+kX3y/FwtyGkA2JmcVGTKYJAITKf4c+agtyBOTJW6n8UDKmcOb\n QN68Djo0Cn1nmLzYH9fyYQW6q+Bk6tGU9Hq3DRfJdzpseWlrGh5DXmwWDLZK31UHaP7RoXv2KMH\n u5rTeiv4cQVsWzpkDSu6cN95xJEPbPEzVHRyftVHqMR7DMKydxqv7yuDmqONNlcy0zwCm2wVAOE\n ospGnpuf/LleO+GcUpXDRRCY/4ovzAWXnxxXqN8CYxIWig4JAMbTj7be0+pJVQd2t8WkC2PI2ZJ\n +3MAbE/gsdBpZ+r+vqA==","X-Authority-Analysis":"v=2.4 cv=AcmB2XXG c=1 sm=1 tr=0 ts=69e00aa3 cx=c_pps\n a=SvEPeNj+VMjHSW//kvnxuw==:117 a=iLqgmErQAxjCjdq5jj1Aqg==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22\n a=EUspDBNiAAAA:8 a=1CZdNKJIaicOdOL1u6UA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10\n a=Kq8ClHjjuc5pcCNDwlU0:22","X-Proofpoint-GUID":"b0OYnlV6iy6QYdY5TggOUyryAXdAQphV","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-15_01,2026-04-13_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n suspectscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 priorityscore=1501\n phishscore=0 malwarescore=0 impostorscore=0 clxscore=1015 bulkscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604150206","Received-SPF":"pass client-ip=205.220.180.131;\n envelope-from=pierrick.bouvier@oss.qualcomm.com;\n helo=mx0b-0031df01.pphosted.com","X-Spam_score_int":"-2","X-Spam_score":"-0.3","X-Spam_bar":"/","X-Spam_report":"(-0.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n SUSPICIOUS_RECIPS=2.51 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]