[{"id":3677778,"web_url":"http://patchwork.ozlabs.org/comment/3677778/","msgid":"","list_archive_url":null,"date":"2026-04-15T17:59:17","subject":"Re: [PATCH v2 0/4] show orphan file inode detail info","submitter":{"id":363,"url":"http://patchwork.ozlabs.org/api/people/363/","name":"Jan Kara","email":"jack@suse.cz"},"content":"Hello!\n\nOn Wed 15-04-26 18:55:01, Ye Bin wrote:\n> From: Ye Bin \n> \n> Diffs v2 vs v1:\n> (1) Fix sashiko review issues:\n> https://sashiko.dev/#/patchset/20260403082507.1882703-1-yebin%40huaweicloud.com\n> (2) Change \"orphan_list\" file mode from 0444 to 0400;\n> (3) The display format of the \"orphan_list\" file is modified according\n> to Andreas' suggestions.\n> Fault injection tests have been conducted to address the issues raised\n> in the sashik review. There is no UAF issue in the ext4_seq_orphan_release()\n> function. The reason for this has already been explained in the code comments.\n> In addition to the fault injection tests, we also performed a stress test by\n> observing the /proc/fs/ext4/XX/orphan_list and the concurrent processes of\n> adding and removing orphan nodes, and no issues were found so far.\n> \n> \n> In actual production environments, the issue of inconsistency between\n> df and du is frequently encountered. In many cases, the cause of the\n> problem can be identified through the use of lsof. However, when\n> overlayfs is combined with project quota configuration, the issue becomes\n> more complex and troublesome to diagnose. First, to determine the project\n> ID, one needs to obtain orphaned nodes using `fsck.ext4 -fn /dev/xx`, and\n> then retrieve file information through `debugfs`. However, the file names\n> cannot always be obtained, and it is often unclear which files they are.\n> To identify which files these are, one would need to use crash for online\n> debugging or use kprobe to gather information incrementally. However, some\n> customers in production environments do not agree to upload any tools, and\n> online debugging might impact the business. There are also scenarios where\n> files are opened in kernel mode, which do not generate file descriptors(fds),\n> making it impossible to identify which files were deleted but still have\n> references through lsof. This patchset adds a procfs interface to query\n> information about orphaned nodes, which can assist in the analysis and\n> localization of such issues.\n\nYe, did you read my comments to the v1 of the patchset [1]? I didn't see\nany reply from you. I don't think this is a good way how to expose orphan\ninformation for a filesystem for reasons I've outlined in that email.\n\n\t\t\t\t\t\t\t\tHonza\n\n[1] https://lore.kernel.org/all/n4sccudy5avcgnkdhc27rzofzoprxqtwhfrlmsh3yyrj6vbc6d@mmu73gmtawkq/\n\n> \n> Ye Bin (4):\n> ext4: register 'orphan_list' procfs\n> ext4: skip cursor node in ext4_orphan_del()\n> ext4: show inode orphan list detail information\n> ext4: show orphan file inode detail info\n> \n> fs/ext4/ext4.h | 1 +\n> fs/ext4/orphan.c | 326 ++++++++++++++++++++++++++++++++++++++++++++++-\n> fs/ext4/sysfs.c | 2 +\n> 3 files changed, 328 insertions(+), 1 deletion(-)\n> \n> -- \n> 2.34.1\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=Hh6b6LAQ;\n\tdkim=pass header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=Lf3VqkTG;\n\tdkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.a=rsa-sha256 header.s=susede2_rsa header.b=ijVV3bdH;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=8ROWJqxS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=pqif=co=vger.kernel.org=linux-ext4+bounces-15847-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=172.105.105.114 arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=suse.cz","gandalf.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=Hh6b6LAQ;\n\tdkim=pass header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=Lf3VqkTG;\n\tdkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.a=rsa-sha256 header.s=susede2_rsa header.b=ijVV3bdH;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=8ROWJqxS;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15847-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=\"Hh6b6LAQ\";\n\tdkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=\"Lf3VqkTG\";\n\tdkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=\"ijVV3bdH\";\n\tdkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=\"8ROWJqxS\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=195.135.223.131","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=suse.cz","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=suse.cz","smtp-out2.suse.de;\n\tnone"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwpp02pnhz1yHM\n\tfor ; Thu, 16 Apr 2026 04:00:08 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fwpnt45b4z4x0Q\n\tfor ; Thu, 16 Apr 2026 04:00:02 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4fwpnt40Trz4wbh; Thu, 16 Apr 2026 04:00:02 +1000 (AEST)","from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fwpnp4XR6z4x0Q\n\tfor ; Thu, 16 Apr 2026 03:59:58 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 676F13005641\n\tfor ; Wed, 15 Apr 2026 17:59:26 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 6B1ED33859C;\n\tWed, 15 Apr 2026 17:59:25 +0000 (UTC)","from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E13E53E3D8C\n\tfor ; Wed, 15 Apr 2026 17:59:23 +0000 (UTC)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby smtp-out2.suse.de (Postfix) with ESMTPS id EAD405BD45;\n\tWed, 15 Apr 2026 17:59:21 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DD0904BB30;\n\tWed, 15 Apr 2026 17:59:21 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n\tby imap1.dmz-prg2.suse.org with ESMTPSA\n\tid Vw+TNPnR32nhbQAAD6G6ig\n\t(envelope-from ); Wed, 15 Apr 2026 17:59:21 +0000","by quack3.suse.cz (Postfix, from userid 1000)\n\tid 990C9A0B59; Wed, 15 Apr 2026 19:59:17 +0200 (CEST)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1776276002; cv=pass;\n\tb=FHQMrX8qWOgOrXstnQunsJ5s6X0gIb+EZCG2voQ8Kd1zRdV8fdrjZLqr3o7eXImGSw8rdFB4/kEFxisSi7lfUBeJYqrzzk7r57/F52ly5MYWRFeN61f+jbxpf+5zs+qy5RuwlHqfAVOWtL2hi9nWDwQvJvu1sVhNNoI+6WwR8FT3ePcfO6RjAJxNlt16qW4ijutHeOLet4ETOgernjvt2jS1PnDTF7ye7KFCI1t0/eusmA+dpksw5bYAxAzOjwxw+MQ8boDn6Bz9p3H3jMXeHGGTCEhRORvO1QErcngcfDcnP3/D+zFnIkhv9LWztQy+oOwBFGZpXNdNTc8fqnEjKQ==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776275965; cv=none;\n b=UDEbmW5QiIuzkIzKFe6xm18fXSsMLRKStYpd4OdJNu7QuXyDcifOhMFT9jkJXh1nFcSzm/DPFFcCWiC2F2rGge/TYAWUccU5MNv4cIZVcjwhvAHQmrR/w3dZtQMQpKOjnHJ6TSuOsAHrQwND1/6/Mbsyv3Bl+SKbU+7D8ZjgPuU="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1776276002; c=relaxed/relaxed;\n\tbh=GRgWkXxWbhqTeZSQjO2XR41qFMF5O21UcprOlIQi2vI=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=XkoxJfgjocCupxG+QrUoKOj/yYmbdNUuWSI7DVIMBHsr6Zqlkhav37y6on1QX7YhkPpzrTZgx6aNglt3VwYyPM6VhdbJfghy0tQoJvcZ7qs2q4orR1PJh9kLUzxY7wc31gnC3lxF6H+yubHdFvwjfncXzPls3PFcon3Y+fHGMzLK4XwYZACzjhdcFLWS1g1ffWmEwKZM3KZF0xDWvrCpMXmGwq6jeWiWya7Mz5TIkOG96nHunZLSgYMzdB9dAb9WItgOhilpKeUJckMxlAJSvGS0TX7KfOwh9wDWJipLBXiOLtDeisHceDTm3aiZTs+zOuFAh6yo+a3C8MzdSoPKnQ==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776275965; c=relaxed/simple;\n\tbh=nPhPTTWiwlwWX8Ov2dqUK0WbDtDa02Mv3zaNymxItzo=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=a9wGxDn+7ARV6rP3iYMHWJTYsp7U+vXiS/SKMlD1230+e81vAeJiEzEulRntn6LZvvIKjGcW2VN3D5Vm9YGzO+BPAA7ma/GOafGjxH3Ir8N4XVaX+k/21+ZkUvx8QCrXR28LgbmnxCbR0HxU6gpLny/aAoiUUnEhCWa5e40ebEQ="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=suse.cz; dkim=pass (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=Hh6b6LAQ;\n dkim=pass header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=Lf3VqkTG;\n dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.a=rsa-sha256 header.s=susede2_rsa header.b=ijVV3bdH;\n dkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=8ROWJqxS; dkim-atps=neutral;\n spf=pass (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15847-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=suse.cz;\n spf=pass smtp.mailfrom=suse.cz;\n dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=Hh6b6LAQ;\n dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=Lf3VqkTG;\n dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=ijVV3bdH;\n dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=8ROWJqxS; arc=none smtp.client-ip=195.135.223.131"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n\tt=1776275962;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=GRgWkXxWbhqTeZSQjO2XR41qFMF5O21UcprOlIQi2vI=;\n\tb=Hh6b6LAQAJmODJayP2iDs9KGKaw3NwLk+Mck9J9gZa+PJvYsaoycsDDaTzTL1MP92sHp+C\n\t1JrrvXS1g0HUdaiApb2ObwW4vdxl+9dDM52h2fmNr3ao9Xp3ji97K9xfGBNezV/oIGp8j+\n\tu9DUOA4ceFcPmGFn5gGdI1zlXLlpZjw=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n\ts=susede2_ed25519; t=1776275962;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=GRgWkXxWbhqTeZSQjO2XR41qFMF5O21UcprOlIQi2vI=;\n\tb=Lf3VqkTG5XJJvDKREbuCYCP4McNDHrNLmyEJ8db+thkVO10eHdTnmYk+m75BJi7trHaxxD\n\t8XZ765BWB3Kr14Aw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n\tt=1776275961;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=GRgWkXxWbhqTeZSQjO2XR41qFMF5O21UcprOlIQi2vI=;\n\tb=ijVV3bdHQOIP1RUxi/wayEm95hy7JAVbW3/Shyt78N1r9KlvTpz4AWjlM8tBk2GF4WIUVv\n\t555bmKQN7xEYqoYWegpYnDFbzhnka6LGPaQNXc+Xj2yfEEi5NTHmGz5kWB9xKJiXw4hlKO\n\tQxS5/Om0Rg3m3KH9VM5cvpf7DT19Nzc=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n\ts=susede2_ed25519; t=1776275961;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=GRgWkXxWbhqTeZSQjO2XR41qFMF5O21UcprOlIQi2vI=;\n\tb=8ROWJqxS7HN7Fju1EL1fwvFm8Oy6AuhMzM/C2mZhjXbuHh1HPKc+BRek/Kre4VhqaNTNAP\n\thCogJWI3pn6sbABA=="],"Date":"Wed, 15 Apr 2026 19:59:17 +0200","From":"Jan Kara ","To":"Ye Bin ","Cc":"tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,\n\tjack@suse.cz","Subject":"Re: [PATCH v2 0/4] show orphan file inode detail info","Message-ID":"","References":"<20260415105505.342358-1-yebin@huaweicloud.com>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260415105505.342358-1-yebin@huaweicloud.com>","X-Spam-Score":"-3.80","X-Spam-Level":"","X-Spamd-Result":"default: False [-3.80 / 50.00];\n\tBAYES_HAM(-3.00)[100.00%];\n\tNEURAL_HAM_LONG(-1.00)[-1.000];\n\tMID_RHS_NOT_FQDN(0.50)[];\n\tNEURAL_HAM_SHORT(-0.20)[-1.000];\n\tMIME_GOOD(-0.10)[text/plain];\n\tRCVD_COUNT_THREE(0.00)[3];\n\tFUZZY_RATELIMITED(0.00)[rspamd.com];\n\tFROM_HAS_DN(0.00)[];\n\tARC_NA(0.00)[];\n\tTO_DN_SOME(0.00)[];\n\tMIME_TRACE(0.00)[0:+];\n\tDKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n\tRCVD_TLS_LAST(0.00)[];\n\tTO_MATCH_ENVRCPT_ALL(0.00)[];\n\tFROM_EQ_ENVFROM(0.00)[];\n\tRCPT_COUNT_FIVE(0.00)[5];\n\tRCVD_VIA_SMTP_AUTH(0.00)[];\n\tMISSING_XM_UA(0.00)[];\n\tDBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.com:email,huawei.com:email]","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_MISSING,\n\tHEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}}]