[{"id":3676523,"web_url":"http://patchwork.ozlabs.org/comment/3676523/","msgid":"<CAHp75Ve59GPAFvKM6yOkPmr=kmHBjVL-Vz78X0WDikiWd+2arQ@mail.gmail.com>","list_archive_url":null,"date":"2026-04-13T07:52:17","subject":"Re: [PATCH v7 0/2] i2c: Add Loongson-2K0300 I2C controller support","submitter":{"id":4675,"url":"http://patchwork.ozlabs.org/api/people/4675/","name":"Andy Shevchenko","email":"andy.shevchenko@gmail.com"},"content":"On Sat, Apr 11, 2026 at 12:58 PM Binbin Zhou <zhoubinbin@loongson.cn> wrote:\n\n> This patch set describes the I2C controller integrated the\n> Loongson-2K0300 chip.\n>\n> It has a significantly different design from the previous I2C\n> controller(i2c-ls2x), such as support for master-slave transfer mode,\n> and  DMA transfers (implementation in progress), etc. Therefore, we try\n> to name it i2c-ls2x-v2.\n\n...\n\n>  - parent_rate_MHz -> parent_rate_mhz to avoid CamelCase.\n\nWas it a special requirement from maintainers?\n\nNote, the physical units are special. The m and M have quite a\ndifferent multiplier value. So, even if asked by somebody I think it's\nstill arguably should be kept as MHz.","headers":{"Return-Path":"\n <linux-i2c+bounces-17042-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=EB/+J5fu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-i2c+bounces-17042-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"EB/+J5fu\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.218.49","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvKQQ51Knz1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 17:53:02 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id BE020300E62F\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 07:52:58 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8A88A39DBEB;\n\tMon, 13 Apr 2026 07:52:57 +0000 (UTC)","from mail-ej1-f49.google.com (mail-ej1-f49.google.com\n [209.85.218.49])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D822D21FF21\n\tfor <linux-i2c@vger.kernel.org>; Mon, 13 Apr 2026 07:52:55 +0000 (UTC)","by mail-ej1-f49.google.com with SMTP id\n a640c23a62f3a-b9825ba7f9dso586822566b.0\n        for <linux-i2c@vger.kernel.org>; Mon, 13 Apr 2026 00:52:55 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776066777; cv=pass;\n b=QbynxHBqVArpghlWYM4wlBkL2xaymgxmAoHBVMqXH+6heAVUMfAniI5RS750HcoPfIXAdP1ecNr8/j2Rrmm/bScWuxb44aOWWHRSbXX9rgEFqPSZEFdLHufLEt+yogAKhjoxA89d+WYVI8fAYSWqIVsX8GuzvFXYhF/rWMJF/Yk=","i=1; a=rsa-sha256; t=1776066774; cv=none;\n        d=google.com; s=arc-20240605;\n        b=fZFFQy8RwdfXNWs40mVVZNTszx1+GjrrMpFHYAdnwQH5lCbE6jz4Oql+oP13NXIeNr\n         DKu5G+iCGG516fYoEwOfdeDXv96fh5L4ytIwp7t3lcrthMJCE8baTWqFjd49niHL6NvE\n         VXrAndJsRSo2Eqljxn0mMVGouoCLLQN04iAOuUcvc+mfGfjwPpY4kI2sRZ3c8FWUfNQU\n         nSt3DN3OM2EUZLMQeyK09hGAMyTNqTehgHMsXQ3FQC1cSsrvZfnmXL/9Q6CIdCLBUycA\n         wyLMBNZgExcSe7NeMLle32xcm1G/aHt91Mx9fcXIjnscftVGoXLmmkJlcNCmA8lYrLE1\n         x1Ug=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776066777; c=relaxed/simple;\n\tbh=8i76hr8Gj+RtGUBroSxVsQfLVKIuEs9W7G61OYrNzFg=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=FxPQtIjUK/+2v7P0WTbGmnWtxocjo8oPPBtbVWl460zoR4Taoa5UHxCIGUWdUpXWbpg6ngur31bZAnjZxptdI4fIpfQ3Kzmk74bwCvBVmkvL3x0RgWFTVb5SFRQrGd1koqN7Dymg/B4DrmsAVSAAByCGhss3UxD/eVpvW/S6F74=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n        h=content-transfer-encoding:cc:to:subject:message-id:date:from\n         :in-reply-to:references:mime-version:dkim-signature;\n        bh=sTeLoPuL69qtHikGrHVR6h29M/vzfp4S7SUKcSWz2wU=;\n        fh=76qyl2j2E+uc+rXDrKPGCLnHR0tZdRSupKiU8i+6GEk=;\n        b=RJ6kCJcH4jrBUXMzxCSWUPOBSrqEyg7ayt34pIyBCBva1kppf4MNJwgIYTWirgHWgN\n         EB9DkrmnLwFeCpMUuE4Tgkyxu2PQ94m8k/phvXUH7lLxIMAAO8ponhFiNg18s15E0JAz\n         Ft+64NPnFZ/x5X6VBF7K3I9jRmBRXtg+umJz3Tg4tiekLwlTuh/MY5hAuA0xU1gtZlmC\n         NafnWFH8Z2wenRkN0KxuE7xwvzLoOK3cobKsiV8LTEiPHUZlEJZeW/BeNSGqkDyszKRc\n         Qj8xXhWJUV4UWHDublbiYl2Gkrs04u/dhHlGaDwpLDnY5cMDAg0/Ozerv7jZxY/DD2/X\n         Y20g==;\n        darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=EB/+J5fu; arc=pass smtp.client-ip=209.85.218.49","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=gmail.com; s=20251104; t=1776066774; x=1776671574;\n darn=vger.kernel.org;\n        h=content-transfer-encoding:cc:to:subject:message-id:date:from\n         :in-reply-to:references:mime-version:from:to:cc:subject:date\n         :message-id:reply-to;\n        bh=sTeLoPuL69qtHikGrHVR6h29M/vzfp4S7SUKcSWz2wU=;\n        b=EB/+J5fujPLcNsgzTuRVpKGVkkNM38PYAGDlDvm3P/R02BQ4yxtw7cNpjBT4LzK+7Z\n         7tMTAh6PEx+Pi1i/XJM9fFoxKm+MwBG/QnZ+gnT3F0uEciUzMDzW1cWpwj2Kx7v3nCoM\n         f5NG2o0D8UtUV406I7K/80ol3+N2JRKHCrHjDG+ZKxeOH84V1iXoYrcAJNhumTqJTQ4F\n         QSTVQQgqrXwq4qWKRAQY2qJgcrAogxLTL+Ox+o+gmiOb/BmJ7rq1S+I2EV8RSz1vPgax\n         v/O7Zi74khPejszE1K5d5mLgrqFiZ3PvQGrWT/PKG7Rc2YhVrHT0iCTQkuCtK3Rxql+I\n         k3Ww==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1776066774; x=1776671574;\n        h=content-transfer-encoding:cc:to:subject:message-id:date:from\n         :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n         :to:cc:subject:date:message-id:reply-to;\n        bh=sTeLoPuL69qtHikGrHVR6h29M/vzfp4S7SUKcSWz2wU=;\n        b=HvPfhAufvazi4sy6FX1TfWKZMsZHIizy+kMpP/7pDPxATE+MjBWCQlK0hfafQPf4CL\n         xnbY1jKi4lKVgKy0M30Nc3jBy3i/TOKGiMO7DR0fkhV2EabQRORqwpOo6Mj2bWHEzwrB\n         Y+rnfR5BeYmFQIju4adpG6Ghfqc1yz67kzgAbM8yWdkQ7IenI6OuIAYNcoISCgfCBcXi\n         3sII9HZSX5PeRXMfZC424wxs924APqFAjTEqnIl3ifozYzA43WeNKr1Esnhj88JcczDi\n         WAWQe4wYatPVhEoUOi865aplAt8piBpk+G3ON2wZCPXDLi7ZIxuN3axiH6VY+a78V03j\n         HrdQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+3/Phvir4V3la1pa6xk4AUw4Zk6O/Wx0ILmRwYUvhU/MJ++jHD3uDYaMv4Kg/VRkzwF8AQuKbm9dU=@vger.kernel.org","X-Gm-Message-State":"AOJu0YzNys4iY+gH8cn4ChXJaqLRYJmFJTyVCxkHz+RQtC5NCEKQi/Qr\n\tB+kCeJI9Nx8iPB46+1Yzkb4NLJFMnccqR19SaniwzB5jqNmgPy42dnqsEHOASUVQfaDK0b1DbRW\n\tw0MLNAXbpz40DJikDGY8HblqyR+1vWWs=","X-Gm-Gg":"AeBDies5q1LMgI8HxQH4lVCnPVZ4IDIwNmvFdLk/OZYjs1/lWgfkNq7pQfAWipniskd\n\tXHeyg7Yo9aDjBpbRdX0YA0vWBnO5IlGyK04UfsLEOQfu2iDyuRDEB3OiyWtC43wIQn4Mil4ZX5k\n\t9VhFKbkyPqFduT2BNQKFZTrzqtPO/MloqlaUQ7OrGp4blJC5Zv8Uv/UN41oBiJ3lu1qJqpKqnz+\n\t6UktdiVMYR2SvmitxUheIU0RwsPs1mk538aZkSMPs2lYMPft05dFy0Eviw0jfRcKUwrh8kH3vDM\n\txejFnsDtZRGJibrkcAvlgwpyjM35TADvDg61NqYeVTkE7it69k8ydmIeGu82NMp1FjPdOgIEBC4\n\tSLnPqtLs=","X-Received":"by 2002:a17:907:3da8:b0:b9b:3b90:1047 with SMTP id\n a640c23a62f3a-b9d46381020mr686807966b.30.1776066773845; Mon, 13 Apr 2026\n 00:52:53 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"<linux-i2c.vger.kernel.org>","List-Subscribe":"<mailto:linux-i2c+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-i2c+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","References":"<cover.1775900045.git.zhoubinbin@loongson.cn>","In-Reply-To":"<cover.1775900045.git.zhoubinbin@loongson.cn>","From":"Andy Shevchenko <andy.shevchenko@gmail.com>","Date":"Mon, 13 Apr 2026 10:52:17 +0300","X-Gm-Features":"AQROBzDd7oISg4nKnjr8XlrN-YmlCPDBGxSBhjMNA29ixq3SfKpY3ltSGMuX2Jc","Message-ID":"\n <CAHp75Ve59GPAFvKM6yOkPmr=kmHBjVL-Vz78X0WDikiWd+2arQ@mail.gmail.com>","Subject":"Re: [PATCH v7 0/2] i2c: Add Loongson-2K0300 I2C controller support","To":"Binbin Zhou <zhoubinbin@loongson.cn>","Cc":"Binbin Zhou <zhoubb.aaron@gmail.com>,\n Huacai Chen <chenhuacai@loongson.cn>,\n\tRob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,\n Conor Dooley <conor+dt@kernel.org>,\n\tAndi Shyti <andi.shyti@kernel.org>,\n Wolfram Sang <wsa+renesas@sang-engineering.com>,\n\tAndy Shevchenko <andy@kernel.org>, linux-i2c@vger.kernel.org,\n\tHuacai Chen <chenhuacai@kernel.org>, Xuerui Wang <kernel@xen0n.name>,\n loongarch@lists.linux.dev,\n\tdevicetree@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}},{"id":3676535,"web_url":"http://patchwork.ozlabs.org/comment/3676535/","msgid":"<CAMpQs4+QmyAObvCcJOFnfTuufG8=M0q5m+XMkaP6-SOp-8wq9w@mail.gmail.com>","list_archive_url":null,"date":"2026-04-13T08:08:14","subject":"Re: [PATCH v7 0/2] i2c: Add Loongson-2K0300 I2C controller support","submitter":{"id":85415,"url":"http://patchwork.ozlabs.org/api/people/85415/","name":"Binbin Zhou","email":"zhoubb.aaron@gmail.com"},"content":"Hi Andy:\n\nOn Mon, Apr 13, 2026 at 3:52 PM Andy Shevchenko\n<andy.shevchenko@gmail.com> wrote:\n>\n> On Sat, Apr 11, 2026 at 12:58 PM Binbin Zhou <zhoubinbin@loongson.cn> wrote:\n>\n> > This patch set describes the I2C controller integrated the\n> > Loongson-2K0300 chip.\n> >\n> > It has a significantly different design from the previous I2C\n> > controller(i2c-ls2x), such as support for master-slave transfer mode,\n> > and  DMA transfers (implementation in progress), etc. Therefore, we try\n> > to name it i2c-ls2x-v2.\n>\n> ...\n>\n> >  - parent_rate_MHz -> parent_rate_mhz to avoid CamelCase.\n>\n> Was it a special requirement from maintainers?\n\nI’m actually a bit confused, because when I submitted the v6 patchset,\ncheckpatch didn’t issue this warning.\nBut now, it produces the following output:\n\nscripts/checkpatch.pl --strict i2c-ls2k0300-v6/v6-0002*\nCHECK: Avoid CamelCase: <parent_rate_MHz>\n#512: FILE: drivers/i2c/busses/i2c-ls2x-v2.c:437:\n+       priv->parent_rate_MHz = clk_get_rate(priv->clk);\n\ntotal: 0 errors, 0 warnings, 1 checks, 574 lines checked\n\nNOTE: For some of the reported defects, checkpatch may be able to\n      mechanically convert to the typical style using --fix or --fix-inplace\n\n>\n> Note, the physical units are special. The m and M have quite a\n> different multiplier value. So, even if asked by somebody I think it's\n> still arguably should be kept as MHz.\n>\n> --\n> With Best Regards,\n> Andy Shevchenko","headers":{"Return-Path":"\n <linux-i2c+bounces-17043-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=X0Njt2Xl;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-i2c+bounces-17043-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"X0Njt2Xl\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.208.54","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvKp35x9Cz1yDG\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 18:10:03 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id C84B4301E7DC\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 08:08:35 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 3177C396D1C;\n\tMon, 13 Apr 2026 08:08:32 +0000 (UTC)","from mail-ed1-f54.google.com (mail-ed1-f54.google.com\n [209.85.208.54])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 8737B399352\n\tfor <linux-i2c@vger.kernel.org>; Mon, 13 Apr 2026 08:08:30 +0000 (UTC)","by mail-ed1-f54.google.com with SMTP id\n 4fb4d7f45d1cf-66ba9dfe83bso5319782a12.3\n        for <linux-i2c@vger.kernel.org>; Mon, 13 Apr 2026 01:08:30 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776067711; cv=pass;\n b=iu8FVqNXrRgsFU094YUi/o1NHRnuyjAg0MT/l3Q2Pcx+hPpWepqrrc5TTMTz8LeqGXv6HWWXSmSJ9poC01880rxazHHnWswdfQVXtgmqR0/vXTvM7zK/Vkck9w9vCQ/+tSBpp8G12f9Mk0K7lhH8s34Xw3d1UaEX3L2JUkDA7iQ=","i=1; a=rsa-sha256; t=1776067709; cv=none;\n        d=google.com; s=arc-20240605;\n        b=ZABesPUMznx09pTM4QFDanI/fDPu7ZL9zxt30f+Y9XAOFB/cNXN63pybErMY1Woeu0\n         sKAdJ5uQ7pvyaXAHp3yT3uun39mbVvU88WWn4V6BRgUeFhsAFlABBGNtNYfSoaWHWmej\n         KZXCPPDRXdym1KiJgQBW+jM89UDLDGZ+irjUeKqiKzl2LUEV5zELdtgn03KSgRQZBZj4\n         UxK89xvIESmLT5ivpqrsgjux9FJ+xxKvnwdeNY9gYJSXWbeWO5U/QPw45Z7HUpVo6CbW\n         v1hkZIQEQkj8DG02zQ6lcFN3Pk6l48NBvVyOXsHpi1TTaMAiAx63Pyb/HG2TAr1TTymt\n         KLpw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776067711; c=relaxed/simple;\n\tbh=8VnhIoj02WULflqqgWqAu3E/FZcCIYMP+zvbnxKj2aI=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=nILNYAfN+uVwnCkN+it7dCLIXUG5yZVeyGnoJwqecX26HYsYJuhHitoS8I8vU3V3GylUcPKnl3SGp+zpjeMAgs+MKwBhnmsWpsXI3xM9ZGXM2x9ygvyPHpQ4ge0cgvmPz+myYb9O2YJpPWCFhTg1KaNLqwm1ltX+rJ57+bYFVAc=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n        h=content-transfer-encoding:cc:to:subject:message-id:date:from\n         :in-reply-to:references:mime-version:dkim-signature;\n        bh=fvkP8KzDKek7CehUY4JTh8N+6Hv3yrPu4Ys2u/4PdPc=;\n        fh=AahGs7hSrgv54VgBf+Ko4JFwbFR1+bBjWq+YYrgwmEk=;\n        b=Fkm2mE62U9Y7eV2mBf6WJHvK2RiXQfXU5xxgw6ITvrkjvSEsKrw5drMWiCQEUAjcQL\n         wftZ0GiOT3e4jjY60lE5+KST+DEMcz9H+wSqMjTr3rTsxCQho0XhbRWfI+BeAkJEdeqf\n         6fNJ1KgcjGPQk+XNzoT7sHtRlZPMvN9lPGDjfVwkT2+exFbasG85ZzUC6zl1WUcxkD81\n         y+shnXWfxhZvNbhM7ICL3g/CUO5KU6dHrk1OuCie5MOhxwhcHnLuzU1zr/XWM1xXurru\n         rqd4zrigelbTXwpKCW6ar9eOBtOIkic4ZlVGwjgxEq1aCYIBfEECvYwaGaPHtscdCLac\n         SW9w==;\n        darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=X0Njt2Xl; arc=pass smtp.client-ip=209.85.208.54","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=gmail.com; s=20251104; t=1776067709; x=1776672509;\n darn=vger.kernel.org;\n        h=content-transfer-encoding:cc:to:subject:message-id:date:from\n         :in-reply-to:references:mime-version:from:to:cc:subject:date\n         :message-id:reply-to;\n        bh=fvkP8KzDKek7CehUY4JTh8N+6Hv3yrPu4Ys2u/4PdPc=;\n        b=X0Njt2XlAwuLFmJovw7MJjUw1XZtfOsK6iGvcWNxJ7lT7iwhY9YlL+OdNYQ6uUxEF4\n         NWkL2dpFX4fFTLn90cxlDiwxXTT677VI/13OmK/DMpvwx91o2HTIi775SeIVYnSFRHru\n         w0BRXh74UNOeBU4RygvrQlmeimqCmshHxZFCiCdlBZRlkicggs6nozqyJMCUYAacsbdi\n         Ad1WW8hxidXXmSsf23u5h+pHYr52HoQfqZ3cAcUfwZQaXyKYCYaHack6H5oPFRDX7/AE\n         WRgZqJ9AnStLROG90icXKBjUeM7ova6tjpdD3twImtcO3whKu2oXBCkVW+rZ/SeoyHAw\n         sqSQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1776067709; x=1776672509;\n        h=content-transfer-encoding:cc:to:subject:message-id:date:from\n         :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n         :to:cc:subject:date:message-id:reply-to;\n        bh=fvkP8KzDKek7CehUY4JTh8N+6Hv3yrPu4Ys2u/4PdPc=;\n        b=CK7X//WBFU7GYCW/+M8Ymsh4J5Rt0b8QrCZdRkZKbjIZD7atP48ERVwkJZE5XC7IO5\n         iVKMOmJidZS57GpCQuXHcWAkUmBpu+0xsqUla/vu3kC/P1u5SB6MqkbnBZMDmgcYidNI\n         g/PZYsyYCav+pwdhCUnpQYXftQ802tZtULCg7FVMw2dPIfG0JrdwVXEL1c4R4hcIhmfd\n         XlXq+kpqtWtq78XKOXYtqUcsDVyvjZlN3O8pp+u7RYPyvN+sgxUVy5vWnopm9aMejROZ\n         jHc0CrRrS/TXLLP+f556e74OfM01GcSN4HqSGeQHnoIeqFowN4xNiyTqZgazNeyC378/\n         YBfw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUyCRftgP4zUBxivAdFcMUJMD3nfNQl8oCOjhX8QBwXoCfDqhkNSh3/7OcI7YEXGAfwn4ujxkfJ0nM=@vger.kernel.org","X-Gm-Message-State":"AOJu0YzqUSXOoaqKVxxjMs1rnJ6GkgBu+3HUSwMbYl98+8lEtvWx4JyF\n\tsIWt2pxFmf3p/VTGjr6qefhuvdefC2j82IzPhebpG7c+Hb5CfEQ8WX81uAIUrs719O6DgA1e2tH\n\tevqDqgyQxrwIT6No1GHMQaIl2lXB97xo=","X-Gm-Gg":"AeBDievIqurZiWtgqF3Ja18wauF0YKTn0pptTFBg9ZGx0SCFp3UDaLwEI5gNCMw+5ff\n\tJ+yd5ju+eJVforNFJS97BYer8VET69Wyj/DdgS70s6IfieUa6V+7IIRnlUzuQARJNnkJ+vUZNWH\n\tjZnSAR/Hn2Q6k6I1XXyy6fTre3q9p/NiovrA+rg0Ao4GBsfoe3unrRlyLY0W/Ns5ZybUWbnuLX5\n\t1Ff/V1fxpYqv8dVYAs2Hwn2YpDG+8cLNGfyvgURJLJWg1ey93Nyes44qxi4fwlne3bE74Lvi4ox\n\taP4pgfyT6EaBfGRDFYY=","X-Received":"by 2002:a17:907:7281:b0:b9c:eede:adba with SMTP id\n a640c23a62f3a-b9d7248aa85mr708424466b.13.1776067708140; Mon, 13 Apr 2026\n 01:08:28 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"<linux-i2c.vger.kernel.org>","List-Subscribe":"<mailto:linux-i2c+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-i2c+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","References":"<cover.1775900045.git.zhoubinbin@loongson.cn>\n <CAHp75Ve59GPAFvKM6yOkPmr=kmHBjVL-Vz78X0WDikiWd+2arQ@mail.gmail.com>","In-Reply-To":"\n <CAHp75Ve59GPAFvKM6yOkPmr=kmHBjVL-Vz78X0WDikiWd+2arQ@mail.gmail.com>","From":"Binbin Zhou <zhoubb.aaron@gmail.com>","Date":"Mon, 13 Apr 2026 16:08:14 +0800","X-Gm-Features":"AQROBzBp1_1f83xVVf78iSav36n4yOfOrZ9Vhqu0U5oqBm33LFFYkL6t-qaEFjA","Message-ID":"\n <CAMpQs4+QmyAObvCcJOFnfTuufG8=M0q5m+XMkaP6-SOp-8wq9w@mail.gmail.com>","Subject":"Re: [PATCH v7 0/2] i2c: Add Loongson-2K0300 I2C controller support","To":"Andy Shevchenko <andy.shevchenko@gmail.com>","Cc":"Binbin Zhou <zhoubinbin@loongson.cn>,\n Huacai Chen <chenhuacai@loongson.cn>,\n\tRob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,\n Conor Dooley <conor+dt@kernel.org>,\n\tAndi Shyti <andi.shyti@kernel.org>,\n Wolfram Sang <wsa+renesas@sang-engineering.com>,\n\tAndy Shevchenko <andy@kernel.org>, linux-i2c@vger.kernel.org,\n\tHuacai Chen <chenhuacai@kernel.org>, Xuerui Wang <kernel@xen0n.name>,\n loongarch@lists.linux.dev,\n\tdevicetree@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}},{"id":3676552,"web_url":"http://patchwork.ozlabs.org/comment/3676552/","msgid":"<CAHp75Veymi3z2atMuSeDyrhyx-HLHgCMzJF5EgpJZzTGgpcD3Q@mail.gmail.com>","list_archive_url":null,"date":"2026-04-13T08:17:22","subject":"Re: [PATCH v7 0/2] i2c: Add Loongson-2K0300 I2C controller support","submitter":{"id":4675,"url":"http://patchwork.ozlabs.org/api/people/4675/","name":"Andy Shevchenko","email":"andy.shevchenko@gmail.com"},"content":"On Mon, Apr 13, 2026 at 11:08 AM Binbin Zhou <zhoubb.aaron@gmail.com> wrote:\n> On Mon, Apr 13, 2026 at 3:52 PM Andy Shevchenko\n> <andy.shevchenko@gmail.com> wrote:\n> > On Sat, Apr 11, 2026 at 12:58 PM Binbin Zhou <zhoubinbin@loongson.cn> wrote:\n\n...\n\n> > >  - parent_rate_MHz -> parent_rate_mhz to avoid CamelCase.\n> >\n> > Was it a special requirement from maintainers?\n>\n> I’m actually a bit confused, because when I submitted the v6 patchset,\n> checkpatch didn’t issue this warning.\n> But now, it produces the following output:\n>\n> scripts/checkpatch.pl --strict i2c-ls2k0300-v6/v6-0002*\n> CHECK: Avoid CamelCase: <parent_rate_MHz>\n\nIt's a false positive of the checkpatch.\n\n> #512: FILE: drivers/i2c/busses/i2c-ls2x-v2.c:437:\n> +       priv->parent_rate_MHz = clk_get_rate(priv->clk);\n>\n> total: 0 errors, 0 warnings, 1 checks, 574 lines checked\n>\n> NOTE: For some of the reported defects, checkpatch may be able to\n>       mechanically convert to the typical style using --fix or --fix-inplace\n>\n> > Note, the physical units are special. The m and M have quite a\n> > different multiplier value. So, even if asked by somebody I think it's\n> > still arguably should be kept as MHz.\n\nSee above why.","headers":{"Return-Path":"\n <linux-i2c+bounces-17044-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=SrqBdkSz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-i2c+bounces-17044-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"SrqBdkSz\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.218.48","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvL4s2nfpz1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 18:22:53 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id EF59F303FFD1\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 08:18:06 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 01D1E3A75A1;\n\tMon, 13 Apr 2026 08:18:05 +0000 (UTC)","from mail-ej1-f48.google.com (mail-ej1-f48.google.com\n [209.85.218.48])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A1A853A6EF7\n\tfor <linux-i2c@vger.kernel.org>; Mon, 13 Apr 2026 08:18:01 +0000 (UTC)","by mail-ej1-f48.google.com with SMTP id\n a640c23a62f3a-b886fc047d5so652926766b.3\n        for <linux-i2c@vger.kernel.org>; Mon, 13 Apr 2026 01:18:01 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776068284; cv=pass;\n b=X4P8ZRvKItJ3Gwpb303SLQZiT5YAoaxgyyUKMU6vS/ldfOM6MvMNEwNti5F30ODQHb+yyTky9w4E+g+RGdeiVVglG6FgxeghUSEqn2//RVbng+r3x24bPSE93ie9a/4WvfC43Qdz2db+gO0nizoPE0rWXGoTGkWpcFIDTnPZ51o=","i=1; a=rsa-sha256; t=1776068280; cv=none;\n        d=google.com; s=arc-20240605;\n        b=Cgh5NxJIFQodSpMHZHfO//Rn7oeasKI+0/3KHOBrwhdW46qtdLGjySQsg3ec9nEHTL\n         9UN1JHsG30kvZNS2y9It1jpM5JpP0wCgOU2jTOh75HDEmvVRG3f02jMBOcTWG7LdUqzE\n         uaS2VxhqqG/HRsE4WtlqdNq8+gfXCN8fvtmBxVAgEYX326WimDQ3HPeG7C6zFwmIaMQL\n         vOkYLP4kAQzUEW8G6pK75UoESkxsBGkE3BDnQjs2PxU7o+v9NPCBwAVlg8WLlxCIsvo0\n         CT5kGrxOPzOhQIfZKI0/1RW29UOzmjK+A+kVxloY23s/OQNWnvMYzWhyyfos//yfRZN+\n         VHUg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776068284; c=relaxed/simple;\n\tbh=Kr7oDKdU55g5UujuqnKWNs4YuX6K9H43zs6YbbtsyO0=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=t44MzWyBDFXBDA+G1NQMqRm2ZysRVG9SFFiiwk3wwC9Ez9QB0l5AoQR7CeZfJsKz6v889vbZuBjgJ3B/FLDpjzRKXhb0ggzMqnQMgUnBcdC8t1pbcBeusCG63AH5eoyuUQC8/7FHqSgzSINFXTjYYQJBfRanMxN26nHQmBwh2PE=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n        h=content-transfer-encoding:cc:to:subject:message-id:date:from\n         :in-reply-to:references:mime-version:dkim-signature;\n        bh=HKKtC3Qnmy/nhNGVLZ07dvj7VhPVzyQUkTlW6PGzNKw=;\n        fh=wvlCDG/XhU7gMesxWfPhDnEcUa5s+ZXWuYY3BMw61/k=;\n        b=F8e1UJqSs5HQ+ajLg77e3sSDGVJTJqcWj9bYgfl94z5+Al2Xzt1Nebj+di8Di3sq3x\n         auuPidJiIUIy7PLh0gMQogtI2R1A+0uwKFLRpPONTWNie3qXnMR5xORqpP02WmSr+MOZ\n         Onke1MC4jsDb4XmjfWptJeJXI471DVqJahDr9ef9/fZ7H+febCQn887n+mE2IIVfZFxF\n         CzdHNC6zeCOCtU2wuUWFNBGYJ8VOvw6SZDD+g4MSTybpRxME65M+zNbyJcPgD/ZMEMtL\n         zmN5q78vOaexywoYqskpJ3OprfGNO1cyEdOXPKbiS752O2WfueX//7wdkmL7azN9I1er\n         goPQ==;\n        darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=SrqBdkSz; arc=pass smtp.client-ip=209.85.218.48","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=gmail.com; s=20251104; t=1776068280; x=1776673080;\n darn=vger.kernel.org;\n        h=content-transfer-encoding:cc:to:subject:message-id:date:from\n         :in-reply-to:references:mime-version:from:to:cc:subject:date\n         :message-id:reply-to;\n        bh=HKKtC3Qnmy/nhNGVLZ07dvj7VhPVzyQUkTlW6PGzNKw=;\n        b=SrqBdkSz3IimTGrj3sYDJ2vp38C2TcOYM5k5gzFIAoGUp8yIcub0LceMVX+/z/nvo3\n         ePark7QRopoaUOTkISEY9Bu56d70UuCvNr7PFmGqe8PYo3HZWC0FmpDggLPkbhhoc0PS\n         hpbul78v6GT8P4YYRRGBrSGnSyUSBmGoICSHH/eOMnysZl19iXPG2bk/Eahnq7VTVVHO\n         7bbuhemlvbG22AVCy8S40k2yo36Y4ZNaSpwnnS+mXpGbtmLiJQFK1jSxj4FqyPiUvx6j\n         7IxrWSSqUeXOSsLSECdvlDnT18rTAVWjJCXhimicZjrN4EHlV8cergaMjv7RdBoW/gch\n         5tEQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1776068280; x=1776673080;\n        h=content-transfer-encoding:cc:to:subject:message-id:date:from\n         :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n         :to:cc:subject:date:message-id:reply-to;\n        bh=HKKtC3Qnmy/nhNGVLZ07dvj7VhPVzyQUkTlW6PGzNKw=;\n        b=iEc6vPaUyXng+waC5+XS+0FcixFIayLbXUsNiMS4fuRBEnH/q4huBSEOhn4e0Q+Cy2\n         slzBHdCWVfr4iRLaHuSK2+ltESEQ6ugnKE6gV2r82DR5lMCvVT32Dfx34d6jEZ+H/A7r\n         cnUN5LyxdUYgT6UvdRzh9sF1Ih7Kc44wpDwNBdjWsnfhgQcCUFPCEB3pXOT5/Ear65qP\n         LrAtpyrFF9NTnyPeL5MH8DTdSaVg1ar87IgGZbNRhZ2EOK8PjP5tBvL/xPrUpf1sfW+O\n         Zc7IZp0bh7KA4csQUICec6cnVkNx4Au5HA60N71Ycwr4VYvdcekRQTUY9aTdbEdh0R/d\n         UcdQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXtb/qh2OrYZmUqLOKpUgQvxaSG43bu/EaoN/S/RXGcKQUMRRa48r+Wt+OML7q6idSz31dbNZ/1CBg=@vger.kernel.org","X-Gm-Message-State":"AOJu0Yxakn6Ws6E1PLWl98Vcyweg7sjOJlQmKBSGMDWohs+zX1ELvaYd\n\t6CKP7YrL0IaJ4vHZ71XVbEwVcp3XKMgIuJRyNPNiJFKTGgfMw5ghKz1eqqiDrx4e8adPGBXc0jm\n\tNl9M+0XqHDOdAwVnFI1s1xYDao67g0wo=","X-Gm-Gg":"AeBDiev0p2PSXXxgCmLAGPItuPEtKO0A7XNsHZF4VwOzirm7HcU8orKtjKWxSB5v9SK\n\tLXkYCuBnyrxS7v8FqwR3Ey6HFX2YL1KMV2hMVxJ3SI9IRX9quiPvNlzWJ2OhLZgyKrozbyo7cpR\n\tBPX6aW7+elMqF2M+tE+O1geNh4JcPRFrdESi/WAwUrxPislCtRNPjfDISuewTEmEvJ8+KuhS3i2\n\tDyvJp8OyfvGPRGM+A5qZUK62gDrFyNRjWwzn2YW5zYMbrzD93bGEAvHhJa77U0iLFhoiXFLQ7US\n\tdMEmYgsh53T/8GBzPuMOjEsxkApVvcMUT3/862LJva2lWZuE+eI/oNZDrp1dK4+ZVmRBjF4YeT/\n\ttqKBeeYI=","X-Received":"by 2002:a17:906:ef0c:b0:b97:34e7:ea87 with SMTP id\n a640c23a62f3a-b9d7248ab15mr627211066b.19.1776068279504; Mon, 13 Apr 2026\n 01:17:59 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"<linux-i2c.vger.kernel.org>","List-Subscribe":"<mailto:linux-i2c+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-i2c+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","References":"<cover.1775900045.git.zhoubinbin@loongson.cn>\n <CAHp75Ve59GPAFvKM6yOkPmr=kmHBjVL-Vz78X0WDikiWd+2arQ@mail.gmail.com>\n <CAMpQs4+QmyAObvCcJOFnfTuufG8=M0q5m+XMkaP6-SOp-8wq9w@mail.gmail.com>","In-Reply-To":"\n <CAMpQs4+QmyAObvCcJOFnfTuufG8=M0q5m+XMkaP6-SOp-8wq9w@mail.gmail.com>","From":"Andy Shevchenko <andy.shevchenko@gmail.com>","Date":"Mon, 13 Apr 2026 11:17:22 +0300","X-Gm-Features":"AQROBzBJwSsZg2tUBgFtmmJxajkFQLHqP5eXC7UwkUnFX9NthWB1sHncPf4yD5E","Message-ID":"\n <CAHp75Veymi3z2atMuSeDyrhyx-HLHgCMzJF5EgpJZzTGgpcD3Q@mail.gmail.com>","Subject":"Re: [PATCH v7 0/2] i2c: Add Loongson-2K0300 I2C controller support","To":"Binbin Zhou <zhoubb.aaron@gmail.com>","Cc":"Binbin Zhou <zhoubinbin@loongson.cn>,\n Huacai Chen <chenhuacai@loongson.cn>,\n\tRob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,\n Conor Dooley <conor+dt@kernel.org>,\n\tAndi Shyti <andi.shyti@kernel.org>,\n Wolfram Sang <wsa+renesas@sang-engineering.com>,\n\tAndy Shevchenko <andy@kernel.org>, linux-i2c@vger.kernel.org,\n\tHuacai Chen <chenhuacai@kernel.org>, Xuerui Wang <kernel@xen0n.name>,\n loongarch@lists.linux.dev,\n\tdevicetree@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}},{"id":3676594,"web_url":"http://patchwork.ozlabs.org/comment/3676594/","msgid":"<CAMpQs4LaQ27ZQhyv-s1OVcBF=4DR=_SiDTrpoB7F4qPRHEWB1w@mail.gmail.com>","list_archive_url":null,"date":"2026-04-13T09:26:09","subject":"Re: [PATCH v7 0/2] i2c: Add Loongson-2K0300 I2C controller support","submitter":{"id":85415,"url":"http://patchwork.ozlabs.org/api/people/85415/","name":"Binbin Zhou","email":"zhoubb.aaron@gmail.com"},"content":"On Mon, Apr 13, 2026 at 4:18 PM Andy Shevchenko\n<andy.shevchenko@gmail.com> wrote:\n>\n> On Mon, Apr 13, 2026 at 11:08 AM Binbin Zhou <zhoubb.aaron@gmail.com> wrote:\n> > On Mon, Apr 13, 2026 at 3:52 PM Andy Shevchenko\n> > <andy.shevchenko@gmail.com> wrote:\n> > > On Sat, Apr 11, 2026 at 12:58 PM Binbin Zhou <zhoubinbin@loongson.cn> wrote:\n>\n> ...\n>\n> > > >  - parent_rate_MHz -> parent_rate_mhz to avoid CamelCase.\n> > >\n> > > Was it a special requirement from maintainers?\n> >\n> > I’m actually a bit confused, because when I submitted the v6 patchset,\n> > checkpatch didn’t issue this warning.\n> > But now, it produces the following output:\n> >\n> > scripts/checkpatch.pl --strict i2c-ls2k0300-v6/v6-0002*\n> > CHECK: Avoid CamelCase: <parent_rate_MHz>\n>\n> It's a false positive of the checkpatch.\n\nOK, I will revert this change.\n>\n> > #512: FILE: drivers/i2c/busses/i2c-ls2x-v2.c:437:\n> > +       priv->parent_rate_MHz = clk_get_rate(priv->clk);\n> >\n> > total: 0 errors, 0 warnings, 1 checks, 574 lines checked\n> >\n> > NOTE: For some of the reported defects, checkpatch may be able to\n> >       mechanically convert to the typical style using --fix or --fix-inplace\n> >\n> > > Note, the physical units are special. The m and M have quite a\n> > > different multiplier value. So, even if asked by somebody I think it's\n> > > still arguably should be kept as MHz.\n>\n> See above why.\n\nI see, thanks.\n>\n> --\n> With Best Regards,\n> Andy Shevchenko","headers":{"Return-Path":"\n <linux-i2c+bounces-17045-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=DpKGXT4e;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-i2c+bounces-17045-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"DpKGXT4e\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.208.50","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvMZd2kMHz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 19:30:17 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id D49D8303FAD1\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 09:26:27 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A9EB43B2FC7;\n\tMon, 13 Apr 2026 09:26:26 +0000 (UTC)","from mail-ed1-f50.google.com (mail-ed1-f50.google.com\n [209.85.208.50])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 031313B19B0\n\tfor <linux-i2c@vger.kernel.org>; Mon, 13 Apr 2026 09:26:24 +0000 (UTC)","by mail-ed1-f50.google.com with SMTP id\n 4fb4d7f45d1cf-6718f336888so1067437a12.1\n        for <linux-i2c@vger.kernel.org>; Mon, 13 Apr 2026 02:26:24 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776072386; cv=pass;\n b=HLPh2VjbUIUJ8qBqVfsdTewBBORIEmo9dn6qGQXgT24iaTKgQpcKuDK+jEa2uYoQG2s7X8PSuc5E8+N9CHSBhi23DcBL0XyeNtcLqORFaFF+mTX1R+eNRP3wB3qy4UFh2XeT8HHVlWguL6CrAt0rk5BN82SkbrzxhYR8Ib1sciw=","i=1; a=rsa-sha256; t=1776072383; cv=none;\n        d=google.com; s=arc-20240605;\n        b=fuANHqdsP/Pjo7QHWViybc+lxSeYamO3UAdV68cWXU+LfXL5+9StTfkZdqMIs9kLO1\n         SIRidU+rlc7spdLVjmboQydD18lidGrsChvBr4riFFEEIU8BHMF5Dr4llY+GBv3KnBs6\n         XzxTZe6eR0qwHP4XT+3wZt2EQO+C/OX155qiPgaoERODkeMJ/wM18+8mgEF66uWUrCmM\n         2XfYnFjnU+Mw0Cz+MCCUiLienuIpxZaqL33S0LQA8MwdAHQMCHt9YFZcNx7W4AjTeCr5\n         ZTccNGmc7ZcR86jT59UNZi+aNqH6COL9jbyFGXWTk7jGvnzmBbaTMXDaPX/zhlIqx9H0\n         kDAg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776072386; c=relaxed/simple;\n\tbh=AIj8v0Hi8sQvxNr/C2OEW3Yh01lDZBaIZhuDD3/FUIw=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=D+SE/czMh8FgjbYhl7CyVMXMffpDCECXL897UPyrMiWY2pNSOrpXQzrZ2m3AA/FiCpPXKWS9UDdQLlXhtJKqXQPBJuxELtTD0jqDpuYnnSNPX/SIwx2iwlEYqjJzoCfpfd9siMjjkR+3SSAAFI+KCk22RfC5kyBz4intZE/leBU=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n        h=content-transfer-encoding:cc:to:subject:message-id:date:from\n         :in-reply-to:references:mime-version:dkim-signature;\n        bh=n3iu2/uJJ+f3nvEEkeX9hHnOtEpFD7REsnR2pQwo48Y=;\n        fh=bKofIr7qbky6OF4epWGLsZLYHZ9fj5GSa4i+0lbQcDk=;\n        b=IfKI0gH+QiVVGMkFu54MrTow0D4FbPxVI5aLBZcHwQ+T2JxufzabtJUANR38wTuuVl\n         3HuitRE4ShMqDA5e5f+ydZK6JoPsr8nh+HMHfcHKN0rcV2tHm07OXIbTiUbOpZe4dkPq\n         QiMO/P/fns2CN7mjim8Gv8FFIFcwivoxmgCwMMd+u/zckYeFAwChY9vWgv+FhlSunGT3\n         Y6RhBv65GFdJCtZqZZygyoh8oFQ6SZtHAnRlPLEmwaj32KhXY3C5f4Mfn+sYVzhJYE56\n         m1oJiRX3Q3bNfu75fB0J+BPlXVwRUs0pHG49NaEaaGBUXO6HJ7WoqjIy63beHr/3AXUr\n         sxng==;\n        darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=DpKGXT4e; arc=pass smtp.client-ip=209.85.208.50","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=gmail.com; s=20251104; t=1776072383; x=1776677183;\n darn=vger.kernel.org;\n        h=content-transfer-encoding:cc:to:subject:message-id:date:from\n         :in-reply-to:references:mime-version:from:to:cc:subject:date\n         :message-id:reply-to;\n        bh=n3iu2/uJJ+f3nvEEkeX9hHnOtEpFD7REsnR2pQwo48Y=;\n        b=DpKGXT4eKUOPmGoqmf5ucGXl2aK6FSd7vE5q9FLxtd/gtoZQl8vXRescoBW4u7CW6e\n         rwbJG01mF55h1YyBUopzO0OIv/FvFg5BVDevT4gn7HDa3ad+zdAdddA14tuU3MbO4m8a\n         jP1I9EYkHf7dkH6OkhUIEo/0kgr+YCZ67jZa8Pjkn744BTPlfbKi9jpOI4mqHnT+Dhs9\n         66P7IF5ONRFZGFRSLR63xd+HS1ezpWNyUebmXHdyfBNT8f12INddZ0yu8s/W/MPCbgks\n         +lAbGYwWSooNqCb0ezT7ZtFN9KFyKtZ56R9t/ylNODOU9/6BeWPyjs0W8dty84ThlKW7\n         Y90A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1776072383; x=1776677183;\n        h=content-transfer-encoding:cc:to:subject:message-id:date:from\n         :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n         :to:cc:subject:date:message-id:reply-to;\n        bh=n3iu2/uJJ+f3nvEEkeX9hHnOtEpFD7REsnR2pQwo48Y=;\n        b=PrAZD5eBkUYVoT52SJDTJ+Z0zMNjNpd+beDYtoA5lVDLAg/2RvWJ6K0R7Lxzzb2yfL\n         i8zoLhnHDlepcaeQo0L4PTtnx5DeaY9iPgXDhOmmxUqqhkLNdXhFa4tp+GRrQOVy7rau\n         xVyX7f8MrZQgDZYxDK8C9khkB2wnvz1tA0wOuBz8zEvVCesSuM9AWRlpS382Cte3hCyS\n         qrxR6MGNckcjtqZQZBFw4wmSgMpcuol2/HxqKhggh3/NrBqlsaNsgIRNVJ8YyV6fV242\n         hMJXXat/Ww4S2Ax+zbvGIRW22a1YFTrI9qcOOCzH7Me+3i4giJo3Pyvpfi5NF+VFHZd/\n         yaiA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/p231Oq9REPVGlPRTzrdENSFxZ3UVqhnAjxLGjEg7c+NmvxHyEoKk/uUZwdArKei8ktb7n6pkCYNU=@vger.kernel.org","X-Gm-Message-State":"AOJu0YzgsVoETsbGbxom2Hyg+sMzUTPl4GbVyCySPTS4NTbxBZQoB5Na\n\ts/PvVpPgnlyA3UT1IDcsz+7myVQqAgd87JuyzYSP2mXrFH+efkaMzmKxIFT8oQPXz/wEMiqKcFw\n\tY+L01y4DxrnahAHIMZAKAmiNSWWu+fRQVB8Henf0=","X-Gm-Gg":"AeBDiet3CeHM/NHOGOdVEbMmgpibWjDuCeFoDM7n8sXaqF/U/ciiHDLskn+BrTwuPtC\n\tkSijw2NljH+l5yQeYtPZMdaNA392frqwxurVHOOEWeIWQavptcy4aqUrr/gnMFuhXTW/y5GprhR\n\t/15GVjPNbvaUYeIrvVfoEtZZ4b17li7AJbLhiSlmUVUvY2/y+SsBgrkP7yDFXCPQ8US3tFMMGpG\n\tQlKId1TF62cmvQVKraBPkSPTasJSzup7LyqSOMtAhtlKJdTIrJB68KmOZEGn7BkN8zpGVhqV0uX\n\t0r8TVfED/oHHfiuSn/0=","X-Received":"by 2002:a05:6402:34cc:b0:670:8d21:dcb with SMTP id\n 4fb4d7f45d1cf-6708d2110cbmr6408870a12.19.1776072382964; Mon, 13 Apr 2026\n 02:26:22 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"<linux-i2c.vger.kernel.org>","List-Subscribe":"<mailto:linux-i2c+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-i2c+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","References":"<cover.1775900045.git.zhoubinbin@loongson.cn>\n <CAHp75Ve59GPAFvKM6yOkPmr=kmHBjVL-Vz78X0WDikiWd+2arQ@mail.gmail.com>\n <CAMpQs4+QmyAObvCcJOFnfTuufG8=M0q5m+XMkaP6-SOp-8wq9w@mail.gmail.com>\n <CAHp75Veymi3z2atMuSeDyrhyx-HLHgCMzJF5EgpJZzTGgpcD3Q@mail.gmail.com>","In-Reply-To":"\n <CAHp75Veymi3z2atMuSeDyrhyx-HLHgCMzJF5EgpJZzTGgpcD3Q@mail.gmail.com>","From":"Binbin Zhou <zhoubb.aaron@gmail.com>","Date":"Mon, 13 Apr 2026 17:26:09 +0800","X-Gm-Features":"AQROBzBh6eBs7REn1Qv9IV594bWuIgt_mTQzWy_FshpZ6l48Ew5CqcVKTNMWbYw","Message-ID":"\n <CAMpQs4LaQ27ZQhyv-s1OVcBF=4DR=_SiDTrpoB7F4qPRHEWB1w@mail.gmail.com>","Subject":"Re: [PATCH v7 0/2] i2c: Add Loongson-2K0300 I2C controller support","To":"Andy Shevchenko <andy.shevchenko@gmail.com>","Cc":"Binbin Zhou <zhoubinbin@loongson.cn>,\n Huacai Chen <chenhuacai@loongson.cn>,\n\tRob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,\n Conor Dooley <conor+dt@kernel.org>,\n\tAndi Shyti <andi.shyti@kernel.org>,\n Wolfram Sang <wsa+renesas@sang-engineering.com>,\n\tAndy Shevchenko <andy@kernel.org>, linux-i2c@vger.kernel.org,\n\tHuacai Chen <chenhuacai@kernel.org>, Xuerui Wang <kernel@xen0n.name>,\n loongarch@lists.linux.dev,\n\tdevicetree@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]