[{"id":3675441,"web_url":"http://patchwork.ozlabs.org/comment/3675441/","msgid":"<20260409163321.GN41863@bill-the-cat>","list_archive_url":null,"date":"2026-04-09T16:33:21","subject":"Re: [PATCH 0/9] arm: hpe: Add HPE GSC (Gen12) BMC SoC support","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Wed, Apr 08, 2026 at 07:24:12PM +0000, Jorge Cisneros wrote:\n\n> This series adds support for the HPE GSC (Gen Server Controller), an\n> ARM64-based BMC SoC used in HPE ProLiant and Synergy Gen12 servers.\n> \n> The GSC is the successor to the GXP SoC (already upstream) used in\n> Gen11 servers. It features dual Cortex-A35 cores with GICv3, a Denali\n> DDR memory controller, Cadence GEM Ethernet (SGMII), and reuses several\n> GXP IP blocks (timer, SPI, I2C).\n> \n> The existing ARCH_GXP Kconfig symbol is renamed to ARCH_HPE to serve as\n> an umbrella for both the GXP (ARMv7) and GSC (ARMv8) SoC variants,\n> selected via a choice menu under mach-hpe.\n> \n> New drivers:\n> - Watchdog (drivers/watchdog/gsc_wdt.c)\n> - Memory-mapped virtual EEPROM for VPD (drivers/misc/gsc_mem_eeprom.c)\n> - Cadence GEM support added to the existing MACB driver\n> \n> Board support includes DRAM sizing from the Denali memory controller,\n> MAC address provisioning from VPD EEPROM, FDT fixups for network\n> configuration, shared Ethernet/DisplayPort PHY initialization, and a\n> server_id command for reading server identification from the CPLD.\n> \n> Notes:\n> - The server_id command (patch 7) is hardware-specific and reads from\n>   GSC CPLD registers, so no sandbox test is included.\n> - MAINTAINERS warnings in patches 1-8 are resolved by patch 9.\n> \n> Based on v2026.04-rc4 (ba7bf918dafcd093ad733b07ba490baeb20cf5da).\n> Tested: both gxp_defconfig and gsc_defconfig build cleanly.\n\nThanks for posting this. I have just a few comments to follow.","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256\n header.s=google header.b=ZW8xMVDX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com\n header.b=\"ZW8xMVDX\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=trini@konsulko.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs7NJ0V6Dz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 04:13:36 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id A5F55841DF;\n\tThu,  9 Apr 2026 20:12:35 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id D667F84099; Thu,  9 Apr 2026 18:33:29 +0200 (CEST)","from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com\n [IPv6:2001:4860:4864:20::2b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id AD2C983CF5\n for <u-boot@lists.denx.de>; Thu,  9 Apr 2026 18:33:27 +0200 (CEST)","by mail-oa1-x2b.google.com with SMTP id\n 586e51a60fabf-42321c8b8f5so945852fac.1\n for <u-boot@lists.denx.de>; Thu, 09 Apr 2026 09:33:27 -0700 (PDT)","from bill-the-cat (fixed-189-203-106-235.totalplay.net.\n [189.203.106.235]) by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-423ddbee0fesm65760fac.17.2026.04.09.09.33.23\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 09 Apr 2026 09:33:25 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=konsulko.com; s=google; t=1775752406; x=1776357206; darn=lists.denx.de;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=i+CBakdrEwu/cYOohDO4esz1hhSw1R39593GJtVydxM=;\n b=ZW8xMVDX/wKL5c0sq2EBslVyB1paw0YjU9uYMZUbcBYWGUqfoMQIPziGEyQTiJSb6C\n 1nTzd7hNlknjckRpOg6Kno/Qll187ykOTUngW72SJVNA2q6Wivak+w9T0H/XB2O86QV+\n R82PkKotNyf/ZuB9pdWNlpYCulFEj6T5DG9Bc=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775752406; x=1776357206;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=i+CBakdrEwu/cYOohDO4esz1hhSw1R39593GJtVydxM=;\n b=K8JCwOeI/CtK7/aYRh/zajOdncdgeuHQ6xyys2jTGq0mHAZKSmWF3PDu4i15BLRahY\n C5AxwtWSwZ16hqr3YMF8wLZVNcHcAZ3X8/VAeFZNIgR/3cjVBuzYn0SQ9wq9IT0fhPLQ\n FiPsJsXmn5tgDpcezrnBiUh7wUw3TIKl5K6nspCOVi2lpJFPhp4aVV7ROGoevqeV0HYm\n +JU4Q6xgo8GKgudmYIpifjkA+k8qwSPHG3odkOkKKD6tlm8wAGT6jJOZpTN18Da6kXvC\n VOROZ/Hhn2MKXYXHUExIyoqsoo1mqdzmF1RG72r7YuO94Ckxz06yAw7bNjcwsQdelsIb\n JDqg==","X-Gm-Message-State":"AOJu0YzXX/hFura81nxg5IMbERE0dtYg9NKF762RYrgHlPlunIDCUGFT\n 3UnpxmBVsy/Ar1BmWtLMYaGgEHRZKFAi3tyrGK8BQjqysPwGo44Ir+/Jk9PFsvmcIxXHzyw7cMa\n ysBC++BU=","X-Gm-Gg":"AeBDies1ISv8Ix+D7yEbrY8V0FJJKzGBwL8q/Rlu0J15xNJiN9XYPbOm9rLt9ctDfew\n 2Bthu8B50DoEAyy6x2HrIw1DIf1JYXiYoO5lopCxhDaTyosVafSExeQg714Lggy73fk0caNbJdb\n ZEVbiqQ7RcSr1chSrmiT1x6He+b0JvNHyzunmofmanSBkXi/HVvUvOMNQB0GbsUjNGjucxW3/GJ\n k5fQv2NKdTHptzujOfIkV6hHEv+ACKW5xHmT4Sw1IxQa7uvdAKhn9JrAXf52K19YaHSlBUriY03\n 64693HzoPuNn6EDT6JwbdX/sqn+HgBtmG3GUTb5bdJfCH6umndQZMK23RmskR117v/z4NzJJa7k\n NyWcjq1CtwBtql0uVNpQXgRTEIc2XDWQwNrARSB+AKJzy9kfAw6JPyqye+hTYn3tniyKJV7jyAe\n DNlVly3fpNumq68E+CTF+iNontoU8SwTRBTUJLlIf0efNH8tsROyWDwWvvQaXHeLB6kspjrJacW\n Jek+7CduOvC/aq9RMSL3qyKzjoAFOgrm9LGxVUksyfIdpmfuFY=","X-Received":"by 2002:a05:6871:eb06:b0:3e8:8dcb:cdc7 with SMTP id\n 586e51a60fabf-423bd02b9dfmr2110896fac.20.1775752406067;\n Thu, 09 Apr 2026 09:33:26 -0700 (PDT)","Date":"Thu, 9 Apr 2026 10:33:21 -0600","From":"Tom Rini <trini@konsulko.com>","To":"Jorge Cisneros <jorge.cisneros@hpe.com>","Cc":"u-boot@lists.denx.de,\n Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,\n Jean-Marie Verdun <verdun@hpe.com>, Nick Hawkins <nick.hawkins@hpe.com>,\n Casey Connolly <casey.connolly@linaro.org>, Anshul Dalal <anshuld@ti.com>,\n Tien Fong Chee <tien.fong.chee@altera.com>, Peng Fan <peng.fan@nxp.com>,\n Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@altera.com>,\n Tingting Meng <tingting.meng@altera.com>, Alice Guo <alice.guo@nxp.com>,\n Quentin Schulz <quentin.schulz@cherry.de>,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Tony Dinh <mibodhi@gmail.com>,\n Marek Vasut <marek.vasut+renesas@mailbox.org>,\n Stefan Roese <stefan.roese@mailbox.org>,\n Svyatoslav Ryhel <clamor95@gmail.com>,\n Patrice Chotard <patrice.chotard@foss.st.com>,\n Mattijs Korpershoek <mkorpershoek@kernel.org>,\n Shmuel Leib Melamud <smelamud@redhat.com>,\n Lukasz Majewski <lukma@nabladev.com>,\n Sumit Garg <sumit.garg@oss.qualcomm.com>, Chen-Yu Tsai <wens@kernel.org>,\n Justin Klaassen <justin@tidylabs.net>,\n Neha Malcom Francis <n-francis@ti.com>,\n Jamie Gibbons <jamie.gibbons@microchip.com>,\n Leo Yu-Chi Liang <ycliang@andestech.com>,\n Jerome Forissier <jerome.forissier@arm.com>,\n Simon Glass <sjg@chromium.org>,\n Neil Armstrong <neil.armstrong@linaro.org>, Yao Zi <me@ziyao.cc>,\n Kuan-Wei Chiu <visitorckw@gmail.com>,\n \"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>,\n Raymond Mao <raymond.mao@riscstar.com>,\n Philip Molloy <philip.molloy@analog.com>","Subject":"Re: [PATCH 0/9] arm: hpe: Add HPE GSC (Gen12) BMC SoC support","Message-ID":"<20260409163321.GN41863@bill-the-cat>","References":"<20260408-hpe-gsc-upstream-v1-0-2be1fb7cbbfc@hpe.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n protocol=\"application/pgp-signature\"; boundary=\"nbyU/ED8A3Db9i+N\"","Content-Disposition":"inline","In-Reply-To":"<20260408-hpe-gsc-upstream-v1-0-2be1fb7cbbfc@hpe.com>","X-Clacks-Overhead":"GNU Terry Pratchett","X-Mailman-Approved-At":"Thu, 09 Apr 2026 20:12:34 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]