[{"id":3674919,"web_url":"http://patchwork.ozlabs.org/comment/3674919/","msgid":"","list_archive_url":null,"date":"2026-04-08T08:40:18","subject":"Re: [PATCH 0/8] tree-wide: use g_clear_handle_id() for GSource\n cleanup","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Wed, Apr 08, 2026 at 01:01:42AM +0000, Matthew Penney wrote:\n> This series replaces open-coded uses of g_source_remove() with\n> g_clear_handle_id() across the tree.\n> \n> This is a more modern (GLib >= 2.56) approach than directly calling\n> g_source_remove().\n> \n> g_clear_handle_id() simplifies cleanup of GSource IDs since it\n> checks the ID is valid, calls the cleanup function and zeros the ID.\n> \n> This reduces boilerplate and avoids open-coded calls to\n> g_source_remove().\n> \n> This series follows an earlier fix that removed a dangling GSource tag\n> and replaced an explicit call to g_source_remove() with\n> g_clear_handle_id().\n> \n> No functional changes.\n> \n> Link: https://gitlab.com/qemu-project/qemu/-/commit/34aad589019c8687fb3b19ba79d64d97071a7205\n\nLooking at your git repo fork, while the commits are creditted under\nyour name, all the activity on the repo appears to have done by a bot\naccount:\n\n https://gitlab.com/mj-penney/qemu/activity\n\nWhat's the situation here with authorship ? \n\nWith regards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=LZ/NUcDH;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frXnZ6L1qz1yD3\n\tfor ; Thu, 09 Apr 2026 05:14:58 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAYK9-0002Kl-H3; Wed, 08 Apr 2026 15:12:25 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAYIw-0007Bi-8X\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 15:11:10 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAOSm-0002S7-Fa\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 04:40:41 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-678-nDRVTIecPha0KzhJ2AdGjQ-1; Wed,\n 08 Apr 2026 04:40:35 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id DC2A81955F41; Wed, 8 Apr 2026 08:40:29 +0000 (UTC)","from redhat.com (headnet01.pony-001.prod.iad2.dc.redhat.com\n [10.2.32.101])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id D84FC1955F2B; Wed, 8 Apr 2026 08:40:21 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775637638;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type:in-reply-to:in-reply-to: references:references;\n bh=vNzURTCjft3pnt4tIwyfboVA0t93gFW+FEnBhvEAE3A=;\n b=LZ/NUcDH3AyyDmAc61F1Lz8hB5VBNPNBjmc7lcfBj3/JUMzLnf5uiNvBBNB4LxNkMj08Mr\n wX3l4OETOvvUjxjW1A/FL+MABtrU8d3QIqpFD6SfOIHE9033cJkZ4kT183CNXdPQtluPfT\n klHZJeNeea5e9hKeaxGSW0TMhSjn6/c=","X-MC-Unique":"nDRVTIecPha0KzhJ2AdGjQ-1","X-Mimecast-MFC-AGG-ID":"nDRVTIecPha0KzhJ2AdGjQ_1775637630","Date":"Wed, 8 Apr 2026 09:40:18 +0100","From":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","To":"Matthew Penney ","Cc":"qemu-devel@nongnu.org, Peter Maydell ,\n\t=?utf-8?q?Marc-Andr=C3=A9?= Lureau ,\n Paolo Bonzini , Joel Stanley ,\n \"Michael S. Tsirkin\" , Samuel Tardieu ,\n Cornelia Huck , Eric Farman ,\n Matthew Rosato , Halil Pasic ,\n Christian Borntraeger ,\n \"Collin L. Walling\" ,\n Laurent Vivier , Amit Shah ,\n qemu-arm@nongnu.org, qemu-s390x@nongnu.org, Jason Wang ,\n Stefano Garzarella , Fam Zheng ,\n qemu-block@nongnu.org, Marcelo Tosatti ,\n kvm@vger.kernel.org, Zhao Liu ","Subject":"Re: [PATCH 0/8] tree-wide: use g_clear_handle_id() for GSource\n cleanup","Message-ID":"","References":"<20260408010026.4611-1-matt@matthewpenney.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260408010026.4611-1-matt@matthewpenney.net>","User-Agent":"Mutt/2.2.14 (2025-02-20)","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"7","X-Spam_score":"0.7","X-Spam_bar":"/","X-Spam_report":"(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]