[{"id":3674720,"web_url":"http://patchwork.ozlabs.org/comment/3674720/","msgid":"<3c7e8261-7528-431c-adb9-3b90124cef99@molgen.mpg.de>","list_archive_url":null,"date":"2026-04-08T11:50:37","subject":"Re: [Intel-wired-lan] [PATCH iwl-next 0/2] i40e: implement\n per-queue stats","submitter":{"id":70275,"url":"http://patchwork.ozlabs.org/api/people/70275/","name":"Paul Menzel","email":"pmenzel@molgen.mpg.de"},"content":"Dear Paolo,\n\n\nThank you for your patches.\n\nAm 08.04.26 um 13:43 schrieb Paolo Abeni:\n> The i40e driver already collects some per queue statistics, but does\n> not expose them to the user-space using the standard interface.\n> \n> Implement the stat_ops callbacks and extends the already collected info\n\ns/extends/extend/\n\n> with basic GSO counters. Overall this allows passing the kernel NIC\n> drivers TSO test cases.\n\nIt’d be great, if you added the commands to show the stats, and to run \nthe test cases.\n\n> Paolo Abeni (2):\n> i40e: implement basic per-queue stats\n> i40e: keep track of per queue gso counters.\n\nNo period needed at the end of the summary/title.\n\n> \n> drivers/net/ethernet/intel/i40e/i40e.h | 9 ++\n> drivers/net/ethernet/intel/i40e/i40e_main.c | 144 ++++++++++++++++++\n> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 8 +-\n> drivers/net/ethernet/intel/i40e/i40e_txrx.h | 2 +\n> .../ethernet/intel/i40e/i40e_txrx_common.h | 6 +-\n> drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +-\n> 6 files changed, 168 insertions(+), 3 deletions(-)\n\n\nKind regards,\n\nPaul","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=4CYWIW/n;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frLy21cydz1xy1\n\tfor ; Wed, 08 Apr 2026 21:51:36 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 2914F822FE;\n\tWed, 8 Apr 2026 11:51:34 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id eE6SbBn82wrS; Wed, 8 Apr 2026 11:51:32 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 11C9D821D1;\n\tWed, 8 Apr 2026 11:51:32 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 2D9FA237\n for ; Wed, 8 Apr 2026 11:51:30 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 1F4224069F\n for ; Wed, 8 Apr 2026 11:51:30 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 0E4Sfcp0HEsu for ;\n Wed, 8 Apr 2026 11:51:29 +0000 (UTC)","from mx3.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 8E2DD4069C\n for ; Wed, 8 Apr 2026 11:51:27 +0000 (UTC)","from [192.168.2.229] (p5dc55707.dip0.t-ipconnect.de [93.197.87.7])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested) (Authenticated sender: pmenzel)\n by mx.molgen.mpg.de (Postfix) with ESMTPSA id 95BCA4C2C37D4D;\n Wed, 08 Apr 2026 13:50:38 +0200 (CEST)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 11C9D821D1","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8E2DD4069C"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775649092;\n\tbh=w1J1z6UfUIsOB2RYoy8vtMchlZQFMSLN8GWX4rfSeVc=;\n\th=Date:To:Cc:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=4CYWIW/neb2DWZMTUvmqv2MvINkMKee0kpe5c9sLj/BBvGgeCcRKE87spTkeQgbq3\n\t Z29kTqe18l5Q3piABVE7M4N/0Dcn10N/hERxu7Awn7BWsnwYrOF3/45rHI4EGfz4uC\n\t xXrrvbwwuold8vkHYaUOuQ/s7+bUQ4SmUFCP9PsIXfap58owGe25m2ZjP2qK2taf3O\n\t 3Tj+kFjIF3D2iveyyHVazKeqf5I1y2zCYOhWA7Zpx/otfnn/1mpEDTUvulCzrk3Nty\n\t 1AR3JSm93d05NuDLxroV/yZpuD8FhJQqpfzKLNCMYjggwSDvBWNcj4nOWDPNKjYTek\n\t LFEzGY1f47YHQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=141.14.17.11;\n helo=mx3.molgen.mpg.de; envelope-from=pmenzel@molgen.mpg.de;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 8E2DD4069C","Message-ID":"<3c7e8261-7528-431c-adb9-3b90124cef99@molgen.mpg.de>","Date":"Wed, 8 Apr 2026 13:50:37 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","To":"Paolo Abeni ","Cc":"intel-wired-lan@lists.osuosl.org, Tony Nguyen\n , Przemek Kitszel\n , Andrew Lunn ,\n \"David S. Miller\" , Eric Dumazet ,\n Jakub Kicinski , Alexei Starovoitov ,\n Daniel Borkmann ,\n Jesper Dangaard Brouer ,\n John Fastabend ,\n Stanislav Fomichev , netdev@vger.kernel.org","References":"","Content-Language":"en-US","From":"Paul Menzel ","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-Mailman-Original-Authentication-Results":"smtp4.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=molgen.mpg.de","Subject":"Re: [Intel-wired-lan] [PATCH iwl-next 0/2] i40e: implement\n per-queue stats","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3674823,"web_url":"http://patchwork.ozlabs.org/comment/3674823/","msgid":"","list_archive_url":null,"date":"2026-04-08T14:58:27","subject":"Re: [Intel-wired-lan] [PATCH iwl-next 0/2] i40e: implement\n per-queue stats","submitter":{"id":67312,"url":"http://patchwork.ozlabs.org/api/people/67312/","name":"Paolo Abeni","email":"pabeni@redhat.com"},"content":"On 4/8/26 1:50 PM, Paul Menzel wrote:\n> Dear Paolo,\n>\n> Thank you for your patches.\n> \n> Am 08.04.26 um 13:43 schrieb Paolo Abeni:\n>> The i40e driver already collects some per queue statistics, but does\n>> not expose them to the user-space using the standard interface.\n>>\n>> Implement the stat_ops callbacks and extends the already collected info\n> \n> s/extends/extend/\n> \n>> with basic GSO counters. Overall this allows passing the kernel NIC\n>> drivers TSO test cases.\n> \n> It’d be great, if you added the commands to show the stats, and to run \n> the test cases.\n\nI'll add some \"show stats\" examples in the v2 cover, hopefully fixing\nthe typos while at it.\n\nHow to run NID driver H/W self-tests is IMHO a bit too wide topic to be\ndiscussed in the cover letter, but there is already a quite\ncomprehensive readme in the selftests dir:\n\nhttps://elixir.bootlin.com/linux/v7.0-rc7/source/tools/testing/selftests/drivers/net/README.rst\n\n/P","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=4AnmB3rO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frR5s2BVgz1xv0\n\tfor ; Thu, 09 Apr 2026 00:58:41 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id BD22281E79;\n\tWed, 8 Apr 2026 14:58:39 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id VV21YomYXiaX; Wed, 8 Apr 2026 14:58:38 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 8754381E51;\n\tWed, 8 Apr 2026 14:58:38 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id BB0C51F6\n for ; Wed, 8 Apr 2026 14:58:37 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 9D43160856\n for ; Wed, 8 Apr 2026 14:58:37 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 7H2HOVU7o61T for ;\n Wed, 8 Apr 2026 14:58:36 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 1993160847\n for ; Wed, 8 Apr 2026 14:58:35 +0000 (UTC)","from mail-wm1-f72.google.com (mail-wm1-f72.google.com\n [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-32-LOiAAr0YM0G_svzIOynS5w-1; Wed, 08 Apr 2026 10:58:31 -0400","by mail-wm1-f72.google.com with SMTP id\n 5b1f17b1804b1-4837b6f6b93so62457815e9.3\n for ; Wed, 08 Apr 2026 07:58:31 -0700 (PDT)","from [192.168.88.32] ([212.105.153.231])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4888a72baa8sm504011835e9.15.2026.04.08.07.58.27\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 08 Apr 2026 07:58:28 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8754381E51","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 1993160847"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775660318;\n\tbh=5k9cDfj6fEVUNaXp8nCyqPBRWfO8zKeH0JyXDvSDvA4=;\n\th=Date:To:Cc:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=4AnmB3rOPATMYjmLBeRACEEw7OuFQwRSsO2OZTeU1DVg0Z28JGPwjkqaVfUsMjcsV\n\t evowSh9WQFqKfpNKC6N6kZlueUzuoD82hQTGt0p4xDSohYanwxaV8tGmYveCc+mNIP\n\t wVp78ahFbMBz7678evHQ/vw2SAi3D8Q7hbK7yzeRuOGyQ1A/pFzr+Z1V1fPw91uP28\n\t xmJsAQnnTgSdHsI/uGkSPZN1WqCPg/7TSWcL5GYyANHsTc4aePDw8zXT99DVLHKwHt\n\t kp4lW8AypxZM39b/y4qZjsWtkAt63MMDqoorodyhK9Hm65j92vC+AKWZFg89yBclmz\n\t VGp3zXiRrVYoA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=pabeni@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 1993160847","X-MC-Unique":"LOiAAr0YM0G_svzIOynS5w-1","X-Mimecast-MFC-AGG-ID":"LOiAAr0YM0G_svzIOynS5w_1775660311","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775660310; x=1776265110;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=5k9cDfj6fEVUNaXp8nCyqPBRWfO8zKeH0JyXDvSDvA4=;\n b=nFuASR1rsPnCXvwkiBSxaK8oP7WORnii7tDkB5bwfElbHNFx1LZcyIEnV6wUpETTVe\n rxv0gtRClyiYDZb55rE2r+2rOHfuPzQgMehJZWiTxCKHdT7U4a5sCgPUW4GrRdEHtsRT\n +ZPir01Q5zG4G2JzTTkM9clMsarLOgJl11HAcjct07lW0vL0Fb4sXnnfz6ilLueAF7Jk\n 5WZuzSah/oDAXExgHMBKMAfLFJoE5fnQ7gibIyxxedaXCMxwrHcHEby05W0OXVdR+qzR\n 6sU3piILsRBsemU2/EhEPtpBkN9yuFFxIatRDqTZIfAiaJl+SL138Fgj25iJ/s62o1ps\n FQEw==","X-Gm-Message-State":"AOJu0YymfsQKUb0G29dnpdLHjVlMV0GWPx3BUDpnLNbtfJ7oze3/gIOg\n Jp8p8Jr4n6x/tebb4ViyfSMmWjBsTi67ch0PrM661pwQ3WZxRv1hUOuU6Wv0C8o/Jxpgs6rWo4o\n sMUtMUL26Ck1Yw3cn978s0DVvZ+l780s5fnZ8Mun2cgNw1PuNT34IS+hpyrKqrHbxcQZVl7Q=","X-Gm-Gg":"AeBDieti5u4+vM7QikyyEIBRVPVqnUOsRe2Fhm8n1ZPCHIqgONJzXdV1ufUT77Zx7li\n uCkXUKQHA1HioNJR9lxy8d1lCqgaA9iqlU4Xav+M5IbD1KlKJoXhPjjtJekQAYqwiyyNHKO6tn4\n a7h33vHBTkMMWX7geSpv72juQ1GSJKLkZEead3oOF6pjh8edBKkjastN7h/BGuomDs8+1UlE6RX\n pf1uogm8pbAWTRH8K7pMwcySuwOGxohEKpcCXtWnMRX7UTHEJevhQT6zsvQfIDjVbTbPWXfhQqF\n eXCnTSIf9H5VUuHC7eQlHZyGq5VgOrXRgzH0ZG8fzo7zhkeSVIWCMCB7O++MD3pXlLTbuBZEa1T\n 2icX947e5hgO5XnN4g5EdsQAA+M8rYCaVdRSiohjfXx5lI5JDJjBkgUQ6dA==","X-Received":["by 2002:a05:600c:a303:b0:487:1fbf:e0a1 with SMTP id\n 5b1f17b1804b1-488ccf3a015mr783515e9.4.1775660310529;\n Wed, 08 Apr 2026 07:58:30 -0700 (PDT)","by 2002:a05:600c:a303:b0:487:1fbf:e0a1 with SMTP id\n 5b1f17b1804b1-488ccf3a015mr783225e9.4.1775660310103;\n Wed, 08 Apr 2026 07:58:30 -0700 (PDT)"],"Message-ID":"","Date":"Wed, 8 Apr 2026 16:58:27 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","To":"Paul Menzel ","Cc":"intel-wired-lan@lists.osuosl.org, Tony Nguyen\n , Przemek Kitszel\n , Andrew Lunn ,\n \"David S. Miller\" , Eric Dumazet ,\n Jakub Kicinski , Alexei Starovoitov ,\n Daniel Borkmann ,\n Jesper Dangaard Brouer ,\n John Fastabend ,\n Stanislav Fomichev , netdev@vger.kernel.org","References":"\n <3c7e8261-7528-431c-adb9-3b90124cef99@molgen.mpg.de>","From":"Paolo Abeni ","In-Reply-To":"<3c7e8261-7528-431c-adb9-3b90124cef99@molgen.mpg.de>","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"vSXUpZkyYJE2knWzf3arzwsLP5dd5Atgglx6envSwP0_1775660311","X-Mimecast-Originator":"redhat.com","Content-Language":"en-US","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1775660314;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=5k9cDfj6fEVUNaXp8nCyqPBRWfO8zKeH0JyXDvSDvA4=;\n b=O9KH5ymaz9sB/FM6GqiqOg67Q6YSaKvv2WbZZiBvBgVvsh8jV7kLEkoBsmMo7cevWm3QpJ\n 1OYgxo3bgVP+4IqIBOy7QgtU+ND8V4m1Geflu1+jHbmo7DH07E+GjDB+kIv+Ydq6IM4mi6\n R/75uZt8dDdc0B+Si7dzLdKEa5S5yjg=","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp3.osuosl.org;\n dkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=O9KH5yma"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-next 0/2] i40e: implement\n per-queue stats","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]