[{"id":3674345,"web_url":"http://patchwork.ozlabs.org/comment/3674345/","msgid":"","date":"2026-04-07T18:21:04","subject":"Re: [RFC v1 0/6] pseries/papr-hvpipe: Fix and simplify papr-hvpipe","submitter":{"id":78084,"url":"http://patchwork.ozlabs.org/api/people/78084/","name":"Haren Myneni","email":"haren@linux.ibm.com"},"content":"On Tue, 2026-04-07 at 20:01 +0530, Ritesh Harjani (IBM) wrote:\n> Haren reported a UAF / null ptr deref issue here [1]. While reviewing\n> that and\n> going over papr-hvpipe code, I found couple of more issues around the\n> usage of\n> copy_to_user() and few refactoring which simplifies the code.\n> \n> This patch series is an attempt to that. Note that this is only\n> compile tested\n> on pseries for now.\n> \n> Haren, I will kindly need your help in verifying this please. Let me\n> know if we\n> have a selftests or any other test framework for this, which I can\n> utilize too.\n\nThanks for fixes and cleanup the code. The testing should be part of\nHMC/RCST framework. So we do not have selftests. I will work with HMC\nto verify these patches. \n\n> \n> [1]:\n> https://lore.kernel.org/linuxppc-dev/20260317040444.2785741-1-haren@linux.ibm.com/\n> \n> \n> Ritesh Harjani (IBM) (6):\n>   pseries/papr-hvpipe: Fix null ptr deref in\n> papr_hvpipe_dev_create_handle\n>   pseries/papr-hvpipe: Fix the usage of copy_to_user()\n>   pseries/papr-hvpipe: Simplify spin_unlock() usage in\n> papr_hvpipe_handle_release\n>   pseries/papr-hvpipe: Kill task_struct pointer from struct\n> hvpipe_source_info\n>   pseries/papr-hvpipe: Refactor and simplify hvpipe_rtas_recv_msg()\n>   pseries/papr-hvpipe: Simplify error handling in papr_hvpipe_init()\n> \n>  arch/powerpc/platforms/pseries/papr-hvpipe.c | 135 +++++++++--------\n> --\n>  arch/powerpc/platforms/pseries/papr-hvpipe.h |   1 -\n>  2 files changed, 66 insertions(+), 70 deletions(-)\n> \n> --\n> 2.39.5","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=lFu2AvMQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19450-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=148.163.156.1","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=lFu2AvMQ;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=haren@linux.ibm.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqvf315Y1z1xtJ\n\tfor ; Wed, 08 Apr 2026 04:21:14 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fqvf21sxmz2ygm;\n\tWed, 08 Apr 2026 04:21:14 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fqvf11FMrz2ySC\n\tfor ; Wed, 08 Apr 2026 04:21:12 +1000 (AEST)","from pps.filterd (m0356517.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 637DXhZI2301594;\n\tTue, 7 Apr 2026 18:21:08 GMT","from ppma23.wdc07v.mail.ibm.com\n (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dcn2fchrn-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tTue, 07 Apr 2026 18:21:08 +0000 (GMT)","from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])\n\tby ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 637EIdQt013821;\n\tTue, 7 Apr 2026 18:21:07 GMT","from smtprelay02.wdc07v.mail.ibm.com ([172.16.1.69])\n\tby ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dcmf44c6n-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tTue, 07 Apr 2026 18:21:07 +0000","from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com\n [10.39.53.228])\n\tby smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 637IL5Ui32244290\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tTue, 7 Apr 2026 18:21:05 GMT","from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 8E27558055;\n\tTue, 7 Apr 2026 18:21:05 +0000 (GMT)","from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 9859558065;\n\tTue, 7 Apr 2026 18:21:04 +0000 (GMT)","from li-4c4c4544-0038-3410-8038-c4c04f423534.ibm.com (unknown\n [9.61.150.36])\n\tby smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n\tTue, 7 Apr 2026 18:21:04 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775586074;\n\tcv=none;\n b=J6bb+Fo1qM7N+WrsUxGJGtIl2CAg4UsfUJe9nFFmRpyUhw7urwvFNgCvi5x62JnS9vdlv/BmHVi5GJcPElZZlv3yvPA4hmgug5cx2802K9WZHH8E5iyclvaVrlQkalXD2E6h20fag3UAffm5Kv9GK9cXUm13XW7NKIJC/g7jolmSnMLbj++jwSQMCm9ZgFsAqLzlMqC59zdPc87mLVfeiBoBnwmdL5VKZgjh1htMwiEukDlCayq9uvbBfrPmtOQgwPmZWJKBic7aaAMEUH/Jinp/C4ieBe9F6oN4WhsZBhn9Zn+WiG6bDfkosRowJOMsuC6yvb9GqJyZk4uqIn8vqw==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775586074; c=relaxed/relaxed;\n\tbh=eNvs0HXImvo0INQNNcJRQbi1TogG903xwwNQgA1mZ9Y=;\n\th=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=XRqHGsFZq70TYRbIPaMYiKqPuPLFA5wpIKj6oI6455PHVGpX8S5YOw90gBCd4iYc1xqfzx3ALXuBXq9dlY+FSt1LCN0nbjsVhq9vHuBxCZTddxHgg3mJUrHxqxwSX9VRECbLtybS4nraCyEFgWYwd3UM55soZ0Sdxs6cv1PD1WzC+uRnoR1C5Np+Omf2NQFV4Q9iKYkNMWYSWqc+SQEm2JTUCUMey+JYiGREa7md3MrvizWZZNFQmOyXe/7tx8LkITXs/11THox6YDCDSO93e3shENH89een02G+wP1LVDgBWQmxWIQfn2mivKKHrqGfgDX8//4c6uwgleYs73K4WA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=lFu2AvMQ; dkim-atps=neutral;\n spf=pass (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=haren@linux.ibm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=pp1; bh=eNvs0H\n\tXImvo0INQNNcJRQbi1TogG903xwwNQgA1mZ9Y=; b=lFu2AvMQ4/KuxTRKdViAii\n\tDWgvTfxA5vBl08MtlRdTP6asaf8+vi5e/7z1ii0CVDUj2YLAewr6nk5MzSPje+Pe\n\tFQifXSZbx9h4TBWcGk9blUCZK9UoiCmrlzHKaY2DGh0PEjuaiKvo5djiZ3eq2R/4\n\t/xLPeY3Ae5udPAiUKaOypOWAMopkts9SgRfY8t1gMqHpXZuDs7MlhWGOvbweiy1x\n\t34TuFETZXbYNKf/yuhhyHcbH/qtaG/aQtOVLWPT/kWiULw1GHZV1bYkCLlMRelTs\n\t+5/4a2R5/qAzikiKWRrxfHbXFuv4uc/GIRGjBAHOUo360jrGM5yT1AoDAuQHemkQ\n\t==","Message-ID":"","Subject":"Re: [RFC v1 0/6] pseries/papr-hvpipe: Fix and simplify papr-hvpipe","From":"Haren Myneni ","To":"\"Ritesh Harjani (IBM)\" ,\n linuxppc-dev@lists.ozlabs.org","Cc":"Madhavan Srinivasan ,\n Christophe Leroy\n\t ,\n Venkat Rao Bagalkote ,\n Nicholas Piggin , linux-kernel@vger.kernel.org","Date":"Tue, 07 Apr 2026 11:21:04 -0700","In-Reply-To":"","References":"","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.56.2 (3.56.2-1.fc42) ","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDA3MDE2NSBTYWx0ZWRfX3nlPNvA6KZnm\n yXICYCfJLvvHJG/W6ZrazHvdgQy2D2+7yzITFjOWnts1AKc85DvzBtMQc8X7m/B0tvd/wXXrbc+\n 25sBu0fvPSW0oMXslMiYf3n/JGp+xRlCymktWZ+6Eo4OOcO/0+/WeW5F0RpUv0/ce2Mqu2qY0I1\n 9IOK+zsy55RSycuBwE75NSYaTblD7FLvv2AEVeGcxVp974gp0+rMJsgPE5WubJLVmuUMr6kiCz+\n gQM90M4N43bndQxNQ04CJyqX0ylFVRgIrM2uHhpNkgNTqZRS8DCmLG874e9/eoswj8Zp5cyb+7X\n xukljcxWqog0nNEg/489KedyZtZOhYbK53YHaHaN4+MEijtyDwvR+tbWXP5lcckIoer6FFxohsS\n 0jagRnUgrhoYaeouchHauqOY3dli8bDR9aRo24nDQZ47AUk/SY/jZtf6eZmsSW9lXHlY/L8/kwy\n /D3EE+MGLE4Bbu4VpOQ==","X-Authority-Analysis":"v=2.4 cv=FsY1OWrq c=1 sm=1 tr=0 ts=69d54b14 cx=c_pps\n a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=VwQbUJbxAAAA:8\n a=VnNF1IyMAAAA:8 a=Fo4P1SXAy8xpn9AqH74A:9 a=QEXdDO2ut3YA:10","X-Proofpoint-ORIG-GUID":"ob_e8oio59vUEGKDosLsNycfxLyOZP6T","X-Proofpoint-GUID":"cZ-3oDN0vbxB39FzN4sgBXDYkyYD6xr2","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-07_04,2026-04-07_05,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n bulkscore=0 priorityscore=1501 impostorscore=0 spamscore=0 phishscore=0\n lowpriorityscore=0 clxscore=1015 adultscore=0 malwarescore=0 suspectscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070165","X-Spam-Status":"No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]