[{"id":3676101,"web_url":"http://patchwork.ozlabs.org/comment/3676101/","msgid":"","list_archive_url":null,"date":"2026-04-11T01:21:28","subject":"Re: [PATCH v7 0/3] PCI: Refactor PCIe speed validation and conversion\n functions","submitter":{"id":89937,"url":"http://patchwork.ozlabs.org/api/people/89937/","name":"Hans Zhang","email":"18255117159@163.com"},"content":"Hi Bjorn,\n\nMay I ask if there's any chance for this series to be included in v7.1?\n\nBest regards,\nHans\n\nOn 4/7/26 21:04, Hans Zhang wrote:\n> This series refactors PCIe speed validation and conversion logic to\n> shared functions in the public header, eliminating code duplication\n> and ensuring consistency across drivers.\n> \n> ---\n> Changes for v7:\n> - patch 0002 add #include (Ilpo)\n> - s/u32 link_speed/enum pci_bus_speed link_speed/ (Ilpo)\n> - The return value of pci_bus_speed2lnkctl2 uses the variable ctrl2_speed\n> to avoid the abuse of variable types. (Ilpo)\n> \n> Changes for v6:\n> https://patchwork.kernel.org/project/linux-pci/patch/20260406105613.1228673-1-18255117159@163.com/\n> \n> - missing one line of code:\n> link_speed = pcie_get_link_speed(pci->max_link_speed);\n> \n> Changes for v5:\n> https://patchwork.kernel.org/project/linux-pci/patch/20260406104708.1218648-1-18255117159@163.com/\n> \n> - Rebase to v7.0-rc1. (pci/next tree)\n> \n> Changes for v4:\n> https://patchwork.kernel.org/project/linux-pci/patch/20251102143206.111347-1-18255117159@163.com/\n> \n> - Maintain O(1) array-based lookup for speed conversion (addressing\n> performance concerns from v3 feedback)\n> - Move pcie_valid_speed() and pci_bus_speed2lnkctl2() to pci.h\n> - Update dwc driver to use the shared functions\n> - Rebase to v6.18-rc3.\n> \n> This addresses the feedback from Lukas Wunner and Manivannan Sadhasivam\n> on the v3 submission, ensuring no runtime performance regression while\n> achieving code reuse.\n> \n> Changes for v3:\n> https://patchwork.kernel.org/project/linux-pci/patch/20250816154633.338653-1-18255117159@163.com/\n> \n> - Rebase to v6.17-rc1.\n> - Gentle ping.\n> \n> Changes for v2:\n> - s/PCIE_SPEED2LNKCTL2_TLS_ENC/PCIE_SPEED2LNKCTL2_TLS\n> - The patch commit message were modified.\n> ---\n> \n> Hans Zhang (3):\n> PCI: Add public pcie_valid_speed() for shared validation\n> PCI: Move pci_bus_speed2lnkctl2() to public header\n> PCI: dwc: Use common speed conversion function\n> \n> drivers/pci/controller/dwc/pcie-designware.c | 28 +++++++-------------\n> drivers/pci/pci.h | 23 ++++++++++++++++\n> drivers/pci/pcie/bwctrl.c | 22 ---------------\n> 3 files changed, 32 insertions(+), 41 deletions(-)\n> \n> \n> base-commit: 525e91d84dc085492b36d4b87abb7c1cc93fcb44","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=gIY5fPrA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-52363-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=\"gIY5fPrA\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=117.135.210.4","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=163.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fswrQ12dXz1yGb\n\tfor ; Sat, 11 Apr 2026 11:22:14 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id C573D3048F18\n\tfor ; Sat, 11 Apr 2026 01:22:10 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E903A1D5151;\n\tSat, 11 Apr 2026 01:22:07 +0000 (UTC)","from m16.mail.163.com (m16.mail.163.com [117.135.210.4])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 98CF540DFA1;\n\tSat, 11 Apr 2026 01:22:03 +0000 (UTC)","from [192.168.50.71] (unknown [])\n\tby gzsmtp5 (Coremail) with SMTP id QCgvCgAnFXIZotlplTr6Vw--.8824S2;\n\tSat, 11 Apr 2026 09:21:31 +0800 (CST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775870527; cv=none;\n b=o8QsHJ1LvJe0yt0pEDIXomzZ7hU0ytOvZe+jnJ2Bw9QQE6eY7chmL8byyOJhAJdsh+jODc2FtejmPoUqfDwEBfdKhc+lbq789vldy67TE0S9KT7YLH2zTuVFyHF8zW7Dd+J6f9wlHKEMADQnXC6XoFwmWEOZLpDdXk3ksDRwhRE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775870527; c=relaxed/simple;\n\tbh=/PwF8G2z6l/Sklihb/YvZ936SeSPy4Fa3jTst40qrDs=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=t9tddvuP8RZD9ZK93Vp1ojsVmIR40G1bM5RXiVKiuYggH6Y7XM4AksYpcDI+UpR5rd03wduaX73LfB6IlGIPhI7pTeKYzwchsC0J1z2XlMvcnhf0m146dWk9m/zie/IOtE+wGWUreb36z7rn5uwGknBzjryETVmR6mrtUwHE6fY=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com;\n spf=pass smtp.mailfrom=163.com;\n dkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=gIY5fPrA; arc=none smtp.client-ip=117.135.210.4","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n\ts=s110527; h=Message-ID:Date:MIME-Version:Subject:To:From:\n\tContent-Type; bh=gsFOLbG7V80dZwqsFNZhbuEJATi7InTrokWZZf8tcJA=;\n\tb=gIY5fPrAqLlrv2E5KIG7g3KAB4Nyup2e78ZyMCDWrXIhQAX7stnzCs85kccrX0\n\te06nAHGihLp3w5htgSq831Dc4SrAWNtaO569Tn2JHk0LXwlTFPDV1yAdSg5l63CH\n\tP7kq+iLrv7tVGXnNgWVkt2ZNJn9qa/Q6AnnIR0w6xOB/U=","Message-ID":"","Date":"Sat, 11 Apr 2026 09:21:28 +0800","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v7 0/3] PCI: Refactor PCIe speed validation and conversion\n functions","To":"bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com,\n kwilczynski@kernel.org, mani@kernel.org, ilpo.jarvinen@linux.intel.com,\n jingoohan1@gmail.com","Cc":"robh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org","References":"<20260407130450.1489318-1-18255117159@163.com>","Content-Language":"en-US","From":"Hans Zhang <18255117159@163.com>","In-Reply-To":"<20260407130450.1489318-1-18255117159@163.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-CM-TRANSID":"QCgvCgAnFXIZotlplTr6Vw--.8824S2","X-Coremail-Antispam":"1Uf129KBjvJXoW7KrWkZFy8Wr4UCF1UXF1fJFb_yoW8KF1Dpa\n\tyY9w4fArW7Gr9xCa97J3Wjqry5Wan3XrW0yry3Gas3Zw13AFn3JF4vgF1FvF9F9rWFvr42\n\tvry3Zw1kCw1qkFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07U0ZXwUUUUU=","X-CM-SenderInfo":"rpryjkyvrrlimvzbiqqrwthudrp/xtbCwxyAJGnZohzAMAAA3F"}}]