[{"id":3674464,"web_url":"http://patchwork.ozlabs.org/comment/3674464/","msgid":"","list_archive_url":null,"date":"2026-04-07T20:01:13","subject":"Re: [PATCH v9 00/20] target/arm: single-binary","submitter":{"id":85798,"url":"http://patchwork.ozlabs.org/api/people/85798/","name":"Pierrick Bouvier","email":"pierrick.bouvier@linaro.org"},"content":"On 4/6/26 7:27 PM, Pierrick Bouvier wrote:\n> This series tackles (most of) the rest of target/arm, especially tcg folder.\n> \n> We extract tcg memory operation in a new header, with a new type representing\n> virtual addresses.\n> \n> Initially, I went down the way to have a dynamic definition of TCGv, which\n> required much more boilerplate and runtime checks. After discussing with\n> Richard, I realized it was not needed, and that could simply split 32 and 64 bit\n> properly in different files instead. This approach will not work with other\n> architectures, requiring something else, but it's enough for target/arm.\n> \n> Files left are:\n> - target/arm/tcg/mve_helper.c\n> - target/arm/tcg/m_helper.c\n> - target/arm/tcg/cpu32.c\n> \n> v9\n> --\n> \n> - introduce aarch64_translate_code *before* adding parameter to translator_loop\n> - use TCG_TYPE_VA as address type for translator_loop\n> - remove inline marker on functions merged from arm_ldst.h to translate.c\n> - refactor arm_ldl_code/arm_lduw_code\n> \n> v8\n> --\n> \n> - make translate.c compilation unit common.\n> \n> v7\n> --\n> \n> - add parameter to translator_loop to indicate address type for current tb.\n> - remove TCGv from target/arm/tcg/translate.c\n> \n> v6\n> --\n> \n> - meson.build: extract decode files in separate variables and explicitly include\n> them in user and system code. The duplication is now minimized: one instance\n> for all system binaries, and one per user binary.\n> \n> v5\n> --\n> \n> - reimplemented what v0 did with new approach defining new tcg-op-mem header\n> - reapply all straightforward patches from v0\n> - only translate.c is left, but first want to validate that changes here are ok\n> for maintainers before doing more.\n> \n> v0\n> --\n> \n> See original thread:\n> https://lore.kernel.org/qemu-devel/20260109053158.2800705-1-pierrick.bouvier@linaro.org/#t\n> \n> Note about v1 -> v4\n> -------------------\n> \n> - After v0 which was trying to do too many changes, v1 to v4 focused on smaller\n> things, and all patches have been merged already.\n> https://patchew.org/QEMU/20260219040150.2098396-1-pierrick.bouvier@linaro.org/\n> \n> Pierrick Bouvier (20):\n> include/tcg/tcg-op: extract memory operations to tcg-op-mem.h\n> target/arm/translate.h: remove tcg-op.h include\n> target/arm/tcg/translate.h: remove tcg-op-gvec.h include\n> target/arm/tcg/translate.h: remove TARGET_AARCH64\n> target/arm/tcg/translate-vfp.c: make compilation unit common\n> target/arm/tcg/translate-neon.c: make compilation unit common\n> target/arm/tcg/translate-mve.c: make compilation unit common\n> target/arm/tcg/translate-m-nocp.c: make compilation unit common\n> target/arm/tcg/op_helper.c: make compilation unit common\n> target/arm/tcg/gengvec.c: make compilation unit common\n> target/arm/tcg/translate.c: remove MO_TE usage\n> target/arm/tcg/translate.c: replace target_ulong with uint32_t\n> target/arm/tcg/translate.c: extract aarch64_translate_code()\n> tcg/translator: add parameter to translator_loop for current addr type\n> target/arm/tcg/translate.c: replace TCGv with TCGv_va\n> target/arm/tcg/translate-a64.c: use translator_ldl_end instead of\n> arm_ldl_code\n> target/arm/tcg/arm_ldst.h: merge in translate.c\n> target/arm/tcg/translate.c: replace translator_ldl_swap with\n> translator_ldl_end\n> target/arm/tcg/translate.c: remove target_ulong\n> target/arm/tcg/translate.c: make compilation unit common\n> \n> include/exec/translator.h | 4 +-\n> include/tcg/tcg-op-mem.h | 126 +++++++++++++++++++++++++++++++\n> include/tcg/tcg-op.h | 100 +-----------------------\n> target/arm/internals.h | 2 +\n> target/arm/tcg/arm_ldst.h | 47 ------------\n> target/arm/tcg/translate.h | 14 +---\n> accel/tcg/translate-all.c | 1 -\n> accel/tcg/translator.c | 4 +-\n> target/alpha/translate.c | 3 +-\n> target/arm/cpu.c | 6 +-\n> target/arm/tcg/op_helper.c | 1 -\n> target/arm/tcg/stubs32.c | 24 ++++++\n> target/arm/tcg/translate-a64.c | 15 +++-\n> target/arm/tcg/translate-sme.c | 1 +\n> target/arm/tcg/translate-sve.c | 1 +\n> target/arm/tcg/translate.c | 72 +++++++++++-------\n> target/avr/translate.c | 3 +-\n> target/hexagon/translate.c | 3 +-\n> target/hppa/translate.c | 3 +-\n> target/i386/tcg/translate.c | 3 +-\n> target/loongarch/tcg/translate.c | 3 +-\n> target/m68k/translate.c | 3 +-\n> target/microblaze/translate.c | 3 +-\n> target/mips/tcg/translate.c | 3 +-\n> target/or1k/translate.c | 3 +-\n> target/ppc/translate.c | 3 +-\n> target/riscv/translate.c | 3 +-\n> target/rx/translate.c | 3 +-\n> target/s390x/tcg/translate.c | 3 +-\n> target/sh4/translate.c | 3 +-\n> target/sparc/translate.c | 3 +-\n> target/tricore/translate.c | 3 +-\n> target/xtensa/translate.c | 3 +-\n> target/arm/tcg/meson.build | 57 ++++++++++----\n> 34 files changed, 301 insertions(+), 228 deletions(-)\n> create mode 100644 include/tcg/tcg-op-mem.h\n> create mode 100644 target/arm/tcg/stubs32.c\n> \n\nv10 sent:\nhttps://lore.kernel.org/qemu-devel/20260407195922.196410-1-pierrick.bouvier@linaro.org/T\n\nRegards,\nPierrick","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=F3sA0Q2M;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqxvS3ywGz1xtJ\n\tfor ; Wed, 08 Apr 2026 06:03:00 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wACcG-0006Zc-KG; Tue, 07 Apr 2026 16:01:40 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wACbz-0006HW-Jv\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 16:01:23 -0400","from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wACbt-0007w3-0I\n for qemu-devel@nongnu.org; Tue, 07 Apr 2026 16:01:19 -0400","by mail-pl1-x630.google.com with SMTP id\n d9443c01a7336-2ab46931cf1so1992015ad.0\n for ; Tue, 07 Apr 2026 13:01:16 -0700 (PDT)","from [192.168.1.169] (216-71-219-44.dyn.novuscom.net.\n [216.71.219.44]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b2749a1e9csm191324835ad.55.2026.04.07.13.01.13\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 07 Apr 2026 13:01:13 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775592075; x=1776196875; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc\n :to:content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=kgmQp1Qqb/ULhBjlWSnR2fKBr7f4uFea4fSlnyCSxNA=;\n b=F3sA0Q2MTKHGhiaU7+vjcPCCSleZCWwT8N2pj36pmiIDmL7zwo5R0lK9g3fm6sRSs7\n 1fiho60MOVeHpjBfQWK4Uo4q5R5b/bQlqxmgCCW5xsx/cOd/Kcrb/MPLwRerP54DmncM\n sU0zsQDgcNPTGZhBSmL1xPTqN6scfgPZEDpqfHDlNT897+brvRnCImnJXnAmWCKq8pcW\n RzUQJOJoLAQ+mPv7ABulROQynZonwcR6nIh2ze+fBM3QGGQZ7XC2EcS8YPSrHxK3FOE5\n Ns4JN8EScr+DxrtZSRJ/aFSZTHNZNQ/VzBzzYXwM7bffSef7x0OgvlVxpJx0VG5MJNo8\n YDMQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775592075; x=1776196875;\n h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc\n :to:content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=kgmQp1Qqb/ULhBjlWSnR2fKBr7f4uFea4fSlnyCSxNA=;\n b=PtiiIuRkgkFqHHlllScMbwZmGeviVDMl0VeuKmH/YXljK/dVwkcYhqRqQbOCAYbblh\n Qm0mM0snAEhbPm6DnuccAlZCWwfey7tRIh/XizU+Idfareg7mmqcFA5FBmKKD+o/b7/y\n DKUwLfgFjN83vmlZ1St7HJ8eQCLeBJnS+jxp+DJABSN1Avj2yzmuoDIg1/LgB9blkD2H\n dq5aFJkQMtJ39ao9bcakuN7Z2Qjyu2hZETsqFjVi/ilhKWdjccgUsItzq9U+WyYfa5Jb\n T/cn0EFfT+E/rbssgeUVcFro6ZfnX448ZRuolc35AcRruHALIz4cqDsWqCTYWd7BZNOd\n 5O+w==","X-Gm-Message-State":"AOJu0YyjEgT3T5tnpICUq/AO1E49uHqZKH3mxV0zjqhzwvkzQCI3AwnZ\n DZMT+tjkuJ87uQWO4Ob+WbjCpwzCI9/jUdnb4CcAA2T+hYCfNsHQXfIj4oPwPVO4G5ajqOBnQYB\n HQQW98uw=","X-Gm-Gg":"AeBDievB26EV1wZaqcw6X+XQzw86CtAeGk+A0RKpmRW1ktir74YgncEn4MTU5Yoc5SH\n DgBRCukGxjL5dpcqboXGnN5CF9aFTLoZJxD7JMn74cjBXQ6JrKoYMf1HeG5bpprffqQWFb1GjUY\n RhdTLv8Sh74dOjuifaEQN9EJa9FGv6XK/p7QXWCHCFYCnwssS//iUlmpzs+f+9Ee3KFyCgB095U\n bGmnNdolbmOuQnPEoYACL53ljvENqcVCsYuIVZVjWumuIeJOKZ+y8JsDY0kJre0CBs2Qk4qAEv5\n 9nC6sUBdqCxm08cfQtMdbu65kam8xfzxUQVTw7JmFz1Gcvlc25heXv4v4nmHqvSQOiYnPBm9/SH\n IvZsC11D1iGJPD7qcBOd4kxUDVXDtmu9a50wUKcqerTx4nIguDX4abLMz/H3rgGuDYefLepAeuq\n tByJTvU5UzBy8JGghthYtN8IfcbiAugYwi8fahu2LDEaZb6nGA/ttF1gyAnZUWV4rd9ORGi7ge+\n rYxIAXC","X-Received":"by 2002:a17:903:1ae3:b0:2b0:badc:c9cf with SMTP id\n d9443c01a7336-2b277dbae60mr195486345ad.13.1775592074765;\n Tue, 07 Apr 2026 13:01:14 -0700 (PDT)","Message-ID":"","Date":"Tue, 7 Apr 2026 13:01:13 -0700","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v9 00/20] target/arm: single-binary","Content-Language":"en-US","To":"qemu-devel@nongnu.org","Cc":"philmd@linaro.org, Paolo Bonzini ,\n Peter Maydell ,\n Richard Henderson , jim.macarthur@linaro.org,\n qemu-arm@nongnu.org","References":"<20260407022748.57629-1-pierrick.bouvier@linaro.org>","From":"Pierrick Bouvier ","Autocrypt":"addr=pierrick.bouvier@linaro.org; keydata=\n xsDNBGK9dgwBDACYuRpR31LD+BnJ0M4b5YnPZKbj+gyu82IDN0MeMf2PGf1sux+1O2ryzmnA\n eOiRCUY9l7IbtPYPHN5YVx+7W3vo6v89I7mL940oYAW8loPZRSMbyCiUeSoiN4gWPXetoNBg\n CJmXbVYQgL5e6rsXoMlwFWuGrBY3Ig8YhEqpuYDkRXj2idO11CiDBT/b8A2aGixnpWV/s+AD\n gUyEVjHU6Z8UervvuNKlRUNE0rUfc502Sa8Azdyda8a7MAyrbA/OI0UnSL1m+pXXCxOxCvtU\n qOlipoCOycBjpLlzjj1xxRci+ssiZeOhxdejILf5LO1gXf6pP+ROdW4ySp9L3dAWnNDcnj6U\n 2voYk7/RpRUTpecvkxnwiOoiIQ7BatjkssFy+0sZOYNbOmoqU/Gq+LeFqFYKDV8gNmAoxBvk\n L6EtXUNfTBjiMHyjA/HMMq27Ja3/Y73xlFpTVp7byQoTwF4p1uZOOXjFzqIyW25GvEekDRF8\n IpYd6/BomxHzvMZ2sQ/VXaMAEQEAAc0uUGllcnJpY2sgQm91dmllciA8cGllcnJpY2suYm91\n dmllckBsaW5hcm8ub3JnPsLBDgQTAQoAOBYhBGa5lOyhT38uWroIH3+QVA0KHNAPBQJivXYM\n AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEH+QVA0KHNAPX58L/1DYzrEO4TU9ZhJE\n tKcw/+mCZrzHxPNlQtENJ5NULAJWVaJ/8kRQ3Et5hQYhYDKK+3I+0Tl/tYuUeKNV74dFE7mv\n PmikCXBGN5hv5povhinZ9T14S2xkMgym2T3DbkeaYFSmu8Z89jm/AQVt3ZDRjV6vrVfvVW0L\n F6wPJSOLIvKjOc8/+NXrKLrV/YTEi2R1ovIPXcK7NP6tvzAEgh76kW34AHtroC7GFQKu/aAn\n HnL7XrvNvByjpa636jIM9ij43LpLXjIQk3bwHeoHebkmgzFef+lZafzD+oSNNLoYkuWfoL2l\n CR1mifjh7eybmVx7hfhj3GCmRu9o1x59nct06E3ri8/eY52l/XaWGGuKz1bbCd3xa6NxuzDM\n UZU+b0PxHyg9tvASaVWKZ5SsQ5Lf9Gw6WKEhnyTR8Msnh8kMkE7+QWNDmjr0xqB+k/xMlVLE\n uI9Pmq/RApQkW0Q96lTa1Z/UKPm69BMVnUvHv6u3n0tRCDOHTUKHXp/9h5CH3xawms7AzQRi\n vXYMAQwAwXUyTS/Vgq3M9F+9r6XGwbak6D7sJB3ZSG/ZQe5ByCnH9ZSIFqjMnxr4GZUzgBAj\n FWMSVlseSninYe7MoH15T4QXi0gMmKsU40ckXLG/EW/mXRlLd8NOTZj8lULPwg/lQNAnc7GN\n I4uZoaXmYSc4eI7+gUWTqAHmESHYFjilweyuxcvXhIKez7EXnwaakHMAOzNHIdcGGs8NFh44\n oPh93uIr65EUDNxf0fDjnvu92ujf0rUKGxXJx9BrcYJzr7FliQvprlHaRKjahuwLYfZK6Ma6\n TCU40GsDxbGjR5w/UeOgjpb4SVU99Nol/W9C2aZ7e//2f9APVuzY8USAGWnu3eBJcJB+o9ck\n y2bSJ5gmGT96r88RtH/E1460QxF0GGWZcDzZ6SEKkvGSCYueUMzAAqJz9JSirc76E/JoHXYI\n /FWKgFcC4HRQpZ5ThvyAoj9nTIPI4DwqoaFOdulyYAxcbNmcGAFAsl0jJYJ5Mcm2qfQwNiiW\n YnqdwQzVfhwaAcPVABEBAAHCwPYEGAEKACAWIQRmuZTsoU9/Llq6CB9/kFQNChzQDwUCYr12\n DAIbDAAKCRB/kFQNChzQD/XaC/9MnvmPi8keFJggOg28v+r42P7UQtQ9D3LJMgj3OTzBN2as\n v20Ju09/rj+gx3u7XofHBUj6BsOLVCWjIX52hcEEg+Bzo3uPZ3apYtIgqfjrn/fPB0bCVIbi\n 0hAw6W7Ygt+T1Wuak/EV0KS/If309W4b/DiI+fkQpZhCiLUK7DrA97xA1OT1bJJYkC3y4seo\n 0VHOnZTpnOyZ+8Ejs6gcMiEboFHEEt9P+3mrlVJL/cHpGRtg0ZKJ4QC8UmCE3arzv7KCAc+2\n dRDWiCoRovqXGE2PdAW8788qH5DEXnwfzDhnCQ9Eot0Eyi41d4PWI8TWZFi9KzGXJO82O9gW\n 5SYuJaKzCAgNeAy3gUVUUPrUsul1oe2PeWMFUhWKrqko0/Qo4HkwTZY6S16drTMncoUahSAl\n X4Z3BbSPXPq0v1JJBYNBL9qmjULEX+NbtRd3v0OfB5L49sSAC2zIO8S9Cufiibqx3mxZTaJ1\n ZtfdHNZotF092MIH0IQC3poExQpV/WBYFAI=","In-Reply-To":"<20260407022748.57629-1-pierrick.bouvier@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::630;\n envelope-from=pierrick.bouvier@linaro.org; helo=mail-pl1-x630.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]