[{"id":3674532,"web_url":"http://patchwork.ozlabs.org/comment/3674532/","msgid":"","list_archive_url":null,"date":"2026-04-08T03:52:09","subject":"RE: [PATCH v10 00/22] media: i2c: add Maxim GMSL2/3 serializer and\n deserializer drivers","submitter":{"id":92980,"url":"http://patchwork.ozlabs.org/api/people/92980/","name":"Dayananda, Vivekananda","email":"vivekananda.dayananda@amd.com"},"content":"Hi Dumitru,\n\nThanks for spinning this series again. I was able to run it end-to-end on our bench (IMX219 → MAX96717 → MAX96724) with the deserializer using control-\nchannel port 1, and everything streamed as expected.\n\nOne thing I noticed while testing: in max96724_select_links() (max96724.c:889), we zero MAX96724_REG3 before we loop over the links, and only set the bits\nthat correspond to disabled links. That means every enabled link finishes with 00, so the priv->cc_port_cfg value we cached from maxim,control-channel-port\n(0xAA for port 0, 0x55 for port 1) gets wiped the first time this helper runs. The side effect is that a board requesting port 0 in DT will keep the default\nport 1 after any call to select_links(). If we seeded val with priv->cc_port_cfg (or wrote that value back after the loop) before writing to MAX96724_REG3,\nwe could preserve the DT-configured CC routing.\n\nVivek","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256\n header.s=selector1 header.b=Kj8NOG0d;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34858-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com\n header.b=\"Kj8NOG0d\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=40.93.201.61","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=amd.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=amd.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=amd.com;"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fr8K34YbRz1xtJ\n\tfor ; Wed, 08 Apr 2026 13:52:23 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 98C22300D4C7\n\tfor ; Wed, 8 Apr 2026 03:52:20 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id C79EE34DB56;\n\tWed, 8 Apr 2026 03:52:16 +0000 (UTC)","from CY3PR05CU001.outbound.protection.outlook.com\n (mail-westcentralusazon11013061.outbound.protection.outlook.com\n [40.93.201.61])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E25716132A;\n\tWed, 8 Apr 2026 03:52:15 +0000 (UTC)","from MW4PR12MB5668.namprd12.prod.outlook.com (2603:10b6:303:16b::13)\n by DM4PR12MB6230.namprd12.prod.outlook.com (2603:10b6:8:a7::10) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.19; Wed, 8 Apr\n 2026 03:52:10 +0000","from MW4PR12MB5668.namprd12.prod.outlook.com\n ([fe80::dde5:4651:de59:c311]) by MW4PR12MB5668.namprd12.prod.outlook.com\n ([fe80::dde5:4651:de59:c311%7]) with mapi id 15.20.9769.018; Wed, 8 Apr 2026\n 03:52:10 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775620336; cv=fail;\n b=K16eGXJhD2uSL6E7bNZlPxQGVFSVUL6iZEpAxSvZI8TPpUb7Dg5oPTPr+v97lbyevD3CekzKkfoMXzw0Vt8Ko2Afz27MhFyltLN+1CujvTHKnYpv1HWvS8zmnKy2kqFXXVeljilX5C+9Q4/C66IP6MgMv3PMuWNOvtSKAsorE2I=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=C4Er+sRZZSiM1sw571KFRt192rv9iawmE6tgC/3DcbELx6Q9RXILgWhkD8/L6za6S9DkiTsW5rLiaGpUx0WFMnGDyqkX7YvRN73/R7kFRUXrfIIXC3RSo8+yz9JyyCkNIUjhU0qhgg2cPnsrGfg4OwCD9yXMdYMZtzgR0TDwuOAXP8Ww08IoOHO0KmPRqrXFGwOQQCG89f/vk9GZ0mdl7r+uZoHCkFpvWiZXPv/XMj3w/A+sCmuhCnLHw5AnquZQQQuq/Gkw4h2TWoc8KnQBeNZ9D/aj0tgMW9UKYq2T80k0OIje8k7SC3qZFeFrniuZlMSP3GH21rT3+cJC7bzLBg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775620336; c=relaxed/simple;\n\tbh=2IARcToub2Gv1O6V6PdsjDSxNIfPmCABrHXKYMfhg3I=;\n\th=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To:\n\t Content-Type:MIME-Version;\n b=ZE1U2momaMQc1ZeX5iuWNeLQcuF8T7QvRGwsJtkctmWeNsm4LBYEN9pDIh/YiyyV7wCxLyZcZ5Go4WNSL2DGkc19w9HJ+KZcEEAIXIC7hbtH8V1nhkgEk5G5208GGEk+nD96p3IQZFBBtE4/rZC25l1nc7nh1VqwaGnwA6SnpOI=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=2IARcToub2Gv1O6V6PdsjDSxNIfPmCABrHXKYMfhg3I=;\n b=nrpSdAKMRi4ri0E0htvDzSgI+y+RyUylyFf0daRhHyqIVRUhqqx22RR/FU7rCFqq1teuVqzN3dSY1m3K/skzAm/9ZHlRWJgAVtfpQ9LiadA4HJV+310EbvuY4r6LE2c0IWR4wKB9rKm9EOJ8ds7otooJrLa5h8i4Z3h0R2LwKitaZbCh7Nd6BVX1bPQ7Yb9cOD+Enm9vv/pEJg1RHHtRR2PFbP8wrCqPHMW+XaVInf/A4ztvy+n0W17j4B9D7NfETUtk5oeLgHowKZSPWE9dlyd6RSA5OZAF43uupGMSIKbdk3kCch+bkkMEnOSQkqRewTJfdFk5LljNoJlPxWHbWw=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=amd.com;\n spf=fail smtp.mailfrom=amd.com;\n dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com\n header.b=Kj8NOG0d; arc=fail smtp.client-ip=40.93.201.61","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass\n header.d=amd.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=2IARcToub2Gv1O6V6PdsjDSxNIfPmCABrHXKYMfhg3I=;\n b=Kj8NOG0dPiWgcafduubCR+DZoypt7r2EWtqc3bzCWZtlvtUIkw2mQ+EGnOI/LHi19WeUWwmOmEo/zJqE5InQvGdum7MpM7eS0569VPBqLSQYxtEfXnozFMdGCFVteRiez3qLPWtSaHDbqvrBZkxrdAAJVbOSWrrsPKWPrlV3KR0=","From":"\"Dayananda, Vivekananda\" ","To":"\"dumitru.ceclan@analog.com\" ,\n Tomi Valkeinen ,\n Mauro Carvalho Chehab ,\n Sakari Ailus ,\n Laurent Pinchart ,\n Julien Massot , Rob Herring ,\n\t=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n Greg Kroah-Hartman ,\n Cosmin Tanislav ","CC":"\"mitrutzceclan@gmail.com\" ,\n \"linux-media@vger.kernel.org\" ,\n \"linux-kernel@vger.kernel.org\" ,\n \"devicetree@vger.kernel.org\" ,\n \"linux-staging@lists.linux.dev\" ,\n \"linux-gpio@vger.kernel.org\" , =?utf-8?q?Niklas?=\n\t=?utf-8?q?_S=C3=B6derlund?= ,\n \"martin.hecht@avnet.eu\" ,\n Tomi Valkeinen ,\n Cosmin Tanislav , \"Dayananda,\n Vivekananda\" , Cory Keitz ","Subject":"RE: [PATCH v10 00/22] media: i2c: add Maxim GMSL2/3 serializer and\n deserializer drivers","Thread-Topic":"[PATCH v10 00/22] media: i2c: add Maxim GMSL2/3 serializer and\n deserializer drivers","Thread-Index":"AQHcxgIb1x5xj34AcUiTIjtSS3peFbXUiiCA","Date":"Wed, 8 Apr 2026 03:52:09 +0000","Message-ID":"\n ","References":"<20260406-gmsl2-3_serdes-v10-0-645560fedca5@analog.com>","In-Reply-To":"<20260406-gmsl2-3_serdes-v10-0-645560fedca5@analog.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","msip_labels":"\n MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_ActionId=6c31534c-1ce5-4595-8d73-7a87065f3c85;MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_ContentBits=0;MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_Enabled=true;MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_Method=Privileged;MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_Name=Non-Business_New;MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_SetDate=2026-04-08T03:37:01Z;MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_Tag=10,\n 0, 1, 1;","authentication-results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256\n header.s=selector1 header.b=Kj8NOG0d;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34858-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com\n header.b=\"Kj8NOG0d\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=40.93.201.61","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=amd.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=amd.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=amd.com;"],"x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"MW4PR12MB5668:EE_|DM4PR12MB6230:EE_","x-ms-office365-filtering-correlation-id":"1e778b18-2d00-4a2b-702c-08de95223602","x-ld-processed":"3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"\n BCL:0;ARA:13230040|1800799024|366016|7416014|376014|921020|38070700021|18002099003|56012099003|22082099003;","x-microsoft-antispam-message-info":"\n gDzIRD3qLedPy/CLOUzyNNLU/LDlSlBm2hDLnu7u8sbuGrKFtn1KyK3dcmePVeAAigZt+HdcFycetV9Sh3nJy84RSzni8H7Gef5vnVeUWrUS6Hs35aN6xIADjXWcCspUmMk7Z/kTd9OIps2+ipzHu6SglrS/SmLNitls47DakFC+j1OWuXdEDh10jXCCCgSBqRsSVFvA45EyCQrjZZl/ouh4Dx9NaPcoBajXmsNiOj6lISfNNVI3ECEgPKvgE09IscH3s3fuWLVLkoLBPSFU2zUMvoO9lextSYdXFKZtXSXkvIWWoGr7iAsUG7oAH7z0MysnpRBOKrEB3QjoLDuVtY9RDlgDaenEMaB75QMoo3s1B4pOV6OfRCTkUUKxfPgW/c/TIcjQO25XdDXNyzLl0fl3MD9nZBU1Hg8e1VXv0Q9VJtC40Y92a4Fu/sO/aNjksl5Nrw5euwJhVfmCE+IeGuCgPeUKKdO9VJ6m7dNVEj7oOJa8nT1sS+ycBoIbshtl2+Xwv4RCJnsKljckgoYUpNoBavzQxzbymmt5R5EwZJtH7+8Npy5klZwjpRZzAWLVjV3KphbjavhGeXFW60693sEHRPcNaBWQbR5kEuSwHVwzlCyUaNWZzm2sDHJQyEiqnEdn+SwKHYrkTdFc2nctFYtLus+Xdcc0AvNroGK5O1czIJ5ChLXWhAly2ESN5AjnMuYA7a/8FtkZQLw02XMgp5TBZPuQyuY4QUVxZeZljiO1CZKkiKvwVlSflwyABWQNlO+5lUUuRSHGZEzZXQ0wzYo2tKVgxpmGANuxYTojJ5ToiTQxwRLztF3TcliKMHF/","x-forefront-antispam-report":"\n CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR12MB5668.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(921020)(38070700021)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"=?utf-8?q?wRY1wPXKYuALFwm8IAKIToC67WkW?=\n\t=?utf-8?q?7yoO3kbT7fAbSjpwdmEkH3GNHcx7rOKsZsdPu5ahbjoIoKQ9Y3ieeuySipinmfrJh?=\n\t=?utf-8?q?rkmJ07ck+RUa1IdcSiuvFm283Uo+ZhU6Gu5z7affsLQCObGbOBX9fs+swfImXxsXO?=\n\t=?utf-8?q?5oeIxmJ4b/pRMAOS1NFL3MrZEomapWSw8TfoWYAXg1bGxCb6HBtipubPASSgqAjNv?=\n\t=?utf-8?q?KeHukMEXmwr5dkqN7iEvMViNY/YK7THgDK5F3FYxy7QZMuXdaqhafS2coTsebsQmS?=\n\t=?utf-8?q?ucc+EmV+Cv40fCBZkZmzigXnNuK5aB6qIqbgZ+JtoGV3SIUFFjVGlAvrwCsT41QYg?=\n\t=?utf-8?q?tBehj75UqW2Li+IIya/Zn3EkNYG3w3/H7x0txVaOTKNWjSIl9YRYCrRDum1kwc+OE?=\n\t=?utf-8?q?NVN7D8yf6QwE86r0SPZOaLSz6B16Hsho44tqdP80o/3ts9Sb4q9f1DzD+DMpDOiLx?=\n\t=?utf-8?q?DVU2/ar0nVR8rv2pNk6UHAeThQCmdR9LtLu2yq+RQg0DCX3x2tTopdO7pfT9sZLKt?=\n\t=?utf-8?q?o5stfxRTvoXK3rUx5ZMIetEOsGmwC5SSOwwuQsV2NmiG5iy3AWzrMZzSu6XRqRskP?=\n\t=?utf-8?q?ekUEGZGa/G4XOhfx6L6U0AaN44gymj+H23E6HCn2IM2x3oTqhrXaIKUVgOZ/NTD+d?=\n\t=?utf-8?q?lzpPtFa3LoBprwYiVVMUu+Hdfh+8RL88eOp6vC4g4Puj9SaOnckK5nQVVMLICZ/2M?=\n\t=?utf-8?q?z5AoQfOGzldqR+TG/seukHsVjKX8c5OAE+5FfpmwfwxUO3EH7k7XWwFA5T1ldpQ+U?=\n\t=?utf-8?q?iMKXjchc5AsOxwVaowhmnWDmm5mSFya9v+Qad4IC7IECkdv/kKs7HD8EeyyBcWWM+?=\n\t=?utf-8?q?hBN/3u30iESGbXCirveKKl/Ekj9YWDWmsWZKJ9vF4jwAw0THiwTzcUjP1EQ7gOvVK?=\n\t=?utf-8?q?/HMi/x3ui9YI5eZ+Zy5wCZKao/bQskF5kWWMxjJicNxusUL7RtrMejWcs8gTZd20D?=\n\t=?utf-8?q?QufkZPRu9iYF3wR12EiCOYW+Z3k61TNO57ZrR6tXmoCIWYeHdkBueUKctVTi4svy5?=\n\t=?utf-8?q?U6no/RF9gCT3K0cSHIrTsP9kfzu5aSIAsEvuI81aiymOpzB92AhOxuiRZ3U15dFzO?=\n\t=?utf-8?q?W+217R5bbnSA+nAEePnd2BdUcHLwrhdYAx/rrC7FMQ7qP6axkyQy+eiQB74jx9Qjg?=\n\t=?utf-8?q?l5klDPRy+c9uuLMaYkk2MVIbxz5o7eu810wsP3nSScCiN/oxmCOCseyRWjAN/4tFc?=\n\t=?utf-8?q?sqqaZsST3UBoT3gGQwbfKhO7rwUXPQECicjUMeMVZn6bP1ltJGC/GYv6eUw4gegoJ?=\n\t=?utf-8?q?1KGFiu4Z46W3CPwaYs8llq3vdrz8N8+nVaB3VZ0OVwVcqDCH6Xp51QqhhsPcBVB/m?=\n\t=?utf-8?q?DAeTgjAkEV0sYLhCUFzG/CMzgPBGJDrhVy/UuHMHjQfYWTEnjPYT3YsorLeTq9kEw?=\n\t=?utf-8?q?0nKelZPDCHiGEncTbHKUh6rVgT2eScHeSUCHYe5/F5TvZI7H365KPq0kl44IxFgME?=\n\t=?utf-8?q?gxBy9h4Iyb/19tFcR1leZ3bkIk35HD5jtBr8iHWA2N3JhRcCgIGqc8uGLS/c+BEfF?=\n\t=?utf-8?q?0IhA4M5+RVPS91ZQ9bBy57AK45xjxKBUrsQVhDLgIwu0RSu3gHygRh7xkTTrL6+oV?=\n\t=?utf-8?q?ls81zPXKOhkL+20RGQDd+ZPCUUDz8dBhU/JVUT4s9bdUbcs0l4Po/3rYthbgjJvgy?=\n\t=?utf-8?q?/ovwb/Mi1B?=","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-OriginatorOrg":"amd.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"MW4PR12MB5668.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 1e778b18-2d00-4a2b-702c-08de95223602","X-MS-Exchange-CrossTenant-originalarrivaltime":"08 Apr 2026 03:52:10.0164\n (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"3dd8961f-e488-4e60-8e11-a82d994e183d","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n 5NEDi9gLHor/GGw5apANQn15zWBvNSxYM2VgcTvb80CoV+yeaS9UW4REe7Sy8b/teEK3mrXOypi9RgjBGDJtjg==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DM4PR12MB6230"}}]